From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CC44E77188 for ; Fri, 3 Jan 2025 18:29:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 53A666B0089; Fri, 3 Jan 2025 13:29:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4EB7F6B008C; Fri, 3 Jan 2025 13:29:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3D88F6B0092; Fri, 3 Jan 2025 13:29:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 202536B0089 for ; Fri, 3 Jan 2025 13:29:32 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 2E5EB1209AF for ; Fri, 3 Jan 2025 18:29:31 +0000 (UTC) X-FDA: 82966978542.19.2B072B2 Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) by imf28.hostedemail.com (Postfix) with ESMTP id 6B368C0010 for ; Fri, 3 Jan 2025 18:29:28 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf28.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1735928968; a=rsa-sha256; cv=none; b=SDka4vMSFsezzjBE+tvjLX64WerVfJ9Db3lhD6BVGi24axAiL+VjeG00oLG2L2UcxTGgKQ lBZNPncZ0bAVfOfDzA+w8UFAwKjY7vrpNYco1ZAHtVMR26Hk5Y6dAME1r2Ag/ss2/Ks9Mu Pf+8wWE0ULISJHS2ycHkTCl2Nq0xt8Q= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf28.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1735928968; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=stpQ0A0o0QQbvaVQB0/eLiJpyzNriqy4BJg9RSY08Yo=; b=3BUo+Db/xhngxxzDVo3nswD/DZEH+PCZb+eaGPv/zTNR+MM2JGb3a3GDYQpVu6UutUHq+7 +RLrYO+FO0cxEfytMhJnZdGxwZpJWZR9d13KVOxHFZ9ircnq3pZtCpVXfcUC0fujk4R86h bTtf1vzjV55LN1Do4grp+dQRsIzXw2w= Received: from fangorn.home.surriel.com ([10.0.13.7]) by shelob.surriel.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.97.1) (envelope-from ) id 1tTmOb-000000004eZ-2eZc; Fri, 03 Jan 2025 13:27:41 -0500 Message-ID: Subject: Re: [PATCH 03/12] x86/mm: add X86_FEATURE_INVLPGB definition. From: Rik van Riel To: Borislav Petkov Cc: x86@kernel.org, linux-kernel@vger.kernel.org, kernel-team@meta.com, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, akpm@linux-foundation.org, nadav.amit@gmail.com, zhengqi.arch@bytedance.com, linux-mm@kvack.org Date: Fri, 03 Jan 2025 13:27:41 -0500 In-Reply-To: <20250102120450.GNZ3aA4oVPnoJYRVUL@fat_crate.local> References: <20241230175550.4046587-1-riel@surriel.com> <20241230175550.4046587-4-riel@surriel.com> <20250102120450.GNZ3aA4oVPnoJYRVUL@fat_crate.local> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.54.1 (3.54.1-1.fc41) MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 6B368C0010 X-Stat-Signature: kw88xh991utrttxa63pzb676sgq1twfc X-HE-Tag: 1735928968-623489 X-HE-Meta: U2FsdGVkX1/TbfqVWy+c/7kFpcgSq7gDS1/VeVtMhi9QkShhxLMFnt1S/WdU+lM7YqiqDDPoMWYb407W5y5SmzteV55ztTpvQT5KKWNA7oKSKWpWk6Kb+L/VBjmTuhaE9A7SrV/wjimIs7QLVuDhI0fXDN5dQqq6+lE3nd05CM0PLQrc1yZRTcrMfgJgE7Qa0LOlYys4/Y6CzcTNkoL+NN0ad5bNQrfaDF4G4xqcifszvSailRaje/WDL4dktLTYaeMvfaf+r0s68lNk/AjS+tkEBjVZCdMEd0FNk/5OUOcwDcHU7cWtuxRpxxrfB9kmvr3J9I7u79k5xztVA83nJVQahPzCFNxnDbkqt5QlIwA+b1I0kLq4YWDL5qbsVtsB1ZPr7JcjGqBna+TClIK/NTRlzDgRm4+4Os/3aiVQNs4k/si1bYbtK03pCOZFsY9Wnh/e9dCwqedMWMgZVzHsHaOAn+GUtDqtF5YjyY3tpwp5/Md5e9Q4TY1J8HZQtQRs80GexptCP0xjYeFYS0z+CNnioXLoP3LEG7kfbsVCGKIDuVOmuGM39q6LqS/1aDslyI0ZaCKtoaK9yvrdKMprsF9BxdiWdpkyVwQJLJsFd0/MeuNFDw//my4Ma2GhF6LFWne4SFye/7N/4tGSa3Rs0y44YkVVbau1jiLdMw++trzxCFq2rtfCvB9Pliztb3wMmo66F99vyIE5s8yDlvDYbL6MzNi0A8i17mW/To2URJHzvH/QofRW4g/DmiZ9RoXWATwEtDlRFtYpGWsIrHx/E/h/NveRyYj+PXQbvVy4dTZzrZ73ZmZNs0dnCeU7dQTAhf34ygmjrvkFm9m9ickEeSez6pjRc+cti3dvF4Krj7z20sYRBdaC93Uh05EhZZQvPZNIPF/uqao9Km3W3bZty4hTtUhtbOPpD/zP6h4L+uREoE7615ehvmW27jVuAkA2uiaQCh6C7cHumILs2uH 5NYpuB8m 5NCg2uGtLiUzp2CHUV7Wq/jlLVbXyv2sKQ1IzwzVujYELnABVoElKhz2Bcz7E7+N06i7JYqpFveOK1fwoX1nNfNxXjRwzj+R8e+6ykaPqxQ4n7yzHiGfvpjIO7Ot8cfZiUAFOVEVZ+Bte6nJD6pUBUkZK9mjNkbvAkr+ITIiX3cV2JbvpaD2CACddbRzw4qWAPBmZwxBIPmqGHjrOuyKqW2LL0Cmfa7OKtC0bgI3eQ6eFGZK0znw01GqcdLPE3MBXeP9xU/IAEbwWScvHAbXzLfEQiJUPGjozBUyeXlDyLX4RaPJ3SQkOhlt8ZcQnaR4HbTXvu0Z3PbJOWoyWD/BmLI+9MJowDfs7o6hNSCGTfeGWS9e85Iab5G0h6QsB6AVcVH5p X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 2025-01-02 at 13:04 +0100, Borislav Petkov wrote: > On Mon, Dec 30, 2024 at 12:53:04PM -0500, Rik van Riel wrote: > >=20 > > +++ b/arch/x86/include/asm/cpufeatures.h > > @@ -338,6 +338,7 @@ > > =C2=A0#define X86_FEATURE_CLZERO (13*32+ 0) /* "clzero" > > CLZERO instruction */ > > =C2=A0#define X86_FEATURE_IRPERF (13*32+ 1) /* "irperf" > > Instructions Retired Count */ > > =C2=A0#define X86_FEATURE_XSAVEERPTR (13*32+ 2) /* "xsaveerptr" > > Always save/restore FP error pointers */ > > +#define X86_FEATURE_INVLPGB (13*32+ 3) /* "invlpgb" > > INVLPGB instruction */ > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ^^^^^^^^^ >=20 > We don't show random CPUID bits in /proc/cpuinfo anymore so you can > remove > that. I still see dozens of flags in /proc/cpuinfo here on 6.11. When did that change? >=20 > > =C2=A0#define X86_FEATURE_RDPRU (13*32+ 4) /* "rdpru" Read > > processor register at user level */ > > =C2=A0#define X86_FEATURE_WBNOINVD (13*32+ 9) /* "wbnoinvd" > > WBNOINVD instruction */ > > =C2=A0#define X86_FEATURE_AMD_IBPB (13*32+12) /* Indirect > > Branch Prediction Barrier */ > > --=20 >=20 > Also, merge this patch with the patch which uses the flag pls. The first real use is 3 patches further down into the series.=20 I'm not convinced things will be more readable if 4 patches get squashed down into one. Are you sure you want that? --=20 All Rights Reversed. --=20 All Rights Reversed.