From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0534AD462A7 for ; Wed, 13 Nov 2024 14:11:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8253D6B00C7; Wed, 13 Nov 2024 09:11:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7AE9D6B00C9; Wed, 13 Nov 2024 09:11:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5B1916B00D5; Wed, 13 Nov 2024 09:11:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 3338D6B00C7 for ; Wed, 13 Nov 2024 09:11:17 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E817B160AC4 for ; Wed, 13 Nov 2024 14:11:16 +0000 (UTC) X-FDA: 82781257650.23.D7052AA Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf10.hostedemail.com (Postfix) with ESMTP id 48B3CC001F for ; Wed, 13 Nov 2024 14:10:55 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="jn/j+yui"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=TuRzXYJI; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Dc+TTr2i; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="/RbG1Tml"; spf=pass (imf10.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731506986; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=F7km93KIIYuqKEt/24YsZ7bNYqLsxNs2esk4LxTHLtI=; b=GsAIQQBSOVBCJ+9vQTuv78qOC9US605ZUdOZNIjUrQvrb+WDpkXLQg+h3mj0RNZIOoW7iP yFhwxEi4+ifMZABa4Hy6jfnXYOOKJlZCn7oF0yo/9ztagDypUsOauc3LZVUVY6WrcsdR/T wMgMKJcDXJnhk3+u0BIqGhCG02pvhcQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731506986; a=rsa-sha256; cv=none; b=rCCAb5PWJtyiaVFVRxWFgUDkhmGun3LE6u6EGwkMR9C5zYikZkBjycxx1mfaaNHwQ/Tvsx hRqqzz9EVzVrnKOkd3yS+ydQB27izRxS4iNLjSMDBd0CbYy3hZnDHH4Ty2v9oaHtyO8dMc YKklvhp9wY7+fNjo7cfzaBrKWeI1LPU= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="jn/j+yui"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=TuRzXYJI; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Dc+TTr2i; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="/RbG1Tml"; spf=pass (imf10.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 5F76E1F37C; Wed, 13 Nov 2024 14:11:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1731507072; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=F7km93KIIYuqKEt/24YsZ7bNYqLsxNs2esk4LxTHLtI=; b=jn/j+yuipCdBcsqWRuDvb/cLFh3auLDQPdWRovSa6UoOYxpPIhwo8G5poeMAWcjJdJ0i3p sr0/jm5m+ZLlsNzt20TDsRJW8MO2i+//GRCeYnLFIOimetT1kIDx74WY+I6JnnpgDAY0IR mYirVCWfn7Cchxx/Zag44ZQD1IppNfw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1731507072; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=F7km93KIIYuqKEt/24YsZ7bNYqLsxNs2esk4LxTHLtI=; b=TuRzXYJIq5yZ8Fd9WPQ67kYV+bjk2TryLSpQo4uzsx86trVjJnl3MqmddojVzevlIah8Is +SNBoV/DrT00tXAA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1731507071; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=F7km93KIIYuqKEt/24YsZ7bNYqLsxNs2esk4LxTHLtI=; b=Dc+TTr2iMd18ayI8zCKYNsRmf5usVG3iluXsAJc9fnFNk6Bfnjl38UteUqJewfKCdeKaCa QMtasC9gLyj7hKJI5MlYRV71HuLKi7sBgbuI10QZs8P0OviMuaSvlValvXaY60miJu4TmA imqmnymIt30gKGdFSbWMwjTQMItDJtk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1731507071; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=F7km93KIIYuqKEt/24YsZ7bNYqLsxNs2esk4LxTHLtI=; b=/RbG1Tml0JjJS9vUYxlr/i5FQPVouO0WtmYG+KmJEwZfU/Koqr/JJrMJYv2Fnq9GBsgVz7 HYEy/vpnjOYXYGCw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 4A9AD13A6E; Wed, 13 Nov 2024 14:11:11 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id oGnbEX+zNGeUawAAD6G6ig (envelope-from ); Wed, 13 Nov 2024 14:11:11 +0000 Message-ID: Date: Wed, 13 Nov 2024 15:11:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: fix NULL pointer dereference in alloc_pages_bulk_noprof Content-Language: en-US To: Jinjiang Tu , akpm@linux-foundation.org, alobakin@pm.me, mgorman@techsingularity.net, david@redhat.com Cc: linux-mm@kvack.org, wangkefeng.wang@huawei.com, sunnanyong@huawei.com References: <20241113083235.166798-1-tujinjiang@huawei.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <20241113083235.166798-1-tujinjiang@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspamd-Server: rspam10 X-Stat-Signature: o7zw4w6aryjrzm9q4k4bj81no8kphkey X-Rspamd-Queue-Id: 48B3CC001F X-Rspam-User: X-HE-Tag: 1731507055-318253 X-HE-Meta: U2FsdGVkX1/MrPThPoYaitiQ7ZVu6ArTVvW56mbLPMfGdiPjYTFWy4s/OJiFKcq1vzZNfukEspuDrtAKyTl9Sc5d7Zu11fv2G6DAaPyfGL1xOXVUYss0tZ7tZg+ad3V45EqguaheAb6WFFCN02tMfHTvKIzD2ix6cV13WvwlEEqZCYoxD+umvt+x5Fk7yWJuJtpMTbGK8WLkDNfCnQrftEAOpy0yNisHSqy9xZxAwpcefB1Lk1ZtYIsSfAF2rZot2DBjzMGbGGalTGort22fr3ruDOELplm27M+8f1oOGKJ46VtlsFv1GMtJlS9/Z3t6T54q0IfzhLhQjng1JdzzqBoBWg77NJXLa8RnBSfmG9L+xESha8pqiSbaY97BALotMg/Y1uJULsavXXTyJYmmYzuHJLxRD0jgtt2i0YFY+NBADW/1Y0YYbLdvKY2mP9jGUfiy523YV6myLvlTakslke60ZWKeu+PmscgFF9sejJtRhlHnDUPd1lvZcNCOtZCj1W/uNVndYkMIJTx4zhQuzKFo1xNn8nx1ZituiqHNIST9grp1cLqaWNfNlYkfyEKWOVlxw3ah3/hURSOm1gzvLSN23fvA6fwyyt8aslA3+HbgBCxKiPchlGFIHDbEdzcbRzcRR/4FSjuuAEnhj8hf79cxTcBcYMDsNjm7sci7bayyDkKedpfV+saMJqQzk1bdZ2ct+4bCyy9sRN3KyIVHbO7Kbhi1gX7wOGy+bwd0zOVeRD8x1e4dPeM0HBNyug2KYMsfLqEHTwdeEvdsRYohkaKik/RyRvmpqCZk0vORCgeJjmmaX4mTz7AaW5d+DgxVuRiEAdHpSA0OAxgi1whi4hladFkQETjBxOBW2XuJRed49qgGtMIUuxvDHqCwCC7XfUloqCp5b6cV1EZgFXA+Z8gubRRzahCXVP7PtpwOAGUbCqnvIL/FJdlRlTlzfnFt4KWM8cIq17LVEKbtVuS tFnSN6BJ Mfjvk+ewVrfnbH6NSdUENUZ3WyTSJmCH9TrRBEV0G2K+PFu8fvCIH+oIauCszNPeie+wpKyyicdRwSrOVQ2GUU4q/0bfcVf9cjX3ZqMP+N5FcX6USk+LVzhG0rCpb6WMQra77bOAIcRFF6XKVLONnwG0/RGdlKuCKbty3vmKOluNalWrD7+SzBzgC+Hq0eK6m37tUY7Ypq1MyqM/buuJMNLavJ2rCRg1vkSm/NfvvkTFftWPbwdLeN1r40ZvmfKo1r+Bhno5ClanbLQwBUeEtfSiY73BvmBB9xa0IUMDmgID78dr/c6u+k8BPoElmvxpmzMSsO6Lp5cAYZxzsnWtARu0suWcym1+jAMQ8 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11/13/24 09:32, Jinjiang Tu wrote: > We triggered a NULL pointer dereference for ac.preferred_zoneref->zone > in alloc_pages_bulk_noprof() when the task is migrated between cpusets. > > When cpuset is enabled, in prepare_alloc_pages(), ac->nodemask may be > ¤t->mems_allowed. when first_zones_zonelist() is called to find > preferred_zoneref, the ac->nodemask may be modified concurrently if the > task is migrated between different cpusets. Assuming we have 2 NUMA Node, > when traversing Node1 in ac->zonelist, the nodemask is 2, and when > traversing Node2 in ac->zonelist, the nodemask is 1. As a result, the > ac->preferred_zoneref points to NULL zone. > > In alloc_pages_bulk_noprof(), for_each_zone_zonelist_nodemask() finds a > allowable zone and calls zonelist_node_idx(ac.preferred_zoneref), leading > to NULL pointer dereference. > > __alloc_pages_noprof() fixes this issue by checking NULL pointer in commit > ea57485af8f4 ("mm, page_alloc: fix check for NULL preferred_zone") and > commit df76cee6bbeb ("mm, page_alloc: remove redundant checks from alloc > fastpath"). > > To fix it, check NULL pointer for preferred_zoneref->zone. > > Fixes: 387ba26fb1cb ("mm/page_alloc: add a bulk page allocator") > Signed-off-by: Jinjiang Tu Reviewed-by: Vlastimil Babka Thanks. > --- > mm/page_alloc.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index c6c7bb3ea71b..4afe8bc06358 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -4592,7 +4592,8 @@ unsigned long alloc_pages_bulk_noprof(gfp_t gfp, int preferred_nid, > gfp = alloc_gfp; > > /* Find an allowed local zone that meets the low watermark. */ > - for_each_zone_zonelist_nodemask(zone, z, ac.zonelist, ac.highest_zoneidx, ac.nodemask) { > + z = ac.preferred_zoneref; > + for_next_zone_zonelist_nodemask(zone, z, ac.highest_zoneidx, ac.nodemask) { > unsigned long mark; > > if (cpusets_enabled() && (alloc_flags & ALLOC_CPUSET) &&