From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E445C83013 for ; Fri, 27 Jun 2025 16:30:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D51058D0007; Fri, 27 Jun 2025 12:30:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D28C28D0006; Fri, 27 Jun 2025 12:30:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C3F6D8D0007; Fri, 27 Jun 2025 12:30:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B62018D0006 for ; Fri, 27 Jun 2025 12:30:21 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 86E161CFE37 for ; Fri, 27 Jun 2025 16:30:21 +0000 (UTC) X-FDA: 83601718242.11.8730801 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf12.hostedemail.com (Postfix) with ESMTP id E07C940006 for ; Fri, 27 Jun 2025 16:30:18 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BUnZceLM; spf=pass (imf12.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751041819; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FMC4YUXygZoZhAtwBUomQlpkOvVYPpeGsXFDd8TvJVo=; b=g3c6zx8wbA9m1RNLn1pSSvP7IJeBgpezUk0Hi8F8bHnbblfXwIDURGFPFquH0h3PlslvLO /hXk0NGq/TxlejDBORJzcwE0rQWX31xqqBkvYJzB+J4bAoNvnzfFoioLWYiew5xr7cLjoQ P6imbIQ0OsM8pe+I+sLS9VA0wBxzLOs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751041819; a=rsa-sha256; cv=none; b=vLdVVEiFGGhBDKMfSRquyxF+tRrCX1R67JETmYwI3uyhdYjYCUL1+jupymBMk3UXFkuvEx DjImwvHjQAbGOL/J2/DxdVf4a8tcwOKO6wTk/QgYOsnrPBLHiA4urXreVLZY1PCkNZvXmk 00uB5hLWHcVEpWc+TzDdKsL9Kl2D2WQ= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BUnZceLM; spf=pass (imf12.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751041818; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=FMC4YUXygZoZhAtwBUomQlpkOvVYPpeGsXFDd8TvJVo=; b=BUnZceLM5JAqttgPj6SbcQD63FHlIsitF87F5Pa0E+1VRnYhjiSEwfQYp7GDHnFT3mothD T5q1TQmEg9eJWP9me5TDkxeCxaoLdxCngnqjFxcrhkw4Yqql7RZ0WhgE6wrzWb36KSRzIi SZ718FZB6p2x8f/4BR7+U5K1c5qp3eA= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-597-2JWd4JVaMXaZBRQ_ZaghLg-1; Fri, 27 Jun 2025 12:30:16 -0400 X-MC-Unique: 2JWd4JVaMXaZBRQ_ZaghLg-1 X-Mimecast-MFC-AGG-ID: 2JWd4JVaMXaZBRQ_ZaghLg_1751041816 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4535ee06160so336905e9.3 for ; Fri, 27 Jun 2025 09:30:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751041815; x=1751646615; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=FMC4YUXygZoZhAtwBUomQlpkOvVYPpeGsXFDd8TvJVo=; b=gcz9SwtnMlo7bnBSvgVnFkM19xnImum7BqCNuEoAdxb6aB1ajsuSf1Rn/xMIvg76/l hwK0EwEpabGP4wNKh36w0CBs3FhGmaPTEMOOpFlwpPoyeqtw6KydEuQo5MB5D9F+GeS2 ZC/1sFtsSKi3Y7kB71brx0HjYW50Nf3DueGdmsCjsFF9CkBt1WD7qu3Zkb0jV5rYm5F4 /6wnqReB0HG4FTObGQrYWnIortb7zJ2w5slTee2x+12N5baK8J1E8KTmbfBXKzM0NSx3 Ps9RWYOJ6tp6JFoX+u4EoItn2/APvBeqzsFo+3MVWkFlk62HztuiPjyS/ucovllupsJ1 UBXA== X-Forwarded-Encrypted: i=1; AJvYcCVphAi0zUc73SyL4OF+0TQVAs3ZJpivZZ7H7T5HPiFYYJDzZqkRrPlwUtE+wzEEDMSLNhseMnpU0w==@kvack.org X-Gm-Message-State: AOJu0YyG4RQfUEnnmzb8EyyqO0CIaM/3vziq1oLth+Q8kQwDrMG+IDEG 2HTKyonqI2G0JZc2B2c73dMAQ8Azz6zs7ZLDIfKVbdOzNjIOqXi5zh0NTOY+8cUL/iSwxm++6Ki W4z0ljl4g6sHWlqEaPiswqJceV5JG5HcO8C/b4CHch1GfSx4CO1eJ X-Gm-Gg: ASbGncsP/DN1YHHO9Zdl5tW3SQaA1DvnU8PWyHPe2zFQxb8NRtnxetGCE5rx7us100l EpsjdJUf5bQAapg7l/kf8qxcsov9jKHmcoweCFUZmkTpz6JzccckGv7JDvYupa9O9Brn1x8pl41 GAVNDnDRqgfCmQWDmTXg3otY6JdHxBMZULBIFMpnp/jAE3+KY0TQkmRwK0vPt1j+WqR27spLO0W VC1juUvFipfGNLgs7B0rDF7LbBngWL2SZsFrzPi06pTj9n+VjZOaFv55sHVW1HvSWbNap4bg2dt gSt1n3I9e+JEWTiQssBi386uzQ0uDjhbMhlCi7/jHfCdkCD0vbZagY1Slxk6Em4ho9aAiZ8HM9x ADywITAlHc31CbBY550LDa7WqyUqzXxaYJcIusz1pLHbidK/eCQ== X-Received: by 2002:a05:600c:4e92:b0:450:cabd:b4a9 with SMTP id 5b1f17b1804b1-4538ee798bemr40361855e9.29.1751041815508; Fri, 27 Jun 2025 09:30:15 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHGqdsT/96F0Mr2PJX6b8M2jQoHI2tRESaMDJOYEgLFFr6DNktefRenln/Df0rWFyaxMn5Jyg== X-Received: by 2002:a05:600c:4e92:b0:450:cabd:b4a9 with SMTP id 5b1f17b1804b1-4538ee798bemr40361545e9.29.1751041815067; Fri, 27 Jun 2025 09:30:15 -0700 (PDT) Received: from ?IPV6:2003:d8:2f2d:5d00:f1a3:2f30:6575:9425? (p200300d82f2d5d00f1a32f3065759425.dip0.t-ipconnect.de. [2003:d8:2f2d:5d00:f1a3:2f30:6575:9425]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a88c7fab15sm3174897f8f.33.2025.06.27.09.30.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Jun 2025 09:30:14 -0700 (PDT) Message-ID: Date: Fri, 27 Jun 2025 18:30:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/4] mm: convert FPB_IGNORE_* into FPB_HONOR_* To: Lorenzo Stoakes Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , "Liam R. Howlett" , Vlastimil Babka , Jann Horn , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Pedro Falcato , Rik van Riel , Harry Yoo References: <20250627115510.3273675-1-david@redhat.com> <20250627115510.3273675-2-david@redhat.com> <6e3df002-fd04-4acf-a670-d36d5478921a@lucifer.local> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <6e3df002-fd04-4acf-a670-d36d5478921a@lucifer.local> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: QBd88qFi0_qBZ6akLVNhYWL-_U2i9g00ht_DOhodgtY_1751041816 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: E07C940006 X-Stat-Signature: qa8h1b4o9tarwzjj3bhw8q6aq1x3k33i X-Rspam-User: X-HE-Tag: 1751041818-711161 X-HE-Meta: U2FsdGVkX1/Ajp4mVDutYl6UI/mF9ziM3Z/pdQfj0MHHiQHW9CfQmlXBVOc5kYIi8W7xsfC6pVI4vIJ4BkR2l2dRoESarvlXxhyptrk21E/DX7aGzlbBMlv/9zCU9fymfJjN4wilJ2S/VhnHa5+9moavUKKXmdgqfntF/7Dd9PVkZEc9DwfPrCEi4xC/IN1aLHM/pWpKt78gPyrnd4bfvvDwZfz5PRUArxy0UbmX3MMB8KD8HUyyyEiCaHwZThN6GNTtPjFvH790/Z/XZ4w5Lfs8TYaTmFkeDZCBKS4J8K0FNTzhlroFQ8vfMIx/eFtd1PyiAPj1uSbo7bxgJo9txvZslPFT0Lxl81ajCg07LaOpUCpKnO+KblthJ9SWxru1ynMbVPtAQRLhRL/EDNBkUbefWUJ1IffnoWWf4M5qcEymSBlZSB2jVHFvnHiWPHlLbyld1xI1BlzZ2sh28+vZpjU6ygv13bGWzxATB0q0lP0iZWHsI1q6ioG6hWqCOsn+FnDlGAkgW6I38L6lvKuYJrFih5nKku7ggdYzDAAZJVjVwr5JHyaZPKXi6088+noytbde3qpfhYBNwKTjQXPTVtqoEUeZGoAGUyKtvUCSeXfkp7KLGe+47AZDvBPNqbdOM6hkhuevhuGby2N+nqpQBEJiUM3OpjK5tMer5gB5Y+eU6hdDukVG4P7GSsGnbLIL/4OVZeaAf5nAT2V23C/hg9frO2UUECZpy9uoNvTiliTjbVwiBE7EvIwDFgqCjbSVvpzFOZNQL99GFX7QcFnZtwbIoWvsXi+jjlZGCb32buukk/nBb4U8fwf7nfoU4i1kRP33op8RYnaqBhUmQkr68ROFxKyhVjasrtYRDukQgPHzk1cpzVZ5rgPkTU5ddRy3j6+V9jOgRIX4x8pE8Ev2iWgMX0DfzBapN58x5QSHvVGQxae9w4iULvHFPAdF/p03x7YAK2SXMr8Z95CVEaY So5nwgha Vix8WZecVY4LCqLxAPuFSm2/B7Xf9Nbs522kxiiBZjka/pd49xkezCC9tvBWOpfmjE204wH98avSrZoFJyzqSvi4f5nzHWjg1XJNgKIqb2Yeoi5Y6lc1xG40+6RJj58nsQHFRSoyG2Uwq4ro9V0qoneSWz32KsMHJDdZ35+7NgZ8Oucy2CC6FRA16n1AN5V7w5xicKNecF96+KPZIBeXFnC8aHI5zjfe8ruGNhuvjPxfFR9SaZwhibWV9hd2od01xlDiJN6EihP8e0COGdxm4JHCduaBCOEo6faAgjNjqfkOObUyzC9p7OJAqvM33KuiF7BW62+tqtYZ8jgYkSdc/OSsAmhMBT8yGY9iLj1aIMm26H6BFIDnHomrv9AnFeVuvnj6srfSmfEgKGoYrYrQbYkBAqtxXSgb8kKS+TXsqiWPo169THVDK//u9gKkRNL8xybHXSpKcwMFnYI1tmHvwIEGPYyVq7cifiuMscnJ1avjIar3S0Wg42GHdNtF9sWmhq0VJoZNGaS5QP5nbhK50V8QIL0vBCVr59Lv8Nl9h8ZDIhQy+fs+J7O4hFFFNvg1OodDy X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 27.06.25 18:28, Lorenzo Stoakes wrote: > On Fri, Jun 27, 2025 at 01:55:07PM +0200, David Hildenbrand wrote: >> Honoring these PTE bits is the exception, so let's invert the meaning. >> >> With this change, most callers don't have to pass any flags. >> >> No functional change intended. >> >> Signed-off-by: David Hildenbrand > > This is a nice change, it removes a lot of code I really didn't enjoy > looking at for introducing these flags all over the place. > > But a nit on the naming below, I'm not a fan of 'honor' here :) > >> --- >> mm/internal.h | 16 ++++++++-------- >> mm/madvise.c | 3 +-- >> mm/memory.c | 11 +++++------ >> mm/mempolicy.c | 4 +--- >> mm/mlock.c | 3 +-- >> mm/mremap.c | 3 +-- >> mm/rmap.c | 3 +-- >> 7 files changed, 18 insertions(+), 25 deletions(-) >> >> diff --git a/mm/internal.h b/mm/internal.h >> index e84217e27778d..9690c75063881 100644 >> --- a/mm/internal.h >> +++ b/mm/internal.h >> @@ -202,17 +202,17 @@ static inline void vma_close(struct vm_area_struct *vma) >> /* Flags for folio_pte_batch(). */ >> typedef int __bitwise fpb_t; >> >> -/* Compare PTEs after pte_mkclean(), ignoring the dirty bit. */ >> -#define FPB_IGNORE_DIRTY ((__force fpb_t)BIT(0)) >> +/* Compare PTEs honoring the dirty bit. */ >> +#define FPB_HONOR_DIRTY ((__force fpb_t)BIT(0)) > > Hm not to be petty but... :) > > I'm not sure I find 'honor' very clear here. Ignore is very clear, 'honor' (God > the British English in me wants to say honour here but stipp :P) doesn't > necessarily tell you what is going to happen. > > Perhaps PROPAGATE? or OBEY? RESPECT? :) -- Cheers, David / dhildenb