From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37D18E77199 for ; Wed, 8 Jan 2025 11:01:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B2D046B0099; Wed, 8 Jan 2025 06:01:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AB6196B009A; Wed, 8 Jan 2025 06:01:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 909736B009B; Wed, 8 Jan 2025 06:01:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 72E8E6B0099 for ; Wed, 8 Jan 2025 06:01:57 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 06F9E44943 for ; Wed, 8 Jan 2025 11:01:57 +0000 (UTC) X-FDA: 82983994674.05.511CE29 Received: from flow-a8-smtp.messagingengine.com (flow-a8-smtp.messagingengine.com [103.168.172.143]) by imf01.hostedemail.com (Postfix) with ESMTP id C8E9A40019 for ; Wed, 8 Jan 2025 11:01:54 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm1 header.b=Cy+D97Sp; dkim=pass header.d=messagingengine.com header.s=fm2 header.b="M SIdJfQ"; spf=pass (imf01.hostedemail.com: domain of arnd@arndb.de designates 103.168.172.143 as permitted sender) smtp.mailfrom=arnd@arndb.de; dmarc=pass (policy=none) header.from=arndb.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736334115; a=rsa-sha256; cv=none; b=5QkPH4y7Ryfu+Jw1+jFAzPNouLNp3sCIOE1qh9Kwx7OgYoYwYBW8gvpymS8tVCCDivPgha Q14oCL0BI9uPefzHb3vVM4A+icpVWc3LbHOmTxr6Rm0W3ccfKvDzOjbLVD3QNywCE3f/Ah pEX4HjXMZFNUYhlATE5i1pr5bUPTRyk= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm1 header.b=Cy+D97Sp; dkim=pass header.d=messagingengine.com header.s=fm2 header.b="M SIdJfQ"; spf=pass (imf01.hostedemail.com: domain of arnd@arndb.de designates 103.168.172.143 as permitted sender) smtp.mailfrom=arnd@arndb.de; dmarc=pass (policy=none) header.from=arndb.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736334115; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=20U5sO/u0uYru3hxNMHsooCdHBrAIIWG/43UdZigSIo=; b=abJPwRL15aJY2gSLZAY4MygJUW1dQwcfBsdWw1Bx+Iz92rfAWnL5HQTiB47V9eSzdMB0Om I4lp3rbi48vF3KgG0PZTQ/Wx0vBVOxFsRHODzasLD2wurfvk/0MvD2FIdlwxMEp8lo6pY5 eLqoT6P5NB/jh++UKZqvX27ZX7XB0jM= Received: from phl-compute-10.internal (phl-compute-10.phl.internal [10.202.2.50]) by mailflow.phl.internal (Postfix) with ESMTP id 01AD8200CCC; Wed, 8 Jan 2025 06:01:54 -0500 (EST) Received: from phl-imap-11 ([10.202.2.101]) by phl-compute-10.internal (MEProxy); Wed, 08 Jan 2025 06:01:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1736334113; x=1736341313; bh=20U5sO/u0uYru3hxNMHsooCdHBrAIIWG/43UdZigSIo=; b= Cy+D97SpayPKf50CJRucU/OjuqxmZo1HPxdDHfFjtk4V4dzkHIGqqI4ZeTBGBIwQ CU43a3abN/lpxbZArBxq7/TC680Cne845B7Mt9ZmA7It+HSwgjARBYDZNaSmXNM2 krcib2kkSpUfF5s2H8og+FziqnBYnNGV+oIkJokZXGPBRm2uRnZPUxupBCIsLyF3 L95dQfXdiAUWRhy4AoFiIf7vssy39N0gIf97bLCYb6UE+9UATBG8UEmpoSxSvb3y VSe4QWYZNxY7/CiTOh3EVoghZyEg8uCRUsZwXWBw32ptH23GUNZihG2RL0COZuPY JUo0rYJf6FqI9B/v7Pe1QA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1736334113; x= 1736341313; bh=20U5sO/u0uYru3hxNMHsooCdHBrAIIWG/43UdZigSIo=; b=M SIdJfQwmksvBJ00U9HcUOaODS1attuTNvWMQryD5z90DVgF6hJ7NU+/6na9R1zMX N4e5muAPBw/KbD4IiqcgMdfPyL5oytjmreBUaObCMGSlSguiImcZFV+PHOogQ0C8 sfMV/tSn2hosWoXw0QfBP8yg8ww3eBodDuz6q/i7vkKifow1ceZYP7CRJ/mj2xVC a+qiTqelX8Gs/hSLYFr9PAhNoCapvXPNYTkqh4KLORdzvEktytEn7MA+4vx6ltiH wkTkgfP+WzoCXr6QB8GCjvYhe0eFs2cVoTQLmYEZANUV5rBtinqFmbMvZKxf3ghZ EQACF6/J+VIomkI/RscUA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrudeggedgvdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhepofggfffhvfevkfgjfhfutgfgsehtjeertdertddt necuhfhrohhmpedftehrnhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrd guvgeqnecuggftrfgrthhtvghrnhephfdthfdvtdefhedukeetgefggffhjeeggeetfefg gfevudegudevledvkefhvdeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpe hmrghilhhfrhhomheprghrnhgusegrrhhnuggsrdguvgdpnhgspghrtghpthhtohepgedv pdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehkvghvihhnrdgsrhhoughskhihse grrhhmrdgtohhmpdhrtghpthhtoheprhihrghnrdhrohgsvghrthhssegrrhhmrdgtohhm pdhrtghpthhtohepiihhvghnghhqihdrrghrtghhsegshihtvggurghntggvrdgtohhmpd hrtghpthhtohepphgrlhhmvghrsegurggssggvlhhtrdgtohhmpdhrtghpthhtoheprghn ughrvggrshesghgrihhslhgvrhdrtghomhdprhgtphhtthhopegrlhgvgiesghhhihhtih drfhhrpdhrtghpthhtohepnhhpihhgghhinhesghhmrghilhdrtghomhdprhgtphhtthho pehvihhshhgrlhdrmhhoohhlrgesghhmrghilhdrtghomhdprhgtphhtthhopehhuhhghh gusehgohhoghhlvgdrtghomh X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id 1006D2220072; Wed, 8 Jan 2025 06:01:51 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface MIME-Version: 1.0 Date: Wed, 08 Jan 2025 12:01:31 +0100 From: "Arnd Bergmann" To: "Qi Zheng" , "Peter Zijlstra" , "Alexander Gordeev" , "Kevin Brodsky" , "Alexandre Ghiti" , "Andreas Larsson" , "Palmer Dabbelt" , "Thomas Gleixner" , "David Hildenbrand" , "Jann Horn" , "Hugh Dickins" , "Yu Zhao" , "Matthew Wilcox" , "Muchun Song" , vbabka@kernel.org, "Lorenzo Stoakes" , "Andrew Morton" , "David Rientjes" , vishal.moola@gmail.com, "Will Deacon" , aneesh.kumar@kernel.org, "Nicholas Piggin" , "Dave Hansen" , "Mike Rapoport" , "Ryan Roberts" Cc: linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org, Linux-Arch , "linux-csky@vger.kernel.org" , linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, "linux-openrisc@vger.kernel.org" , linux-sh@vger.kernel.org, linux-um@lists.infradead.org Message-Id: In-Reply-To: <26d69c74a29183ecc335b9b407040d8e4cd70c6a.1736317725.git.zhengqi.arch@bytedance.com> References: <26d69c74a29183ecc335b9b407040d8e4cd70c6a.1736317725.git.zhengqi.arch@bytedance.com> Subject: Re: [PATCH v5 03/17] asm-generic: pgalloc: Provide generic p4d_{alloc_one,free} Content-Type: text/plain Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: C8E9A40019 X-Stat-Signature: aisaom6d74r1oeazmq9fag5i4p8xmofn X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1736334114-733644 X-HE-Meta: U2FsdGVkX1+5HA46aoOqboqV1KQm1S9g6vwiWWv1QhRg7W8BLQqgtP/OgxORnd1p7zHKBBFsK+WKJiPDkvS03cQRTUEUMu7t/iYNnFjRremlgGK55Uc10ZOZbmlfsd4slrsjNhm4nQ1lqeNjWZT/MGcZ9hkE5t2ULC5LN/4wVFqjokWksukNbcQfFPO7bRJJXnNwprFeuSkJ/tJ88CULuqfsyuU4ampWUkJlRGPXoTbsueN42RhjlvUf81Vu37FWLbY4WpbnqtHuBkCab/InzawoLQ+FHyQXvGSb9mjKBuokn/owNfTygmp0UN30CA+SwS87aSShnuwjXmcHtFlayzRw3fFA17OV4GnkELR3KmPm3hrYDvRX7u45oSFSaKg8V6whpznNn4Xg2THJla+sz5nQxA/E7YciYQtsl3x0gPHSE3+DOcvbdZyO7xOKx7d0oFgWtxgVatfXTSNRj4L3wwYYAWdzXRm+niHNNPanZ+seiwl3bT2G0oACbe9x27+TgVV/4G161edHy5vNHUBXzSmQV1a9P6AM3l2RVTRCExSFG3FmuNsi8JOuWZwqHsRO3qLostfwDj5xmPNzg5dqwWsCCEuL0qHeeazeL8C0XQXk+CVCaPpTSokd9EaU9Juq9rDudiyII57/bFcZz1E8ElVNKxnms+UuOdp3w4QK5ZKEM/MmjXqOVbA6KBGgCQfim0URPeALzF97x13OfGgLypA1rE7LJ/B9x4jLvwT2g5wdCtP2hyFw/KIwyx0RCQC0dRg/71fW7ioJ8zFcMQPM/Axk+k/m9F2z3MyiFtdMuk36pgKZd+z/AnNI+1pD05bd1gZ7hYicDST/ZZ/EimuPk3BzG6WMEgDHBanfE0hYMYHd/MYCjYtp0fBLF/ZFiZckdU2Fy1z00g+nGK2gDewTcpCFr8TmX7fnV4s5EvmhI+lrzaScpurTCmjxznQC9SF5tpHKfrb2lfvIMTi+3KL /Aj6AZ+B JZNRh6oW7xBvvIxJpxpA88E7aDxQ286Pw1W/uBJO+9PXWIBRlKEySYSbdN8JBuyhpjK9UvSmgVST5yERvNRi+syTTTqu4SzFC64Ps2HZNyVdOvkXfYHsOyUKsI9z65nqHJNi/5VngSPhKFFbhvvc+Z0TvmSKD1tf9C6P6TMspvlJRPQ/bixlwRRqrQ5kNM6vgyI9Kii5c7CEvrcxJYA9BBFVhdwUBfx0WlvQ1G7KxhMZYY9WEzSiMfF5muXvoYJtag20dmbwdRj0o6RbBewCA4cwBFNDtT3IEKjXfTxBZChjRzxAbqiIgih123ClV5rj2MGYKrdBF1fD3oyb9rbKrpUwrORnP06YG2mZrO3vAU/0NU1E6IrT61OBbzKbyFWDORbRfFzCGLjItGvtUBSbj9SELGoLXjYSOnoAf9urMIRUeH/xWk/QX5evI8iocHFFfkqfM X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jan 8, 2025, at 07:57, Qi Zheng wrote: > From: Kevin Brodsky > > Four architectures currently implement 5-level pgtables: arm64, > riscv, x86 and s390. The first three have essentially the same > implementation for p4d_alloc_one() and p4d_free(), so we've got an > opportunity to reduce duplication like at the lower levels. > > Provide a generic version of p4d_alloc_one() and p4d_free(), and > make use of it on those architectures. > > Their implementation is the same as at PUD level, except that > p4d_free() performs a runtime check by calling mm_p4d_folded(). > 5-level pgtables depend on a runtime-detected hardware feature on > all supported architectures, so we might as well include this check > in the generic implementation. No runtime check is required in > p4d_alloc_one() as the top-level p4d_alloc() already does the > required check. > > Signed-off-by: Kevin Brodsky > Acked-by: Dave Hansen > Signed-off-by: Qi Zheng > --- > arch/arm64/include/asm/pgalloc.h | 17 ------------ > arch/riscv/include/asm/pgalloc.h | 23 ---------------- > arch/x86/include/asm/pgalloc.h | 18 ------------- > include/asm-generic/pgalloc.h | 45 ++++++++++++++++++++++++++++++++ > 4 files changed, 45 insertions(+), 58 deletions(-) Acked-by: Arnd Bergmann # asm-generic