From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39EFEC369AB for ; Fri, 18 Apr 2025 10:58:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0ACFA280131; Fri, 18 Apr 2025 06:58:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 05CCF28012D; Fri, 18 Apr 2025 06:58:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E1A1B280131; Fri, 18 Apr 2025 06:58:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C0B2328012D for ; Fri, 18 Apr 2025 06:58:24 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 14B271219D7 for ; Fri, 18 Apr 2025 10:58:25 +0000 (UTC) X-FDA: 83346865770.06.C5F91F3 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf22.hostedemail.com (Postfix) with ESMTP id 9EF0FC000E for ; Fri, 18 Apr 2025 10:58:22 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Dnxs6aHz; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744973902; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=u0MV4YptBECn0AEWRqEAwwCIqsmfcfaJ0sFseRPrKu4=; b=Tv+o+Vi09QFnpeYrcGhXlB+lmbfDTR+d8epm9akIiWvBZJ7VaS81eK7m1Tmn7iTLD+hInT 6jKSXbvP19GNEMP+2pJXFK2FoFbdFWXbOXhnXeHTM1ZnQmSdVXcJtdl8WtoPfsHgNlI5vI VENlhzweyHQsFz7FuNyoDxqdeZ1pmKI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744973902; a=rsa-sha256; cv=none; b=0zRYA9f00lf5sgOqaroUJF31TrRAFT77OFabec5Lr8I3niC2TCdsUPOtsQ4nQ1m8M6FxyY ZlW72yv7/Gqa43xBEKpIDCmrdXL4jMKNN0H2w2MIufvf/nXO+wA8u4xySOSXDz5Ik1wnFY 7d4BUmmW8UutGAprhRMojX8ptn9NEJI= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Dnxs6aHz; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744973902; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=u0MV4YptBECn0AEWRqEAwwCIqsmfcfaJ0sFseRPrKu4=; b=Dnxs6aHzQsDyZqe3QtnjdMTg4RhcPikVEpTi1z3iKFOisEwdd7i5F+spEp4VyPw7mlWMcj 1F4niUAEIIV1pySmVjMJpGV/U0hMbglvQ3/T4YMpKqlxQ+zWGhOxBNHeZxlTkzHCNhdWNM /fjcZTZU7ZAUaFaYidDuYmMmNNqllaU= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-138-mfZLACl_MJmi58tJMxb7Vw-1; Fri, 18 Apr 2025 06:58:18 -0400 X-MC-Unique: mfZLACl_MJmi58tJMxb7Vw-1 X-Mimecast-MFC-AGG-ID: mfZLACl_MJmi58tJMxb7Vw_1744973898 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-39126c3469fso673415f8f.3 for ; Fri, 18 Apr 2025 03:58:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744973897; x=1745578697; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=u0MV4YptBECn0AEWRqEAwwCIqsmfcfaJ0sFseRPrKu4=; b=ucFFTSLQQckBLoNsIN2zUCL+HyMM0zPNcoCya5OG+WtqeU+CX2U7ZH1XFYc8t8zdBX EXUk6KfhImbNzMNeF8TcbsFlKbeXdz+r+mOAfgpSO7c4SMdaI1Hn1cGHBKA8dBsgMUoY ukmVx+Qleo9Vdws82cQK9du6mfd4A/e781XW8ajMDrNFVDLxiEX8NKk8OUNrFymqw+4Y EbqLC4N224IbOqORP9m9iMp2imN1KCcDbDFnxKLVDQgX4fspih6kPzdY+3BQBz2Zm2nS Jq++MrByyh31c1ov9aWlbAPGbHV7qJfwSd80yn6jl0+8xlF7/CqFgcZDVRR/g0wGiZQ4 HAkA== X-Forwarded-Encrypted: i=1; AJvYcCVeoCQQw/SWeQa/cqcnBoSaIpTR+4h6Qa9kFMIIWR0tZmi+arJn2P3gja6kdhfpPinPEAR5jP8G9Q==@kvack.org X-Gm-Message-State: AOJu0YxVC12SMFgRPBP44uG93GwI4MaHfECHg+HF9mpAf900cnLR78uP vMUVGQ6oNjHHLogGaQ96Kzol8NyHgmc5VLiHIWs3VAzl8NP+sEjYLAJuzH8F3ATDyP9vCBJLtz6 pv1hpI5ZEjEt7clt34GRNDoCaGUkHBZEU9XhGMywBvjTc1FMe X-Gm-Gg: ASbGncsM4QaD2wQU/MXvh0enQ6r6WwYQWwG6MdB4S8coybNTfGQ6JCfaFVWFejU80Kx GMEvXTiTHjsUaUm99Q/RRjymetKj+Z2IjWURIdkkeTZjMeI2PldX/ItV1aB3HysbKx5lCdL1/uM 33JrFqr8mwN4prO/wt+elEA+56X1LXC0bs1WJ6ChZHIa6NuqIoRz13knK65O61HHpCC3YuEC4sM jdIx3aXAKujXm+9e6nnaHN6gYSeMwEizIqylMeD1Vx1gYz+II87UcnObrsAsctxc0rhmC1omVz9 GqJmC9goMZJ7qMtgp8mtQZwcGgnKwtkHtvP6r3kQrK7+x/smHWbfO01ywU6b5zOGd6s9Efoi4No 93BQ3Cocwmu33Boi87jxo/6G+ocAoYQxQuoaYwLo= X-Received: by 2002:a05:6000:1846:b0:39c:11c0:eb98 with SMTP id ffacd0b85a97d-39efbae03admr1796869f8f.39.1744973897618; Fri, 18 Apr 2025 03:58:17 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHWVydDYkQahQCU3P6/5YeQqHOxwuV9tHBqkFWlpkBjSfFSUtaDqNUuaHg5loIpQnY5j20cMQ== X-Received: by 2002:a05:6000:1846:b0:39c:11c0:eb98 with SMTP id ffacd0b85a97d-39efbae03admr1796858f8f.39.1744973897286; Fri, 18 Apr 2025 03:58:17 -0700 (PDT) Received: from ?IPV6:2003:cb:c70e:6700:cada:5396:a4f8:1434? (p200300cbc70e6700cada5396a4f81434.dip0.t-ipconnect.de. [2003:cb:c70e:6700:cada:5396:a4f8:1434]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39efa42082csm2417281f8f.3.2025.04.18.03.58.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Apr 2025 03:58:16 -0700 (PDT) Message-ID: Date: Fri, 18 Apr 2025 12:58:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] mm/rmap: rename page__anon_vma to page_anon_vma for consistency To: Lorenzo Stoakes Cc: Ye Liu , akpm@linux-foundation.org, nao.horiguchi@gmail.com, linmiaohe@huawei.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Liam.Howlett@oracle.com, harry.yoo@oracle.com, riel@surriel.com, vbabka@suse.cz, liuye@kylinos.cn References: <20250418095600.721989-1-ye.liu@linux.dev> <20250418095600.721989-2-ye.liu@linux.dev> <9490ed5c-f6e0-40f3-839b-7b3a5decb5f4@redhat.com> <752651d1-7cca-45b8-b5ac-9c32ab97e9fd@lucifer.local> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <752651d1-7cca-45b8-b5ac-9c32ab97e9fd@lucifer.local> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: tagS2A09VhmOg9PhZ03xxZCxr9tKucrMVFsIpoBaO_E_1744973898 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 9EF0FC000E X-Rspam-User: X-Stat-Signature: s9ohkw7i1pdzwoi7otdrsu564dfy5pt6 X-HE-Tag: 1744973902-117896 X-HE-Meta: U2FsdGVkX1+4X5vebuX4t4JpNFwJUPUwEQF78Yee3fedSZUS+MCEhp3eI/45SAk3L7PS6gJPU2dxEQvZWejw35wl85CNLj4cJ1OXOOEqs+KQuemiXT4bJLzxYqgBfTvqkg3m1WBB03ATeCvekO+Jd2iX6Q4TGW6u2y1Z9l3Yus9hROSsxevnA7xCP1NvYCnr1QWJOFb5p1Yp7pLBEzZyxUdAcfH/X1XfgMM3TxGuOezq5x9oxZzgoEzfvQjMnmEuCScUnbCc1p/QV+dxeTrA89QcNyOma2hUyxKOfWcfKsPOVeX5iiSAZrmkipdM5W3DtWxQw0L1cSQDZWDbtLOViFeJd7no9FxyQGyuDzs8eMW6ZvjcA5M5sWt7/j3jSDRnO8wFseZt7w44DwiIc9noxMadGZfDpC9/4F7Dx9980q5lrrqCc7ZkrL5774OV44G89wJKZ4JwVxwgdskCkTZTm5yxUa1G8YZxpOkjuG/5XB+7ISUpH/AZXe37xR/prPP6mJAn8/qOBZ1FqBaM37In99Gzzs/SVvVmKe93JmLA32M4UyOg+PEArA2UV5yfQa18NxiX5w/bubpoAZvOEJ8eLjzQ8ax1UA9Xuu+hicpHfMWpfcQKJ6igqvfNMe5iF5xrW/lpkBpgCaxgJJJ6i5bqgSVsw3YDt/N9Fl5AfpvQRuC5QYgLOZHPkNjK5iu5fkOkuF/5TOLIyE68t2t1eB2uCx/rpXWKp5smBym2qY55eW2dk+NfuGF/ksq4jd4yAdTzFR7FSg62KZwyAhBm1oDH8i1O6B0uE+zV4clH954rd/OMt5K8h7t9hDbjX/z6Wr18X3QA7NlGe08sJ2KaPaeEGg6Zo6/4fzqAahf7fDdH/gR6q92RCKmImXfJibjniAD9zc70cl+qly1LbgqcShfq7GvepO3jfhpweMbtvfV8+z5+hF5LIo26kRcv5NaJO/IcEzemQJ2tlR0JBqYAygZ ypEafqWP kuBeaRtk/JnDcRKWqycirA1NMZgwzPCAJGyAb0EeHs7tWCVrMiF1jM49JKAB1b+Kg4l1QLn2+9swJBYYLNnNmc5kRLOPyGOnpIdUWyvAxLUj1382n7yW0Rx26aJorVsL1kocSTV++zm9xMgpAFke0XCsT5edtv0SLahIuTVk9cP1gSWQURzUdco7Wi0v3tMf4sntR X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 18.04.25 12:50, Lorenzo Stoakes wrote: > On Fri, Apr 18, 2025 at 12:40:10PM +0200, David Hildenbrand wrote: >> On 18.04.25 11:55, Ye Liu wrote: >>> From: Ye Liu >>> >>> Renamed local variable page__anon_vma in page_address_in_vma() to >>> page_anon_vma. The previous naming convention of using double underscores >>> (__) is unnecessary and inconsistent with typical kernel style, which uses >>> single underscores to denote local variables. Also updated comments to >>> reflect the new variable name. >>> >>> Functionality unchanged. >>> >>> Signed-off-by: Ye Liu >>> --- >>> mm/rmap.c | 8 ++++---- >>> 1 file changed, 4 insertions(+), 4 deletions(-) >>> >>> diff --git a/mm/rmap.c b/mm/rmap.c >>> index 67bb273dfb80..b509c226e50d 100644 >>> --- a/mm/rmap.c >>> +++ b/mm/rmap.c >>> @@ -789,13 +789,13 @@ unsigned long page_address_in_vma(const struct folio *folio, >>> const struct page *page, const struct vm_area_struct *vma) >>> { >>> if (folio_test_anon(folio)) { >>> - struct anon_vma *page__anon_vma = folio_anon_vma(folio); >>> + struct anon_vma *page_anon_vma = folio_anon_vma(folio); >> >> I'm extremely confused why this should not simply be called "anon_vma". Why >> do we need the "page" in here *at all* ? > > Presumably to differentiate from the VMA's anon_vma, but it seems redundant > and silly to preface it as the page's (really, folio's) anon_vma. Exactly, thus my confusion :) > > The original patch is strictly an improvement so I'm fine with that, but we > could also rename this to anon_vma to make the function a little simpler to > read. > > I guess the key bit where this becomes vaguely relevant is: > > vma->anon_vma->root != page_anon_vma->root > > This whole thing seems to be to deal with races with unuse_vma() as per the > comment. > > Anyway, TL;DR: fine with that rename if we want it! Okay, let's drop the "page_" part if possible. -- Cheers, David / dhildenb