From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF54EC77B7A for ; Tue, 30 May 2023 08:03:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 388716B0074; Tue, 30 May 2023 04:03:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 338C26B0075; Tue, 30 May 2023 04:03:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1D92C280001; Tue, 30 May 2023 04:03:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 0D6C66B0074 for ; Tue, 30 May 2023 04:03:20 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id CFDB21A0149 for ; Tue, 30 May 2023 08:03:19 +0000 (UTC) X-FDA: 80846181318.21.E203183 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf18.hostedemail.com (Postfix) with ESMTP id DA3781C000D for ; Tue, 30 May 2023 08:03:16 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=QqJvJXdj; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=KjrLeWrX; spf=pass (imf18.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685433797; a=rsa-sha256; cv=none; b=Xql3EjRscfdIRhja3vc3cW6HIPUbdqbHV1LLydMfhQjXYq/FzB2HiGuPmmHdLJ1pjX70z7 OhRuCt7/zzZcvIb2AiwkkDAO98ZhEvt0qE7MV+SUUixjSIxAJXwHKaRkgSsotybW5TiS9b NGTjRERnOvTCF6Wxac3ze9kiVgGQuJ8= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=QqJvJXdj; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=KjrLeWrX; spf=pass (imf18.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685433797; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+qoS3jIGlkGKPUSBmvDpUF0eZZvpHB3VQF5UkbjDa9E=; b=GK9+ZBHJ0iwJehoupBaa8ypN8xTvc8g2BM7HQW0asLsnKTGoT5fRKPnEPF2HoWzKcRGVqN OZi48NpceXm2UkDeGS+Se5EnGItn2ugHROIzviJZ6kg3ZfVtes6H0/PXdhw5VtJ7V3z9ff e8NppCHixdcB/WJMlMgTSTwz929Mz0I= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 4EE2C218FA; Tue, 30 May 2023 08:03:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1685433795; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+qoS3jIGlkGKPUSBmvDpUF0eZZvpHB3VQF5UkbjDa9E=; b=QqJvJXdjmHGYAFHj+C/oCXHEEmpyjbpt3lHiorTLWJnzfPd/A4USCED3ZzL6PDBqezMrPc P+/2OT0TbHmykTmkdjBjLM9ys2AjrcQF+58sU1uN9ewdFwRrEBpvMzTLtalgwOlR/D+GLx BCH0KL6JHQG9/hX8V8s/bbgbXAuazmA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1685433795; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+qoS3jIGlkGKPUSBmvDpUF0eZZvpHB3VQF5UkbjDa9E=; b=KjrLeWrXT/WSCfbdht4AaM45VsO+plc77xE5L/o9KJ9wVXgKzppcRAcXx/JZ5RZJbC+W0H 1laj5UwAzHlQiHDw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 386F913478; Tue, 30 May 2023 08:03:15 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id SBQjDcOtdWRUJgAAMHmgww (envelope-from ); Tue, 30 May 2023 08:03:15 +0000 Message-ID: Date: Tue, 30 May 2023 10:03:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH 4/6] mm: compaction: only set skip flag if cc->no_set_skip_hint is false Content-Language: en-US To: Baolin Wang , akpm@linux-foundation.org Cc: mgorman@techsingularity.net, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <0eb2cd2407ffb259ae6e3071e10f70f2d41d0f3e.1685018752.git.baolin.wang@linux.alibaba.com> From: Vlastimil Babka In-Reply-To: <0eb2cd2407ffb259ae6e3071e10f70f2d41d0f3e.1685018752.git.baolin.wang@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: DA3781C000D X-Stat-Signature: 1aiosgfhjoyb13dsi5nes4b1pin5pd83 X-Rspam-User: X-HE-Tag: 1685433796-769789 X-HE-Meta: U2FsdGVkX1+zWXmzDo6/iMWdpWQwVqyaPzUd6MGOW8oY5dsPiCFIMnzJ6rfntZQSVukAomA4/C4C3ZaM9RHWWL8kLW612lm4Djh51E5HK1Mm5OVPeaR0TLf4FRp8PEs/nkFYo2YYcnqCdggAMF42rBYSgWsj6fIjvP4xRtUzidQaxJE70HAsfxou12mzzmH767kDM9+ueGRwZQE7BDfVYvIlMBxqfM9eBuZoO4iB7D2T9cM60DPH4YkoesIYoFRCJ5ZwTgL0Yx9F4hGNLZ1Z77w7uR1T00IGJivputKeX+3+m+bxN7sKTBbPxUluZpN7DfqFv4xYH52nW5JBcXSwzF7zwKVBtWRh5LhhpbOBAQcd77KxhejvH38KUQX6tfB29UWdkEnuR8k86OIAotsMqzNMEpMD6Hk4AkzwjOame6mJNlo54aJlj0GrJIaq2U0eX/rXAUpPeCdKrNOeatzKan88VcetdxcUrAt+aBZGMmksTPWTL8qmaj0//gZloksjpC1ZTNuogZcPdLjlTvb0ld4rsxExy/uqDkmwcFS40B0rpm+PUOt0wxbeApwKPyadlM5sIO4HThZNMHsROxNUEGL5gs4C6gAf9yiqYO0WzpaLHkNDMuVuxUH2jNzB2Ng3VwkbmRGNGdTkAE9hCLCLXOY9oJ5noPBjd4owYMKCKCU6y6qjghVLif/GVR0bYZS2HOSuL1HOYKL2HWFfwNfEBQLqN4ee+u5lePU3QM2HV87D3VBwof/4XvHrjiHlgOVS6Q9qLc3yQMTW8Di+vFHZnrIqcOWIj63BTOg82Hssbf8pPDLaHHcrj68WA+gSNK9cHG2bhPoZ1gfICxkTu/kO1IhE+Pdzf9JhufAMJ/Fgbri4sl0/86euAuacijQnzUYnCy2Day+mBjHtA/vG9xtRdayYbmdpHRzLi3ngyexCk2LY6QM+lYOZRxWnpPc5ip+kzENYdlOdp/QLlDAb3SH hokBCdLL b7H6yja4sescxMOD1h1+mvF+i7JRK/TnwWO6Phb0wXXd2Ex6+TDz0UwBCvgwiWI9XD8GO7wcX+NNlkGLZLef1RKhcA7/jjc0jFDpH26/K5ailwnhdRNBrb4ogA0wpAjowTjzqZEydZebUNeXRcfBdWMqU4YKLuUQnQCpKaqCMePemoGLjOHHR9lrnPNxqlqkhFwH8TQiMECLhXyMv6LTaO1Y0Del6WtPIiId5GCrOl2gsEGcSk/o0S13B17Y5vI1NK/87StWu4rRX6cQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/25/23 14:53, Baolin Wang wrote: > To keep the same logic as test_and_set_skip(), only set the skip flag > if cc->no_set_skip_hint is false, which makes code more reasonable. > > Signed-off-by: Baolin Wang Acked-by: Vlastimil Babka > --- > mm/compaction.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index 1e5183f39ca9..65d8d9223acc 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -1223,7 +1223,7 @@ isolate_migratepages_block(struct compact_control *cc, unsigned long low_pfn, > * rescanned twice in a row. > */ > if (low_pfn == end_pfn && (!nr_isolated || cc->finish_pageblock)) { > - if (valid_page && !skip_updated) > + if (!cc->no_set_skip_hint && valid_page && !skip_updated) > set_pageblock_skip(valid_page); > update_cached_migrate(cc, low_pfn); > }