From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41BC9C4332F for ; Sun, 20 Nov 2022 16:50:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8FE256B0072; Sun, 20 Nov 2022 11:50:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8AE148E0001; Sun, 20 Nov 2022 11:50:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7760D6B0074; Sun, 20 Nov 2022 11:50:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 65E806B0072 for ; Sun, 20 Nov 2022 11:50:27 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 263D61407BC for ; Sun, 20 Nov 2022 16:50:27 +0000 (UTC) X-FDA: 80154408894.29.DA9FBB9 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf24.hostedemail.com (Postfix) with ESMTP id 6423018000B for ; Sun, 20 Nov 2022 16:50:26 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id C423D2234F; Sun, 20 Nov 2022 16:50:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1668963024; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KfVu7FWkHQ2Bojm6W10rAhMWKqZU3HIBARL9zZ8Ec6Q=; b=ClCAE1gTBD7L0VHqYX1j1nPLr8bzlVQR367tUEYAo+XO0eBUZse8pBuW0kz2b6gPjNRZBn aQGUA7mXLZ1wbExWdMVlF36LbyBzZErSyi6rqCu7DyeJWhB1bMmEkL/XF3hjAkqluHGc2t m5d2XY4ySVoN89WBjiON/DcRpV1L0ws= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1668963024; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KfVu7FWkHQ2Bojm6W10rAhMWKqZU3HIBARL9zZ8Ec6Q=; b=4bUXNii3ybC/Lc1z7dMzDj/jXBGbveL1kNLLsyAbN1AL4OXRRGCXm6TDlVWaovZAJORDw0 bgOxWnAg0gUOoiAA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8C98813216; Sun, 20 Nov 2022 16:50:24 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id +1/FIdBaemOlWAAAMHmgww (envelope-from ); Sun, 20 Nov 2022 16:50:24 +0000 Message-ID: Date: Sun, 20 Nov 2022 17:50:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v2] mm: Make ksize() a reporting-only function Content-Language: en-US To: Kees Cook Cc: Andrey Konovalov , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , Vincenzo Frascino , linux-mm@kvack.org, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org References: <20221118035656.gonna.698-kees@kernel.org> <230127af-6c71-e51e-41a4-aa9547c2c847@suse.cz> <202211180907.A4C218F@keescook> From: Vlastimil Babka In-Reply-To: <202211180907.A4C218F@keescook> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668963026; a=rsa-sha256; cv=none; b=BxlosXMYt575yuR8O02ZohOr1m1PlvsrAyHrOZhJKqLNuCYjbY2lZkvXVNg8Iqoin3sNlP FWU784psba/H8SdtWRFzht7pMfh9djFseH89PoVxLLzmULkT4enmSMlcYkOHaTuD6ZpZMT wY0Oqur0uKy1XmTiskesuWrQfekU1IQ= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ClCAE1gT; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=4bUXNii3; dmarc=none; spf=pass (imf24.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668963026; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KfVu7FWkHQ2Bojm6W10rAhMWKqZU3HIBARL9zZ8Ec6Q=; b=2dddAMibhlO8VqEKpBUUuf1M1NQZrpp3b4YrGLujLkQCUyGZQlII2bxyelBSUzKax89XwI NSvrDDvrkFDSIsJXGgP7Ojo+22Ct2k3cUYYpQc/lGS9/pDNlTkxqVw2MNhULqJdGZdMzfF SiaeBe1DJd8fx77uXB0EigSlCe/u+l4= Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ClCAE1gT; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=4bUXNii3; dmarc=none; spf=pass (imf24.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz X-Stat-Signature: twsbct78bb9xxwu19qzh5ji3adg1gzrr X-Rspamd-Queue-Id: 6423018000B X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1668963026-428477 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11/18/22 18:11, Kees Cook wrote: > On Fri, Nov 18, 2022 at 11:32:36AM +0100, Vlastimil Babka wrote: >> On 11/18/22 04:56, Kees Cook wrote: >> > With all "silently resizing" callers of ksize() refactored, remove the >> >> At cursory look seems it's true now in -next (but not mainline?) can you >> confirm? > > Almost, yes. I realized there is 1 case in the BPF verifier that > remains. (I thought it was picked up, but only a prereq patch was.) I'm > going to resend that one today, but I would expect it to be picked > up soon. (But, yes, definitely not for mainline.) > >> That would probably be safe enough to have slab.git expose this to -next now >> and time a PR appropriately in the next merge window? > > Possibly. I suspect syzkaller might trip KASAN on any larger BPF tests > until I get the last one landed. And if you don't want to do the timing > of the PR, I can carry this patch in my hardening tree, since I already > have to do a two-part early/late-merge-window PR there. OK I'm fine with you doing that, there's my ack already, hopefully Andrey is now also happy :) Vlastimil