From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3351CE7A81 for ; Mon, 25 Sep 2023 07:18:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 636FB8D0008; Mon, 25 Sep 2023 03:18:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5E69E8D0001; Mon, 25 Sep 2023 03:18:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4ADD98D0008; Mon, 25 Sep 2023 03:18:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 39AC18D0001 for ; Mon, 25 Sep 2023 03:18:49 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id DA21B80785 for ; Mon, 25 Sep 2023 07:18:48 +0000 (UTC) X-FDA: 81274267536.13.4B95CE5 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf20.hostedemail.com (Postfix) with ESMTP id B9BFD1C000B for ; Mon, 25 Sep 2023 07:18:45 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MY0g3mWe; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695626325; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Fcs7WDgaaor+yyoRDl34XzlrYWO5pL3qK+P9ELjfqAQ=; b=RO16ZziKWIaQBnd/OwOhnjYajFtvOYlkPLoJ7Ir4VICFbg8cPOo/m7ZAAxJKXW14vurOCk 57oXbm7bZ9DG2t1hWS0ZhwWacgc7SfWsmBESwsEK48xvrDRCD4ZZcmluoGqGoukc1I7gls 6OQeIDhsCVAGZnc57KzmrATpS2Q7T8I= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MY0g3mWe; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695626325; a=rsa-sha256; cv=none; b=IS+jRKzk6CdfAsNxXlfYzLM6xPa5Zc645DFdfzqrZbCkAG9ORVMe+0Pkar2PmxH8yfLTP4 f20kbKh+AkBAHftZr6FX5SCojd7iJaQcUKbJWGO7iy5GuKosl8+8yndTkM519NaFup1sEB Ic3NSHRDPnZCh7vti5G087tYfCvVHV4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695626325; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Fcs7WDgaaor+yyoRDl34XzlrYWO5pL3qK+P9ELjfqAQ=; b=MY0g3mWepyFr7/4lKR2yAte+XWcaGiylmIb5MNHBeJleoNgGyIrVPAaEVuxIzkYeWYbAU3 AA+gSqyzV/UmN1ePYDUNhJr1Yl7hLeXVH0dusxN+mU0F3aPq1VAsjhn3ktVFTEPhRf4sO6 E/BDR6pEtsg82+SP47W/akZd1jpsxdI= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-593-eAhVTiSxM_ylLIadgp22yg-1; Mon, 25 Sep 2023 03:18:43 -0400 X-MC-Unique: eAhVTiSxM_ylLIadgp22yg-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3232c3df248so549785f8f.3 for ; Mon, 25 Sep 2023 00:18:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695626322; x=1696231122; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Fcs7WDgaaor+yyoRDl34XzlrYWO5pL3qK+P9ELjfqAQ=; b=MdPZPC0QPam0V9cqZVNKbvP7eo4zH9fKeibadmL6N510xlsbhQl0BXfaWFoCP5hUYI f3jCnqjnLTLstsuqrhJp8nDmN/Bp6uOMS6WS5ns2AbhqVNkSB8S/6mzBQn+Gkjh1NYHv MfESj7KX9ECuAEmFT2C4wu69LJ6p8r1wRaZDTqVuKuEw9yU2xiya/rWCH8CZ8TKwcQTb y0E9oMkAGCDGCiJSpW3oSMzMYvpIpZTA2iguHrHVURPUb/h+0rq9V9Aolrwp8RWZ7iU8 GTjRFQtS1sTAR6Ub2nRBUOXlDIFXsmgUHMqZmS/XaENrirdntlgLzxCNfmZQeTSrS1Xp tCGw== X-Gm-Message-State: AOJu0Ywtx/TLmginikVR39IGDWm8y6dwLjpM2zrd95F+SDTgk4VhUJlc 7abU0Rvj1okgWGG0BJDSYvcy6wIfl01D1RWMx8xhW0BgfhbRze40Cg4y8yY7GFpgX/cHCWK8l4H V3hLkTOJoPVc= X-Received: by 2002:a05:6000:1042:b0:316:ee7f:f9bb with SMTP id c2-20020a056000104200b00316ee7ff9bbmr4957011wrx.65.1695626322205; Mon, 25 Sep 2023 00:18:42 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHHNnV6BW/Dwz1YloekACrBUY61xghgDgRm46nbk5hePHmA1Qz0sMXucB3bceggj+tGoILiGA== X-Received: by 2002:a05:6000:1042:b0:316:ee7f:f9bb with SMTP id c2-20020a056000104200b00316ee7ff9bbmr4956992wrx.65.1695626321798; Mon, 25 Sep 2023 00:18:41 -0700 (PDT) Received: from ?IPV6:2003:cb:c736:2800:494a:6093:9096:6ae1? (p200300cbc7362800494a609390966ae1.dip0.t-ipconnect.de. [2003:cb:c736:2800:494a:6093:9096:6ae1]) by smtp.gmail.com with ESMTPSA id p5-20020a5d4585000000b0031ad5470f89sm11001731wrq.18.2023.09.25.00.18.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Sep 2023 00:18:41 -0700 (PDT) Message-ID: Date: Mon, 25 Sep 2023 09:18:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [RFC PATCH 1/2] mm/khugepaged: Convert __collapse_huge_page_isolate() to use folios To: "Vishal Moola (Oracle)" , linux-mm@kvack.org Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org References: <20230922193639.10158-1-vishal.moola@gmail.com> <20230922193639.10158-2-vishal.moola@gmail.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230922193639.10158-2-vishal.moola@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: B9BFD1C000B X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: h41iohq8myg9o8dg4fufrm8epoggdc63 X-HE-Tag: 1695626325-191534 X-HE-Meta: U2FsdGVkX1+gok3c43njN+foA2T0bFAg486Nc09aSZHCnvgaA7CNRlG45aF5puu2+CaKCu0sfNrgEK/JA+iHq3YhCJfpm2X4MQz6q/d+ybylWxrw3p4DJZDrRUFIRABTISLrfMRsq6kn3U68T/LT78YNNMyKlSywC/vg23dx2Cgd5uMqIu+EaySvRZLX8/FBut6lGtoNMMO2dnOZKhCmT86gq0l16ABBm/GfTgsiJBLeTw2h4SC3xTq1iSuucy87tkZ3Vmn/5Lm0KJYezHf/Kg/4UgJivJ8JSUylHtkeScaIgAn0wbXyhqN7yLCADiPTucIOvvPbEpHOMLeq873o2qgUR7UKOsm6E7SrR+UKZKKt1ARIxYnK41hD1WjNqpK6ZXJEhMXjXYbd8q2pfSwG9kQzASmOVkUrQ7Se/GYnIQ0AHLqgUAFDfj4I7pvl/nQKJHoInwOVvOVgJpoH8RuVKR3g/sng4iuQWQUHnzG+6tQdygC5W9v1Yk0e9hCwEA2L9+9z9JRKSaKhqA6V37caIgaN8AGIiISfz65YvGPq1bbw+L3sUzpyifMu9++75GbrNUMLoOt8a+0167bpsreBMMcn6v8QQchhB54sswg6Up6lyYTMxMn1+k+zVzm68LDGZVdY5EZZPCFlGhWrWcfVWjlOCiGLJ/XPsu9VvdnKCt3zzqSZ+sqfYejxBHXBgzrOs0juTMvtnf+O0bMePT06DhNWbAvMso4Fh0ohLR53g9Mhgfk75eZ40/6A5EjZy/5Yw62yH0SXJ1gLKRTXqkVE3nnUn22P7J2pGhykUYZ5TSj81vRfsj77XT6VMomfJnQondN6D3QoDISekH1d3NO39zpSaOtuGVCbzbl+p5PFB+c2BwGKnJHtqH2Qsug8Fh6VHVuEG4raYEbjpwN7x0pTIUk0zF+ag5Mvu63f0C6oAss+fD6Hi1CLnHLYXFzY6A9dgUL7qOxYGogC5acdC21 qtJSnbbN co29M7uGpvnaws2P34Y4EbTzuBpe4UvJ95lUx3TVew7vfgR+FW6gqz454OGym5BlmayQEu8YJEeuMmggRysxxTRMA4sBegWLVKAsaeAB18+59AfKRXc0XtEMunEXn09RLxVRMCumMdyoMQy7qpo/sWAepEn7MCrcSzJ3t4uDLRrKSGgYElfZkLyfpv4t8El04BDSL5KMOFlntwx3xSneMqsqNz/hgEKRNnB/kn9vqF9i5RvL82v5hXenJIb6SD229rws61wK9AAWH91XRra+FGeWT7+QV0vV3q/OrUczmNuVI4w1aDrTXilONTjKZ8ovrMlEvFwcAPVeDf+7Bi7hCNw28l8CnvB+udZ1Gr3lbuR0tvLKGxzbNwk0NClf5S0S9NSyezYCqj9VitVtkI40xio9Vh3+2TougckRU6wCffUbUusx3n8+a9VfFL5YG2WvcmfBNYxt2YFcrIYHYBzYeBic130Q061t9llfE9pUZwJDnNh5AqfAGzx5go/3BHj2pYH4nGL8cLuTEPKnJMIaT9BR6TQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 22.09.23 21:36, Vishal Moola (Oracle) wrote: > This is in preparation for the removal of the khugepaged compound_pagelist. > > Replaces 11 calls to compound_head() with 1, and removes 499 bytes of > kernel text. > > Signed-off-by: Vishal Moola (Oracle) > --- > mm/khugepaged.c | 52 ++++++++++++++++++++++++------------------------- > 1 file changed, 26 insertions(+), 26 deletions(-) > > diff --git a/mm/khugepaged.c b/mm/khugepaged.c > index 88433cc25d8a..f46a7a7c489f 100644 > --- a/mm/khugepaged.c > +++ b/mm/khugepaged.c > @@ -541,7 +541,7 @@ static int __collapse_huge_page_isolate(struct vm_area_struct *vma, > struct collapse_control *cc, > struct list_head *compound_pagelist) > { > - struct page *page = NULL; > + struct folio *folio = NULL; > pte_t *_pte; > int none_or_zero = 0, shared = 0, result = SCAN_FAIL, referenced = 0; > bool writable = false; > @@ -570,15 +570,15 @@ static int __collapse_huge_page_isolate(struct vm_area_struct *vma, > result = SCAN_PTE_UFFD_WP; > goto out; > } > - page = vm_normal_page(vma, address, pteval); > - if (unlikely(!page) || unlikely(is_zone_device_page(page))) { > + folio = vm_normal_folio(vma, address, pteval); > + if (unlikely(!folio) || unlikely(folio_is_zone_device(folio))) { > result = SCAN_PAGE_NULL; > goto out; > } > > - VM_BUG_ON_PAGE(!PageAnon(page), page); > + VM_BUG_ON_FOLIO(!folio_test_anon(folio), folio); > > - if (page_mapcount(page) > 1) { > + if (folio_estimated_sharers(folio) > 1) { For a tail page of a PTE-mapped THP this is not the same. The possible side effects this might have should be spelled out in the patch description. -- Cheers, David / dhildenb