From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEE07C10DC3 for ; Fri, 8 Dec 2023 01:20:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3E8D26B008C; Thu, 7 Dec 2023 20:20:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 396F46B0093; Thu, 7 Dec 2023 20:20:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 260EA6B0095; Thu, 7 Dec 2023 20:20:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 1150A6B008C for ; Thu, 7 Dec 2023 20:20:36 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id E6505A1105 for ; Fri, 8 Dec 2023 01:20:35 +0000 (UTC) X-FDA: 81541896030.14.0E05405 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by imf14.hostedemail.com (Postfix) with ESMTP id 607F1100009 for ; Fri, 8 Dec 2023 01:20:32 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf14.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701998434; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=t3zRE1ib3eVluIw9812to3c6afI0u5isvYtGeugfp/8=; b=8m/yeqIbgtorD0XaCT2LN3nSaTo0SwowSI2rmi2r9OnKmm/vTYyFEFmx4TSQS0V812w5i0 N8+/mvFkqfe/4srUjj/cKwR/4HbYN/WC/AWi1oZAUWeeYcDgGDNUi6cYw0kOHokxrTB1T9 TzRhJI+DyMDMcIHwfRUlAjDO+zsxAFQ= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf14.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701998434; a=rsa-sha256; cv=none; b=33lyDDPYWmvZuiD+hK30SFZF44q7E4SG89di3I610MbWsX7EizK4NYTSX0/4xAVHBJbxhb f7lTn8N+CRB4Bdxw7wAJgiKGqRbZpFjDKm51AFtGqYyh7OWX6RE2WBPY20vaYJOf0h9GB9 ZYFmVebsE92q6Xpn3CwE/GLjPRJ40II= Received: from dggpemm100001.china.huawei.com (unknown [172.30.72.54]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4SmYGw6HsPz14Lvb; Fri, 8 Dec 2023 09:20:24 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm100001.china.huawei.com (7.185.36.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 8 Dec 2023 09:20:26 +0800 Message-ID: Date: Fri, 8 Dec 2023 09:20:25 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: fix VMA heap bounds checking Content-Language: en-US To: Andrew Morton CC: , , , , , , Ondrej Mosnacek References: <20231207152525.2607420-1-wangkefeng.wang@huawei.com> <20231207141613.1d7d59d8c151729e25be53fa@linux-foundation.org> From: Kefeng Wang In-Reply-To: <20231207141613.1d7d59d8c151729e25be53fa@linux-foundation.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpemm100001.china.huawei.com (7.185.36.93) X-CFilter-Loop: Reflected X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 607F1100009 X-Stat-Signature: dr614o8531ugmsir7ps335iqowmu4uib X-HE-Tag: 1701998432-112549 X-HE-Meta: U2FsdGVkX1+A/COIJIhkPL2rq9vlM4LTz2MSXtj690Hoc+W7dR3QVW1vtIuC50SWm/XHQ3MS9WGFB1djo2TqyMuvpSe9c2/SsFGG3DnkorK/WaIneOrb835Qj+jZV3KcUFVJgrKzUq+KS2XjpaEbQr2NooC+vBiS68zkUJGtgL69IxzDkzo5sKcewJ3tdKYCHd4jb0h15v7v5VKmaDVFM+KA6RuPyF1I0NBcNv2NO2mDBszh9nAgVFI0OAqImY4eGBiVdc6NfB6+s2DieQDpN54HkGoBGgjNQrEyqQlJ2fTuvlGzcCQOGDjrRhBzd9+WpZgB9U5ue1HWssiIVpYthAfrdOzDUUIRnVM3Gen8E+goAvQT55KT3oaJMUTPiuNTUQAgumKkGHW4VlJNDeu5YEb3Cd9fsp7keH2WNobAkH60qTjNYFq17qFJDjHCGLu7gd1wG8lpimsaICHh/T86pSJFwthKxzkp2yQIuGgXXDxv6p7zFIxNxkvQ34cjTFn0Gg0qrv8O0Y+NG9KZJpZIkai1Je/cOBZ1RX42NVODFbZTH1ZRILHrU4Itp90UeSjRw9oNjRVmy1gRV8f8/n/oGeulqjmr2Gh+Om5FDyQYKFwBSBIzFV9Zh9+yR/6T/tImgZ6QGHESvkCAKCyox2s55/Qj1NZvu+Q81q+j9zPvUvRvkZzr4+O86Y9j4KoW+/a30XeC//tIoJJG3ULbUeE11KoAoHUCkt46e2yzzkKl16ysiZJB1Fqi82foUfqe1pX/koP9sEMyPHBVTiLgT6sFIPHbdXU7UvURWFa3qgXxAI+YsCvHnxQbK7/2cWqrY5HOL2giBc5W/Vq6fxPBYLpvLLf3q8tYuv4BrmeBJvvkBqjmlOueBdEp0aagfwYJzSFcJnUIzVsAG49IKWLQB3fPuG7BB7uvguqXfdk+2TgDBgdtAE5pIGXt9mN38aXCLxSpOSrGug/Cp5YNomf8RtA +2FXhYdI xhQcXCOCNTYSAc6WTYCtiEZ9mJ4H7fgoamFRyf6LBbtoOvTXtzk487MjFjJGGOVwycI2rgqF+5F07EnPFXAJTZS3+FCVmIIxTpg7yDEGBs2JjoPB9DpRQiagIAqt7EbOzIePvRMQBcRTIJgcgg0K+O7U7mznUWU9PtncI/GZGiWlT6s+MgTzde7MV5akXVf8AGnRMjuBE19wceaUptzx7qqsALNhzeOnhqUf9X0mjhNdZDevQGFCei0soXQESCjaEd88Tuni6pmgoftBmwlQ6vYK11tdZuWO4y5FUBoI8YPe+gBlgZu7cUst1EqDJ0SQ/oUXLAHR+Waj75fezZVK6Uz17r4BZa3s/yHf7K84mQZYA5aQ2ZWijiRQ72w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2023/12/8 6:16, Andrew Morton wrote: > On Thu, 7 Dec 2023 23:25:25 +0800 Kefeng Wang wrote: > >> After selinux converting to VMA heap check helper, the gcl triggers >> an execheap SELinux denial, which caused by different check logical. >> >> The old from selinux only check VMA range within VMA heap range, and >> the new will check the intersects between the two ranges, but the corner >> cases(vm_end=start_brk, brk=vm_start) doesn't be handled correctly. >> >> Since commit 11250fd12eb8 ("mm: factor out VMA stack and heap checks") >> only a function extraction, it seems that the issue introduced from >> commit 0db0c01b53a1 ("procfs: fix /proc//maps heap check"), let's >> fix above corner cases, meanwhile, corrent the wrong indentation of the >> stack and heap check helpers. >> >> Reported-and-tested-by: Ondrej Mosnacek >> Closes: https://lore.kernel.org/selinux/CAFqZXNv0SVT0fkOK6neP9AXbj3nxJ61JAY4+zJzvxqJaeuhbFw@mail.gmail.com/ >> Fixes: 0db0c01b53a1 ("procfs: fix /proc//maps heap check") > > I suggest this should be Fixes: 11250fd12eb8 ("mm: factor out VMA stack and > heap checks"). Sure, 0db0c01b53a1 may have been wrong, but is there > any point in suggesting to people that they backport this fix over 12 years > worth of kernels? Or is it the case that only kernels which contain > 11250fd12eb8 need this change? Fair enough, also thanks for updating the commit message. >