From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56825C7EE2E for ; Mon, 12 Jun 2023 09:12:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E4FAB6B0072; Mon, 12 Jun 2023 05:12:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E008B6B0074; Mon, 12 Jun 2023 05:12:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CC7916B0075; Mon, 12 Jun 2023 05:12:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id BC9456B0072 for ; Mon, 12 Jun 2023 05:12:47 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 7AEB6120194 for ; Mon, 12 Jun 2023 09:12:47 +0000 (UTC) X-FDA: 80893530774.01.063677B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf03.hostedemail.com (Postfix) with ESMTP id 263D120018 for ; Mon, 12 Jun 2023 09:12:44 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gST1jRpH; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686561165; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3NMvLsGaoAc+ApiQBDtCmSAApQPFNCHvp0vvUyzH0to=; b=PvkbTJ0bM8G1nVfsv7MCZ5xGCJEYX0cKt7By3RHZFaEp/Gep5OeLrb1QlwPn6uVbjnJqN9 BLeHEjTRhlDgWdfjLJduPSx/COTtK1v8SsdXcbYjl0cqSHpH/hFj3kRk4YXVyIdpE5QZOj HEKTwLuiv02znvWlq+PfOaRXCYCLqoY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686561165; a=rsa-sha256; cv=none; b=yx1/hFeXxAFJP4hHKM1JujSZME8bIMKol20IbZQ6alvsSFQ2RuRn1cfJ5m9aPBVXx1n4kX NW6Q4FNwpktzF6D/SyI1cE3LkRX9jdE8bJ6tBpHrgi/EcBAEzYqKPohkgEE4uZHeZY6zOm LHywHi5v3b4Jcz1Ad9TNd89sD4dRqjM= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gST1jRpH; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686561164; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3NMvLsGaoAc+ApiQBDtCmSAApQPFNCHvp0vvUyzH0to=; b=gST1jRpHn2CxRU49/cw1rg0yk7uLww54oguRNkdOp0phYx30X+7TdVFA8WpdyjekitcNHz XFpYLYC6nkSArAIRo9Nd7MlQtemahbxd5Dl9phaE2Qtb3avh66kmoCXkbc3m/H4z8PugXe YNpu+mDyt6TaRebal8m9FjelCXozUZ4= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-435-Rh0oT72fM0Gr3r8GJEk_Ww-1; Mon, 12 Jun 2023 05:12:41 -0400 X-MC-Unique: Rh0oT72fM0Gr3r8GJEk_Ww-1 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-4edbdd8268bso2945225e87.2 for ; Mon, 12 Jun 2023 02:12:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686561159; x=1689153159; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3NMvLsGaoAc+ApiQBDtCmSAApQPFNCHvp0vvUyzH0to=; b=CzCQaOqLehWHr0qxTziiTShGELZpr0kAbfs5VZwXVEzWnUnNZj1zb6efNWydol2fCD BXfUHSgjGAEaRWjlvH6hGX22/VRJTf11j4qbq5tNWKswo75ikA26yAK+a5boVwQX/Uv9 QjFt3JxqBKqQoBeVT5Xa5jo+G8dVyV3QE8Vf9RGqxUtZf8FaZ4nwFekicqE2fyBguX37 Xhb0rkyvyXRQX9WuLJ8MDvbl4+7HxcSPObfD+ce8CrNpJAdLVWQXeol3cYI/AweMsEyL LLJNJV8HO10VNqd8rqodPzVPQL4RJB2wLzZ8wlBo/tW4YnPGzOZhZd9B3AZcuMPiGD6M 0A8Q== X-Gm-Message-State: AC+VfDy0JCBsYG5o+bS8eMZ15tkeaAb/8qERZzwiYPXQjOWUbjYT96Vt coKBHOmGkMGqnkndrs41hAP1LaR4v34Nnq/fc3eU4JJ4DmIzBDbCfI4MPgW4jLmb9iElcEeDqSS l3JKw8i0WCVU= X-Received: by 2002:a19:5059:0:b0:4e9:59cd:416c with SMTP id z25-20020a195059000000b004e959cd416cmr3429812lfj.0.1686561159760; Mon, 12 Jun 2023 02:12:39 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5ObVeJndaNY6Sp9QSQya6Q8InTnThpLB6JyNIT69cgIZg/6pZhGlyZLEWmcgAPJaq7qpRaTQ== X-Received: by 2002:a19:5059:0:b0:4e9:59cd:416c with SMTP id z25-20020a195059000000b004e959cd416cmr3429790lfj.0.1686561159386; Mon, 12 Jun 2023 02:12:39 -0700 (PDT) Received: from ?IPV6:2003:cb:c74e:1600:4f67:25b2:3e8c:2a4e? (p200300cbc74e16004f6725b23e8c2a4e.dip0.t-ipconnect.de. [2003:cb:c74e:1600:4f67:25b2:3e8c:2a4e]) by smtp.gmail.com with ESMTPSA id y8-20020a7bcd88000000b003f7febc8fb8sm10775635wmj.34.2023.06.12.02.12.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Jun 2023 02:12:38 -0700 (PDT) Message-ID: Date: Mon, 12 Jun 2023 11:12:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH] mm: hugetlb: Add Kconfig option to set default nr_overcommit_hugepages To: David Rientjes , Josh Triplett Cc: Andrew Morton , Mike Kravetz , Muchun Song , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Jens Axboe References: <88fc41edeb5667534cde344c9220fcdfc00047b1.1686359973.git.josh@joshtriplett.org> <71834e10-098c-7d15-b9d4-36d33a57499c@google.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <71834e10-098c-7d15-b9d4-36d33a57499c@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 263D120018 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: y331n3zbgct5154xxwrcnjracjdbfubp X-HE-Tag: 1686561164-765642 X-HE-Meta: U2FsdGVkX1+PHx7uRzMNJafOD/HUarOQ5cqrPVzqsV0Sb+GKOeeKS1vwfrlscOQ4PUZNm1DDXukmK+Z1L8CVlpqEPvF5Yc4hGYlT5Xj8uGNKQhjF3ynKoQt2gRE2uDf2GgiYk51R+Wx0OiI8foKis2So7YKKAyaM2Hky6CnHNXF5BtfYaiOLcE8cGHdeKUO6Suv4h4cdUCuFMwrpZioesmYr5d+KKJVo4RJWuggBLQ1dhFDm+oX7NL0aIhD2Y3p6ZJ8ovfSbTE8vO2/IDqh/qSKpb7ndNc7+q7AiMf5yxPjMBAXIDRUOPEc5WvC+9q4o7yZF50Uu0YG4v+gM3CRTR8Q3ItnG7/6cOHyrz7Ige7Dc0F5lLoEgAolC38E0wjRbEeP25P0q8S20Ydd2YX7OenX26ga935UZEVU5NuIDNtBdlc8Er2HaBncLn69Y5ZKP/wGy6hHP5Lkls57yArYyW8tHB5UW7FoxAi0VFVv0KRvbng6XKAuA8QwdgawDtQbXks/S6UmKx79TkhmMPCgE77IVXhuPaJCl12nKGtBzwB7ECzt2AT9FMnYURdi1Q9q+xDQC6JI/tlJOmr9XSUFWcW6IaA6eay7U68k2f7IrMolCy06gZdIbXMxlEX9QGOAq4piGRvrzVOxQb5oI729nYBGU7KkJRz1l2RW/EbL5yjEnz90KdiiDFpmOzzmncjv9PdMBgL0+nizMQAYqIps8z1FAuivUUalzx6BjM311wh0tdSW7DgR+TUMF7IpHA+B6ZoqAB6l0PGHx5GrCWR6sWo/5Zw/edL+EsZgukQo+MawjvsuvLWPjK7EgW4gly2cNhB+YRmpj6gyrHm2VjbSOQ9JJfsa+/Xjmci4IpwX9oWp6yWpJbv0jt+i7zedcltK+hRt6iNDNN4Ph+DOeWGpIiYovq3LzHBrZsJoLV9EgtwgVy0m2bBro7iwxNk5oiUK78V+IbmbRmboQXrJuwB2 kwWBrAhb DPSes5OsFyRj4VtxLYEdZ6HLkynomkYrUnyTUK6kjUGEcU0BuMRWdYuTR3qemATp9PPaTn01eVQJk0S6ba6kYKu/nlRJ45dFOBCSQwckm/pgGVPM93787d8LfAMt8G2kpK1Df5sjUE8MAFSEWnfUJJ1dvtjM/unPzbAhDEmTYmmS0R4o68Fu9DDeJzRN/3FCxFnotKkDAlgoA9h17O2EoW5qXHRGrX3QYl06Ep9qT5Ot67B8LTN8Cj6o7uO683rv1xukE4Ev9wRBhfsQquhDZ6+bK/l3a/S5/Jd57Ez7MSySw0GTYXMNMsrLYBwZPDsHgJiAXJvYra6FCZvu68XuxtImzXDwyu4czjmP9HSg35WtEL6PHHm4FqN1fhxcv5yWCNJ/w2gfACFp2UQzILcvbXiyo6d6g+Cw+rreMdoqr9mfnBu7jWWcFrt2JZfD7K25MnrmRolAFFjjgPuZV0zMcudIRS9QzM0H3+0yH4k88HPYxwe8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11.06.23 07:20, David Rientjes wrote: > On Fri, 9 Jun 2023, Josh Triplett wrote: > >> The default kernel configuration does not allow any huge page allocation >> until after setting nr_hugepages or nr_overcommit_hugepages to a >> non-zero value; without setting those, mmap attempts with MAP_HUGETLB >> will always fail with -ENOMEM. nr_overcommit_hugepages allows userspace >> to attempt to allocate huge pages at runtime, succeeding if the kernel >> can find or assemble a free huge page. >> >> Provide a Kconfig option to make nr_overcommit_hugepages default to >> unlimited, which permits userspace to always attempt huge page >> allocation on a best-effort basis. This makes it easier and more >> worthwhile for random applications and libraries to opportunistically >> attempt MAP_HUGETLB allocations without special configuration. >> >> In particular, current versions of liburing with IORING_SETUP_NO_MMAP >> attempt to allocate the rings in a huge page. This seems likely to lead >> to more applications and libraries attempting to use huge pages. >> >> Signed-off-by: Josh Triplett > > Why not do this in an initscript? > > Or, if absolutely necessary, a kernel command line parameter? > > A Kconfig option to set a default value to be ULONG_MAX seems strange if > you can just write the value to procfs. > Agreed, not to mention that huge pages in some environment can cause trouble (some architectures -- or with gigantic huge pages -- don't support huge page migration and you can run into trouble with ZONE_MOVABLE or MIGRATE_CMA, because you'll end up "consuming" all memory for unmovable allocations in the system), and we shouldn't advocate the use of unlimited overcommit for huge pages ... -- Cheers, David / dhildenb