From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f71.google.com (mail-wm0-f71.google.com [74.125.82.71]) by kanga.kvack.org (Postfix) with ESMTP id BE41A6B0007 for ; Wed, 11 Apr 2018 05:00:03 -0400 (EDT) Received: by mail-wm0-f71.google.com with SMTP id 195so770215wmf.0 for ; Wed, 11 Apr 2018 02:00:03 -0700 (PDT) Received: from pegase1.c-s.fr (pegase1.c-s.fr. [93.17.236.30]) by mx.google.com with ESMTPS id r14si601229wmc.5.2018.04.11.02.00.02 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 Apr 2018 02:00:02 -0700 (PDT) Subject: Re: [PATCH v3 2/2] mm: remove odd HAVE_PTE_SPECIAL References: <1523433816-14460-1-git-send-email-ldufour@linux.vnet.ibm.com> <1523433816-14460-3-git-send-email-ldufour@linux.vnet.ibm.com> <20180411083315.GA23400@dhcp22.suse.cz> <5bd1bb46-8f71-e6db-7fb7-43d023a37f58@linux.vnet.ibm.com> From: Christophe LEROY Message-ID: Date: Wed, 11 Apr 2018 10:59:58 +0200 MIME-Version: 1.0 In-Reply-To: <5bd1bb46-8f71-e6db-7fb7-43d023a37f58@linux.vnet.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit Sender: owner-linux-mm@kvack.org List-ID: To: Laurent Dufour , Michal Hocko Cc: Rich Felker , linux-doc@vger.kernel.org, Catalin Marinas , Palmer Dabbelt , Will Deacon , x86@kernel.org, linux-mm@kvack.org, paulus@samba.org, sparclinux@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, Yoshinori Sato , Jonathan Corbet , linux-sh@vger.kernel.org, Ingo Molnar , linux-snps-arc@lists.infradead.org, Heiko Carstens , David Rientjes , Robin Murphy , Jerome Glisse , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Vineet Gupta , linux-kernel@vger.kernel.org, aneesh.kumar@linux.vnet.ibm.com, Albert Ou , Martin Schwidefsky , akpm@linux-foundation.org, linuxppc-dev@lists.ozlabs.org, "David S . Miller" Le 11/04/2018 A 10:41, Laurent Dufour a A(C)critA : > On 11/04/2018 10:33, Michal Hocko wrote: >> On Wed 11-04-18 10:03:36, Laurent Dufour wrote: >>> @@ -881,7 +876,8 @@ struct page *_vm_normal_page(struct vm_area_struct *vma, unsigned long addr, >>> >>> if (is_zero_pfn(pfn)) >>> return NULL; >>> -check_pfn: >>> + >>> +check_pfn: __maybe_unused >>> if (unlikely(pfn > highest_memmap_pfn)) { >>> print_bad_pte(vma, addr, pte, NULL); >>> return NULL; >>> @@ -891,7 +887,7 @@ struct page *_vm_normal_page(struct vm_area_struct *vma, unsigned long addr, >>> * NOTE! We still have PageReserved() pages in the page tables. >>> * eg. VDSO mappings can cause them to exist. >>> */ >>> -out: >>> +out: __maybe_unused >>> return pfn_to_page(pfn); >> >> Why do we need this ugliness all of the sudden? > Indeed the compiler doesn't complaint but in theory it should since these > labels are not used depending on CONFIG_ARCH_HAS_PTE_SPECIAL. Why should it complain ? Regards Christophe >