From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62151C4708E for ; Sat, 29 May 2021 18:43:08 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id EE2F861155 for ; Sat, 29 May 2021 18:43:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EE2F861155 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=amd.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 14F806B006C; Sat, 29 May 2021 14:43:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0FFE26B006E; Sat, 29 May 2021 14:43:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E46CE6B0070; Sat, 29 May 2021 14:43:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0211.hostedemail.com [216.40.44.211]) by kanga.kvack.org (Postfix) with ESMTP id A4E626B006C for ; Sat, 29 May 2021 14:43:06 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 27E58181AEF1F for ; Sat, 29 May 2021 18:43:06 +0000 (UTC) X-FDA: 78195140772.01.AB8B95D Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam08on2042.outbound.protection.outlook.com [40.107.100.42]) by imf01.hostedemail.com (Postfix) with ESMTP id 94D5450904A7 for ; Sat, 29 May 2021 18:42:55 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HedB0G3iQYDsmefND71jfcTbQIoJmHdY8TRCUgft4bcxZPxjFQp3T0CRFwytIqzcC86es8YYe0b7jJ8RLUQWQjVG8M2fK/Xil8fj2bBxR+UEIL9ibEROdqZMhPLYfjImAObY33LB4+5Fomn7XJoYQ+cXCZklZ7gzZ3jM4zyRh1fnxx8KJJVpKvKqXJ1MIA6f4qiTFD10wRpMoACEAIgewNgknk7oFmiTgCIQIhjN52WpaYm+ft0kIYX4PUAaNi5B+vzEfZOgR3lYXQeEiCkt76YfFVt/M1sa/2vRmXY1k8i+htoB7+m5kkLsQkWOtkuDTLqnhftyj7UoouDqgViUVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Um5SzYYBar9xF2UWeqhd9Ziqz6bSounZAcGSaIPkxdM=; b=g+xFRjLWctsDeuFqxKRYbcqr0vVx3xniHISsQQLxlfosVrioSXArLqAe1ol9GU0+0v5aXU1U90/HI07hpApzg8O+xHaVtzX2GtxuUdsni7YIiB41ZvFwqtB95FsoMOf73S8Y3KOXNAi2s7PvzV6FdnygWaYpQ52pdO59MkpAJFky456z+rw3FA4LQvDDQljsKUCGia0d0V+tWO8orHrUWyCUDpSbL3proQENvieeF1R6B8Ci/1QoxJcpLTDru+iWhmsqyF9kLCosdQYz5VXy8Fyhty6zEzZoVKmG6kyiy+c9odzlMTTC0QMTfcJxd3OSQIL0Ttb3O5WeaTdq+V/iMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Um5SzYYBar9xF2UWeqhd9Ziqz6bSounZAcGSaIPkxdM=; b=sPcjDHetbox/8OjbhKqJHM8HMPnOi60QEMmaooFPbMblRnUfNRqLV0QWyRVFlpgfnBCBbCMlVRD1ccf02PUkL0vTMy3uZG5fM2Q0isd6/cqcANqbng4VkdZLldjRqVa3yxEoW707BZv+1eSjjuJ5amPHxHbWKHyQV8UDj9AtDm4= Received: from BN9PR12MB5129.namprd12.prod.outlook.com (2603:10b6:408:136::12) by BN9PR12MB5225.namprd12.prod.outlook.com (2603:10b6:408:11e::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4173.21; Sat, 29 May 2021 18:43:02 +0000 Received: from BN9PR12MB5129.namprd12.prod.outlook.com ([fe80::3c78:e58b:fba7:b8dd]) by BN9PR12MB5129.namprd12.prod.outlook.com ([fe80::3c78:e58b:fba7:b8dd%6]) with mapi id 15.20.4173.028; Sat, 29 May 2021 18:43:02 +0000 Subject: Re: [RFC PATCH 1/5] drm/amdkfd: add SPM support for SVM To: Christoph Hellwig Cc: felix.kuehling@amd.com, akpm@linux-foundation.org, linux-mm@kvack.org, jglisse@redhat.com, jgg@nvidia.com, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, Alex Sierra References: <20210527230809.3701-1-Felix.Kuehling@amd.com> <20210527230809.3701-2-Felix.Kuehling@amd.com> <20210529063828.GA15834@lst.de> From: Felix Kuehling Message-ID: Date: Sat, 29 May 2021 14:42:54 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 In-Reply-To: <20210529063828.GA15834@lst.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US X-Originating-IP: [142.116.203.225] X-ClientProxiedBy: YT1PR01CA0075.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:2d::14) To BN9PR12MB5129.namprd12.prod.outlook.com (2603:10b6:408:136::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.2.100] (142.116.203.225) by YT1PR01CA0075.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:2d::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4173.27 via Frontend Transport; Sat, 29 May 2021 18:43:01 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f92f47ca-1ea4-4750-572b-08d922d19669 X-MS-TrafficTypeDiagnostic: BN9PR12MB5225: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1KM9i30gCVItcYp1tpYhOhL6lSIFsFRaeCYxe7sEno9f55ozvHbRtbqvgZM4LTvGpXm2K78UOQNpvdoh5VNfRUR8bPKY3honSaV6KYTjdAvKXzPlxvMOXnynNoxUzjeTw9ML/ANTB6kSvQaQw578W1NyFNee5vQ2C5uIiQCw8R7jK8rHltmQ6DB+s8yfGcUo7eHVIGwy+Qg1oEQkDqe3plCoqVmfGeO/6gnIKTlN7Qw6PnqmC8yUG4vMb+kozZXxTKD6s3//xwDdTJSBpJg9vcHWqhO5UMRBukWfA7aR1VopURz8ebefuP8BS+S6LsMSGeqfYHV/uN2Otn7vmYqBcDLvizuW2VpSHXsxgrkXcrdVE0Wa/rtw4ubv4PMKrSsfvblyJVt9cJ63yCw8W4h2ouFQR1yo5pIGjnM8c02cyq4Mfb9EbYSANkoVeMWLEEMSMVBjq5N8yznaO9P+1oWmUj5mj5Wm6Ef8UQV0ZUYVou7XKEOBUrTgjJVshYV58lX6qLbkcSEh/BMCLoP24uRhbgeBj8K3CjaG8t/UY50pi4KK/SNdKZZGdHQooK1t7IczCrIbIbVxYJJ18rQ3mukcfedvd7ThUXkcHSLC4NqX0T2S4f9cji4DaPHUTZo08Gvnx0FYuj3VzSQCzNaAcQnRKYSlX0T9hrmSlrx4Xb8R7ltK77iAgf4QSMyOxxKOVgfS X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR12MB5129.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(346002)(366004)(376002)(396003)(136003)(83380400001)(478600001)(4326008)(38100700002)(6486002)(6666004)(2616005)(36756003)(8676002)(2906002)(956004)(6916009)(16576012)(316002)(5660300002)(26005)(16526019)(8936002)(86362001)(66556008)(31696002)(44832011)(66476007)(31686004)(186003)(66946007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?c01MdHhyeUtlTDhoTUJaeWNISTh6MEVEQjBGRUdXM29hMGQrVE9xaWtaaG13?= =?utf-8?B?NTlPTnVXQnNrcmZ4ZEQ4OEd1M2NpSWNlLzkvWDAyUjNrcjdVLzVmdWNFLy81?= =?utf-8?B?eHRhWWtEWnQ1dkFYOHJscmQ1WjNYcy9sSmYyc3BRTkRVUGtBMWdGMXBocDNK?= =?utf-8?B?SmhOeXIvelhjd1MwRUZQWUh4TVZvdmVaVmtRN05RWW9qNllPNG5XN0NaVXFi?= =?utf-8?B?eUQrMGZWV3Z4UHlsMXhiWWkwYTNpc1U0L1pnZzRFdHpQSXhXS2lnSlpoMnov?= =?utf-8?B?KzNhR1NSYzFhaUxONUtlYTRZa2xsV1dzdkRVUFZ1V0VjUERMRk9DV085YWRp?= =?utf-8?B?MFl2ZERERldXUTdRYytZSVlHS290ZWdsQzd2NUFzTys4S3QvaXpOZHpmZ0dZ?= =?utf-8?B?cEd3RXRidGFKZE9KcWFwU014blFSb292NmFyNmcyS2U2Nk1sKzBjVEx1QkRp?= =?utf-8?B?STlhRnoxREYyVkRUQ2ZJcjJjRkFOc2VyY1ZnL1RlZkdrVCtaS3FWcGh2bXo3?= =?utf-8?B?WlQ0QTlBOW9meWhiWGQrcWdSQ1B6SWNTSTZPcG05Zk9zOUdwQUZUSXVkR3I3?= =?utf-8?B?V3gyYjdOdlcrSVZWenRSaktFWDFQZ3kzb3JuZW1FWkFZNitBeU1GTldYVWxL?= =?utf-8?B?dDAvRmZxSWFVRzBSdGVra1Z5TC9YeDlpUy82MjY0aWdUam5DUE1OUE9WMlgv?= =?utf-8?B?QUNrc3ZQOU00TFlRM2c1c1M5YkladUtxL3N1MlFBNHFzQmxIb2IvWFVwd2c1?= =?utf-8?B?a0NYNnRJdWxJTDc1VVNjcU83NW44aUZjY3VHUEhsZHJLWG1ab3ZIZnFCZkhN?= =?utf-8?B?eFhvcmpuSHZkckFOQ3RPUUhJN2Z2dWsyRGlZUjZQWUxpZEVhdzVsc0R2bWxW?= =?utf-8?B?Q0ZLY0xmWklHQndXeDhjSk5iaEJmRXVBWGpDR2ZCTmpEdCtoKzFodis5b2RO?= =?utf-8?B?QTRPZFpvaCtYRi8xVHdvUm5hWTFHc2pUMHZVZFhwMEtYQ1M5KzQyWS9qY0NC?= =?utf-8?B?U2Rub28yZnRPWUZLdk9yUVkyck50RldrK20wNEJXbmtkTlVHd1A1SXdHWDFz?= =?utf-8?B?eEc5VE5zNVVqaVVPSTB0dkp3QUt1YXZkbk1RWFd1ZmUxNHlUMHM5d0VGUGJL?= =?utf-8?B?Z05OMWxrVi9VeTZBcFhXbHF5LzdoZG9jVjc2SDliVmVNYVFtb1JRdE8xNFRq?= =?utf-8?B?OU10RGwvNXE2d0FpcTR6Qk1Ca2NJeVVmckp1SjhWaC9maXFycmhoTHJLbEIw?= =?utf-8?B?akF4N0w1bTIwQWNYM0FjTklvWVI0S2tNY2hUbm4rbWhkYzdSM0hodnEzQVlt?= =?utf-8?B?SDQ2ejgvT0RCR0xLclVHbkpwd3JmWG1nVktuV1JmZkRVTVJsbm1jVDB0L0lu?= =?utf-8?B?by9oMzdmN1lTYlNuMjFMRHdXcFNLMFgybFdCbnZQMGFGcEhkZUJlaFFyZ2dK?= =?utf-8?B?cWNyaUpRSjNNZnlwNkRkcGFtNWhqalJ3SFRFSW5FdkhoeEZYcm1VTFJoTElz?= =?utf-8?B?Z3Z0UytEcTNjbTQ0U2MyaVpsZ1NIOGsyQjRXUkhKTVBqQldlZGFFUVQ2SVp6?= =?utf-8?B?WXh0MTBXUElhUXZZZ2E3dHdaQXprRXBVbU9kSDBTTlhXKzBlNGFZNkdvU01l?= =?utf-8?B?N0tJYUgwM3ZKUTlXT0xsNThVVGZGNWpaUVdzWmRBK0MvMVdDL0F2RnlTc2dU?= =?utf-8?B?VTNEa2x5a29jVjM3U3c5TkFMdmEzdFBvekJwSndkU3ZQVHZyZ083c2pLaUNt?= =?utf-8?Q?tOcl66BG78WiIkW4d+DXGfmGvBN7whaa8lYnrwn?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: f92f47ca-1ea4-4750-572b-08d922d19669 X-MS-Exchange-CrossTenant-AuthSource: BN9PR12MB5129.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 May 2021 18:43:01.9040 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nscXJSJU+kRLR2i8MwDTPg+i4HtJvKuqROnTINuUXMrtfjG8QPbvXS77p8IRlL/oL5k2kmkRQRxUuHDmxkl9Kg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5225 X-Rspamd-Queue-Id: 94D5450904A7 Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b=sPcjDHet; dmarc=pass (policy=none) header.from=amd.com; spf=pass (imf01.hostedemail.com: domain of Felix.Kuehling@amd.com designates 40.107.100.42 as permitted sender) smtp.mailfrom=Felix.Kuehling@amd.com X-Rspamd-Server: rspam03 X-Stat-Signature: ifufwruejzebau16w1yyd68ftxe8w33d X-HE-Tag: 1622313775-591457 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Am 2021-05-29 um 2:38 a.m. schrieb Christoph Hellwig: > On Thu, May 27, 2021 at 07:08:05PM -0400, Felix Kuehling wrote: >> diff --git a/kernel/resource.c b/kernel/resource.c >> index 627e61b0c124..da137553b83e 100644 >> --- a/kernel/resource.c >> +++ b/kernel/resource.c >> @@ -783,7 +783,7 @@ struct resource *lookup_resource(struct resource *= root, resource_size_t start) >> =20 >> return res; >> } >> - >> +EXPORT_SYMBOL(lookup_resource); > NAK on hiding random exports in a driver patch. This needs to be a pro= per > patch with a proper rationale, a kerneldoc comment and use > EXPORT_SYMBOL_GPL. And even then it smells rather fishy, but I'll wait > for the rationale. Yeah, I missed that in internal review. I agree this needs to be a separate patch. The rationale is, that the GPU driver needs to be able to look up and claim the resource corresponding to its VRAM in order to register it as DEVICE_GENERIC memory with devmap. If there is a better way to do this, I'm open to suggestions. Regards, =C2=A0 Felix