From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21B92C282EC for ; Wed, 5 Mar 2025 21:49:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EE0D1280005; Wed, 5 Mar 2025 16:49:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E9039280003; Wed, 5 Mar 2025 16:49:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D5752280005; Wed, 5 Mar 2025 16:49:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B22A4280003 for ; Wed, 5 Mar 2025 16:49:28 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 1DE411A0B57 for ; Wed, 5 Mar 2025 21:49:29 +0000 (UTC) X-FDA: 83188839258.28.0CAC64D Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by imf03.hostedemail.com (Postfix) with ESMTP id 41BB020002 for ; Wed, 5 Mar 2025 21:49:27 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=T8iPf6nS; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf03.hostedemail.com: domain of hughd@google.com designates 209.85.214.169 as permitted sender) smtp.mailfrom=hughd@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741211367; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=omvL6JKP93PIw7TY0fUbQoFMf9D9z+VnaM97mXHofWw=; b=ua5CzzpX/CqzCM3ciZLQAXKhs2bcA6tNGu9kIfHqN+sxvLx78AdqU1TUND6iuwSC1wgNpP yrjPpNCnmD9xrhcDI9smG7KWUIWks0fZ/ol0eQzsQ4EWPFUuBSBx2c+iHUBmNtF5o4jpGK FZXm/WTjfnlsi2trAkkzyQrCDVWZyow= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741211367; a=rsa-sha256; cv=none; b=m5eyDrdLT0MOin1Fmi16NiyaMBx7AWchYtwTcQADWapKQVVXwDU5Ju+7pymgo1QkDwTzYA /KdFKEYkYOOUeolN3VOSMY5R0f3tL+LpiN3Xg3F8Pw8tzb1S7YtDAN35SWCPbgmn3rK3k9 AhlJ10ROIviIDJqcQJFC9F2seQ4k8wQ= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=T8iPf6nS; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf03.hostedemail.com: domain of hughd@google.com designates 209.85.214.169 as permitted sender) smtp.mailfrom=hughd@google.com Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-22403cbb47fso16102495ad.0 for ; Wed, 05 Mar 2025 13:49:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1741211366; x=1741816166; darn=kvack.org; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=omvL6JKP93PIw7TY0fUbQoFMf9D9z+VnaM97mXHofWw=; b=T8iPf6nSEu1Ck7kebr5bS6WUd3HdUfXc2Kolo0wvNh/GOwJbEfjeNqBzJTImDzpuRM /M30FhBNageoSWLvrQEzZiWHL8gD5+OaG22vpe9ZgQ6ny7NZvMC8JUF9eMl4dQLN6rPK g9ZbABPKYdJjIGPh6bY1IpAbeo3hUBywkQRz0wi89LpEqg8iMtYTiwkfxasY7TUZwnpv Kxpv5u82Uvp49boDmseqxZwW22Xv31JBekyGxF12X7qlMkQgxtVhk6Uv6LVLJJbnKHxR BOb9z3FWYpxsGwBFym2Of4tZJ16NrqJnDXcYg00L3/Kq+4zFNtUINg3x9mmkqlFTFU3w Z3nQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741211366; x=1741816166; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=omvL6JKP93PIw7TY0fUbQoFMf9D9z+VnaM97mXHofWw=; b=ejf5qxaY24ILXIcjiaCbBxkwJcwLQlU0oYjcSuU2yEzqN8ysQZKhTJPZDhnRzbTP+i uCDPZB6oPwgtz4Ju3xx5XpNk5o4nPrmF8VVRN59dSGWwI3Hd+fQoHInYqSmz/7XsDS06 hh4jxscqthrYpYjJfgoQ6Evd62/XndkcdIksK5buJt0siVjHBq/YW70HMoUJDsh/1+qc VbIXKfKcw0OpbqIeecVbVJZJbFNlh6RmX1Ke4tnrqevmcE+Ep3lCxsWfIFJzn/ZdckXp L7g+pQenWBWfmREr3arBTQeSij0PPQaZOSG/BCEEhWVChJ8tej1pPwwzRGVG0mEnZtj3 erDg== X-Forwarded-Encrypted: i=1; AJvYcCXjbU1rGUPpL1d0cuIuSbw0pDwkgBgvt7PzqbWhi6VG/LdUfnUeE0yMpmP/NNOx3TlZMIPz+hYGuA==@kvack.org X-Gm-Message-State: AOJu0Ywop7mVpr9QNPVb8KNUhjmUStufgyYGvdtYAl6oog79h51V844J 5et4GdC/stf3oNfoh3wIWh4CGTviL69zJD1ppbOlD/k8EHZX56I2pBjI9Qcy6Q== X-Gm-Gg: ASbGnctbdPJNX+RfR5JkYRsa6R8IX6iF8A4+ANA2+/omxuoPa5qbMYvcIJWYxGfPzmi SJV81UBS4yOQK2D0nkrqU6eIPopFFaNfVZ9egfLZszWhMhjPAnzxBE+yXEkzNvFrs4ieBbQTWIB m0ZJeT1Hh671/6r38U9A8Pdso6YFFQFCxmx9c8H/tWrDTHIOMJUQbiMM5EqM0Q0M3q+YrX/EguP oWg9whFk/Y3yL/ws0iU8O2dhuOrK7xJ0tbrnHIRIsAuR1r7YxpueKmL03C3fykcvNsmXl/rYusG 9dWCPom9+MM/Gt16lwidaZ44zU4EPRHGxCvY9k7IYdD02BtyYbRASTyoAOw0FMskDYWlouszjRj o3JcLY/RBjToXFIy2VZLvDt35oq2a X-Google-Smtp-Source: AGHT+IHSkFlk8MRI3CZ7RZFHiHVlcup3GLPbGFJoYnXtQKvKTu0EkzQziZ13veZ5NCqPBYhRd4YuXQ== X-Received: by 2002:a17:903:18a:b0:220:faa2:c90a with SMTP id d9443c01a7336-223f1cf3264mr68708715ad.37.1741211365880; Wed, 05 Mar 2025 13:49:25 -0800 (PST) Received: from darker.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2240a59d176sm1897595ad.127.2025.03.05.13.49.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Mar 2025 13:49:24 -0800 (PST) Date: Wed, 5 Mar 2025 13:49:13 -0800 (PST) From: Hugh Dickins To: Zi Yan cc: Hugh Dickins , linux-mm@kvack.org, Andrew Morton , "Kirill A . Shutemov" , "Matthew Wilcox (Oracle)" , Ryan Roberts , David Hildenbrand , Yang Shi , Miaohe Lin , Kefeng Wang , Yu Zhao , John Hubbard , Baolin Wang , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Kairui Song , Liu Shixin Subject: Re: [PATCH v9 2/8] mm/huge_memory: add two new (not yet used) functions for folio_split() In-Reply-To: <43642DB0-17E5-4B3E-9095-665806FE38C5@nvidia.com> Message-ID: References: <20250226210032.2044041-1-ziy@nvidia.com> <20250226210032.2044041-3-ziy@nvidia.com> <2fae27fe-6e2e-3587-4b68-072118d80cf8@google.com> <238c28cb-ce1c-40f5-ec9e-82c5312f0947@google.com> <43642DB0-17E5-4B3E-9095-665806FE38C5@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 41BB020002 X-Stat-Signature: wduimzghbo7euxf6kr8yt69i69qzbgud X-HE-Tag: 1741211367-668766 X-HE-Meta: U2FsdGVkX18DheEj5Bw2jnstZK0VjvLj+hRWr7JPWH32uVO5Yg2Ef9Nk/9yCujy0kzD7bnKhvPzV9ACFK8q221b4Y1bVbsNX6Nb0gonIHzaD5ruKitSkwibUlPDR3t/Fj7oKxHKxz9nUt3isLU+ayyKgEmoe9i23C5wxqclplnmkcPBhHzWquLwJToNYKGCwRi9sNw0CA4jCD+N6a+uA8yvF3ycDnhG+59swXF0c5kqXuGgmElfMm6pBZdte2cey04djyNmDJjTkQqlu2pmaaA6SkBmpoFneNE55hDTNGGA3lHr48SCLGgL48HUc1teBSCm5rr8bk6I5UfrQgiV+dhimfqkebWlxhmSYm+36G4hOwLgCNLCTMmjNNf0aPvOf7zfUxsYH7u3A2vvrLjiyQCqK+ymo+BRDj15uYrl6GxpqwhRlI62kfILnGIOQsGbC51ni8ivLl9m04vzr1+/PuvsZTd7TARPnltV+8/RK2I5491A09hwgp9Lno6YwfAPpb1VntG5CiOlGkgVJ18AscbP1q6hNlilgjjTD/anNQQDOprNBRRGeQZsSmAH2C3GPS3WOvsEl40tHsjn/MOD8wGPPBW/pcG1HdjUTMsxYibafOyWEWziYPOeIIrqh/aRhHSvemQdQ+p1t5O0xAqTWneZa7ulIhs6v54ISR3YK8v1Ex3otnTR7SHTqhjXq4ILFCNK8jK9MfNjfiTI3bsnapxqMCD0Xm/fkWIC4DuztcJzqfr15d3GSOD0Sn46VY5TimD8BBF9QHrF754402dyBUkmD6HCjP5Mi+BvVN/WUSQUF6CuqcxVSgmwJ7pbtpzCcVlpSiFbb2HuxFzGs6+CLPJt7KawcRk51SALuNONJs54FFGY92psk7BgshLNsHDzVuUYU1rdHsXbVBZPBwGJRT+h4ssD/GM139wVvtygM3q3VpSWTEYmriHLZdpG/CJpxhrtTPqa3O51gK4/Lj9D qZMHDHXz i3+pXS8LbkhLjbsfTuRDeHxgkenwcYLmqiN199vMn6BeVL+PwVHLIUTr0ronjNilAymEI5/S+ZCfQ54zUS9kkl5mLDv0f4kz0Go8Sd/XHJPU8cXbcJbrKh+jp1aExIrR4x83h6TOSfaN0y+Tov6FSUv0gAj3O8j04Ax6spWG61IG0OSpDJ63dqNVHU2F8OPx+0hOws79x8n7Jp2LqR27AZDCQWntRuku8K4o3yZGpGLnaYrr97dQoy9USo6fsqBQX3n6sG6zBwRTUlapOU8sLBOWvBO2kQAP2WTnQvIDdJYahzRazvWDaWABFufkxbhh6ECj6HVWOfdKdsz9l+1m+NmoCE/Tkcde0ufb5LwuiqeRXR6PJ/wyNM6GN5EC5WT0XVgruSKXLpX7olyCw1GAjKUTjiiaFWWRnngOF X-Bogosity: Ham, tests=bogofilter, spamicity=0.000051, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 5 Mar 2025, Zi Yan wrote: > On 5 Mar 2025, at 15:50, Hugh Dickins wrote: > > > > (Historically, there was quite a lot of difficulty in getting the order > > of events in __split_huge_page_tail() to be safe: I wonder whether we > > shall see a crop of new weird bugs from these changes. I note that your > > loops advance forwards, whereas the old ones went backwards: but I don't > > have anything to say you're wrong. I think it's mainly a matter of how > > the first tail or two gets handled: which might be why you want to > > folio_set_order(folio, new_order) at the earliest opportunity.) > > I am worried about that too. In addition, in __split_huge_page_tail(), > page refcount is restored right after new tail folio split is done, > whereas I needed to delay them until all new after-split folios > are done, since non-uniform split is iterative and only the after-split > folios NOT containing the split_at page will be released. These > folios are locked and frozen after __split_folio_to_order() like > the original folio. Maybe because there are more such locked frozen > folios than before? Sorry, I gave up trying to work out what you're asking me there. Let's assume I don't know the answer. Hugh