From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68A2EC433EF for ; Mon, 6 Dec 2021 16:34:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BFF7C6B007E; Mon, 6 Dec 2021 11:34:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B82D16B0080; Mon, 6 Dec 2021 11:34:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9FBFD6B0081; Mon, 6 Dec 2021 11:34:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0214.hostedemail.com [216.40.44.214]) by kanga.kvack.org (Postfix) with ESMTP id 8D5856B007E for ; Mon, 6 Dec 2021 11:34:08 -0500 (EST) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 4778A18098A0C for ; Mon, 6 Dec 2021 16:33:58 +0000 (UTC) X-FDA: 78887916156.19.2756277 Received: from mail-il1-f170.google.com (mail-il1-f170.google.com [209.85.166.170]) by imf21.hostedemail.com (Postfix) with ESMTP id C11FED0369DB for ; Mon, 6 Dec 2021 16:33:57 +0000 (UTC) Received: by mail-il1-f170.google.com with SMTP id t8so10811250ilu.8 for ; Mon, 06 Dec 2021 08:33:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=0A+n/8oYWAVLEaX6QNHvT8JRs25q0UkHcPBeVY3Ef3M=; b=xq9AwavLLfVfJKTBWllxznuajFIjbap2Xzd0ClVwTDLZCEJnqaYTzOVVmeygvtgSFo V4EhQZqw7l1YxrK1/EysxfyNz9gBC4Ckf5SbjUI4XysB8tvCpP4qbjQnOsbMez3sCrWG 4k+0o6abyy32x3WbsVlSb9A0GhbhwVTJenONESVi62Y8/PewTjBIypFw9HFRzudQKqId M9n3e2oiWHhmi9SBR4Rc7jVr4jCvPGWdVAj7sfXu/LDlXLdtZn2S8rFZadVFFWWsA+C7 HPDY+yCL1MKTDodapGxkGJgVPVH3Y9lPJ8/bKBMuoPMPG8f1mYPViiT/lX5FgP6eJSKu 43FQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=0A+n/8oYWAVLEaX6QNHvT8JRs25q0UkHcPBeVY3Ef3M=; b=zTHAiWQfcPcCTVYIMkzZJBskGhTgRvXqwM0rkSQq+tBwdkuXXc4mvesNElv3jgJr9Q yW6F6c4KcSjIg0gTsjLJ46J9laGuHU2MploYR5ETwsk0Ic5/9Dmhi1RefZvb7Icyd8ch /mf/YXnu9NjqUqpRDsDhERNdYwg6Yee4oz2LuCJGr2jacoLenl69Ysn6v7AInMCbqTqL +wZBJIn1gTm0HtnPqjKGe0ljF+JjWbhJvaaNN8reMkEwWb5pTNkJB2SnZJkfgMJkwXOJ QjRI56cE6bE7kauHV8C+314fTueH+Vesw1+YpOjPDbBo8WeicqWjtyYkBvi6l1jmyuem o8CA== X-Gm-Message-State: AOAM530j0cEo8Pn9ZzMo9twrVit4tE+tfgt2+Kh17cOVjjwk6/JsMS/t UdeBP9cqVsCwXmQY0+NjO8rfhqMU0AYPUVzH X-Google-Smtp-Source: ABdhPJzVY0jOFXTRVbJa0UFmJY2n1MJYYqppN9UG2PDpUBGG9ZaDG/OV6/ctedxJbCOlHCPbB9ddpg== X-Received: by 2002:a05:6e02:1d88:: with SMTP id h8mr35349108ila.138.1638808436771; Mon, 06 Dec 2021 08:33:56 -0800 (PST) Received: from [192.168.1.30] ([207.135.234.126]) by smtp.gmail.com with ESMTPSA id m2sm6933625iob.21.2021.12.06.08.33.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Dec 2021 08:33:56 -0800 (PST) Subject: Re: [PATCH 2/2] block: move direct_IO into our own read_iter handler To: Christoph Hellwig Cc: linux-block@vger.kernel.org, linux-mm@kvack.org References: <20211203153829.298893-1-axboe@kernel.dk> <20211203153829.298893-3-axboe@kernel.dk> From: Jens Axboe Message-ID: Date: Mon, 6 Dec 2021 09:33:55 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: C11FED0369DB X-Stat-Signature: xexd4ixcw6j1a46n5fw4ks95yzoh8phw Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=xq9AwavL; dmarc=none; spf=pass (imf21.hostedemail.com: domain of axboe@kernel.dk designates 209.85.166.170 as permitted sender) smtp.mailfrom=axboe@kernel.dk X-HE-Tag: 1638808437-346795 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 12/5/21 11:58 PM, Christoph Hellwig wrote: > On Fri, Dec 03, 2021 at 08:38:29AM -0700, Jens Axboe wrote: >> Don't call into generic_file_read_iter() if we know it's O_DIRECT, just >> set it up ourselves and call our own handler. This avoids an indirect call >> for O_DIRECT. >> >> Fall back to filemap_read() if we fail. > > Please also do it for the write side, having a partial ->direct_IO is a > really bad idea. Sure, I'll do the write side as well. -- Jens Axboe