From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82854C76196 for ; Mon, 3 Apr 2023 08:00:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 16A556B0072; Mon, 3 Apr 2023 04:00:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1189A6B0074; Mon, 3 Apr 2023 04:00:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EFA726B0075; Mon, 3 Apr 2023 04:00:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id DE6436B0072 for ; Mon, 3 Apr 2023 04:00:00 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 924211408AA for ; Mon, 3 Apr 2023 08:00:00 +0000 (UTC) X-FDA: 80639331360.16.4500F93 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf13.hostedemail.com (Postfix) with ESMTP id 6D0CD20021 for ; Mon, 3 Apr 2023 07:59:57 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=H3J+a5MI; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680508797; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pXxZmEIu5fHKpEMjWe4VFwGD5foe1yAV7hjfRn3UlQw=; b=kmXIIDAcw41cNoXH6H+shOLJ8HxD/PPrhiKiRrxuxQIM4PZXeEfepCz9noziHjMImRt7Iv NWGvNNWzsofWBElH5Hks7EAu/TEo3fZmP5WdfVMA7BRPiY3v65YYLftud4S3x/oT0PIEO2 XaGqBhW1jvRQ8GcrLqyxH/06E4g87JE= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=H3J+a5MI; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680508797; a=rsa-sha256; cv=none; b=HYHy7TPMKti6YhKndLDghQAzSfiw7nFNibVaL1d6oSX0m1XcdvcWdp28Ddu8JaYfPlCHCA fwmNNQsHdtTq/rtiBluGBLsAPucr1U3asnl1ZG1Qny+ebE7rMlkFltZLANNo89TU/Z6cJb sIKrcy0AGAFIqLdg8NCWmzA6kfGtECI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680508796; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pXxZmEIu5fHKpEMjWe4VFwGD5foe1yAV7hjfRn3UlQw=; b=H3J+a5MIYc6nvvKP4dyQr2toAmxFExFSVihf5tKaB2ayA/oMW/P1Ljn1VRDVPRuO8By5ua pP0C0b+txjAvcJZ5qs/RdZMn6lP2BpkoZCu7qHfF0OA7wnCw9JUtOMXqxKwThBxs+FAs7w Q30SznGULD3UA+2Q8fYPg0mlgev6ROI= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-372-lnWdikmyP5OssTZlib_KkQ-1; Mon, 03 Apr 2023 03:59:53 -0400 X-MC-Unique: lnWdikmyP5OssTZlib_KkQ-1 Received: by mail-wr1-f69.google.com with SMTP id l11-20020adfc78b000000b002db44581302so2986382wrg.7 for ; Mon, 03 Apr 2023 00:59:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680508792; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pXxZmEIu5fHKpEMjWe4VFwGD5foe1yAV7hjfRn3UlQw=; b=sTBaKKwKSyVNWXryNkxsi2P2DSpWz1nWM+EHPumbNtZQXdRL1dPTwcIAsCZANTRz14 u8UjiFBkdzK1D26dsZPxQo+9KU3ZDBdtrMx/cYCSsvLELELsBXO+C+SsXAuFYnVtK/U1 8Gz1zENjkqyH0GY0pr+5/a+EQqY3653TqWAVHPLG1dyXFiKnEwXK0aqkqtb0uRxOHJuP jtlpTc+uDyjxflZeMS2mD1J5Xp9hG6kjedT9oGTymcGucLEkulC6SR0J6JHil+NapaxP 5XOKyPWqZORQsJOLpMchqB4nkuMYLbU4yX8tFlti23F17dxwzE0t674FZgbcbtgM9V+L FGRw== X-Gm-Message-State: AO0yUKVWsV2tdjPg/pMhq/KtV8+oIAhyfvtjLhj8fqqQAyiqwCAO9cB6 Sg2C9vUkhAntIhWprzgzA2uzxXPvDLFqWeCHtcPTWE7tIJ6c6keXrbVXFH8N539wB6z4th3IcH/ PAHAWeiLECiU= X-Received: by 2002:a1c:7207:0:b0:3ed:2606:d236 with SMTP id n7-20020a1c7207000000b003ed2606d236mr25401778wmc.38.1680508792346; Mon, 03 Apr 2023 00:59:52 -0700 (PDT) X-Google-Smtp-Source: AK7set/X8u79MwLl/J+jYDyOlSnA4U8KdIDWLyX6dzDnoptzNHhMETa2Fns7sTP9CEwwl0Dk04D5Hg== X-Received: by 2002:a1c:7207:0:b0:3ed:2606:d236 with SMTP id n7-20020a1c7207000000b003ed2606d236mr25401770wmc.38.1680508791986; Mon, 03 Apr 2023 00:59:51 -0700 (PDT) Received: from ?IPV6:2003:cb:c702:5e00:8e78:71f3:6243:77f0? (p200300cbc7025e008e7871f3624377f0.dip0.t-ipconnect.de. [2003:cb:c702:5e00:8e78:71f3:6243:77f0]) by smtp.gmail.com with ESMTPSA id h16-20020a05600c351000b003f046ad52efsm9861898wmq.31.2023.04.03.00.59.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Apr 2023 00:59:51 -0700 (PDT) Message-ID: Date: Mon, 3 Apr 2023 09:59:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH 16/29] selftests/mm: UFFDIO_API test To: Peter Xu , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Andrea Arcangeli , Andrew Morton , Nadav Amit , Mike Kravetz , Axel Rasmussen , Leonardo Bras Soares Passos , Mike Rapoport References: <20230330155707.3106228-1-peterx@redhat.com> <20230330160752.3107283-1-peterx@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230330160752.3107283-1-peterx@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 6D0CD20021 X-Stat-Signature: qt38i7ry7m5c9prwawr97ogziaau8juz X-HE-Tag: 1680508797-949847 X-HE-Meta: U2FsdGVkX19JxV4mJBtN1ssRrlRITn44bFXA4q2gt6P9wSfEm/zIPWnS8RK1T++IwRO2tvekOCWlt43kjfzFFzwrtPwR09/DLiFF26mJ8O7v5L7FuUDTOm/UC1SKCJI+g/I669V9GQ0C5CUBrkNplVsDNhYZpRUc7rxM6fTKjFu4YbFzeycWZtJAz+QAY5v379yVSjz7+dIp9BqkCd/pFXW46Kqr5oJxblyjz7ijWwbxw66zi5iWpl4S04KhAhVrrcpN93G/M++O1LA6ZpFQx7sTE9BfPxJwgtqSfd3ktKTagjwCsIhVVRtVFM+w9O8alYmygwMLGhLJLNCg6EP35LgetpYYMK1lOg6qsm+zqI2g93K/tyCn/mtxXSXg0KK3vgyeHK5Sq9HUAcL8amqQ59lsPUdb0XTE0wN6X6eNHuPM+DtfdSMQCc+2B2maXs0adr0J/d1/IbAVdJkPVFtZyBjFsNC7btlSGGwNToihdQVeAgLGVN90oHov7+/nyoY+UUikN9IeJYDv0Puo5v6ybQCPJY2i5lG8JwiRzGNuJQf1vftjYdVq63J8Jw7bCw3ecQePfBu7gTAxkZLFsDTeUhCerpmOHVO8bKcnc9cUnu/oe9YFgp7l/vMu64eOYKFWO/GZWCqZ9rPIRnr1cZMo371ZJhu7Ekl8LPSS2zfuhwFMkzDU/YaZJHTrGOqibtBPFIzZkk7ePV95+3ZbuJ25olR2KYki0V/Bl/WXH/ga1353MM6AxXsd0eD7Is7HFsi/HQVtibGEvzbCOUK5b8uUzhy5D2Qopwle5i2gDhZKsE+XpzCj050fwBv6WxnwujJ2ytjc7QNNS3ml65roXMM318wkHYB18Flddss6Swh3yrmsGPHAanMSCrpXsusXdjBkyTt9AXUdPr5qN2gBccc3Git3hb0utHk0fI0xQ7/UrT4vCwFX64TQbTvCg2fc374bLaedtEGiragV8E+WUli BkP0vGWA ocMyAaOGkYGcy3803lkzqvCrfcBQBSl3eWg57DIBjHNzNPst3qZG5qAQTTcft7DmiOp1z9yFlHpy9J72yvLGJxPNF9I5FtQmM3sQAIlbmpAopn2Qq4t5vgcIPALSZFmRS5kA45tPbSzimg8drec2YKdPtNR0a4QyoQAehNn2PBZAlI7zjGL1uor5GDLN2DertPfOKu9JSnCLjwJyCDqDklz/oTOPq63CSBeCNuylq9OAyTgaOWYSa2DXPmbXQxyoCqdvBpBifAVv7sMioutbz3FbF+gyzWsQa2R1Ck9qjwsYtldCVexC2a0e20oAtHQ30HeukzTExrOZRrECe40Br9EqjK/T81RowVNjb8tXMqR4yDhTZ5P1gpGcZXjwFX0iiHYlH+GXLZoTT0wx/fAFh7fNP5A248Up6emwYzz4cTWut67w59fegli7J6WvOLgwHRX65lgFl4efTlI7sZ2g1JRTYlDrZg26fgsovgas3Cc2Ol4ef90UAC/oQUJxL1cCNjSOid935BIcVLkquU7/HjNC4uYxI3ZkA5FWR X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 30.03.23 18:07, Peter Xu wrote: > Add one simple test for UFFDIO_API. With that, I also added a bunch of > small but handy helpers along the way. > > Signed-off-by: Peter Xu > --- > tools/testing/selftests/mm/uffd-unit-tests.c | 111 ++++++++++++++++++- > tools/testing/selftests/mm/vm_util.c | 10 ++ > 2 files changed, 120 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/mm/uffd-unit-tests.c b/tools/testing/selftests/mm/uffd-unit-tests.c > index 6857388783be..dfb44ffad5f5 100644 > --- a/tools/testing/selftests/mm/uffd-unit-tests.c > +++ b/tools/testing/selftests/mm/uffd-unit-tests.c > @@ -9,9 +9,118 @@ > > #ifdef __NR_userfaultfd > > +struct { > + unsigned int pass, skip, fail, total; > +} uffd_test_acct; > + > +static void uffd_test_report(void) > +{ > + printf("Userfaults unit tests: pass=%u, skip=%u, fail=%u (total=%u)\n", > + uffd_test_acct.pass, > + uffd_test_acct.skip, > + uffd_test_acct.fail, > + uffd_test_acct.total); > +} > + > +static void uffd_test_pass(void) > +{ > + printf("done\n"); > + uffd_test_acct.pass++; > +} > + > +#define uffd_test_start(...) do { \ > + printf(__VA_ARGS__); \ > + printf("... "); \ > + uffd_test_acct.total++; \ > + } while (0) > + > +#define uffd_test_fail(...) do { \ > + printf("failed [reason: "); \ > + printf(__VA_ARGS__); \ > + printf("]\n"); \ > + uffd_test_acct.fail++; \ > + } while (0) > + > +#define uffd_test_skip(...) do { \ > + printf("skipped [reason: "); \ > + printf(__VA_ARGS__); \ > + printf("]\n"); \ > + uffd_test_acct.skip++; \ > + } while (0) > + There is ksft_print_msg, ksft_test_result, ksft_test_result_fail, ... do we maybe want to convert properly to ksft while already at it? -- Thanks, David / dhildenb