From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40D83C3064D for ; Tue, 2 Jul 2024 13:09:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C69256B008A; Tue, 2 Jul 2024 09:09:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BF2E06B008C; Tue, 2 Jul 2024 09:09:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A1D6D6B0092; Tue, 2 Jul 2024 09:09:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 8145E6B008A for ; Tue, 2 Jul 2024 09:09:38 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 1C28C421CF for ; Tue, 2 Jul 2024 13:09:38 +0000 (UTC) X-FDA: 82294844436.19.192B348 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf01.hostedemail.com (Postfix) with ESMTP id B8F024001E for ; Tue, 2 Jul 2024 13:09:34 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IZVPu2EP; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719925753; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yGUSClHeMzg6nbPRrAvX7VyagP9LdEEerfHwKxYR08g=; b=APrUQCpQdzUs4mNU0s8aQOr/Fi/5mGX6mCZtafiUHppJyN7mAwpKlHA8zKbixYaYekuvRG Dx5ITgQAhWt6KnMUVG3whZCI9ZXS/vA0K6U44P3lsqGXFnhI5h8vviU3YUICwriKOOYjP9 xAYLGxzbWG8+LbsVI8/SYaPc+jVS+qs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719925753; a=rsa-sha256; cv=none; b=wLUQZwDZcvyArE4Q/5Y6p8NKjpW3XTjqAHmvxR0B2SLnbrn1csP+KNiLHdCjgQHeZP1/WE DAo40ilFvuQEgwC7bi+cjUpiZIlsXbxkgh8kXvzM2NpKk7ProZigo+5K/xjKe5xtjnVJUd CCBjYujZqulltlfFFPe5D/2sEtqG2eQ= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IZVPu2EP; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1719925774; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=yGUSClHeMzg6nbPRrAvX7VyagP9LdEEerfHwKxYR08g=; b=IZVPu2EPlwVKcczBxLBwCbRGo7SwCNcH1Z+OmPG/htKfYOKD/z6ZXKHw60U39HIDzE4TBN UaTXYByy+uZt9I7wOC/AOPOTXKfpoHrQqAgckgTYrHHrwXgoG4faIb9ak+C0oaaZOZwaLO KyIc+3h6nLzDIKKAvTrb9dfVAUnC/ik= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-13-2S6nCnuaMs-chjtYpTJ6GQ-1; Tue, 02 Jul 2024 09:09:32 -0400 X-MC-Unique: 2S6nCnuaMs-chjtYpTJ6GQ-1 Received: by mail-lj1-f197.google.com with SMTP id 38308e7fff4ca-2ec4df4e2e8so46510501fa.0 for ; Tue, 02 Jul 2024 06:09:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719925771; x=1720530571; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=yGUSClHeMzg6nbPRrAvX7VyagP9LdEEerfHwKxYR08g=; b=qeaQPb+gr2ijek8QlG3kL8lTlpUgRBRQP0TjBd6V8bnxzixIqaCElGMYrEKgm9ifRW dvL4+mDf6Sa1L9ukY7kbh5lYmyB+wLWNvJct17+VlBYVzZtAOGPcQOfoRs0oW7IdHM4v M043mkLnYRL3bjxAI5KmaBjxH4H089p6RzmkNmymtQJJC/8DWdnHMaKXL+2BQXfZfwJI 5IejWcuu3R4QKWwhuklsg67eQ4Gvr/oQv0mTuGZXs9K2ybU1RusT5XbiItSSDbTzBRoe s79dMiuQSXOVB3nwQzBxr6MwYG6iklmltu18L6Lpy485G9Jdm469DPhBcUPuFMdPsSt8 xBwg== X-Forwarded-Encrypted: i=1; AJvYcCUdP6W6RIDL0IjbBZ5lmHiURVjnIfeaxud0AdAzlbFpBMP2A8gDYNFh++LYSAYLBvYc1dDo/jHkxlUHYst9fAqypV8= X-Gm-Message-State: AOJu0Yw78kia+5byB7BxYqrEXcng4BQI+uziKnTGpDja1W4ixixXBgRe Npy3LTuURbsmvZt8M51Xp23qwf4HwaQXIvj4rv91+iZ1yKZmaTaApv/xucUt8iSqNTvp+G8p+Ms 7E++KHAlGixHmgbwBqdm7lCIoLetYinruVbY0cHr41ujBJ4hL X-Received: by 2002:a2e:b52f:0:b0:2ec:5a85:66ec with SMTP id 38308e7fff4ca-2ee5e6f53e0mr52093221fa.48.1719925771129; Tue, 02 Jul 2024 06:09:31 -0700 (PDT) X-Google-Smtp-Source: AGHT+IElp/GUCQIPCGUan1vDspIbGqVIvT/w73lPBqY8eNvOW5s0aY67EApd7i7oGUnP2lLKZ783BQ== X-Received: by 2002:a2e:b52f:0:b0:2ec:5a85:66ec with SMTP id 38308e7fff4ca-2ee5e6f53e0mr52092681fa.48.1719925769680; Tue, 02 Jul 2024 06:09:29 -0700 (PDT) Received: from ?IPV6:2003:cb:c739:2400:78ac:64bb:a39e:2578? (p200300cbc739240078ac64bba39e2578.dip0.t-ipconnect.de. [2003:cb:c739:2400:78ac:64bb:a39e:2578]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4256b06377dsm199222015e9.28.2024.07.02.06.09.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Jul 2024 06:09:29 -0700 (PDT) Message-ID: Date: Tue, 2 Jul 2024 15:09:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] hugetlbfs: add MTE support To: Catalin Marinas , Yang Shi Cc: muchun.song@linux.dev, will@kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20240625233717.2769975-1-yang@os.amperecomputing.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: B8F024001E X-Stat-Signature: b6q11ro369xusxmi86476ded41zm9bg9 X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1719925774-125945 X-HE-Meta: U2FsdGVkX18yIsW79Pd8ZQLaYtlV7mrNDxLrus4Msj25VLbaEcK6fP4ccRnIKfY+q6Kmn0z8nvK+0lIoCDG0dfyrDkI3SRl8wPen46zMh9FtmF4wLAUdL30GUZQr7EM2LSlvTu68QFVuyJHsCFThvTDKXIhrIggDLfEQ1XZYrne3++1TejgY7i8l+0Nv65DvDhtXThyrv8uIO90gHbekv0YrnJijTyMNemORWVRhtaQPUZz3AWOXVDI4BrWiuQlOylXZDjVhf8vqV59giVp4TR7IFO56WrRxrxXQVtERQ/RnJy52Zs4QPPHIpZnxvlfhBYy37P1QXVm6mvOESooXdS1Cj1nYvFy0Zxm61klTey8ulK8WWsikyUzecH4E+wsYtLGuUeT5HwqkHHVDhEdNov+7UU8w2AgqVAkxTkj5SB5553YhB0ls9+hHsowyeYACs7/6+nOzEQ/p4C86wtDZP7UZxlYEYmdbgh86bZAiEIqv9vCAi5bMkPPvGMTx1CFnOnFsHrHwkqu/8ohiTGobRCaS0id/L10ffXJ8Hh2WGM7ZslO3S/fe8RcBd+9/b1godMGBfPnELB6xLr7XvOf2tKwJ9dnKjWxAw7uZ4z8mRj1Sz3ty2t//+gmdo3EbQPho+JCkf7bemYJ4e0JNZ5Cykm3JtRaTN0kuZoUsV8USQ3VXQHcAwYFvdCPqF4i1VbFZ/4nuwAlKD/ltc54oQ93O6+u7g7te8xOPKCW48QYlnDsW9RnSYbdcxdC8UYj3pl7lFyTXLNPjoNngjEtf7xRggo47FIJMOvSe4fBcDCjn9WlFpjzhF6ZrXCLr5tFUXG1jMHkJhzFPzi47IlUyaZ9CKRzE2KfPGQzsCgWDlJtX7gsv3+GrcTdHo9DoHUA5TbX4yuYh25wOxw8jdVqT32BHiqtGbYSPYvtwY/UqArusA15g8swf1woeoSqVHkboAtOeVdaYRHADWeTDaWfSPhN /UjaaPOG X6lwC/QHG/FfDV/mQotNOf+yM2BcDDQ7MnaG7ed0efVRY3j7S5YWSVbFQp/qVxqd4eoAG0/YozQI3lMb4PBbqQIN827oWw6yEB4DIJG9jRYRlTpA/G7ANhRwozpP26RFQfGf53KNkDSpyIc5QQ/7/fc7ElEYtsZCiKZ3s6kvKaaq9sPUsBZ5JlVsadPlB/kh2twQmdVQpk78GU1aaWu/+2fEfucpIshVJHxdc40J8r9atMMDPzCSPPF4pybVzL8jMoAyJH7TiKalGX6loGYXCqDNcl+qXFH9JItVoyS/wq9BoiLBCyRCJN8JpJErB4sD0+l9LxMOqtdP6pCwsWsIvIr7H16GtDNZGwc8R1dg6Tu1f+vZRC17huz55KJcJceqGt3Q66DRBoNGYVYH5hkTd5XzDutljLX3QDK0H5pMMlU+R0+0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 02.07.24 14:34, Catalin Marinas wrote: > On Tue, Jun 25, 2024 at 04:37:17PM -0700, Yang Shi wrote: >> MTE can be supported on ram based filesystem. It is supported on tmpfs. >> There is use case to use MTE on hugetlbfs as well, adding MTE support. >> >> Signed-off-by: Yang Shi >> --- >> fs/hugetlbfs/inode.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c >> index ecad73a4f713..c34faef62daf 100644 >> --- a/fs/hugetlbfs/inode.c >> +++ b/fs/hugetlbfs/inode.c >> @@ -110,7 +110,7 @@ static int hugetlbfs_file_mmap(struct file *file, struct vm_area_struct *vma) >> * way when do_mmap unwinds (may be important on powerpc >> * and ia64). >> */ >> - vm_flags_set(vma, VM_HUGETLB | VM_DONTEXPAND); >> + vm_flags_set(vma, VM_HUGETLB | VM_DONTEXPAND | VM_MTE_ALLOWED); >> vma->vm_ops = &hugetlb_vm_ops; > > Last time I checked, about a year ago, this was not sufficient. One > issue is that there's no arch_clear_hugetlb_flags() implemented by your > patch, leaving PG_arch_{2,3} set on a page. The other issue was that I > initially tried to do this only on the head page but this did not go > well with the folio_copy() -> copy_highpage() which expects the > PG_arch_* flags on each individual page. The alternative was for > arch_clear_hugetlb_flags() to iterate over all the pages in a folio. This would likely also add a blocker for ARCH_WANT_OPTIMIZE_HUGETLB_VMEMMAP on arm64 (no idea if there are now ways to move forward with that now, or if we are still not sure if we can actually add support), correct? -- Cheers, David / dhildenb