From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 172EDC48BC4 for ; Mon, 19 Feb 2024 01:14:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6DCB38D0003; Sun, 18 Feb 2024 20:14:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 68D0B8D0001; Sun, 18 Feb 2024 20:14:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 554258D0003; Sun, 18 Feb 2024 20:14:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 438A78D0001 for ; Sun, 18 Feb 2024 20:14:52 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id DA0751601AA for ; Mon, 19 Feb 2024 01:14:51 +0000 (UTC) X-FDA: 81806783982.18.BA79836 Received: from dggsgout11.his.huawei.com (unknown [45.249.212.51]) by imf20.hostedemail.com (Postfix) with ESMTP id 562B11C000D for ; Mon, 19 Feb 2024 01:14:46 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=none; spf=pass (imf20.hostedemail.com: domain of yi.zhang@huaweicloud.com designates 45.249.212.51 as permitted sender) smtp.mailfrom=yi.zhang@huaweicloud.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708305290; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+IefNoVoSV7BbIwGcel1hJGb5nO+snSMy1oUdQp53kM=; b=z5slfzEEg1TIbPFvBwhJJB1F62AOQZ9RglCbdgZZgi4lkbdnz2FJXo222jkRFyDCB8LTpg jE/qwjylfEdLUGgPL10Zc1kVrZb8/jjVcvgOhe8APAqqslekDWvX80tyRCnHIL9ka0JfBB Q7Xohcr3lqE/5dVzOnTbUd279X0edyk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708305290; a=rsa-sha256; cv=none; b=wh9bG2AN0knxbGnul1bgVv776RVxt19gIcVmc6OlyuM1xOgEU9aeBPim0o8ctpI7MPIxnm Z7z0K1cq3hRCR9Z/GkctjlSMpYb6mlnkpYj2bGX3LW7SMRIQri3jOwoqpF3b9mtjKuU4N7 KJ+6YY39DpvE9CXrhq9gV4+wXMlsOnU= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=none; spf=pass (imf20.hostedemail.com: domain of yi.zhang@huaweicloud.com designates 45.249.212.51 as permitted sender) smtp.mailfrom=yi.zhang@huaweicloud.com; dmarc=none Received: from mail.maildlp.com (unknown [172.19.93.142]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4TdPhZ6Whsz4f3k63 for ; Mon, 19 Feb 2024 09:14:38 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.112]) by mail.maildlp.com (Postfix) with ESMTP id 078BE1A016E for ; Mon, 19 Feb 2024 09:14:42 +0800 (CST) Received: from [10.174.176.34] (unknown [10.174.176.34]) by APP1 (Coremail) with SMTP id cCh0CgDHlxB_q9JlUdbNEQ--.27706S3; Mon, 19 Feb 2024 09:14:41 +0800 (CST) Subject: Re: [RFC PATCH v3 07/26] iomap: don't increase i_size if it's not a write operation To: Dave Chinner Cc: Christoph Hellwig , linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, tytso@mit.edu, adilger.kernel@dilger.ca, jack@suse.cz, ritesh.list@gmail.com, djwong@kernel.org, willy@infradead.org, zokeefe@google.com, yi.zhang@huawei.com, chengzhihao1@huawei.com, yukuai3@huawei.com, wangkefeng.wang@huawei.com References: <20240127015825.1608160-1-yi.zhang@huaweicloud.com> <20240127015825.1608160-8-yi.zhang@huaweicloud.com> <74ab3c3e-3daf-5374-75e5-bcb25ffdb527@huaweicloud.com> From: Zhang Yi Message-ID: Date: Mon, 19 Feb 2024 09:14:39 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-CM-TRANSID:cCh0CgDHlxB_q9JlUdbNEQ--.27706S3 X-Coremail-Antispam: 1UD129KBjvJXoW7uw17Ww48ZFWxWr48ur1xZrb_yoW8Gry5pr 9093ZYkr1ktF1SyrZ7Aay7Xa4rK34xKFy7JF9rWw15JrZ8Zw1Skr48Xa45ua4DA397Xr4F v3yvy34rCa15ZFDanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUvIb4IE77IF4wAFF20E14v26ryj6rWUM7CY07I20VC2zVCF04k2 6cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4 vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Ar0_tr1l84ACjcxK6xIIjxv20xvEc7Cj xVAFwI0_Gr1j6F4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x 0267AKxVW0oVCq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG 6I80ewAv7VC0I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFV Cjc4AY6r1j6r4UM4x0Y48IcVAKI48JM4IIrI8v6xkF7I0E8cxan2IY04v7Mxk0xIA0c2IE e2xFo4CEbIxvr21l42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxV Aqx4xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r4a 6rW5MIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6x kF7I0E14v26r4j6F4UMIIF0xvE42xK8VAvwI8IcIk0rVWrZr1j6s0DMIIF0xvEx4A2jsIE 14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf 9x07UZ18PUUUUU= X-CM-SenderInfo: d1lo6xhdqjqx5xdzvxpfor3voofrz/ X-Stat-Signature: k66nw9uxahumq8gahhe8go3zjqbq5544 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 562B11C000D X-Rspam-User: X-HE-Tag: 1708305286-336344 X-HE-Meta: U2FsdGVkX1+pG0zI6iqhcRos8YyKvmD1sDi4229cA9YYzjp8RIUZ+zHyQSoDjyuNL6kAYwktJvtGaqs5hLqGOX66+YTu45fmFiZBMm07WNSesnKhoJKP6fZVFzomEN9jjVsFitdWRNNR1omZvc2eRNyqntNwj5eZQZ2Wa53noIECl9zS05sFpL8zM9C+IlkXnulzCmJ3+Cln1xTrS+aZ6YOxKSL0HBvHfoLrVD1j9pohXYH1/GmuiyiK3jYE2Tv2BPJPFJsQtxEyLMnPKMjbOpvQuaLk4+y3rSi/hHA82aEIjEFr2LGXgMRUJ8Ojxx44yxEjy6QiwLudrv4Y263F1qDAXBUv2zhZUw7u3efRwSDRq6Lf6owpAftA4N4dbRBmVHOPEc8rAEJw6s0GzwKcp9fqeo42QpTPtw4bO15zFP3y4kgQKSHiceIaYTQ3UaQ0QeL7pcTvG6zyHNuYm+9pcPQg9OcGryNKGKe22mAehallKcndzVJEVf1N7ECPzHjhlmGL0YtC8g6a5di9d32kHFE1yFRpEpP/Dxow9jkxn/dkhBI/LVe+XJ8Yxu3sIJDJcXlimG+cfIu9WqBov7f4182+lSbTiUos2JtEwFkONbvqXVeGLTkrI99dpKIMS3QBll4ZXIa1eli1itUb8OUwEUp8WzSoiOslL3kojqJmTbqqLyZ7QtgtKs+ik+gW5sCtKS8OT81AsQ16bGvyeHFSB5Sy6CfYkzcUT3LYL+EGtEHTpRgtSDRW5nJNQfM/a4GXBqKix8nJsm6phl/zWwRAEo1CkgKgS9lohV7XKoHYW0w7sXMwueqF3kXlX37+kFOSDiK9Ew4ssrirkn8RGi2b7QiwaaF/4hrPuscnSBGilpAFZJAxbUZ7Z85mhA+8nbZKvAZHWPqOdkI2Z2mcJ9GeVODW6z5RfWa8U/xAzvgUBsmSpk50XqSm6V27AIErFsnPFHhR4f5flGyR3eL0qtK v1biL8+T PyVxM+IXP5VMmCSWSw5ecV4JQqCmmTsLBUKihvQpUEto0HyBgFMFL3GpFwfoFDaWALK3/56TslLuXxpEFYr87/QXRqJr6zeE/ZPc/E5cDNDWsNfkrzsWoljS9TFP5JX9t+FPux7Oz2CB3YchEb3mfub2IcYk3QBC4SX2yx1lPNgfNJsdSyX2u8ewksD4Sk4RDa7YAq0z/5TkETDvsn2J0jk1QOfCjjhk0nwHUSRUnnCgbWHVm5fB8W5daMaPlciZDpBRXfA5LF7OsXwK6jtsyK5tXt2h5u1G8fXHu X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/2/19 7:30, Dave Chinner wrote: > On Sat, Feb 17, 2024 at 04:55:51PM +0800, Zhang Yi wrote: >> On 2024/2/13 13:46, Christoph Hellwig wrote: >>> Wouldn't it make more sense to just move the size manipulation to the >>> write-only code? An untested version of that is below. With this >> >> Sorry for the late reply and thanks for your suggestion, The reason why >> I introduced this new helper iomap_write_end_simple() is I don't want to >> open code __iomap_put_folio() in each caller since corresponding to >> iomap_write_begin(), it's the responsibility for iomap_write_end_*() to >> put and unlock folio, so I'd like to keep it in iomap_write_end_*(). > > Just because we currently put the folio in iomap_write_end_*(), it > doesn't mean we must always do it that way. > >> But I don't feel strongly about it, it's also fine by me to just move >> the size manipulation to the write-only code if you think it's better. > > I agree with Christoph that it's better to move the i_size update > into iomap_write_iter() than it is to implement a separate write_end > function that does not update the i_size. The iter functions already > do work directly on the folio that iomap_write_begin() returns, so > having them drop the folio when everything is done isn't a huge > deal... > Sure, I will revise it as you suggested in my next iteration. Thanks, Yi.