From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92A8EC25B50 for ; Mon, 23 Jan 2023 22:23:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 18C766B0075; Mon, 23 Jan 2023 17:23:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 13C906B0078; Mon, 23 Jan 2023 17:23:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 004306B007E; Mon, 23 Jan 2023 17:23:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id E62C76B0075 for ; Mon, 23 Jan 2023 17:23:02 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B47C740624 for ; Mon, 23 Jan 2023 22:23:02 +0000 (UTC) X-FDA: 80387490204.13.2044EC9 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2062.outbound.protection.outlook.com [40.107.101.62]) by imf22.hostedemail.com (Postfix) with ESMTP id 930F6C000D for ; Mon, 23 Jan 2023 22:22:59 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=dtN9TqJg; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf22.hostedemail.com: domain of jhubbard@nvidia.com designates 40.107.101.62 as permitted sender) smtp.mailfrom=jhubbard@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674512579; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=b78PDXZwyKm0ALpasvEvgtnkxHhiOoOSB2vsVFI9HIU=; b=bylmyhdW6Wzang6sRE3RWPjZoNc/1ToxevfewH4h0Ja6bGFT+b8/aMaI+nsbz9IxmAtT8Z zENPK4M8qgS6DW2blmZ43OuHChMxx359oUN8t4Ou+MuwFtZgnzxIayKGUIccVWUcSDh5t9 4qyYMnjiSO6riFmMcrY0e7H57dQ1mbs= ARC-Authentication-Results: i=2; imf22.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=dtN9TqJg; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf22.hostedemail.com: domain of jhubbard@nvidia.com designates 40.107.101.62 as permitted sender) smtp.mailfrom=jhubbard@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1674512579; a=rsa-sha256; cv=pass; b=Q0lUmgoieqy4OJxQN44BEY5bVbis6F0xB2xB1tbfnk+5TtVOSDGBl9c+DvIY4mqpVxrZ63 zF7F+s1Zm2Y3PAoAVKKCtUtKB1PKNF5CsdFoU/Sz/VMfgPnKBzThg7wWmEocAU+hxZGAgd 08FOsI/UGzpMJCDlqEpdXl4leuyi9q4= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZRqKj914VbK7fNZj+rdx55xxskm2Wu4raqJ1kum2adz0crFYfTvPE19P/L+BtguuL4j4Ssu3naxgAHTa/Od0d5C/6gX/GLTgFWJ8dbC8t1of2b5b2GnroGCLPA9Jg0SidYNH3WCeHJe2lpcCHgFtU9ayHEBeBGDGowT672p+LVN8JfRAtvoU6F9GhTUE+IVN24S8kBFnOzKK7RIp2nzmd5rH/8tkvzwirFw1Lsja9YZPcFIEOCvutiEoSzyd/V1AeEDKLysItpRvKz7Yvd9/8L1gjHMr1QtDgyhTNvKZSSWZazdlPViw3OOXoiutyEU0WBLYJAmJhfqnO4ebQH+OiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=b78PDXZwyKm0ALpasvEvgtnkxHhiOoOSB2vsVFI9HIU=; b=HcvnMmfJzEieTcY1gjLGmZ7kSweuT61CWBxfNpg1XRU8+NY6jSDxBeaOWOZn+flxHhYyd+FVO9tCYW+TcltB3y6cHUEY8y2oZ9aTOdViCtxde3EpzanSbbgB6iDeDVtwFK3gRYkwVWIjAiEI090D63rjVzoJ8+15pOKxYcwEw6m4KwJKVgxzpvmA5+TD4xH7CUHCeW8gX0bN6dh/o+hZ9vsFJu6GqbqpAIsg9gSDFfU3/nfEKfsA36ol74ZjNYtvo/4T+mMKr3z+GvbqcXDGZhHYcazqc6PiuKR/0GhhMLB2xINBOFFpY5Xj2iMUs4Wzzk7/ySZwU4t8518YlEQCdw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=redhat.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b78PDXZwyKm0ALpasvEvgtnkxHhiOoOSB2vsVFI9HIU=; b=dtN9TqJgebhV/n/6dxXyilpd6DvLuand+U3jz5WiLOQFuI/4yiHO8+/4I6bAYx6pXiq7sDKah3qcst7ApklD3wkE/ogPFL6CwsqXETRIhofZiblCdh03zMcV0U9F8jP0G2tg35uUYwHoeBJ3cGEeft+i1I/T8MxPKq6gnByxQQmfnLIpvixua+pRbCXMHntO5zEfBWUZdiYcALyjWaoE0jAwa3fnDRSFu7oV2QFw1nJ1/qgpNM1koU0BvuCl++dvXjdvEbTduDs7EHF+kaR1douj15E3Y4Z5PrsZrZbdBQFhN9uw0Mm4lblkFX3qfOPdlYToO0bVHuQJSKpMISEaHw== Received: from BN9PR03CA0860.namprd03.prod.outlook.com (2603:10b6:408:13d::25) by BL1PR12MB5063.namprd12.prod.outlook.com (2603:10b6:208:31a::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.28; Mon, 23 Jan 2023 22:22:57 +0000 Received: from BN8NAM11FT035.eop-nam11.prod.protection.outlook.com (2603:10b6:408:13d:cafe::88) by BN9PR03CA0860.outlook.office365.com (2603:10b6:408:13d::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.33 via Frontend Transport; Mon, 23 Jan 2023 22:22:56 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by BN8NAM11FT035.mail.protection.outlook.com (10.13.177.116) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6023.16 via Frontend Transport; Mon, 23 Jan 2023 22:22:56 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Mon, 23 Jan 2023 14:22:44 -0800 Received: from [10.110.48.28] (10.126.231.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Mon, 23 Jan 2023 14:22:44 -0800 Message-ID: Date: Mon, 23 Jan 2023 14:22:43 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 5/8] mm/gup: add FOLL_UNLOCK Content-Language: en-US To: Jason Gunthorpe , David Hildenbrand CC: Alistair Popple , References: <5-v1-dd94f8f0d5ad+716-gup_tidy_jgg@nvidia.com> From: John Hubbard In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.126.231.37] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT035:EE_|BL1PR12MB5063:EE_ X-MS-Office365-Filtering-Correlation-Id: c7aeaf79-ee00-4519-99e9-08dafd9060eb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BiRbIolwY6EML4mGVljWZep2/sXgr2H9yA78uNCbXuFG1w7W3urQKeLEg6I8P5wxrGCQPfDhHEw8a4QTyaXY+B9oZrM2x5vFAQEfmY12du8CuLQLQrO6Cmv+DmjZPamSzkV7WoAkqKzBRBJ8CZ/KoaT3wSxNB6nTH84EGa/7EJ0hA07tFBHGgg69bC9sJVoIknIhYe4dnIQRbSq5I1YJf1mnoPuM5qyQSpGpPnC8860dDVRPy1q2+/V3idGDkdmjPSC5iNEN72kgTWoDQsyzCDvhhN24pod3v4xtgwhDDzk0mxINQxvUC51BpewwChJFZG0szdoNvxlACTj6IQsPE0qtYrqog2hzzH9he5M1gYFHfF65NK1hr33nQ36cJ/IYFkZP5ub4hEwDwaQUnd7j9xYrIdlEFYoLwJQVsee0iaEiXfdKkMbEnm6yPD1O8tL8gKzKE2KwQLZfmaaIiVvJKfUvMcS5LTdWX3NMMEv1e4o7g8f5g5sAi7nkLWjEmT5wCBFyKOrVALQ7Y7i5mqR82RvRWxlrO3rDwIfDNOrw/KOHFpl1bT+aRm9IAwk4EttLmru6MK+oXabR7+R3QJHIKbIr0Y2Gef073Wkh/CH5gnAduGOI4td7bG4Zmwihi6yd+UguUVZaUs5BYCMlcbHk/apRKceV5aC9j5o2/DoJxU43b1PDqNAmwaWBNJ37L4AdmuczHRm8H+kN0m0ykjm6ayiUuwF6LTTCloIqTBXo+UY= X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(39860400002)(376002)(136003)(396003)(451199015)(36840700001)(40470700004)(46966006)(86362001)(40480700001)(16526019)(31696002)(2906002)(4326008)(4744005)(186003)(26005)(70206006)(70586007)(336012)(426003)(478600001)(47076005)(8676002)(2616005)(16576012)(7636003)(40460700003)(110136005)(53546011)(54906003)(82740400003)(356005)(5660300002)(8936002)(316002)(36860700001)(31686004)(41300700001)(82310400005)(36756003)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jan 2023 22:22:56.7330 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c7aeaf79-ee00-4519-99e9-08dafd9060eb X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT035.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5063 X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: ez14naddcdfkom4yzxm9uf1rpkwysxdb X-Rspamd-Queue-Id: 930F6C000D X-HE-Tag: 1674512579-651878 X-HE-Meta: U2FsdGVkX18xO6E8A24R3JoRJd6+pRBUtFkHrmzivJ4vyEhy+QH6reHAWpw507PHB8RomwWgftHsGjTEwE9GIHvSMgnG+GPk72NkniZxHIGI5xWdSDswxeG5oIysmxgrZ9Mxl4JASnWUrpdYNyZJs8Cz6eD/jqmC6zFnsfreIOAZQiRKBcqv1JRrsmJEzHRk9sjS+Fej1wRmvdghsaHOXXI0Xq61NkkNpwXA/eM+GbeUOUU/hRCJt5Xwfc4j0iaDSd9DLP1S8c5BI2bWdyQxjGU7CcYf8cViyxRuRPAK5Ex7dpkdaVzMnsvD/v4YgLHUP/uQf+/dPqXwICLrj+u6W0W6v+lOffJBzJas2RDVgaRkxVDSUr7K/1j6LIG1KN8d1AVFHE+UUExrn56jWdv05g3Vi6+hytf/7A99mIO+/Y8XSbTLovo6P9MgiiLimje4iTULo4H0sL70iptAzjlZo2+rRFLPpdiIgaiZtFP+i8Phc/+S//thwPwzE0T8bTMiWS8yGfPNMC0Zbq73TZQ0SaRBJGyjzExt6CPFU9JOc986KylUMdue68bW6SYWO5sKJ4hZ+abRK8vh2nIvvzy2SisLiXhQus5tGY+V5zruaBGkdRwWymegeXftNwNQAdP/v3Ygvo09xLMoXx8B5xgrNKDQKojMXGmH9Rv6Ha4FA+jXcQgRBV4WXPgAct5Q0a/CNyZQ++onMLBwtKWVJUJjSWjnLuDCvELg2LwC/N14xSs5XK/Xt+TubIfHAJ7vzzIDqMZWTdnflpMD7+hKmTQofOeOOOaOLEMS8EgMvB1Hcuzxpvqi2dspGp3+O70GUkBG9viYAeauwUdoeNG0xLLqYM9+fpBqjFYN23aAnAJfonVTisPztHnjENJUWnlUjg8V8DilXZeyYrRqfTW7bnByiSLHcb2Rwt6n0KUV2xIBOieuFTNfLrhdyjrx6gtYhdRpmcx2S1kKD+qVmVMJH3+ PYJm9TCh RNYi7FEoEc9vOQjAUqVLU0KgQwFscliS5E4YFh8G/6aGEF9FgMEsSgVYkutL6B6Nq99/4zZOj81WTcX4PexNQw4QZreCuOYSR6pqPvghiiuVbNGYZIXmjYqaHaej60LGFawhBbrx/InIb3CmptbpJ2JP5l6vchjfwokUvngjrTlBu+UXyI9PITpUhm16+Kp7Ta1cdP63hpL1Vy+tFIxTedq/xyIDeisUMzk9J0gCCN/BpWosL1yBTCdGResm4rlAhsuSTr+ufdOUDlTYJGUqP7hNUw45C9c/tSLL529yungPX4UE1VtBexyl1zuBy7mpbm0WfqDViwl94gxK0YDObqeRZ3s/iVM2CuAbPil9eh/df+2U= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 1/23/23 09:58, Jason Gunthorpe wrote: ... > How about, I made a patch to move all the internal FOLL_ flags into > mm/internal.h ? Yes, after thinking through the internal and external APIs, and the FOLL_* situation, that sounds like the best overall approach right now, IMHO. I also considered whether adding some naming hints on top (suffixes such as _INTERNAL) might help, but so far, it looks like it would add more clutter than is justified. Instead, just looking at where the FOLL_* flag is defined seems like it could be enough. And there aren't *too* many flags, after all. thanks, -- John Hubbard NVIDIA