From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F5A9C433F5 for ; Thu, 10 Feb 2022 11:37:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 716E86B0075; Thu, 10 Feb 2022 06:37:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 69F876B007B; Thu, 10 Feb 2022 06:37:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 567556B007D; Thu, 10 Feb 2022 06:37:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0237.hostedemail.com [216.40.44.237]) by kanga.kvack.org (Postfix) with ESMTP id 43E716B0075 for ; Thu, 10 Feb 2022 06:37:50 -0500 (EST) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id F1C46213AAB for ; Thu, 10 Feb 2022 11:37:49 +0000 (UTC) X-FDA: 79126670658.10.EBE8CA1 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf02.hostedemail.com (Postfix) with ESMTP id 7BB5380060 for ; Thu, 10 Feb 2022 11:37:32 +0000 (UTC) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.56]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4JvZT42pQKzcckG; Thu, 10 Feb 2022 19:36:24 +0800 (CST) Received: from [10.174.177.76] (10.174.177.76) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Thu, 10 Feb 2022 19:37:24 +0800 Subject: Re: [PATCH 01/27] mm: remove a pointless CONFIG_ZONE_DEVICE check in memremap_pages To: Christoph Hellwig CC: Felix Kuehling , Alex Deucher , =?UTF-8?Q?Christian_K=c3=b6nig?= , "Pan, Xinhui" , Ben Skeggs , Karol Herbst , Lyude Paul , Jason Gunthorpe , Alistair Popple , Logan Gunthorpe , Ralph Campbell , , , , , , , Jason Gunthorpe , Chaitanya Kulkarni , Muchun Song , Andrew Morton , Dan Williams References: <20220210072828.2930359-1-hch@lst.de> <20220210072828.2930359-2-hch@lst.de> From: Miaohe Lin Message-ID: Date: Thu, 10 Feb 2022 19:37:24 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20220210072828.2930359-2-hch@lst.de> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.76] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected X-Rspam-User: Authentication-Results: imf02.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf02.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 7BB5380060 X-Stat-Signature: hbgqrzjy7o8qxc81untzqnkxhgwcydm3 X-HE-Tag: 1644493052-57763 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/2/10 15:28, Christoph Hellwig wrote: > memremap.c is only built when CONFIG_ZONE_DEVICE is set, so remove > the superflous extra check. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Logan Gunthorpe > Reviewed-by: Jason Gunthorpe > Reviewed-by: Chaitanya Kulkarni > Reviewed-by: Muchun Song > Reviewed-by: Dan Williams > --- > mm/memremap.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/mm/memremap.c b/mm/memremap.c > index 6aa5f0c2d11fda..5f04a0709e436e 100644 > --- a/mm/memremap.c > +++ b/mm/memremap.c > @@ -328,8 +328,7 @@ void *memremap_pages(struct dev_pagemap *pgmap, int nid) > } > break; > case MEMORY_DEVICE_FS_DAX: > - if (!IS_ENABLED(CONFIG_ZONE_DEVICE) || > - IS_ENABLED(CONFIG_FS_DAX_LIMITED)) { > + if (IS_ENABLED(CONFIG_FS_DAX_LIMITED)) { > WARN(1, "File system DAX not supported\n"); > return ERR_PTR(-EINVAL); > } > LGTM. Thanks. Reviewed-by: Miaohe Lin