From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16BBAC5320E for ; Tue, 27 Aug 2024 06:15:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6DA4E6B007B; Tue, 27 Aug 2024 02:15:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 68A6E6B0082; Tue, 27 Aug 2024 02:15:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 579236B0083; Tue, 27 Aug 2024 02:15:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 391476B007B for ; Tue, 27 Aug 2024 02:15:50 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id D16451A1609 for ; Tue, 27 Aug 2024 06:15:49 +0000 (UTC) X-FDA: 82497014418.04.A8A8950 Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) by imf04.hostedemail.com (Postfix) with ESMTP id C58054001D for ; Tue, 27 Aug 2024 06:15:46 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=none; spf=pass (imf04.hostedemail.com: domain of lihongbo22@huawei.com designates 45.249.212.191 as permitted sender) smtp.mailfrom=lihongbo22@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724739233; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ATgThddsaRJ0Lv2B3vQU2qI3Ij0yS8SbdQgqs8q5jKY=; b=7ekJ6jabLsnJ+vgdLpg6wtrfXwoqCxZOc9p+O8Dspx9MOazi2d0Tx5vGaliyqP3RZh9Z+7 P/ZaFHyOUMvOKtovR7WwHSdv8z2GflYveKGASr0AwXLxvK4VFnJMOf/oRLFsAGAxR0YJua rUs7huPXMc1U6DG5sCNhgEDm+fOme+I= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=none; spf=pass (imf04.hostedemail.com: domain of lihongbo22@huawei.com designates 45.249.212.191 as permitted sender) smtp.mailfrom=lihongbo22@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724739233; a=rsa-sha256; cv=none; b=ICaq5a3vkmmQ3xIxA+at+WIT7HMoIzHoaCGgDN48INKVsclqDzzVzLIM04z56kIR4M9e0I 3KQVfZozkjuISn88iUuLim+rDhq3xSN1/zptJN2sOnmFOGScZ5OiOJ56ldpgcnxXmmtiQE Xth1iGMNOUurhHQ+4ZZvswYqxnHjcHU= Received: from mail.maildlp.com (unknown [172.19.163.17]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4WtHJP1XsDz1HGfr; Tue, 27 Aug 2024 14:12:21 +0800 (CST) Received: from dggpeml500022.china.huawei.com (unknown [7.185.36.66]) by mail.maildlp.com (Postfix) with ESMTPS id A56771A0188; Tue, 27 Aug 2024 14:15:39 +0800 (CST) Received: from [10.67.111.104] (10.67.111.104) by dggpeml500022.china.huawei.com (7.185.36.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 27 Aug 2024 14:15:39 +0800 Message-ID: Date: Tue, 27 Aug 2024 14:15:38 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH -next v3 3/3] nfs make use of str_false_true helper Content-Language: en-US To: Matthew Wilcox CC: , , , , , , , , References: <20240827024517.914100-1-lihongbo22@huawei.com> <20240827024517.914100-4-lihongbo22@huawei.com> From: Hongbo Li In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.111.104] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpeml500022.china.huawei.com (7.185.36.66) X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: C58054001D X-Stat-Signature: qhs6uoj6kyfut6ethnz6am3qeaxr1dtg X-Rspam-User: X-HE-Tag: 1724739346-942257 X-HE-Meta: U2FsdGVkX1+xKEbIcUA9jDEuJuCS2YS04A3m5vcXDdogpxpF8XQhAUw01Oz1FbnOGMbhZ4bMC/V1pQCgfW4LPw/oAoHQjB1/z98mzUGN0bq2Ep9doULxwVRZ+REAlHJeFH71Humcw7dPT/6ClMxZkAGck7WNu3Oombr9W0MyCBq8AFLyYJSNwj2bXqVvafJWFerXIAEgOkbr2diEFfoJf9Ye9bjBwDXVXcG9nb01yrFwXV8Xzhi8VrMAHUn9wiBhkJyxX1n3P4DeFFCyj6gHxyJjjrXYfdVs9s/DBcb1pIDfpril/74a4rvynzSs2sQra3vCul8RvtsBMlsWAFN8QEQZmgIPb7KW4kpDXfjNsJkKfkx7XwnGCVQT5Z9dBWFr5do50npEfyhPrAKfQYjrKQY0vLFNT6eqiBChOtgjpY6JhWM3N/Ci0TOP/lSGaFBMXK23lm+LuoxpgtILGMuwYEYQwhcF4Oy0zUjfzGsfP8JDYaOFXkTG3R8CQF2cE6jTwRXxPNrv+D7KozYNlPCejjiWOS92pY9o5Hkr8BlHvg/Zm0fhkvtBOdFjfbiViy2ymP9w3qa7Z6usxRjkWhSOXwjof/ldk25aXqY1ilFOGndeTdg5RlZk3S5V93srb6d7QIy5MNuTK5uz09zeGvnSO5Vugr6yDgpSa+x/TgHx9wLAHy/P5+fP8goUq7kgx43g2ltBIKNi4letxnvlqLdT3wbLpR2OkXDlhYkE3ttShzBWZuqxxwJ2oNAGDIrXy5ypkVsA6UXSDkME64z7G8DM2C4pBzIFy6jz1ADPeo5+JhX8deKZit1gPAQ4tHC6+kt7ZMzp+s3ELSxqODmzYYq1Q2d7b6VRTwQzLCMgIbqZc5HI7ahOXxHGz9qW+4suBMgzvGD1xgi5Z6L1bDSQpwA2dZvC37tkgMSACYKBdAxCHeRL8JJp+cIIcUxgElGC+45JvSzy7N/jwqFNR7/q/SL O3SOmsvi tnhWMPIulhw0XFIK7sZCkLzd/qexHNsa5UIYDD8nj98ExcEO5Xge9q6Gv/LP3bYZrmdwgFh8oaVoTpBcXrhrdlzpj5H8PKFtG1Z/NDxOZSQeZSiAZTBYi/SKJvlSIFef4kEP+TUIKIzBhS3A18NLu7nAYUx5RBoM9NoGRy34NGUOcDvt2NDj2G7vJKMMvABoZIfpMzjFxrQ3eGzxSOYx/JLkGmQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/8/27 11:33, Matthew Wilcox wrote: > On Tue, Aug 27, 2024 at 10:45:17AM +0800, Hongbo Li wrote: >> The helper str_false_true is introduced to reback "false/true" >> string literal. We can simplify this format by str_false_true. > > This seems unnecessarily verbose & complex. How about: > > dprintk("%s: link support=%s\n", __func__, strbool(*res != 0)); This just keeps consistency with other string literal helpers such as "str_up_down", "str_yes_no" defined in include/linux/string_choices.h. > >> - dprintk("%s: link support=%s\n", __func__, *res == 0 ? "false" : "true"); >> + dprintk("%s: link support=%s\n", __func__, str_false_true(*res == 0)); > > (do we have a convention for the antonym of kstrtoX?) No, I haven't found this kind of convention helpers. Thanks, Hongbo >