From: Hongbo Li <lihongbo22@huawei.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: <kees@kernel.org>, <andy@kernel.org>, <akpm@linux-foundation.org>,
<trondmy@kernel.org>, <anna@kernel.org>,
<gregkh@linuxfoundation.org>, <linux-hardening@vger.kernel.org>,
<linux-mm@kvack.org>, <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH -next v3 3/3] nfs make use of str_false_true helper
Date: Tue, 27 Aug 2024 14:15:38 +0800 [thread overview]
Message-ID: <fcc670ec-47fa-4ee3-ab10-b76236711091@huawei.com> (raw)
In-Reply-To: <Zs1JAfGWQOZMfHKT@casper.infradead.org>
On 2024/8/27 11:33, Matthew Wilcox wrote:
> On Tue, Aug 27, 2024 at 10:45:17AM +0800, Hongbo Li wrote:
>> The helper str_false_true is introduced to reback "false/true"
>> string literal. We can simplify this format by str_false_true.
>
> This seems unnecessarily verbose & complex. How about:
>
> dprintk("%s: link support=%s\n", __func__, strbool(*res != 0));
This just keeps consistency with other string literal helpers such as
"str_up_down", "str_yes_no" defined in include/linux/string_choices.h.
>
>> - dprintk("%s: link support=%s\n", __func__, *res == 0 ? "false" : "true");
>> + dprintk("%s: link support=%s\n", __func__, str_false_true(*res == 0));
>
> (do we have a convention for the antonym of kstrtoX?)
No, I haven't found this kind of convention helpers.
Thanks,
Hongbo
>
prev parent reply other threads:[~2024-08-27 6:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-27 2:45 [PATCH -next v3 0/3] Add str_true_false()/str_false_true() helper Hongbo Li
2024-08-27 2:45 ` [PATCH -next v3 1/3] lib/string_choices: " Hongbo Li
2024-08-27 23:42 ` Andrew Morton
2024-08-28 1:48 ` Hongbo Li
2024-08-28 3:22 ` Andrew Morton
2024-08-28 3:49 ` Hongbo Li
2024-08-28 20:25 ` Andrew Morton
2024-08-29 1:12 ` Hongbo Li
2024-09-05 16:51 ` (subset) " Kees Cook
2024-08-28 12:59 ` Andy Shevchenko
2024-08-27 2:45 ` [PATCH -next v3 2/3] mm: make use of str_true_false helper Hongbo Li
2024-08-27 2:45 ` [PATCH -next v3 3/3] nfs make use of str_false_true helper Hongbo Li
2024-08-27 3:33 ` Matthew Wilcox
2024-08-27 6:15 ` Hongbo Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fcc670ec-47fa-4ee3-ab10-b76236711091@huawei.com \
--to=lihongbo22@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=andy@kernel.org \
--cc=anna@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kees@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nfs@vger.kernel.org \
--cc=trondmy@kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox