From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D65D9C54F30 for ; Tue, 27 May 2025 16:33:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 744806B00A7; Tue, 27 May 2025 12:33:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 71BD76B00A8; Tue, 27 May 2025 12:33:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 657EA6B00A9; Tue, 27 May 2025 12:33:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 471376B00A7 for ; Tue, 27 May 2025 12:33:09 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id F18FA5840B for ; Tue, 27 May 2025 16:33:08 +0000 (UTC) X-FDA: 83489232456.12.1AF8443 Received: from dggsgout12.his.huawei.com (dggsgout12.his.huawei.com [45.249.212.56]) by imf09.hostedemail.com (Postfix) with ESMTP id A9430140005 for ; Tue, 27 May 2025 16:33:05 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf09.hostedemail.com: domain of pulehui@huaweicloud.com designates 45.249.212.56 as permitted sender) smtp.mailfrom=pulehui@huaweicloud.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748363587; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4f+GcCQI8IF8YUNyQ6ePzYy0OGajECwpN3U0NqTKGug=; b=72w1XIjkITSIN0qPQaySdoB+72WmeGxrnkL9CwZ9MJ9UaeCOks90WXWJUrg6nTHqn8UeGp E1EEHSAZciRnRlEQByGXSSrJ9OPZ6dTeV7EUKlCNLVORxNYvNxdB343ndWw3bdwGsNSv6R AfubYURGA42QWFGoKrITCVPgM3SSyx0= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf09.hostedemail.com: domain of pulehui@huaweicloud.com designates 45.249.212.56 as permitted sender) smtp.mailfrom=pulehui@huaweicloud.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748363587; a=rsa-sha256; cv=none; b=v67fUh0nna1qb1nP8qowmAZoqCY8h+op2hyT+PaK13R6jHVSwDsRas9xKFJEDSPydX17Uc 9whnf8zOspALWbEUVKCPidNJgMfG2uAV3oMjxxKSYKyPOdpRfyzYpq6QNHMH641w6L7syh gOun+nkBBzAlDf9BE2KMgbKbSlXLOS0= Received: from mail.maildlp.com (unknown [172.19.163.235]) by dggsgout12.his.huawei.com (SkyGuard) with ESMTP id 4b6J802Fy9z4f3jd9 for ; Wed, 28 May 2025 00:32:32 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.252]) by mail.maildlp.com (Postfix) with ESMTP id 922BD1A0AD5 for ; Wed, 28 May 2025 00:32:57 +0800 (CST) Received: from [10.67.109.184] (unknown [10.67.109.184]) by APP3 (Coremail) with SMTP id _Ch0CgDHZcA56TVollDvNQ--.39387S2; Wed, 28 May 2025 00:32:57 +0800 (CST) Message-ID: Date: Wed, 28 May 2025 00:32:57 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v2 1/2] mm/mremap: Fix uprobe anon page be overwritten when expanding vma during mremap Content-Language: en-US To: Oleg Nesterov Cc: mhiramat@kernel.org, peterz@infradead.org, akpm@linux-foundation.org, Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, vbabka@suse.cz, jannh@google.com, pfalcato@suse.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org, pulehui@huawei.com References: <20250527132351.2050820-1-pulehui@huaweicloud.com> <20250527132351.2050820-2-pulehui@huaweicloud.com> <20250527142314.GA8333@redhat.com> From: Pu Lehui In-Reply-To: <20250527142314.GA8333@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CM-TRANSID:_Ch0CgDHZcA56TVollDvNQ--.39387S2 X-Coremail-Antispam: 1UD129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7v73 VFW2AGmfu7bjvjm3AaLaJ3UjIYCTnIWjp_UUUYT7kC6x804xWl14x267AKxVW8JVW5JwAF c2x0x2IEx4CE42xK8VAvwI8IcIk0rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII 0Yj41l84x0c7CEw4AK67xGY2AK021l84ACjcxK6xIIjxv20xvE14v26F1j6w1UM28EF7xv wVC0I7IYx2IY6xkF7I0E14v26r4UJVWxJr1l84ACjcxK6I8E87Iv67AKxVW8Jr0_Cr1UM2 8EF7xvwVC2z280aVCY1x0267AKxVW8Jr0_Cr1UM2AIxVAIcxkEcVAq07x20xvEncxIr21l 5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r106r15McIj6I8E87Iv67 AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41lFIxGxcIEc7CjxVA2 Y2ka0xkIwI1l42xK82IYc2Ij64vIr41l4c8EcI0Ec7CjxVAaw2AFwI0_Jw0_GFyl4I8I3I 0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWU GVWUWwC2zVAF1VAY17CE14v26r1q6r43MIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI 0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r4j6F4UMIIF0xvE42xK8VAvwI8IcIk0 rVWUJVWUCwCI42IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r4j6r 4UJbIYCTnIWIevJa73UjIFyTuYvjxUOyCJDUUUU X-CM-SenderInfo: psxovxtxl6x35dzhxuhorxvhhfrp/ X-Rspam-User: X-Rspamd-Queue-Id: A9430140005 X-Rspamd-Server: rspam09 X-Stat-Signature: 43rqyxf5zbk7rnu8sdnqsw87h9mni7xd X-HE-Tag: 1748363585-898822 X-HE-Meta: U2FsdGVkX1/fgQdq1xiO36IIDHc7Gg+Nb2YbKYFUTdHDS94kTpphzhXPaq+S5x3V+JD5gkWroo0VunQTyehECD8Aw43QIDD32o0kH7JXxbaJoieKwTxVFPiuDOsWtBZadcTZsVRqtLqsv19QtZzlT/u8M7tqWwuWEKLgkBj8cLseW2XSeOtiUb/omvCFmrPy6QfY8Xit6wIV/C0hUMP+5Csu3WmzUvWtCv5U4TH1dUvJanUdGjlY+2772GAs515l9RznIiM6brshMbZxKmdSlrhBM0VrQxzk3tPfAluRmD8tH5WteqOovOuekGz5aJcsAmhFBHvIEevsChzfdIY0E0/C3Xz2TX6DsChjnQG4wZrBL8vFhM2i1/9SRFv0Sdxlt3PSaWzgXsVa3T0sPWK/UstGztXB4nAyT4ezDxWgjAqI+o674KOojk0fwITi4P57pgnVA6BhJk0+NfBGieu0sZgBgQtmOGdITUpUZU1oxMeNtKofNJrtUbPn3Fe7tu7tmmkMBVabbWfZSaUwu6yboFwfNvtnGQs4BpJ4EDoEDuywmz3vNHl76cTWWysdkjhbY7v9h8NuT3Q87Wo9yEkWt9b+arnoMS1Mtcq+1tdQBpZbYh7tBu1BCi9IUuX4SqgELO+fTjCXCFvtFE8iYW+Vamgzf5AxROmOkOp7NTOCtFkrTgW+kh7wATitnZA04R95gR3q6W4UerBfq5oclOxV/cJIV3xvEJBBFczFOBVO5sARhgwnkl0lqNWYyaDUPKZ97TuesxOpHlYU7YqXvYY9PhxP5V1vh0pCkJ+fOKjnua8sunX+m/uXThRmFjuLiXlLTRVqmlys4f6OSKw2ZBiT+aE1wqNjrAQ28OPhZdAOyqqhv860m62TG5uvjyikmXGrivbIC7cv4WuYSzKQPZOBhvinN0k3/9/4m3CiDRraqWmU/dTK7ivHNrcYi+11kQm94cm4E1GVlpVOwv3d9hQ J5jMvFu7 qUhVG2Y6BGyYEDt7Rua+mvbh+tJmEKO2HjMQcPSCShi/TB7Zw5y17sTdt2q7N1SdGiFaceMhi3dyRN0WGIji2iLcFLLyRcL5D4Qvcpgt/XrDi6Zhvxc3X33PQa3PyoT2i18/ZZiUapoDRMbLEWIlBgaAXc0fA9aqS6UhS X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/5/27 22:23, Oleg Nesterov wrote: > Well, I leave this to you / Lorenzo / David, but... > > On 05/27, Pu Lehui wrote: >> >> Fixes: 78a320542e6c ("uprobes: Change valid_vma() to demand VM_MAYEXEC rather than VM_EXEC") > > I don't think that commit could cause this problem. Hi Oleg, Me too! I was test that before and after commit 78a320542e6c, so call it the `directly related commit`. In fact, I think the issue was introduced in the original commit 2b1444983508 ("uprobes, mm, x86: Add the ability to install and remove uprobes breakpoints") # v3.5-rc1. > > Oleg.