From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1BA3C433F5 for ; Thu, 21 Oct 2021 06:19:05 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3209A61212 for ; Thu, 21 Oct 2021 06:19:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3209A61212 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=perches.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 9D93A940007; Thu, 21 Oct 2021 02:19:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 989936B0072; Thu, 21 Oct 2021 02:19:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8C6E2940007; Thu, 21 Oct 2021 02:19:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0111.hostedemail.com [216.40.44.111]) by kanga.kvack.org (Postfix) with ESMTP id 7FBE06B0071 for ; Thu, 21 Oct 2021 02:19:04 -0400 (EDT) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 3C434230E0 for ; Thu, 21 Oct 2021 06:19:04 +0000 (UTC) X-FDA: 78719441808.15.9AD0FEF Received: from smtprelay.hostedemail.com (smtprelay0174.hostedemail.com [216.40.44.174]) by imf05.hostedemail.com (Postfix) with ESMTP id E73795088894 for ; Thu, 21 Oct 2021 06:18:57 +0000 (UTC) Received: from omf14.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay04.hostedemail.com (Postfix) with ESMTP id 85EFE180A7FD9; Thu, 21 Oct 2021 06:19:03 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf14.hostedemail.com (Postfix) with ESMTPA id E44AE268E38; Thu, 21 Oct 2021 06:19:01 +0000 (UTC) Message-ID: Subject: Re: [v5 PATCH 3/6] mm: filemap: coding style cleanup for filemap_map_pmd() From: Joe Perches To: Yang Shi , naoya.horiguchi@nec.com, hughd@google.com, kirill.shutemov@linux.intel.com, willy@infradead.org, peterx@redhat.com, osalvador@suse.de, akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Date: Wed, 20 Oct 2021 23:19:00 -0700 In-Reply-To: <20211020210755.23964-4-shy828301@gmail.com> References: <20211020210755.23964-1-shy828301@gmail.com> <20211020210755.23964-4-shy828301@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.40.4-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX19JoPEesXP36Tf6MauoxaqjNy1Pzi0FNk8= X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: E73795088894 X-HE-Tag-Orig: 1634797141-827303 X-Stat-Signature: s5zpj5owmadf4in3sbysmqrkjay9hkuu Authentication-Results: imf05.hostedemail.com; dkim=none; dmarc=none; spf=none (imf05.hostedemail.com: domain of joe@perches.com has no SPF policy when checking 216.40.44.174) smtp.mailfrom=joe@perches.com X-HE-Tag: 1634797137-292278 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 2021-10-20 at 14:07 -0700, Yang Shi wrote: > A minor cleanup to the indent. [] > diff --git a/mm/filemap.c b/mm/filemap.c [] > @@ -3195,12 +3195,12 @@ static bool filemap_map_pmd(struct vm_fault *vmf, struct page *page) > } > > if (pmd_none(*vmf->pmd) && PageTransHuge(page)) { > - vm_fault_t ret = do_set_pmd(vmf, page); > - if (!ret) { > - /* The page is mapped successfully, reference consumed. */ > - unlock_page(page); > - return true; > - } > + vm_fault_t ret = do_set_pmd(vmf, page); > + if (!ret) { > + /* The page is mapped successfully, reference consumed. */ > + unlock_page(page); > + return true; > + } It might be more preferred to add a blank line after the automatic when touching this block.