From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 12D8BCA1016 for ; Mon, 8 Sep 2025 19:02:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 74D5D8E000D; Mon, 8 Sep 2025 15:02:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 725978E0001; Mon, 8 Sep 2025 15:02:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 614348E000D; Mon, 8 Sep 2025 15:02:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 512598E0001 for ; Mon, 8 Sep 2025 15:02:13 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 296321A026D for ; Mon, 8 Sep 2025 19:02:13 +0000 (UTC) X-FDA: 83867003346.08.F5EF8A6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf14.hostedemail.com (Postfix) with ESMTP id C03B010000C for ; Mon, 8 Sep 2025 19:02:10 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JbQtQnop; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1757358130; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Gmtib10VgDsxeCsuKSbiFn6OKNGc3wSlE9js8H+6KJs=; b=pw4lysYrspJWRBIJh1dcQU9wm2WoYiQ4tHccb+E7TAdCu8cjgxLtMDsiJbbtpLwGJPNpkS 1BqVpppfLxTfV4ZZJRHnSIfdsuFeOqjerO/QVR071hg7b81RRZ9M4rlSV/fSW5j58zILbJ YZcOxZzRglxH6m55kv8XpvYo7/WS+tE= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JbQtQnop; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1757358130; a=rsa-sha256; cv=none; b=yYkvCa1PjuXZDSRQHZnUqbdBoN7Q1tLowMB8+5+I1ZzNyuojyplHs6MT6uq42xNSk0Idyv WdTmO4PkZ375qENiJUt91ttznRJUzF6wMdzu4bm4f4pc7TPdzDZ05rg97m3+wdadBXjssd 4et6N29u330OYxuBvndYDGvMfXntOSI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1757358130; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Gmtib10VgDsxeCsuKSbiFn6OKNGc3wSlE9js8H+6KJs=; b=JbQtQnopCKWElJwUHo4op/fQz3kelrxCiQ03ZN9c+msjDbOjE7gKT1nyHDqDyaJJFbCmPF 3NVdyagGSib2Zi+NnsBwJAG4CmXEFVP9jVmmj5iMeyN3rq4Pvz6on7+wq2C9L/fPhZ+gt5 nnX2SzLtWXxHv1JxspyJTr7JrFELTxM= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-207-nzBeONVeM6Cl66JOwkOjqA-1; Mon, 08 Sep 2025 15:02:08 -0400 X-MC-Unique: nzBeONVeM6Cl66JOwkOjqA-1 X-Mimecast-MFC-AGG-ID: nzBeONVeM6Cl66JOwkOjqA_1757358128 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-45dd66e1971so32131465e9.2 for ; Mon, 08 Sep 2025 12:02:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757358127; x=1757962927; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Gmtib10VgDsxeCsuKSbiFn6OKNGc3wSlE9js8H+6KJs=; b=vm4YuNuIZz7Ys3PUdL6+2R5WPoeFty5chb+I3vtqvktB/LpUo5/orGtwPqIsVjmXIB ef7b+aL+NHKu+19/7pU/NvT8HH32D61pmLW7ROwP6buJI2RmmgX9rwQzsE9K9sfqj1+w ipj4J5ZaEBXx04sdlG5lDBAR0BzQTryG4HOxBSRJC3CsKjSQsis2nyAvI34Zo/Dc9XtM uiQKDf3J5civtxLh64hKvkIu9Rk5MpfOK0P/ClJimxS7AmXSEFOaxrWcMzd7WwD9Nx0l BsvNJbBJUoWsQgH3OX/emyEI+jQqEFChCTRe6Jxc8+yDIqJoUiWjsMM909/qV6I1Dcbq 0QXQ== X-Forwarded-Encrypted: i=1; AJvYcCXS5nZB+Zt+9sC9ulI/Kc7XLqpG5z4HLj8TekrepLYtgUGMoHvtWaGJSkix833KG32+fLVl3GMuUg==@kvack.org X-Gm-Message-State: AOJu0Yz7gNjo9523uGliwD0VVU0hVDLMBas2w/KB/w76n1+WowtiMRTX dlfQwXrDp7YSdCjz0rcLPTvQR/4uypDjwwT1A1TNDCl39qUR2FtOEsDTJmNL8iX4JzxjBqbjvx6 xvK1LCjiiCQblQPxm95EkLaJ+/lEhhpJFfjprZhmQjL8viupVB+zO X-Gm-Gg: ASbGncsHVsBaABsXFo9gVgBQOLmOcLxPQOPrlOq/eQXgFts07Rsl4BYfAQgbNsZbAsA qvYfKXbp8zQQCRs3Rdbb67Qv3ZIKUVuV+a5FnnM+RHnVOjpzP3gxWv7+t39/CgoFwq5NXgGqj89 Cj1jKVynSC7qYlXILY90/DirQjZHBkh7S2IftZJEKZsFcIkRlF+szR8T9qRCLzOjqCMCneAuvu8 zhGnqremT+3+TFoEBmFXbuRguKIpb1uOnqcKjKVqNuXz8tQFjjIkzCv+KIYe6x2eBmEsY0AdOdI Sraije6FKYBmb905MeYggFEALMVljAY2amcJ6D/4Kr8eSL2i1CiMjrB967MWDcA3oUYyWpj4bpQ RaAjtI33tyWF1hnpY0Jz9IjBHKXi6qD0ga6qX1wEyS/ZtQWJFD8A8rUJdrzzshZhv X-Received: by 2002:a05:600c:4694:b0:45d:d908:dc02 with SMTP id 5b1f17b1804b1-45ddded9c21mr75728485e9.31.1757358127350; Mon, 08 Sep 2025 12:02:07 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEs8y1x+Exxj0+uBNj9bFOyP7D7vv4bDun2+4IppnvfFcz7vwjW0GdrRhrh+4rIlBPR8FzbqQ== X-Received: by 2002:a05:600c:4694:b0:45d:d908:dc02 with SMTP id 5b1f17b1804b1-45ddded9c21mr75728125e9.31.1757358126762; Mon, 08 Sep 2025 12:02:06 -0700 (PDT) Received: from ?IPV6:2003:d8:2f25:700:d846:15f3:6ca0:8029? (p200300d82f250700d84615f36ca08029.dip0.t-ipconnect.de. [2003:d8:2f25:700:d846:15f3:6ca0:8029]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45b7e898b99sm449738625e9.19.2025.09.08.12.02.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Sep 2025 12:02:06 -0700 (PDT) Message-ID: Date: Mon, 8 Sep 2025 21:02:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 06/22] mm/mshare: Add a vma flag to indicate an mshare region To: Anthony Yznaga , linux-mm@kvack.org Cc: akpm@linux-foundation.org, andreyknvl@gmail.com, arnd@arndb.de, bp@alien8.de, brauner@kernel.org, bsegall@google.com, corbet@lwn.net, dave.hansen@linux.intel.com, dietmar.eggemann@arm.com, ebiederm@xmission.com, hpa@zytor.com, jakub.wartak@mailbox.org, jannh@google.com, juri.lelli@redhat.com, khalid@kernel.org, liam.howlett@oracle.com, linyongting@bytedance.com, lorenzo.stoakes@oracle.com, luto@kernel.org, markhemm@googlemail.com, maz@kernel.org, mhiramat@kernel.org, mgorman@suse.de, mhocko@suse.com, mingo@redhat.com, muchun.song@linux.dev, neilb@suse.de, osalvador@suse.de, pcc@google.com, peterz@infradead.org, pfalcato@suse.de, rostedt@goodmis.org, rppt@kernel.org, shakeel.butt@linux.dev, surenb@google.com, tglx@linutronix.de, vasily.averin@linux.dev, vbabka@suse.cz, vincent.guittot@linaro.org, viro@zeniv.linux.org.uk, vschneid@redhat.com, willy@infradead.org, x86@kernel.org, xhao@linux.alibaba.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org References: <20250820010415.699353-1-anthony.yznaga@oracle.com> <20250820010415.699353-7-anthony.yznaga@oracle.com> <5c43116f-fef9-426d-8c90-1a3a129f3d20@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZoEEwEIAEQCGwMCF4ACGQEFCwkIBwICIgIG FQoJCAsCBBYCAwECHgcWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaJzangUJJlgIpAAKCRBN 3hD3AP+DWhAxD/9wcL0A+2rtaAmutaKTfxhTP0b4AAp1r/eLxjrbfbCCmh4pqzBhmSX/4z11 opn2KqcOsueRF1t2ENLOWzQu3Roiny2HOU7DajqB4dm1BVMaXQya5ae2ghzlJN9SIoopTWlR 0Af3hPj5E2PYvQhlcqeoehKlBo9rROJv/rjmr2x0yOM8qeTroH/ZzNlCtJ56AsE6Tvl+r7cW 3x7/Jq5WvWeudKrhFh7/yQ7eRvHCjd9bBrZTlgAfiHmX9AnCCPRPpNGNedV9Yty2Jnxhfmbv Pw37LA/jef8zlCDyUh2KCU1xVEOWqg15o1RtTyGV1nXV2O/mfuQJud5vIgzBvHhypc3p6VZJ lEf8YmT+Ol5P7SfCs5/uGdWUYQEMqOlg6w9R4Pe8d+mk8KGvfE9/zTwGg0nRgKqlQXrWRERv cuEwQbridlPAoQHrFWtwpgYMXx2TaZ3sihcIPo9uU5eBs0rf4mOERY75SK+Ekayv2ucTfjxr Kf014py2aoRJHuvy85ee/zIyLmve5hngZTTe3Wg3TInT9UTFzTPhItam6dZ1xqdTGHZYGU0O otRHcwLGt470grdiob6PfVTXoHlBvkWRadMhSuG4RORCDpq89vu5QralFNIf3EysNohoFy2A LYg2/D53xbU/aa4DDzBb5b1Rkg/udO1gZocVQWrDh6I2K3+cCs7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: suhV1XSnx6yZdlPxtTq8JQMf1aCmYwWDbKkBcPKsri4_1757358128 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: C03B010000C X-Stat-Signature: 7djh4dnrd9ehyiyk8acntz15snh5h4d8 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1757358130-964341 X-HE-Meta: U2FsdGVkX1+hB6Dqqy+gpXWOhUFo+w+FL9G6eHbQZySIX20pwMLgLqr70cVreCu7N+FkAUwN1skFj8qIHPoIt0VEuXy25bMViHB8lv0n7d5qflyqLnuz874akiTUu0SbYgX+k1hKMIU0FWXN5jR0dwT116D2TMfyuzL3Cjw/vgnkf+c6p8OA5rzcLuRjfr0AWXzABXBiTN3gV4EzXhEDdret4VPXDMq9/tvRDa7oWjIAYx7W5VPp+HiUGaleZMw4LiDNZyjnihGHWDMTc2+ruwh14M1zJy2ao89PMu5YA6aXu4AOXSvTL1pLePrZW+77uG1eeT0E+zDIhRXgIFgp2VudlERf6NLEu5tMcNm0SmVdnswFEOxLmGpcLjRZgTCECQVijH7+WCjES+6yWZx/i/QnIyfrOHjHFvJSmVphIbFvLVNoH6OiLMoq7ES3RAtLxmtS2aJN53QyJCFd6VLhIvgRh/P5QhiHgE/7pJtTEH2WgU/lVjtCtJvqfvM25GwhjrsWbQeVmBmFG69mnQpMH/gPAC+ep3KWHRcc7kDPeAMKgkXGj+6rT3CcGPg52mc1sXxrDweCefiKHZeRu7VL8XWMygAtzlkHUoOLGak4e2Ira+jOz7deKfqkbKhHFfD7i9GNxPzKs0WqP3TWT+q3o6qZUPjgepS+WzQKTpTgVGG3bX2J5gX4EjLk6WQ/6LyxHWs8kaQYxssjbLUPz2wMJ9R0f7RbFBmuOcHRiWQjHRXSQ0mjHS7Lbf7mA4YRzOfvHU+JGGoeuCzpO4+6i1PAHYcN8Gh51fdVuvsC3tWDLpN+1w/5n5RtXB42yGQ86BzCWBkHCamuGPs11HpDZ8/PwnorC0CgwdEXlm4RonIgKKRU35GKbIJBi9u4PXRI4tN0kzEHClGez23gNsp2seJlHS93FunshsQMqkOWVJ6bwIJHKGTmp1TOKgVmZrAplzGOxRAybo8TWS+kg0x2d+W PcpA7wzu Jyt56JPAYSryhL9+p8qkb/khcQ6fC8FCVGtKLee7dw8ORbDIqiF+hvoDvD9WHw2KGvMd40aal4KOY6sCUFwMvA33h+HDxZVAm5+5hnjrc08HCmDaM5Xx1HTLcTh9dT2VGy+hy9UGp10CBWyFwyh+PiFazPV0pZyS9u7Q0QHgD83XQp1lpOYHomhqjR8yYistiBDXTLwtMnOUeOcgKB6lGcxNA1UzkU8U8qTy/i9Vn5QhbrObU2/1kovJ3doF4wTtwbAFP4m4sgz7oZJXn/dL3GODbiSbVtJvLhxjbakR+VCc96VacNbcHjECGZBomD62BO2mJvv9sortvWeMH4/+BazoDGYMENXBdyrvyQSDhqhcrOTEO7JkFTECkff0ubeXdYboQn7VP/u2mzrwGxR4NvgponJrGuswlBH9n4A/9eygw/56BxBcMq47vA5ZZmRaGpy1QNgoYcbuH7bjIr/QJqWoluZ1fwnf+79mAYHdHPSE2rAtREQ1UPMOhALK9kxflXyzgHKTOQ0RAkiBoaTwkrnQWvTPOPOHP0kuR2VCRLmVpfmIJF5TDy3OC4Hdo4HIA2HxAAeg575zS/0dg1W9iv7AWXo5ABykAhdEy3gPGYI9qh/4JU+gIu4m5gQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 08.09.25 20:56, Anthony Yznaga wrote: > > > On 9/8/25 11:45 AM, David Hildenbrand wrote: >> On 20.08.25 03:03, Anthony Yznaga wrote: >>> From: Khalid Aziz >>> >>> An mshare region contains zero or more actual vmas that map objects >>> in the mshare range with shared page tables. >>> >>> Signed-off-by: Khalid Aziz >>> Signed-off-by: Matthew Wilcox (Oracle) >>> Signed-off-by: Anthony Yznaga >>> --- >> >> Why can't we query the mapping instead? >> > > > The bit check is nice and zippy since vma_is_mshare() is called for > every fault, but it's not required. The check could be made to be: > > return vma->vm_ops == &msharefs_vm_ops; Yes, like we do in secretmem_mapping(), for example. (there, we also have a vma_is_secretmem()). -- Cheers David / dhildenb