From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92261E77197 for ; Tue, 7 Jan 2025 12:31:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 252F16B009B; Tue, 7 Jan 2025 07:31:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2019E6B009C; Tue, 7 Jan 2025 07:31:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 07DE76B009E; Tue, 7 Jan 2025 07:31:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id DA58A6B009B for ; Tue, 7 Jan 2025 07:31:32 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 709551A07F0 for ; Tue, 7 Jan 2025 12:31:32 +0000 (UTC) X-FDA: 82980591624.15.D16E82A Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by imf25.hostedemail.com (Postfix) with ESMTP id 6C9F6A0010 for ; Tue, 7 Jan 2025 12:31:29 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=MwdGOjPr; spf=pass (imf25.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736253090; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=j2Sg0kNPwV4gGCFeUvrc0oDDUwUGkE4XjlNGrPro8W4=; b=EJEjH+2ySocnSy9lru9mx7MziTftaC3Fj917Y3zI4lyckfRpx0aQmvlxoJrU7I3zpu2os1 wj+HubWdrXvCFJRd6V+lMqTc5rC0G2LGWPwhqaTCSxIjclGEM0cHPeA+ytzzrxNsJM9IgF PpMIXkK4OiPV4fzlWQukQDG2Tz0dn6M= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=MwdGOjPr; spf=pass (imf25.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736253090; a=rsa-sha256; cv=none; b=dwh/JER02woHzbahj8sMY+36T3jwGpkV0csBfGjh0kUFGForYQX5cXt6j0IjAflUIeGcev N5TWYCuHZXI2yqwe6bXRKLOXokd1Usul5RbtBMlViqOMu20pMObAOB2PJqHHok6wg0uMSE YbbF1ZoibStV0X6bQM+cuakJhvmRUwY= Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-215770613dbso167964105ad.2 for ; Tue, 07 Jan 2025 04:31:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1736253088; x=1736857888; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=j2Sg0kNPwV4gGCFeUvrc0oDDUwUGkE4XjlNGrPro8W4=; b=MwdGOjPrZN4ZMnrcDupBGa9No/Q/ddIoD132QPreifpdw415viLUVEk5ZtTcwsq6L3 EZnFjEpKZIo+WChuZcVUpFdHvBJLnb4omKso4z2Nz66Y45YE67sRvmpm+J6A0/s/X78f KxEAea/qPdHS46OZqOPf5i1zlQPkjOw3j7Pd77DQ01En3JFL7e5oj3jS/sUASwbtcCF5 I+C2c5CyQcG0pr76zv72ggnuCWlt3210aKwW7u3t1o9YW8pyCxj62ZmfGd1kpMUA2qfN DLpdARdsw6dhAeZrLYn0XWjibGL/W3EK8d742UJFDM3CPX6tmm2+utYV+yJs1k6uRkGg qBjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736253088; x=1736857888; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=j2Sg0kNPwV4gGCFeUvrc0oDDUwUGkE4XjlNGrPro8W4=; b=QwpFgZtJnB1p15T1QbMQ1c/aZHssKSOeAqqaWXnTYS1UIdiTgOuj4bUJmkG2sl5D8U onTBWAUCWPIec8u8taUOGp/gIWDeM2wfFqNODyNcl3YL/6vU9SES/6M5nqZuoGr0FnNg z1Re0GYunuOWTZ8z/Me1KQIrU4fkyPoi7UpqCjYNhbpWAKoIXZKJZm2kmDIYdmRlFAxW mw1sS7o70XgXNgvmytGdSyLPnm+GW71dYZ0s6tIHXinkMhi3FTu5nWYu50jU+XEDr10b Clizd+PIWxDOgLtuS70NdSMUUQZdzEMYCckfF63YjJnWz69qFlmfyt0F5TCCLnOY2hxl sR1g== X-Forwarded-Encrypted: i=1; AJvYcCV5+zycHYSMV9y9Hg3M8iBqk/x2lQgaJ2Cgf4ThPHD8Ry9X9Bbyl1Rj4EZkKN5h0y3p33aak73GLA==@kvack.org X-Gm-Message-State: AOJu0YyCQhStbaTmKAo1l9dhP21WAPanmNcveouUS8puzpbBTll8j+iM OBNMbPvNg9LVNZHI2jftvki0cNRYuPZtXso7g+YL5XX9Gqx5FXCVFQNRk44BELE= X-Gm-Gg: ASbGnctk0/rKY9KM+Xxv5j5H3ztVVs/seQ1s08KegtWokJ15OaIjZ7CqRQtgBFDzVjI F+PHIqBGgAZ4u8XRb/IO9sOfivy568hdq6XqGCj0pAgmJX+5QiKi1TE5HyNndqaTMvR/aY/YRQ5 8LzFrmOl2bn4MNsMmxbtWudyRknpgyUKzwGtwKid7sPbK2HrKGUQHQeK1M1yHNetquLfkRFssbH xaBCPImEpfZNeNYmBH2vmy/gLj5/vZsFuwmuVd86SF1Xsjob+vKjujsbx8g+Xe2NrdMhaULUiAA LNlQ X-Google-Smtp-Source: AGHT+IHdrC/g0o4yqle0rmLjmhkyYNUhmDJ4pfXjCTmOvwgBk4798gzhlJqtML37UPom2J/Tnd9DQg== X-Received: by 2002:a17:902:ce81:b0:216:282d:c692 with SMTP id d9443c01a7336-219e6ec1499mr788151455ad.34.1736253087824; Tue, 07 Jan 2025 04:31:27 -0800 (PST) Received: from [10.4.33.153] ([139.177.225.247]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-219dca006fasm309326755ad.227.2025.01.07.04.31.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Jan 2025 04:31:27 -0800 (PST) Message-ID: Date: Tue, 7 Jan 2025 20:31:10 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 10/15] riscv: pgtable: move pagetable_dtor() to __tlb_remove_table() Content-Language: en-US To: Kevin Brodsky Cc: agordeev@linux.ibm.com, palmer@dabbelt.com, tglx@linutronix.de, david@redhat.com, jannh@google.com, hughd@google.com, yuzhao@google.com, willy@infradead.org, muchun.song@linux.dev, vbabka@kernel.org, lorenzo.stoakes@oracle.com, rientjes@google.com, vishal.moola@gmail.com, arnd@arndb.de, will@kernel.org, aneesh.kumar@kernel.org, npiggin@gmail.com, dave.hansen@linux.intel.com, rppt@kernel.org, ryan.roberts@arm.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org, linux-arch@vger.kernel.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-sh@vger.kernel.org, linux-um@lists.infradead.org, peterz@infradead.org, akpm@linux-foundation.org References: <0e8f0b3835c15e99145e0006ac1020ae45a2b166.1735549103.git.zhengqi.arch@bytedance.com> <1b09335c-f0b6-4ccb-9800-5fb22f7e8083@arm.com> <7e2c26c8-f5df-4833-a93f-3409b00b58fd@arm.com> <31e1a033-00a7-4953-81e7-0caedd0227a9@bytedance.com> <07e0c05f-cb69-4263-885d-6d20d4442152@bytedance.com> <4a0b5edb-6fc7-4df4-93d9-ca834e6a760b@arm.com> From: Qi Zheng In-Reply-To: <4a0b5edb-6fc7-4df4-93d9-ca834e6a760b@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 6C9F6A0010 X-Rspamd-Server: rspam12 X-Stat-Signature: tmba1dn5jhgybqnf39ao1rniuqbxwx1i X-Rspam-User: X-HE-Tag: 1736253089-161446 X-HE-Meta: U2FsdGVkX19BHKpM8V+SNTHtRAaC05VfXnL7+ZJDN91hup6Zf/wS+UVcVA/gk/nFHWcorvj3RwWANSlA8xggm6Ko06HAxbe9w3s4Wv1AF6jVjPXD27Clwg9CTgKcmiWjTee2dJXyT9TowgGAqjeUXeAnEZRpSADVA+v154hnMe++cIUAsyk/yatzsKprZ64oPQYpbKYk+lEG4YYZJaGbJEv5kYcEq+1ZGEvVKxB/Oi3WMr1pBMGmSO8N+gXHDckuFifbXxPnOC8Q4oUBA0qvSraUARIvD8knIHccCXo1w6AO4UmK18XhPEoKGGntkzAJfYgAcQg81EIy/w2xmIXwnNcV5u+dNLTAorBh9TnOaPBpCU0WdnhqDy54Wv5As00y5HTVQLmc0lGXtAEB1dR/AN1b0PD6N90khOE58mWPBidJ0NX3+yTT2LrVQnHt3HklQmfbfh1REwa8zO94oACxsDyh7JCUKLTZmHMkxj40jszm1kSk6OwolfqW1fAlyvOtC7ZJEJc9raN4L24xlv9hPUVKp94FS9W3RRdw3gqI/Wb8+ZVa+4wKoBltSHx7m5tqdM3QvAMyfPKC15I5ZROIhdqAUi6OV4uH1CoQrCyRzutFL7YHUQbXM7PZD+SvJXu4ZqQPR05gGUUyn/24rrtQjsCj1NVLPoMbdpU9YCjuFnm0khnxdK3mi+wxYW99xm6r0ZhNXCOfT55oeKEwcGnQ5osnyUjLxPWcYc8XH685pXvn8QMJRzryBXEGO7OE1aJRSNAJpaN5iRg8Neplz/CDGQnXulxW8Qv0HVJLHJyS+NTGdZlwnMUBcERuTE0jeuSf3lfJZbw/HdrxLkAXKhweBWHrSUfWMeYvSO9tJnfYNJfLVma6FrIgMpPnGPhlaiicVRAqew5H+FixoGt92UaZhFFlMFqZF8Vy31QhaYnDBUpoRNhDBdm2Myu7RIWK5UPKetZqWTs44HcD5NKmHhf ZxgUYGhB vKCIco4XhpWTYfZyrEwOJSfHbhpDo4/AUhLGvbJzWh0Vqv08cBcjUxOxwShh5QjemyNmJzT7MZyklx7srMPV3O3t3VXP1CPkiP4vOW0kdDjYiOLdifIHXbmpKhZBHXPKqJOMA2jMMelc9/RlvD3TRFReK4oFDT2wcwP2sw/1xgOACJZu3XdvLwkWR043lvW2oPPLCAvib1hM4SyxI1SKdoPwhVYllihPrWPcEaR6p8q5XtbVQk5ipDgBi9hMVrohJlYgm6qkodJ6pzrrHy9Plsi4SwnGlpjWsveRBWDGVEblatYUysghF+F1ckoAyq9PQk7p8sxGGmmfarNXoxFAAaxTyzVZKSOkd0dscJAyLvnJou1UmUmoM20bYQHum7rUbEDF48zlumUdv1dCvIBrwdvdTL9650g1qHwz+bFry+F0052xEM75tsIGdKAf4vS9T27Wct10Z9hdhtxtYEcIVvfAs9j/QfMN+I+SQjYkdS8F074IS1vgJEWewjA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/1/7 19:58, Kevin Brodsky wrote: > On 07/01/2025 11:51, Qi Zheng wrote: >> [...] >> >> Author: Qi Zheng >> Date:   Fri Dec 13 17:13:48 2024 +0800 >> >>     mm: pgtable: completely move pagetable_dtor() to generic >> tlb_remove_table() >> >>     For the generic tlb_remove_table(), it is implemented in the >> following two >>     forms: >> >>     1) CONFIG_MMU_GATHER_TABLE_FREE is enabled >> >>     tlb_remove_table >>     --> generic __tlb_remove_table() >> >>     2) CONFIG_MMU_GATHER_TABLE_FREE is disabled >> >>     tlb_remove_table >>     --> tlb_remove_page >> >>     For case 1), the pagetable_dtor() has already been moved to generic >>     __tlb_remove_table(). >> >>     For case 2), now only arm will call >> tlb_remove_table()/tlb_remove_ptdesc() >>     when CONFIG_MMU_GATHER_TABLE_FREE is disabled. Let's move >> pagetable_dtor() >>     completely to generic tlb_remove_table(), so that the >> architectures can >>     follow more easily. >> >>     Signed-off-by: Qi Zheng I missed your Suggested-by, will add it in v5. >> >> diff --git a/arch/arm/include/asm/tlb.h b/arch/arm/include/asm/tlb.h >> index b8eebdb598631..ea4fbe7b17f6f 100644 >> --- a/arch/arm/include/asm/tlb.h >> +++ b/arch/arm/include/asm/tlb.h >> @@ -34,10 +34,6 @@ __pte_free_tlb(struct mmu_gather *tlb, pgtable_t >> pte, unsigned long addr) >>  { >>         struct ptdesc *ptdesc = page_ptdesc(pte); >> >> -#ifndef CONFIG_MMU_GATHER_TABLE_FREE >> -       pagetable_dtor(ptdesc); >> -#endif > > I guess this hunk will disappear since this call isn't present to start > with. Yes, I plan to add this in the patch #8, and remove it in this patch. > >> - >>  #ifndef CONFIG_ARM_LPAE >>         /* >>          * With the classic ARM MMU, a pte page has two corresponding pmd >> diff --git a/include/asm-generic/tlb.h b/include/asm-generic/tlb.h >> index 69de47c7ef3c5..53ae7748f555b 100644 >> --- a/include/asm-generic/tlb.h >> +++ b/include/asm-generic/tlb.h >> @@ -220,14 +220,20 @@ static inline void __tlb_remove_table(void *table) >> >>  extern void tlb_remove_table(struct mmu_gather *tlb, void *table); >> >> -#else /* !CONFIG_MMU_GATHER_HAVE_TABLE_FREE */ >> +#else /* !CONFIG_MMU_GATHER_TABLE_FREE */ > > Good catch! > >> >> +static inline void tlb_remove_page(struct mmu_gather *tlb, struct >> page *page); > > Nit: might be better to move the declaration up, e.g. above #ifdef > CONFIG_MMU_GATHER_TABLE_FREE. Now only the tlb_remove_table() below calls it, maybe it's better to keep the impact to minimum? > >>  /* >>   * Without MMU_GATHER_TABLE_FREE the architecture is assumed to have >> page based >>   * page directories and we can use the normal page batching to free >> them. >>   */ >> -#define tlb_remove_table(tlb, page) tlb_remove_page((tlb), (page)) >> +static inline void tlb_remove_table(struct mmu_gather *tlb, void *table) >> +{ >> +       struct page *page = (struct page *)table; >> >> +       pagetable_dtor(page_ptdesc(page)); >> +       tlb_remove_page(tlb, page); >> +} >>  #endif /* CONFIG_MMU_GATHER_TABLE_FREE */ >> >>  #ifdef CONFIG_MMU_GATHER_RCU_TABLE_FREE > > Looks good to me otherwise. I will add your Reviewed-by to all patches (except yours) in v5, can I also add it to this new added patch? (if we agree with the discussion above) ;) Thanks! > > - Kevin