From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C0F0C0015E for ; Fri, 21 Jul 2023 02:31:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9FFDD280181; Thu, 20 Jul 2023 22:31:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 988B628004C; Thu, 20 Jul 2023 22:31:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 829FC280181; Thu, 20 Jul 2023 22:31:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 6D36528004C for ; Thu, 20 Jul 2023 22:31:07 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 3C77C801DB for ; Fri, 21 Jul 2023 02:31:07 +0000 (UTC) X-FDA: 81034041774.20.9E2C542 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by imf18.hostedemail.com (Postfix) with ESMTP id 81C0E1C001A for ; Fri, 21 Jul 2023 02:31:03 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf18.hostedemail.com: domain of zhangpeng362@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=zhangpeng362@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689906665; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WCSbP2GXvxbQkErL+7oAeGSQBBFrzwCw9scA45FJNho=; b=jDg8sHoDmA7GaNBOcq7DAunNliGRrl+qZLuYzn1jg4/kwr8OajEvg8RGd2hhbyhzOQTbAI ct6WbOeptYgggfEVG2cTybLaCvWqO4ryjlnd/dnPZ++pPGhTv1xIG0GI+lnxJaJZfVpaum b5n6zVvOxBOVmwgyREMt4eeGwCDK9DM= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf18.hostedemail.com: domain of zhangpeng362@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=zhangpeng362@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689906665; a=rsa-sha256; cv=none; b=haaBx3Q6JPk4hxi6sGS+VAzjKYPg4f7poYN8ofAcJPdv9BWeWDJa9g0Q74klM+NUIu4dUN lUv78FKMidLGFKBqooihBHjYlWmDRUc8xQzwWfrEsNy3LVHEre+DTtb0rDb3b1F+2LrqlE g4lkstoHVIQXSSaU2ZCWxR6CHEdnjjY= Received: from kwepemm600020.china.huawei.com (unknown [172.30.72.56]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4R6YS44vNHz18LQp; Fri, 21 Jul 2023 10:30:12 +0800 (CST) Received: from [10.174.179.160] (10.174.179.160) by kwepemm600020.china.huawei.com (7.193.23.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Fri, 21 Jul 2023 10:30:57 +0800 Message-ID: Date: Fri, 21 Jul 2023 10:30:57 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v3 09/10] mm/page_io: convert count_swpout_vm_event() to take in a folio Content-Language: en-US To: kernel test robot , , , CC: , , , , , , References: <20230720130147.4071649-10-zhangpeng362@huawei.com> <202307210951.NCdscoSS-lkp@intel.com> From: "zhangpeng (AS)" In-Reply-To: <202307210951.NCdscoSS-lkp@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.179.160] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemm600020.china.huawei.com (7.193.23.147) X-CFilter-Loop: Reflected X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 81C0E1C001A X-Stat-Signature: rwngiq4q3xjebm5wryr5aoregzbdwf9y X-HE-Tag: 1689906663-867841 X-HE-Meta: U2FsdGVkX19TaQXu2nl7gpVFoV21u4uvH5AsgFiXI2STM0Qfk59gxOFrqPIADgMsZhHWdlQ3KGF/YvRGqeacSlwPujrk/O68BHkiPleBss+bCTH0/DndXigY4P/lIxrxpVeWBmALjwbFj5FlGZFJ3JgMJ7jSAwLWaUjcOa09uIf2T0184Lpq+HiPSgEYIE6AaLlO48+wgJVK5MdD0gHphDEyUQ5ySwYJ/McrPcW0m2dxwXdCgYsvCiOBfOztSyNthXbnY9FIKWjat2ifC5aukx7Fh+VziUbJGKTd/UvlcKSjUaG/42JaI30JPMTo0yI+q1rqaVO5938bQBGk0ufmUv/9kIiq1P5y4QLy3nh2dDJnV0rFNA4WhyEFC9SudtWTjOmpZZp/CgzBTwYV4D82QMMLVM0rKJkP6aExsd5rEDab5GBgLyNaHlbq9An5u5BIHFsvuTY4Y6bI0OJdlvyqgB3p3+tSemj7WA+2Od9BkDDim4LEPCf2LUofbBSUlY0eJUHhTbROijn91MMMbxXVB86YQuaulAuzbt3YuecAvYn1xr060xbLQGfoDTmIlC9DGm5AhYH2O9Va3fRdeggwn4+AgxNonDDNTKKkl4WTxuiKYpkzjx1a20lqxjeTlkUQtwAb7g662wHLkET1D7zp1U1C5gKFw3CiVugoI5EDieTTRJ3bSfqVarFfbOWFMDMJS9FQyD2felNrfa+Kuq2+D110CtxYLErXjZonHIx8DC6/uRqiYtXndkrK2uyKQdz9YbQGP2eg7qPdKfCXUTfA0Vk8OetbvjX/zU5HmuCxUn5aDOHcRpbmzMQrcASKfJDJ4pPZvLgN22zDYo1OvzP6VwxR0JBBzBYAIDhX7CRpEpFW0aM2ih7tDTyQwW9M2RHXQCjay8ygP+2687yerQwJ1p4hJeu2HcMVKbpqZtcjCq/t8L5sPqMZVUDHIvdMN9Myr1vQziLwiQvCWzlfpWX ynia8fdd z+PNxIEZN5zZafdgidJw7uJQv8D9Kl6aBa3lRea31oZZuQqaWpVIMl7BPhrGnZgyCi5sCfPRlMYyVOfcfkr6+i0TVhKka+cHhS330MF8syx2h2SgFg1lGzlbkdsmPKfFx6F8rTdFM1/R6czsFQRqFpA6kkcuzIbzNNsBMdwyilukMlx9QXgTGzM9gSt00s2dBetTFesJ8M9tRH6LyuOv1wwR3VceqhDYeU9qv4G6QiMMjlBuyFCu0a+N1CC1N42Jt8S0RBhFnUWiyg3LAL4d0ZHdcHcVWm+ASRe3rfyMGYG16nFSiLMJCbX4yFYMoNzR+2uFVRY6J3EeG+HgmYN4avl4rf40ati6vpTRjMNWRjBUSuPJUGf9hoal8/3ZPNy5YZuKW3YPHLcIS0Hu/cZ/BVEqh3aqeqaSgBU/0iiYg/I3mJJM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/7/21 9:31, kernel test robot wrote: > Hi Peng, > > kernel test robot noticed the following build errors: > > [auto build test ERROR on akpm-mm/mm-everything] > [also build test ERROR on axboe-block/for-next linus/master v6.5-rc2 next-20230720] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > url: https://github.com/intel-lab-lkp/linux/commits/Peng-Zhang/mm-page_io-remove-unneeded-ClearPageUptodate/20230720-210515 > base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything > patch link: https://lore.kernel.org/r/20230720130147.4071649-10-zhangpeng362%40huawei.com > patch subject: [PATCH v3 09/10] mm/page_io: convert count_swpout_vm_event() to take in a folio > config: um-randconfig-r003-20230720 (https://download.01.org/0day-ci/archive/20230721/202307210951.NCdscoSS-lkp@intel.com/config) > compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project.git 4a5ac14ee968ff0ad5d2cc1ffa0299048db4c88a) > reproduce: (https://download.01.org/0day-ci/archive/20230721/202307210951.NCdscoSS-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202307210951.NCdscoSS-lkp@intel.com/ > > All errors (new ones prefixed by >>): > > In file included from mm/page_io.c:15: > In file included from include/linux/kernel_stat.h:9: > In file included from include/linux/interrupt.h:11: > In file included from include/linux/hardirq.h:11: > In file included from arch/um/include/asm/hardirq.h:5: > In file included from include/asm-generic/hardirq.h:17: > In file included from include/linux/irq.h:20: > In file included from include/linux/io.h:13: > In file included from arch/um/include/asm/io.h:24: > include/asm-generic/io.h:547:31: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] > 547 | val = __raw_readb(PCI_IOBASE + addr); > | ~~~~~~~~~~ ^ > include/asm-generic/io.h:560:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] > 560 | val = __le16_to_cpu((__le16 __force)__raw_readw(PCI_IOBASE + addr)); > | ~~~~~~~~~~ ^ > include/uapi/linux/byteorder/little_endian.h:37:51: note: expanded from macro '__le16_to_cpu' > 37 | #define __le16_to_cpu(x) ((__force __u16)(__le16)(x)) > | ^ > In file included from mm/page_io.c:15: > In file included from include/linux/kernel_stat.h:9: > In file included from include/linux/interrupt.h:11: > In file included from include/linux/hardirq.h:11: > In file included from arch/um/include/asm/hardirq.h:5: > In file included from include/asm-generic/hardirq.h:17: > In file included from include/linux/irq.h:20: > In file included from include/linux/io.h:13: > In file included from arch/um/include/asm/io.h:24: > include/asm-generic/io.h:573:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] > 573 | val = __le32_to_cpu((__le32 __force)__raw_readl(PCI_IOBASE + addr)); > | ~~~~~~~~~~ ^ > include/uapi/linux/byteorder/little_endian.h:35:51: note: expanded from macro '__le32_to_cpu' > 35 | #define __le32_to_cpu(x) ((__force __u32)(__le32)(x)) > | ^ > In file included from mm/page_io.c:15: > In file included from include/linux/kernel_stat.h:9: > In file included from include/linux/interrupt.h:11: > In file included from include/linux/hardirq.h:11: > In file included from arch/um/include/asm/hardirq.h:5: > In file included from include/asm-generic/hardirq.h:17: > In file included from include/linux/irq.h:20: > In file included from include/linux/io.h:13: > In file included from arch/um/include/asm/io.h:24: > include/asm-generic/io.h:584:33: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] > 584 | __raw_writeb(value, PCI_IOBASE + addr); > | ~~~~~~~~~~ ^ > include/asm-generic/io.h:594:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] > 594 | __raw_writew((u16 __force)cpu_to_le16(value), PCI_IOBASE + addr); > | ~~~~~~~~~~ ^ > include/asm-generic/io.h:604:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] > 604 | __raw_writel((u32 __force)cpu_to_le32(value), PCI_IOBASE + addr); > | ~~~~~~~~~~ ^ > include/asm-generic/io.h:692:20: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] > 692 | readsb(PCI_IOBASE + addr, buffer, count); > | ~~~~~~~~~~ ^ > include/asm-generic/io.h:700:20: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] > 700 | readsw(PCI_IOBASE + addr, buffer, count); > | ~~~~~~~~~~ ^ > include/asm-generic/io.h:708:20: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] > 708 | readsl(PCI_IOBASE + addr, buffer, count); > | ~~~~~~~~~~ ^ > include/asm-generic/io.h:717:21: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] > 717 | writesb(PCI_IOBASE + addr, buffer, count); > | ~~~~~~~~~~ ^ > include/asm-generic/io.h:726:21: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] > 726 | writesw(PCI_IOBASE + addr, buffer, count); > | ~~~~~~~~~~ ^ > include/asm-generic/io.h:735:21: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] > 735 | writesl(PCI_IOBASE + addr, buffer, count); > | ~~~~~~~~~~ ^ >>> mm/page_io.c:211:18: error: use of undeclared identifier 'THP_SWPOUT'; did you mean 'PSWPOUT'? > 211 | count_vm_event(THP_SWPOUT); > | ^~~~~~~~~~ > | PSWPOUT > include/linux/vm_event_item.h:32:47: note: 'PSWPOUT' declared here > 32 | enum vm_event_item { PGPGIN, PGPGOUT, PSWPIN, PSWPOUT, > | ^ > 12 warnings and 1 error generated. I will fix it in the next version. Thanks. > > vim +211 mm/page_io.c > > 2f772e6cadf8ad Seth Jennings 2013-04-29 207 > c40c44eb86eb74 ZhangPeng 2023-07-20 208 static inline void count_swpout_vm_event(struct folio *folio) > 225311a46411c3 Huang Ying 2017-09-06 209 { > c40c44eb86eb74 ZhangPeng 2023-07-20 210 if (unlikely(folio_test_pmd_mappable(folio))) > 225311a46411c3 Huang Ying 2017-09-06 @211 count_vm_event(THP_SWPOUT); > c40c44eb86eb74 ZhangPeng 2023-07-20 212 count_vm_events(PSWPOUT, folio_nr_pages(folio)); > 225311a46411c3 Huang Ying 2017-09-06 213 } > 225311a46411c3 Huang Ying 2017-09-06 214 > -- Best Regards, Peng