From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65D06C54798 for ; Tue, 27 Feb 2024 09:53:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E29D08000A; Tue, 27 Feb 2024 04:53:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DDA00940008; Tue, 27 Feb 2024 04:53:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C52E68000A; Tue, 27 Feb 2024 04:53:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B67DD940008 for ; Tue, 27 Feb 2024 04:53:25 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 89DC4C0BF3 for ; Tue, 27 Feb 2024 09:53:25 +0000 (UTC) X-FDA: 81837121170.03.C05E2DA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf30.hostedemail.com (Postfix) with ESMTP id 3672A8000E for ; Tue, 27 Feb 2024 09:53:23 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QmWVsXq9; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709027603; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=C4U206G991wButn18QTKU/VXchme3CjjGj/qsBUFTkk=; b=J61bpD/oo/OMOAxLl/PB1hijHjaymHMTMLcfFI2b0emWWi/rod1uJw0D1hXnfxxXJme3OT ePt2/TPVL/75U+zrGQdrbbb9TX0nFVe34/uUrOy5nMDxaliAcqKcWPXQc1WwLzW7diNjlK jp/OggFI6KHtoC+63O3EvcJQ7EvP9kg= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QmWVsXq9; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709027603; a=rsa-sha256; cv=none; b=oX3HwbXy70jB0L5oht/h/fBWe3gxKYAb4ZWFoo4E916B48klmB38egcJcvRkCbZNuG9Nkq Jqu6Oe/fHlcSK8XHQUQpp0hZhsw11NFi+OYVX7MqUtaBW5OGQhPFYwJ6fA0Yoz9ZtqcbmZ 0qYVbTqyQq2LWeGiNlDsZpvSXIrspr8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709027602; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=C4U206G991wButn18QTKU/VXchme3CjjGj/qsBUFTkk=; b=QmWVsXq99BEHdFmq4Z/zFUedtEE/Hbk1LR8/SMGLB3H2iAU5AzUeaX3nu3Xy8IFBGlzze3 C5YPn++9E7g/yXBE7bd+UujcLLIzH3i8lk8ZrQDFOewycc2j/faetM7gOlHF/inoo285qQ 3Ez1pjR94ST+0EPt0Ss/Uzf5TkDL67Q= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-496-FEwTjw_KNne83gQrwMlQGg-1; Tue, 27 Feb 2024 04:53:20 -0500 X-MC-Unique: FEwTjw_KNne83gQrwMlQGg-1 Received: by mail-lj1-f197.google.com with SMTP id 38308e7fff4ca-2d2654a942cso29896561fa.0 for ; Tue, 27 Feb 2024 01:53:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709027599; x=1709632399; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=C4U206G991wButn18QTKU/VXchme3CjjGj/qsBUFTkk=; b=sCLwwGVPCyzO/Z6MQImlTTaY7pGNXjq21quUX8Ek2CAkVq9DNNPzfr7FYyf+lwr/jm Dii4e3W60AtOKTh/2ho20UaVg6SKQ3QXVWrtJd+aR08q4ue032jwI/K6q3TXT/czUQv0 OyvHulQFHaKI4bYvx2JmtEd5Yo3MkwhN8YJPo78qq//p6uzQ7l+lkaPpGqV7vlY99P8S BBMPKTVp5JKWrqvqfK7/WreXR/ucb0SBVjrrn6atFaeQzAsNFpGEcHCVVQ10ycH94MxK 4iYXGJyoNphiFgJZhPTMv/7PzKrAT0g7GhHEsj095J+/l3M5l+zVNkNTWZpAUmqECvis UwHQ== X-Forwarded-Encrypted: i=1; AJvYcCX+BR2Rm6dbwG4dT0bXyuNCisrGB5cSvfQ5cfCR1peXoz/TbnAe2fzsXm3LpMq7d3bVfLDexW5boV+XEeAaz4p/4G4= X-Gm-Message-State: AOJu0YyBP+hmOEwYGEXQvYmac1RiofHCD8Q74WOWGWskRp8UZAv9IpO3 7TJlukY2k0enH4YHif2ZRJnBzSx4peySQl4Ypylh15gJZGRtNC8Jw7proHTToLms2XJvu9Crwok TAqTAg2+quAt33Fr0itkSGXn5QIJV4cho99OWg5j1qWphIpDY X-Received: by 2002:a2e:a30a:0:b0:2d2:85d0:f65 with SMTP id l10-20020a2ea30a000000b002d285d00f65mr4605457lje.0.1709027599369; Tue, 27 Feb 2024 01:53:19 -0800 (PST) X-Google-Smtp-Source: AGHT+IGhbuSngP6uAgMj5xZGYwfLLlM0IibKqb+IqO+I1JrqEm/UihVhyZR/MVQgey+3ecmOa0qxiw== X-Received: by 2002:a2e:a30a:0:b0:2d2:85d0:f65 with SMTP id l10-20020a2ea30a000000b002d285d00f65mr4605444lje.0.1709027598938; Tue, 27 Feb 2024 01:53:18 -0800 (PST) Received: from ?IPV6:2003:cb:c707:7600:5c18:5a7d:c5b7:e7a9? (p200300cbc70776005c185a7dc5b7e7a9.dip0.t-ipconnect.de. [2003:cb:c707:7600:5c18:5a7d:c5b7:e7a9]) by smtp.gmail.com with ESMTPSA id r9-20020a05600c458900b004122b7a680dsm10892489wmo.21.2024.02.27.01.53.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Feb 2024 01:53:18 -0800 (PST) Message-ID: Date: Tue, 27 Feb 2024 10:53:17 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: export folio_pte_batch as a couple of modules might need it To: Lance Yang Cc: Ryan Roberts , Barry Song <21cnbao@gmail.com>, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Barry Song , Yin Fengwei References: <20240227024050.244567-1-21cnbao@gmail.com> <61b9dfc9-5522-44fd-89a4-140833ede8af@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Stat-Signature: 36omnfuc1kw8a1x1i6x7fjq6g5jah58u X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 3672A8000E X-HE-Tag: 1709027603-62670 X-HE-Meta: U2FsdGVkX18RLDsM/1HNFYdlomhNTHyFjesrWFxxe8xK/TcWpQ3Ia5fXiH21bnPjh7Ki/xZe3KLkN56l8gZZreFqGDVVLvVwhynqIXkU6najPIYzJIPnzu9kdNA5E7TX4WIgBQGxvuvjPj9Q9JVS9HostogIzWSAx6+xdfGBmI8EwGjQ2xBji0XsBOqH6EijwFEKwyeAVHnyehOpHg62eaYho5BNU5aLoT0fjqsOSONQa9vNVI6OEnUspY+/3os7wKNoW+c5WscnxoQfK0ajkmO7e471kdJzzx9Gl9syCBj/4LhLY0RjAuH7cd8yg4vkg8xHmMfnIEHhnGIvQZsZ37KxY2WdxlkuRP6C1oGItCa72jVbaO0NNao3qPIzI2Kx5Yo3TbXmB1tW538ULCgYoLAdBn9Uzhh0aoaNPjtLsqjKpWsluETZpau0o3YfthzGIGLGXdRaRetVxd2QlBPJmWlrT98apQKMnP20VfhP1Cj6nUt+Kxwk3PTpRNNqkwhQ3xKfSNe1Q3uWSk5r9NRHLp83BZLw2aJsrQyg/Pj/31C0lnEd90hCYReT/PWCzrt3fDkL39OCFqlzgVZ+u1V9ijDBFF/DxicxVUT7G8AnCMX++utjvGEiaTxdq+duX2HrGGyDedhEYQTo1vpzuH/ZKFrHiVDDm1p8aU+Fztmhse4Jqh1gTw9D6Mto4KyP+BRWvTh9j9FIA9wjzGtBEwsxn/XtqtvcSDIs9bMHULj9nZHsIq13xRjhBDH+9l25h4Mc/6ynzGCQqqWP+4AdfyuT5jnrNhjGlkDynX+ak09MTiNcWbsVAUxH1Zg1TNXBrW8qDznqtBynYm9hB3aI5AysQPQZTHqkiaijF8rHKqSbzaR+BqwJarcgN6gBiTcfBMEWv8Wql3ySsMzkUQ4YuxVKThPM3qCafjpX0GC+00cFDkHtVdzyy/G4Y1csIqTtbTOoFmw1UrN9L3szkzcCur0 WNUSxsX1 30SCSngv46bUS/iN+aSNAWKYEs0Sd4J18BSjVh1Hk9RFzW9XY+sfRt1DpAsAwTWysdvePL8SOeDwtoe1jizp3un4EnF+FLZpvU4273LPU2KUJTvrZsnJHKibqxezeHoytEF/coQRMA1T1VDsIfzBAY50q+bX5x9kngxxLRW2Zvyq7wVx7SBdcdiVpgj6IJMMXwRTnBoajPgmEZuMZZy6HWXsL99yxdg6mxXNa8ml1vCa2EHnrG7zWqna/49kDVso2ItUDakg2C+meGVxRahfTvHxZH+VR8RD1932SMofxZu0f1XI18bMOnbYCp6rtQodlmHoQnLzlFJPklFtNXsV3TsEvwEQmXrJzaB045H6Apzs7ksfKpI929mGTDBEDNx3FnQ7qVGNHhctZAMSlzABr9YPCSUcq22G8Wh4w9H+EZ7CKLd4pveq+5A0dMyC/3KxHQC0Az0CQ8svyjhRPiqwOQXUJIIwvyqWErWTCT2GMdr709v3KcEiNVSHz5BBH3Tt08LOejHD064NnoAKyUUCgmjnKZXB6bFa0JStRn0qK3CncmCTpebvDl06ywUbL413h2NnLO5yqCC3qdBn2PqyQ/ToerUVegijhyU+y64ocoBTO05llkqPYhiP8W6cZvVTvqpVHxtOoPnsuLqYjU4cCN8oAEsnC82WXhkcxIx7/QiHqfd97c7YNtcTeF297EMGB0G160qZ91kB8K2xJWwKUzIX0Pg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 27.02.24 10:51, Lance Yang wrote: > On Tue, Feb 27, 2024 at 5:14 PM David Hildenbrand wrote: >> >> On 27.02.24 10:07, Ryan Roberts wrote: >>> On 27/02/2024 02:40, Barry Song wrote: >>>> From: Barry Song >>>> >>>> madvise and some others might need folio_pte_batch to check if a range >>>> of PTEs are completely mapped to a large folio with contiguous physcial >>>> addresses. Let's export it for others to use. >>>> >>>> Cc: Lance Yang >>>> Cc: Ryan Roberts >>>> Cc: David Hildenbrand >>>> Cc: Yin Fengwei >>>> Signed-off-by: Barry Song >>>> --- >>>> -v1: >>>> at least two jobs madv_free and madv_pageout depend on it. To avoid >>>> conflicts and dependencies, after discussing with Lance, we prefer >>>> this one can land earlier. >>> >>> I think this will also ultimately be useful for mprotect too, though I haven't >>> looked at it properly yet. >>> >> >> Yes, I think we briefly discussed that. >> >>>> >>>> mm/internal.h | 13 +++++++++++++ >>>> mm/memory.c | 11 +---------- >>>> 2 files changed, 14 insertions(+), 10 deletions(-) >>>> >>>> diff --git a/mm/internal.h b/mm/internal.h >>>> index 13b59d384845..8e2bc304f671 100644 >>>> --- a/mm/internal.h >>>> +++ b/mm/internal.h >>>> @@ -83,6 +83,19 @@ static inline void *folio_raw_mapping(struct folio *folio) >>>> return (void *)(mapping & ~PAGE_MAPPING_FLAGS); >>>> } >>>> >>>> +/* Flags for folio_pte_batch(). */ >>>> +typedef int __bitwise fpb_t; >>>> + >>>> +/* Compare PTEs after pte_mkclean(), ignoring the dirty bit. */ >>>> +#define FPB_IGNORE_DIRTY ((__force fpb_t)BIT(0)) >>>> + >>>> +/* Compare PTEs after pte_clear_soft_dirty(), ignoring the soft-dirty bit. */ >>>> +#define FPB_IGNORE_SOFT_DIRTY ((__force fpb_t)BIT(1)) >>>> + >>>> +extern int folio_pte_batch(struct folio *folio, unsigned long addr, >>>> + pte_t *start_ptep, pte_t pte, int max_nr, fpb_t flags, >>>> + bool *any_writable); >>>> + >>>> void __acct_reclaim_writeback(pg_data_t *pgdat, struct folio *folio, >>>> int nr_throttled); >>>> static inline void acct_reclaim_writeback(struct folio *folio) >>>> diff --git a/mm/memory.c b/mm/memory.c >>>> index 1c45b6a42a1b..319b3be05e75 100644 >>>> --- a/mm/memory.c >>>> +++ b/mm/memory.c >>>> @@ -953,15 +953,6 @@ static __always_inline void __copy_present_ptes(struct vm_area_struct *dst_vma, >>>> set_ptes(dst_vma->vm_mm, addr, dst_pte, pte, nr); >>>> } >>>> >>>> -/* Flags for folio_pte_batch(). */ >>>> -typedef int __bitwise fpb_t; >>>> - >>>> -/* Compare PTEs after pte_mkclean(), ignoring the dirty bit. */ >>>> -#define FPB_IGNORE_DIRTY ((__force fpb_t)BIT(0)) >>>> - >>>> -/* Compare PTEs after pte_clear_soft_dirty(), ignoring the soft-dirty bit. */ >>>> -#define FPB_IGNORE_SOFT_DIRTY ((__force fpb_t)BIT(1)) >>>> - >>>> static inline pte_t __pte_batch_clear_ignored(pte_t pte, fpb_t flags) >>>> { >>>> if (flags & FPB_IGNORE_DIRTY) >>>> @@ -982,7 +973,7 @@ static inline pte_t __pte_batch_clear_ignored(pte_t pte, fpb_t flags) >>>> * If "any_writable" is set, it will indicate if any other PTE besides the >>>> * first (given) PTE is writable. >>>> */ >>> >>> David was talking in Lance's patch thread, about improving the docs for this >>> function now that its exported. Might be worth syncing on that. >> >> Here is my take: >> >> Signed-off-by: David Hildenbrand >> --- >> mm/memory.c | 22 ++++++++++++++++++---- >> 1 file changed, 18 insertions(+), 4 deletions(-) >> >> diff --git a/mm/memory.c b/mm/memory.c >> index d0b855a1837a8..098356b8805ae 100644 >> --- a/mm/memory.c >> +++ b/mm/memory.c >> @@ -971,16 +971,28 @@ static inline pte_t __pte_batch_clear_ignored(pte_t pte, fpb_t flags) >> return pte_wrprotect(pte_mkold(pte)); >> } >> >> -/* >> +/** >> + * folio_pte_batch - detect a PTE batch for a large folio >> + * @folio: The large folio to detect a PTE batch for. >> + * @addr: The user virtual address the first page is mapped at. >> + * @start_ptep: Page table pointer for the first entry. >> + * @pte: Page table entry for the first page. >> + * @max_nr: The maximum number of table entries to consider. >> + * @flags: Flags to modify the PTE batch semantics. >> + * @any_writable: Optional pointer to indicate whether any entry except the >> + * first one is writable. >> + * >> * Detect a PTE batch: consecutive (present) PTEs that map consecutive >> - * pages of the same folio. >> + * pages of the same large folio. >> * >> * All PTEs inside a PTE batch have the same PTE bits set, excluding the PFN, >> * the accessed bit, writable bit, dirty bit (with FPB_IGNORE_DIRTY) and >> * soft-dirty bit (with FPB_IGNORE_SOFT_DIRTY). >> * >> - * If "any_writable" is set, it will indicate if any other PTE besides the >> - * first (given) PTE is writable. >> + * start_ptep must map any page of the folio. max_nr must be at least one and >> + * must be limited by the caller so scanning cannot exceed a single page table. >> + * >> + * Return: the number of table entries in the batch. >> */ >> static inline int folio_pte_batch(struct folio *folio, unsigned long addr, >> pte_t *start_ptep, pte_t pte, int max_nr, fpb_t flags, >> @@ -996,6 +1008,8 @@ static inline int folio_pte_batch(struct folio *folio, unsigned long addr, >> *any_writable = false; >> >> VM_WARN_ON_FOLIO(!pte_present(pte), folio); >> + VM_WARN_ON_FOLIO(!folio_test_large(folio) || max_nr < 1, folio); >> + VM_WARN_ON_FOLIO(page_folio(pfn_to_page(pte_pfn(pte))) != folio, folio); > > Nit: > IIUC, the pte that maps to the first page. > - VM_WARN_ON_FOLIO(page_folio(pfn_to_page(pte_pfn(pte))) != > folio, folio); > + VM_WARN_ON_FOLIO(pte_pfn(pte) != folio_pfn(folio), folio); That would only work if the PTE would map the very first subpage of the folio, not any subpage? -- Cheers, David / dhildenb