From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4013DC3ABC0 for ; Wed, 7 May 2025 09:55:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1A7BB6B000A; Wed, 7 May 2025 05:55:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 158316B0083; Wed, 7 May 2025 05:55:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EEAF36B0085; Wed, 7 May 2025 05:55:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D1D806B000A for ; Wed, 7 May 2025 05:55:06 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 077771CE13E for ; Wed, 7 May 2025 09:55:07 +0000 (UTC) X-FDA: 83415653454.30.4424C6C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf01.hostedemail.com (Postfix) with ESMTP id 912CB40007 for ; Wed, 7 May 2025 09:55:04 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UJqXVjMl; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746611704; a=rsa-sha256; cv=none; b=N8EDWBdtREXDT9lqCam6TbXqG+DWtoI4m3er6tXWj96Ld/Mv8qFgRJLattII39QsPgM5xC CETvC9DKlxLAlC4E8gHAeArx/RB9YjMQw/0mkzttWIyXMHqMH+vhPGJYahsVFkXuBS2jMn tv88NJma47qi7t0txlYnswzEiIcepEI= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UJqXVjMl; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746611704; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zSfDWkBsK8oZu+WL4cNbDwVvy7S2QgA9Nl9XOOAqIZU=; b=bK4CweKTqaL+wlmqdc3DyBoqBhpLnQFBcZ77EOys8NKsJpeAZ+JRNpGZ7yW+/d1XsiVI3e Ysbf6dWrAZtXC2SP1q6EbQLOk9vOOvk1UtjtkN5/GE5a4INLVtZvIdzlM217BWcQ9yhT+f Er+GWWW7NhA71KIu5Y7A8Eq5WDONkBM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1746611704; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=zSfDWkBsK8oZu+WL4cNbDwVvy7S2QgA9Nl9XOOAqIZU=; b=UJqXVjMlh5MF1jfnRikLEZMnqM5U+gY+G/cUyXmac6bXTfdVjyqsd7aKOqlEQTSzZkYnR9 azmAL+cFcoBkfhlbtRXa0oxtbX/XqYdGfFqhZtghHAXgGU3d6s8M/IEY+0saxoofCgZloi JYjJUnCkAmuV4DQVqVKhdW5ozpLJa8g= Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-659-sgrdT0R1OzarcjSh64JJmQ-1; Wed, 07 May 2025 05:55:02 -0400 X-MC-Unique: sgrdT0R1OzarcjSh64JJmQ-1 X-Mimecast-MFC-AGG-ID: sgrdT0R1OzarcjSh64JJmQ_1746611702 Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-22e544a4c83so7025905ad.1 for ; Wed, 07 May 2025 02:55:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746611702; x=1747216502; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=zSfDWkBsK8oZu+WL4cNbDwVvy7S2QgA9Nl9XOOAqIZU=; b=jCQx4eI3umFrOOGzLuu9QWYauHyJigivp74Cza+rn7QNwuXP0SzzivERWoRLz5+kGM xPfz8td0pUxfXpdkKiz0Tkr3GpstmbuPapkye8y2fBpyfVSWUog4aoi9DGQbciSxYB16 5O5aOfAJ44kQgkQwpApKHq1Dv0X8aCmMPiZZKxZWdL/NW2t7coxH/gdPbv/0w7gzEzYt qf+hy78rgt1LZhLDRxpDXpv2r58KqsX0/QYp5fbcvGU+ohP9Ul8SfRKWEe30emuJ9Ocu J1/TNalxIV9wZNrniiw4NqNk776DvW7/y++Vs+HHPTsHRzj6NwEqzZhVIZPPUL1hxogK Lb0w== X-Forwarded-Encrypted: i=1; AJvYcCWyIdjeYUZINCh53eEdj2sBJ5o7ZGBt/nZxdteX/uAsrDY6bmG4Nu9bui91fWQCq2iwV0ZrTugXog==@kvack.org X-Gm-Message-State: AOJu0YxqHSpByqklXNspTE3CXNkeO5hD/lpObmZvOFGKVJjBwT04bon+ 54nY3VxN6jEDlbKGFeMK2fnyc0iA8L0SGV4UxFB6jowY9LOXJqUcYCJyeEhdBG1rAZt02Gz+i/H NXefUKvXzyyTfUOuRODzf116YSWMYhMGeabVsQmr4jBxLK8W8 X-Gm-Gg: ASbGncuWw5xzd7xWg1nDkvQt7LjW07AGrwNBBPn7ld/Ak87dE3H47TvX4bGyQFO9rpj FAPECSunSIaFhkTIKPuk/gkEjKO7NPQMzkJY1kCf//JUTn67rIeywwJKmKqck49k+dtEjtCZwBS jGmu4c6mtsHelXi9biupRZPzQ5TdQdk+RgEuki2qSRLhOSmLQ86i0rGwws4kFnC2UNnmnrznSzw XPA4bcB0x7N6pf/0vokyv5n85gZKjtv2pPisoxOJqkQCLv/+Tl2C85i9x/UBqO+1Z7/9PMm/OhE mWQzauVxxdT1dA3UhOHgtgWPJH9to4Plrrc5C2c+P2Bznn9Tmc/RHU5iYmJhUo0Or8C0m95j2Qu GEq5ecO3S0lfTv+Zs4x+z8ag7gHQAuM3lZIxi5CU= X-Received: by 2002:a17:903:2a84:b0:220:fe36:650c with SMTP id d9443c01a7336-22e619e2226mr45789265ad.23.1746611701890; Wed, 07 May 2025 02:55:01 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG/r4dsF4GCF1c/smLA19mxLwkzxTgauy8/CvcoJA20MacvEUTz1fmtODdQ54QDtLIQvsyOuw== X-Received: by 2002:a17:903:2a84:b0:220:fe36:650c with SMTP id d9443c01a7336-22e619e2226mr45788875ad.23.1746611701502; Wed, 07 May 2025 02:55:01 -0700 (PDT) Received: from ?IPV6:2003:d8:2f12:d400:ed3c:fb0c:1ec0:c628? (p200300d82f12d400ed3cfb0c1ec0c628.dip0.t-ipconnect.de. [2003:d8:2f12:d400:ed3c:fb0c:1ec0:c628]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22e15228f9csm90036545ad.178.2025.05.07.02.54.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 May 2025 02:55:01 -0700 (PDT) Message-ID: Date: Wed, 7 May 2025 11:54:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] mm: mincore: use folio_pte_batch() to batch process large folios To: Baolin Wang , Dev Jain , akpm@linux-foundation.org, hughd@google.com Cc: willy@infradead.org, 21cnbao@gmail.com, ryan.roberts@arm.com, ziy@nvidia.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <7ad05bc9299de5d954fb21a2da57f46dd6ec59d0.1742960003.git.baolin.wang@linux.alibaba.com> <17289428-894a-4397-9d61-c8500d032b28@arm.com> <6a8418ba-dbd1-489f-929b-e31831bea0cf@linux.alibaba.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <6a8418ba-dbd1-489f-929b-e31831bea0cf@linux.alibaba.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: aLy5W8CllG1xjCKaMBo_4gn0AMTbt8jJlS6hX7yrCZA_1746611702 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 912CB40007 X-Stat-Signature: euj3dhgan1i8n9k5f8ryxkzy8qb4cc54 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1746611704-728218 X-HE-Meta: U2FsdGVkX18RrtJisQ3+Bubg4CKxSLDgiFMFqQSQl5vZpzmog7Qj3l5xKBK3hIzDhwtyuJoQW40Tun1Ax7RP11saypSnhLP0O0Wh2dlAwKJZiZ/lTG1wSsytvA/v2xTwM6K3eAli5OC0ccJRFNT/AjOf04FQ1lflhQjXh4kJlVbEqQ7/8BXdvrj0lhTo6B3k9CkJarX4UVP75lOkaQgrBMC9Rso7WnFyZkAwnr9G6mtm9/M8rPIk39npAl74w8Zaoy4i+dmE5DaGRtHNi/wKkDeFIqyNs6h03iui1qZQVBwsbKLRhP6mT4NBIzvNWZQmfoQrbV/uVfz/UQ4wPH7vEr+HAwsF/v513LeTvgtGIiz3aVtw3hrdiXzLgkwXCX5GmJodsY3wGQmgLLFvAICuIdNts3YHcOZqsQt7fceqm/MZnqdQwFjGSZDKX4w5WjqBkNmjBhIYabr2fa5O+4nz7JNQuKdy9SImMb3KCKOYQLh5CLV7wuxmKUNnTf2Dw9FRzmWYoFcLpNs965PzCrQoDEvJcZIzjCBG6O+MhysOiIUST0rREpg67ye02fk140OvwJgshiolXGSkWOvYjgjwxOKnvVU7WC+887VdS2q8pdmlE8vwrBnyEcJMwmiJYoRTFZ+LCyRaZQlVAtzs5VSjleOPKbzsodd5oruwsVw9hNWHIu5jrfsLfNP9ViuKYcViAt4iCiftWs89+LeEDKYI06kyDzgA9X/bDdHQZlKI+RcVAvh9C+1DnxMBuz2KQpQWR+5d9WphftsTdFJX2tBxk1OhofAQyz5T++YIxiGGjHMFgxNdxo0KKoZMW+w1czeqoPdoHEJOrTJ2e9SoDSGkNBWkrtLfqH+PEZH/R5hbL6S0chR+F9aYMUB7sExvRAQA1BrtDE4nL8/7A2DMlKtnZcLIQ46N+IkTp9JaglBa4LUO88fOKsYiUaFhi8Xmaww3EhHEmZwOOid/QpIy/8h bPjM7WSX nAAzIw/vdEUajTrW9YMPIQIn2fnTN3GM/lUIik5MyfUIjD37mIwYzGgjopk7nzU+vjhAdJwwwfSSOYeFy8uc1ITvxoSZM3MhmZ0ekNQmZn/RXC/lmWiy+25+x2gd3ucnGltkWuEGIErcJs+SDoi469yM5bLHldyiPCBvC+obQr3B9CSg3JsHJP7hkQYiP3CiIG3MQ7SZKKDFuoSDGP5svCRMZfE+mAmpRG5hIeQL3ONUjzDLyh8+ESFrGH6L2JOEbrFWilzCxHi8ABYm0Go5dr02MnIOoCvQ414LcqzKPPCNgPHbHSW+F99ji8gunShnGJGHMbUMSpY1VIQVk3IxnMoR6z1ZJCIFPNrNs2weupayttUbGLexaK3+U73io1Xfwx3tJdTw3BKZI/QUsRSooKJlzhcAAq1Xqy1dgfRr7w0504p+2iwf+YFX74JNNyXTZ83BXJAP7FGcf0OjHXCNIJeZraqsaCDNGUr+u14A3GlG+4JCT0XBue8qtm5yCuOV3ANx77fTYAAWuMxbBgtNaNsN7yUXxjq+T4h7KJ5qrx9cB5W4F/3YfHy32uztXhUkJLEA116YPdkoVLyc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 07.05.25 11:48, Baolin Wang wrote: > > > On 2025/5/7 13:12, Dev Jain wrote: >> >> >> On 26/03/25 9:08 am, Baolin Wang wrote: >>> When I tested the mincore() syscall, I observed that it takes longer with >>> 64K mTHP enabled on my Arm64 server. The reason is the >>> mincore_pte_range() >>> still checks each PTE individually, even when the PTEs are contiguous, >>> which is not efficient. >>> >>> Thus we can use folio_pte_batch() to get the batch number of the present >>> contiguous PTEs, which can improve the performance. I tested the >>> mincore() >>> syscall with 1G anonymous memory populated with 64K mTHP, and observed an >>> obvious performance improvement: >>> >>> w/o patch        w/ patch        changes >>> 6022us            1115us            +81% >>> >>> Moreover, I also tested mincore() with disabling mTHP/THP, and did not >>> see any obvious regression. >>> >>> Signed-off-by: Baolin Wang >>> --- >>>   mm/mincore.c | 27 ++++++++++++++++++++++----- >>>   1 file changed, 22 insertions(+), 5 deletions(-) >>> >>> diff --git a/mm/mincore.c b/mm/mincore.c >>> index 832f29f46767..88be180b5550 100644 >>> --- a/mm/mincore.c >>> +++ b/mm/mincore.c >>> @@ -21,6 +21,7 @@ >>>   #include >>>   #include "swap.h" >>> +#include "internal.h" >>>   static int mincore_hugetlb(pte_t *pte, unsigned long hmask, unsigned >>> long addr, >>>               unsigned long end, struct mm_walk *walk) >>> @@ -105,6 +106,7 @@ static int mincore_pte_range(pmd_t *pmd, unsigned >>> long addr, unsigned long end, >>>       pte_t *ptep; >>>       unsigned char *vec = walk->private; >>>       int nr = (end - addr) >> PAGE_SHIFT; >>> +    int step, i; >>>       ptl = pmd_trans_huge_lock(pmd, vma); >>>       if (ptl) { >>> @@ -118,16 +120,31 @@ static int mincore_pte_range(pmd_t *pmd, >>> unsigned long addr, unsigned long end, >>>           walk->action = ACTION_AGAIN; >>>           return 0; >>>       } >>> -    for (; addr != end; ptep++, addr += PAGE_SIZE) { >>> +    for (; addr != end; ptep += step, addr += step * PAGE_SIZE) { >>>           pte_t pte = ptep_get(ptep); >>> +        step = 1; >>>           /* We need to do cache lookup too for pte markers */ >>>           if (pte_none_mostly(pte)) >>>               __mincore_unmapped_range(addr, addr + PAGE_SIZE, >>>                            vma, vec); >>> -        else if (pte_present(pte)) >>> -            *vec = 1; >>> -        else { /* pte is a swap entry */ >>> +        else if (pte_present(pte)) { >>> +            if (pte_batch_hint(ptep, pte) > 1) { >>> +                struct folio *folio = vm_normal_folio(vma, addr, pte); >>> + >>> +                if (folio && folio_test_large(folio)) { >>> +                    const fpb_t fpb_flags = FPB_IGNORE_DIRTY | >>> +                                FPB_IGNORE_SOFT_DIRTY; >>> +                    int max_nr = (end - addr) / PAGE_SIZE; >>> + >>> +                    step = folio_pte_batch(folio, addr, ptep, pte, >>> +                            max_nr, fpb_flags, NULL, NULL, NULL); >>> +                } >>> +            } >> >> Can we go ahead with this along with [1], that will help us generalize >> for all arches. >> >> [1] https://lore.kernel.org/all/20250506050056.59250-3-dev.jain@arm.com/ >> (Please replace PAGE_SIZE with 1) > > As discussed with Ryan, we don’t need to call folio_pte_batch() > (something like the code below), so your patch seems unnecessarily > complicated. However, David is unhappy about the open-coded > pte_batch_hint(). I can live with the below :) Having something more universal does maybe not make sense here. Any form of patching contiguous PTEs (contiguous PFNs) -- whether with folios or not -- is not required here as we really only want to (a) Identify pte_present() PTEs (b) Avoid the cost of repeated ptep_get() with cont-pte. > > static int mincore_hugetlb(pte_t *pte, unsigned long hmask, unsigned > long addr, > unsigned long end, struct mm_walk *walk) > @@ -105,6 +106,7 @@ static int mincore_pte_range(pmd_t *pmd, unsigned > long addr, unsigned long end, > pte_t *ptep; > unsigned char *vec = walk->private; > int nr = (end - addr) >> PAGE_SHIFT; > + int step, i; > > ptl = pmd_trans_huge_lock(pmd, vma); > if (ptl) { > @@ -118,16 +120,21 @@ static int mincore_pte_range(pmd_t *pmd, unsigned > long addr, unsigned long end, > walk->action = ACTION_AGAIN; > return 0; > } > - for (; addr != end; ptep++, addr += PAGE_SIZE) { > + for (; addr != end; ptep += step, addr += step * PAGE_SIZE) { > pte_t pte = ptep_get(ptep); > > + step = 1; > /* We need to do cache lookup too for pte markers */ > if (pte_none_mostly(pte)) > __mincore_unmapped_range(addr, addr + PAGE_SIZE, > vma, vec); > - else if (pte_present(pte)) > - *vec = 1; > - else { /* pte is a swap entry */ > + else if (pte_present(pte)) { > + unsigned int max_nr = (end - addr) / PAGE_SIZE; > + > + step = min(pte_batch_hint(ptep, pte), max_nr); > + for (i = 0; i < step; i++) > + vec[i] = 1; > + } else { /* pte is a swap entry */ > swp_entry_t entry = pte_to_swp_entry(pte); > > if (non_swap_entry(entry)) { > @@ -146,7 +153,7 @@ static int mincore_pte_range(pmd_t *pmd, unsigned > long addr, unsigned long end, > #endif > } > } > - vec++; > + vec += step; > } > pte_unmap_unlock(ptep - 1, ptl); > out: > -- Cheers, David / dhildenb