From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 490D1C369D3 for ; Wed, 25 Sep 2024 12:01:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CF0A56B009D; Wed, 25 Sep 2024 08:01:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CA13E6B009E; Wed, 25 Sep 2024 08:01:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B68FF6B009F; Wed, 25 Sep 2024 08:01:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 938686B009D for ; Wed, 25 Sep 2024 08:01:27 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 9BA1A1C6982 for ; Wed, 25 Sep 2024 12:01:26 +0000 (UTC) X-FDA: 82603120572.11.D0DE3A4 Received: from outboundhk.mxmail.xiaomi.com (outboundhk.mxmail.xiaomi.com [118.143.206.90]) by imf30.hostedemail.com (Postfix) with ESMTP id 149FF80009 for ; Wed, 25 Sep 2024 12:01:21 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=none; spf=pass (imf30.hostedemail.com: domain of gaoxiang17@xiaomi.com designates 118.143.206.90 as permitted sender) smtp.mailfrom=gaoxiang17@xiaomi.com; dmarc=pass (policy=quarantine) header.from=xiaomi.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727265623; a=rsa-sha256; cv=none; b=8hWTgJo4Vazt/zHN/FYIXNGFzRIPrqdNDhlu4sMo/efy28Zbvpp1dmeQWJMpSEyCj0XHDF G6h/MRelE/2QhvInDc6ltYRZvDTp2vpZfJYVIQsRwvY7YH+nw0oym/LCoA61SlK19cgvRX zlYRj0R5z2QHyysdtlPNVP6qSINzF/4= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=none; spf=pass (imf30.hostedemail.com: domain of gaoxiang17@xiaomi.com designates 118.143.206.90 as permitted sender) smtp.mailfrom=gaoxiang17@xiaomi.com; dmarc=pass (policy=quarantine) header.from=xiaomi.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727265623; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2DgUl8Ai37rxpscY+QI388Sm5gEWULYbAlcwbzxp114=; b=hF2kdmePDJTQNsjPIysncTDwHnvYmNgK/EZt27T4VJ9X7i+1iy8bheHj3gBihER1zwfuaO pmF6QEPWcLmME+WefY+aRQ73GOkCCmm6B/rjgqpYMExbhlJwmHcnYP3Dt/BMUbRyFdICIa w069EtUSy0fFSfRPjoSy7xKwc+h30qY= X-CSE-ConnectionGUID: c+3y5PXWRiWU+lVHFpwvQg== X-CSE-MsgGUID: C8Gpky4VTZ2HgpsyWP3D1w== X-IronPort-AV: E=Sophos;i="6.10,257,1719849600"; d="scan'208,217";a="97349362" From: =?gb2312?B?uN/P6A==?= To: Andrew Morton , Xiang Gao CC: "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" Subject: =?gb2312?B?tPC4tDogW0V4dGVybmFsIE1haWxdUmU6IFtQQVRDSF0gbW0vY21hLmM6IFRv?= =?gb2312?B?IGJldHRlciB1bmRlcnN0YW5kIGNtYSBhcmVhIGR1cmluZyBkZWJ1Z2dpbmcs?= =?gb2312?B?IGFkZCB0b3RhbCBhbmQgdXNlZCBjb3VudCBsb2dzIHRvIGluIGNtYV9hbGxv?= =?gb2312?Q?c?= Thread-Topic: [External Mail]Re: [PATCH] mm/cma.c: To better understand cma area during debugging, add total and used count logs to in cma_alloc Thread-Index: AQHbDuGyXww1cQzfZkKtLognutBLp7JoVCTG Date: Wed, 25 Sep 2024 12:00:56 +0000 Message-ID: References: <20240918124325.109236-1-gxxa03070307@gmail.com>,<20240924172719.a486793abd66643d9938081f@linux-foundation.org> In-Reply-To: <20240924172719.a486793abd66643d9938081f@linux-foundation.org> Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.237.8.19] Content-Type: multipart/alternative; boundary="_000_fc8822dd647c4aafbb72a83f5f57c6f1xiaomicom_" MIME-Version: 1.0 X-Stat-Signature: 883a9wnynm9goodtwfrytrdgyiyw6naj X-Rspamd-Queue-Id: 149FF80009 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1727265681-741233 X-HE-Meta: U2FsdGVkX1+Ul5vyxCWxognmDL77yOkEEVFUpTi9o4ixYLpG+21rVKazDb1AT2aJnu/N7EW4BSyD5T8AFu5+uAXznekkmMBARl8+TJFoAZUiWafg2PIQ9Ge1rCQiW9CibCk03B0J2ewbC5ufAkZVNzsZR5JeN8LbUj/4ioU2+raRpfP+5LE00XHpXpJRr4PDtZMwdZawQ4C+MDLrWN2LjhXHd5RSgOBn/QjruGUAFBLJssiLZdnNEQBGQEgbjFfXlmYVJGBcRbUUmIMaoM0IetVjXX66VMKN0KKLFR1ga2PaeIZAocG/9LYsDHvbWEcGxqym2c4T4L/0lL5RrK1jOVWq5ugTF4hjsoTONHi+ohIK+izwYUkb1CjGM/wQzW2qo/O8/hX8Q0w2NdRXBp63nINexQN2Z3zRTSIoTsS8WgI6yySyrRaFKEApdf8I2V7PhoYp9uT2YZf8l1M8E3AmCMEj8eLz1NRIDz5Yfw6dF8sClP1nV+jslXgJRkJ6s8xx7npJC86CX5hAJyzQy12Xg70zdhhigQjdz4zLINZLwFuLAezOWaJBUWeiIDtpi6SVcWmZPj9kP0ykVANFUfmndozEmVPz0msi+WOdQKHd9YNO16KWsNR/Taqkf96F/rwsftIA50bWWw3TiZIw/0bUAQoHwgZq290Wa/K0ZvR8XZ7J3GmBliHY3zH2GdvU0AnOePzwXffD1mZj2J8AGsTaIaNJW3JYsp5Qv3FHfpPZgL3p6OSqFntRu2FkBbDm8qp0pEIejD28odV6ujfCs+bj/brsZa+PzE/0wR8OpgQPSVc8PjPdurbwKR4pWZWbDjppl1bzadKn42E7yu6v2By9yGOBHWHoVcSja+YpS7UcWjppFIXawZwfq0vIunkgJU7rCqkFki5BbzfvgZP2UE4RcQvLAlBXttvIu7lfzDWKUzVJdNiYNnTmMCWwwlulkS6bPBbX/i1xBT8Y79fusuo WcKW/VjX 8Hv0H/u1bN8MVq+dcgMaJ5+G2RRvWR/R+bXlALaq/j0ZgcIzsd9j7cvqrDN5g27DuXH+o5hZ6MGTzm3bUSemx5OSpbxvOEe7Ss9Y/1a8zl12kv5C3+Tvb9icrGx+VB4KCzwvNMPB5fnuYTpl8q5W7rb2Ge32uKqlejaVa9iGv7ISc3s19BoKdGGLzMalnAYMFVSDUWjhZ4X/23IHRo0uAiY7lh+ccwut+XzOIULn3UGLi9CnTG6u4F++k57cAUmuSIaTFCI46jrw2TRNFEdksAQJF90EauWX5eduJ70kr32+NyAiSgBFO2HEH8QJrgro2Gm5jhaq+qtYEWUakG6bZ6DHoyw/KPAMlpWhZyBb9IdC2H9rwD1OEGBX4ijylwbVEJGCM9V5yzeJW6DevbWnWkirSo17Uqg3OwOu1KCccb3I+CeVoaXWRxb7YgTUUQqQ5McmzaizXeTIHyRBkG4GUeUIIvd7HOaKhQtmFo6o3hQ7lpF6Sz9TWyVrp/+eh338shL/Od+WnzmtCZWKSk01RZKMrOu+Q/K/o7G0dyAKVSJvDstQX0W8iVG1r5xZU+EoQMCwqlysajRBfyJk8bYg8gL4iiF68qQ/jYxYgxRCxcYgAiTt8dyoA3KaTQQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --_000_fc8822dd647c4aafbb72a83f5f57c6f1xiaomicom_ Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: base64 PiBbICAgMjQuMjI1MTI1XSBjbWE6IGNtYV9hbGxvYyhjbWEgKF9fX19wdHJ2YWxfX19fKSwgbmFt ZTogcmVzZXJ2ZWQsIHRvdGFsIGNvdW50IDE2Mzg0LCB1c2VkIGNvdW50OiA2NCwgcmVxdWVzdCBj b3VudCAxLCBhbGlnbiAwKQ0KPiBbICAgMjQuMjMxOTYzXSBjbWE6IGNtYV9hbGxvYyhjbWEgKF9f X19wdHJ2YWxfX19fKSwgbmFtZTogcmVzZXJ2ZWQsIHRvdGFsIGNvdW50IDE2Mzg0LCB1c2VkIGNv dW50OiA2NSwgcmVxdWVzdCBjb3VudCAxLCBhbGlnbiAwKQ0KPiBbICAgMjQuMjM1NzEyXSBjbWE6 IGNtYV9hbGxvYyhjbWEgKF9fX19wdHJ2YWxfX19fKSwgbmFtZTogcmVzZXJ2ZWQsIHRvdGFsIGNv dW50IDE2Mzg0LCB1c2VkIGNvdW50OiA2NiwgcmVxdWVzdCBjb3VudCAxLCBhbGlnbiAwKQ0KPg0K DQoNCkFib3ZlIGlzIHRoZSBjbWEgYWxsb2MgZHVyaW5nIGJvb3QuIFRoZSBiZWZvcmUtYW5kLWFm dGVyIGNvbnRleHQgaGFzIG5vdGhpbmcgdG8gZG8gd2l0aCBjbWEgYWxsb2MuIEJlbG93IGlzIHRo ZSBsb2cgd2l0aCBiZWZvcmUtYW5kLWFmdGVyIGNvbnRleHQgYWRkZWQuDQoNCg0KWyAgIDI0LjAw NjYwNV0gU2VyaWFsOiA4MjUwLzE2NTUwIGRyaXZlciwgNCBwb3J0cywgSVJRIHNoYXJpbmcgZW5h YmxlZA0KWyAgIDI0LjA3MTY0NF0gU2VyaWFsOiBBTUJBIGRyaXZlcg0KWyAgIDI0LjA5NjA2M10g YXJtLXNtbXUtdjMgOTA1MDAwMC5zbW11djM6IGlhcyA0NC1iaXQsIG9hcyA0NC1iaXQgKGZlYXR1 cmVzIDB4MDAwMDAzMDUpDQpbICAgMjQuMDk3OTg5XSBjbWE6IGNtYV9hbGxvYyhjbWEgKF9fX19w dHJ2YWxfX19fKSwgbmFtZTogcmVzZXJ2ZWQsIHRvdGFsIGNvdW50IDE2Mzg0LCB1c2VkIGNvdW50 OiA2NCwgcmVxdWVzdCBjb3VudCAxLCBhbGlnbiAwKQ0KWyAgIDI0LjEwNDI2MF0gY21hOiBjbWFf YWxsb2MoY21hIChfX19fcHRydmFsX19fXyksIG5hbWU6IHJlc2VydmVkLCB0b3RhbCBjb3VudCAx NjM4NCwgdXNlZCBjb3VudDogNjUsIHJlcXVlc3QgY291bnQgMSwgYWxpZ24gMCkNClsgICAyNC4x MDc1MDRdIGNtYTogY21hX2FsbG9jKGNtYSAoX19fX3B0cnZhbF9fX18pLCBuYW1lOiByZXNlcnZl ZCwgdG90YWwgY291bnQgMTYzODQsIHVzZWQgY291bnQ6IDY2LCByZXF1ZXN0IGNvdW50IDEsIGFs aWduIDApDQpbICAgMjQuMTQwNDk1XSBjYWNoZWluZm86IFVuYWJsZSB0byBkZXRlY3QgY2FjaGUg aGllcmFyY2h5IGZvciBDUFUgMA0KWyAgIDI0LjQ4NDk5OF0gbG9vcDogbW9kdWxlIGxvYWRlZA0K WyAgIDI0LjUzNjE1Ml0gdmlydGlvX2JsayB2aXJ0aW8wOiBbdmRhXSA0MTk0MzA0IDUxMi1ieXRl IGxvZ2ljYWwgYmxvY2tzICgyLjE1IEdCLzIuMDAgR2lCKQ0KDQoNCj4gLS0tIGEvbW0vY21hLmMN Cj4gKysrIGIvbW0vY21hLmMNCj4gQEAgLTQwMyw2ICs0MDMsMTcgQEAgc3RhdGljIHZvaWQgY21h X2RlYnVnX3Nob3dfYXJlYXMoc3RydWN0IGNtYSAqY21hKQ0KPiAgICAgICBzcGluX3VubG9ja19p cnEoJmNtYS0+bG9jayk7DQo+ICB9DQo+DQo+ICtzdGF0aWMgdW5zaWduZWQgbG9uZyBjbWFfZ2V0 X3VzZWQoc3RydWN0IGNtYSAqY21hKQ0KPiArew0KPiArICAgICB1bnNpZ25lZCBsb25nIHVzZWQ7 DQo+ICsNCj4gKyAgICAgc3Bpbl9sb2NrX2lycSgmY21hLT5sb2NrKTsNCj4gKyAgICAgdXNlZCA9 IGJpdG1hcF93ZWlnaHQoY21hLT5iaXRtYXAsIChpbnQpY21hX2JpdG1hcF9tYXhubyhjbWEpKTsN Cg0KSXMgdGhlIChpbnQpIGNhc3QgbmVlZGVkPw0KTm8gbmVlZCBoZXJlLg0KDQo+ICsgICAgIHNw aW5fdW5sb2NrX2lycSgmY21hLT5sb2NrKTsNCj4gKw0KPiArICAgICByZXR1cm4gKHVuc2lnbmVk IGxvbmcpdXNlZCA8PCBjbWEtPm9yZGVyX3Blcl9iaXQ7DQoNCklzIHRoZSAodW5zaWduZWQgbG9u ZykgY2FzdCBuZWVkZWQ/DQpObyBuZWVkIGhlcmUuDQoNCg0KDQoNCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fDQq3orz+yMs6IEFuZHJldyBNb3J0b24gPGFrcG1AbGludXgtZm91bmRh dGlvbi5vcmc+DQq3osvNyrG85DogMjAyNMTqOdTCMjXI1SA4OjI3OjE5DQrK1bz+yMs6IFhpYW5n IEdhbw0Ks63LzTogbGludXgtbW1Aa3ZhY2sub3JnOyBsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwu b3JnOyC438/oDQrW98ziOiBbRXh0ZXJuYWwgTWFpbF1SZTogW1BBVENIXSBtbS9jbWEuYzogVG8g YmV0dGVyIHVuZGVyc3RhbmQgY21hIGFyZWEgZHVyaW5nIGRlYnVnZ2luZywgYWRkIHRvdGFsIGFu ZCB1c2VkIGNvdW50IGxvZ3MgdG8gaW4gY21hX2FsbG9jDQoNClvN4rK/08q8/l0gtMvTyrz+wLTU tNPa0KHD17mry77N4rK/o6zH6733yfe0psDtoaPI9LbU08q8/rCyyKvQ1LTm0smjrMfrvavTyrz+ 16q3orj4bWlzZWNAeGlhb21pLmNvbb340NC3tMChDQoNCk9uIFdlZCwgMTggU2VwIDIwMjQgMjA6 NDM6MjUgKzA4MDAgWGlhbmcgR2FvIDxneHhhMDMwNzAzMDdAZ21haWwuY29tPiB3cm90ZToNCg0K PiBGcm9tOiBnYW94aWFuZzE3IDxnYW94aWFuZzE3QHhpYW9taS5jb20+DQo+DQo+IFsgICAyNC4y MjUxMjVdIGNtYTogY21hX2FsbG9jKGNtYSAoX19fX3B0cnZhbF9fX18pLCBuYW1lOiByZXNlcnZl ZCwgdG90YWwgY291bnQgMTYzODQsIHVzZWQgY291bnQ6IDY0LCByZXF1ZXN0IGNvdW50IDEsIGFs aWduIDApDQo+IFsgICAyNC4yMzE5NjNdIGNtYTogY21hX2FsbG9jKGNtYSAoX19fX3B0cnZhbF9f X18pLCBuYW1lOiByZXNlcnZlZCwgdG90YWwgY291bnQgMTYzODQsIHVzZWQgY291bnQ6IDY1LCBy ZXF1ZXN0IGNvdW50IDEsIGFsaWduIDApDQo+IFsgICAyNC4yMzU3MTJdIGNtYTogY21hX2FsbG9j KGNtYSAoX19fX3B0cnZhbF9fX18pLCBuYW1lOiByZXNlcnZlZCwgdG90YWwgY291bnQgMTYzODQs IHVzZWQgY291bnQ6IDY2LCByZXF1ZXN0IGNvdW50IDEsIGFsaWduIDApDQo+DQoNClByb3ZpZGlu ZyBiZWZvcmUtYW5kLWFmdGVyIG91dHB1dCB3b3VsZCBtYWtlIHRoZSBwcm9wb3NhbCBtb3JlIGVh c2lseQ0KdW5kZXJzdG9vZC4NCg0KPiAtLS0gYS9tbS9jbWEuYw0KPiArKysgYi9tbS9jbWEuYw0K PiBAQCAtNDAzLDYgKzQwMywxNyBAQCBzdGF0aWMgdm9pZCBjbWFfZGVidWdfc2hvd19hcmVhcyhz dHJ1Y3QgY21hICpjbWEpDQo+ICAgICAgIHNwaW5fdW5sb2NrX2lycSgmY21hLT5sb2NrKTsNCj4g IH0NCj4NCj4gK3N0YXRpYyB1bnNpZ25lZCBsb25nIGNtYV9nZXRfdXNlZChzdHJ1Y3QgY21hICpj bWEpDQo+ICt7DQo+ICsgICAgIHVuc2lnbmVkIGxvbmcgdXNlZDsNCj4gKw0KPiArICAgICBzcGlu X2xvY2tfaXJxKCZjbWEtPmxvY2spOw0KPiArICAgICB1c2VkID0gYml0bWFwX3dlaWdodChjbWEt PmJpdG1hcCwgKGludCljbWFfYml0bWFwX21heG5vKGNtYSkpOw0KDQpJcyB0aGUgKGludCkgY2Fz dCBuZWVkZWQ/DQoNCj4gKyAgICAgc3Bpbl91bmxvY2tfaXJxKCZjbWEtPmxvY2spOw0KPiArDQo+ ICsgICAgIHJldHVybiAodW5zaWduZWQgbG9uZyl1c2VkIDw8IGNtYS0+b3JkZXJfcGVyX2JpdDsN Cg0KSXMgdGhlICh1bnNpZ25lZCBsb25nKSBiYXN0IG5lZWRlZD8NCg0KPiArfQ0KPiArDQo+ICAv KioNCj4gICAqIGNtYV9hbGxvYygpIC0gYWxsb2NhdGUgcGFnZXMgZnJvbSBjb250aWd1b3VzIGFy ZWENCj4gICAqIEBjbWE6ICAgQ29udGlndW91cyBtZW1vcnkgcmVnaW9uIGZvciB3aGljaCB0aGUg YWxsb2NhdGlvbiBpcyBwZXJmb3JtZWQuDQo+IEBAIC00MzAsOCArNDQxLDggQEAgc3RydWN0IHBh Z2UgKmNtYV9hbGxvYyhzdHJ1Y3QgY21hICpjbWEsIHVuc2lnbmVkIGxvbmcgY291bnQsDQo+ICAg ICAgIGlmICghY21hIHx8ICFjbWEtPmNvdW50IHx8ICFjbWEtPmJpdG1hcCkNCj4gICAgICAgICAg ICAgICByZXR1cm4gcGFnZTsNCj4NCj4gLSAgICAgcHJfZGVidWcoIiVzKGNtYSAlcCwgbmFtZTog JXMsIGNvdW50ICVsdSwgYWxpZ24gJWQpXG4iLCBfX2Z1bmNfXywNCj4gLSAgICAgICAgICAgICAo dm9pZCAqKWNtYSwgY21hLT5uYW1lLCBjb3VudCwgYWxpZ24pOw0KPiArICAgICBwcl9kZWJ1Zygi JXMoY21hICVwLCBuYW1lOiAlcywgdG90YWwgY291bnQgJWx1LCB1c2VkIGNvdW50OiAlbHUsIHJl cXVlc3QgY291bnQgJWx1LCBhbGlnbiAlZClcbiIsIF9fZnVuY19fLA0KPiArICAgICAgICAgICAg ICh2b2lkICopY21hLCBjbWEtPm5hbWUsIGNtYS0+Y291bnQsIGNtYV9nZXRfdXNlZChjbWEpLCBj b3VudCwgYWxpZ24pOw0KPg0KPiAgICAgICBpZiAoIWNvdW50KQ0KPiAgICAgICAgICAgICAgIHJl dHVybiBwYWdlOw0KPiAtLQ0KPiAyLjM0LjENCiMvKioqKioqsb7Tyrz+vLDG5Li9vP66rNPQ0KHD 17mry761xLGjw9zQxc+io6y99s/e09q3osvNuPjJz8PmtdjWt9bQwdCz9rXEuPbIy7vyyLrX6aGj vfvWucjOus7G5Mv7yMvS1MjOus7Qzsq9yrnTw6OosPzAqLWrsrvP3tPayKuyv7vysr+31rXY0LnC tqGiuLTWxqGiu/LJoreio6mxvtPKvP7W0LXE0MXPoqGjyOe5+8T6tO3K1cHLsb7Tyrz+o6zH68T6 waK8tLXnu7C78tPKvP7NqNaqt6K8/sjLsqLJvrP9sb7Tyrz+o6EgVGhpcyBlLW1haWwgYW5kIGl0 cyBhdHRhY2htZW50cyBjb250YWluIGNvbmZpZGVudGlhbCBpbmZvcm1hdGlvbiBmcm9tIFhJQU9N SSwgd2hpY2ggaXMgaW50ZW5kZWQgb25seSBmb3IgdGhlIHBlcnNvbiBvciBlbnRpdHkgd2hvc2Ug YWRkcmVzcyBpcyBsaXN0ZWQgYWJvdmUuIEFueSB1c2Ugb2YgdGhlIGluZm9ybWF0aW9uIGNvbnRh aW5lZCBoZXJlaW4gaW4gYW55IHdheSAoaW5jbHVkaW5nLCBidXQgbm90IGxpbWl0ZWQgdG8sIHRv dGFsIG9yIHBhcnRpYWwgZGlzY2xvc3VyZSwgcmVwcm9kdWN0aW9uLCBvciBkaXNzZW1pbmF0aW9u KSBieSBwZXJzb25zIG90aGVyIHRoYW4gdGhlIGludGVuZGVkIHJlY2lwaWVudChzKSBpcyBwcm9o aWJpdGVkLiBJZiB5b3UgcmVjZWl2ZSB0aGlzIGUtbWFpbCBpbiBlcnJvciwgcGxlYXNlIG5vdGlm eSB0aGUgc2VuZGVyIGJ5IHBob25lIG9yIGVtYWlsIGltbWVkaWF0ZWx5IGFuZCBkZWxldGUgaXQh KioqKioqLyMNCg== --_000_fc8822dd647c4aafbb72a83f5f57c6f1xiaomicom_ Content-Type: text/html; charset="gb2312" Content-Transfer-Encoding: quoted-printable

> [   = 24.225125] cma: cma_alloc(cma (____ptrval____), name: reserved, total count= 16384, used count: 64, request count 1, align 0)
> [   24.= 231963] cma: cma_alloc(cma (____ptrval____), name: reserved, total count 16= 384, used count: 65, request count 1, align 0)
> [   24.= 235712] cma: cma_alloc(cma (____ptrval____), name: reserved, total count 16= 384, used count: 66, request count 1, align 0)
>


Above is the cma alloc during boot. The before-and-after context has nothing to do with cma alloc. Below is the log with before-and-after context added.


[   24.006605] Serial: 8250/16550 driver, 4 ports, IRQ shari= ng enabled
[   24.071644] Serial: AMBA driver
[   24.096063] arm-smmu-v3 9050000.smmuv3: ias 44-bit, oas 4= 4-bit (features 0x00000305)
[   24.097989] cma: cma_alloc(cma (____ptrval____), name: re= served, total count 16384, used count: 64, request count 1, align 0)
[   24.104260] cma: cma_alloc(cma (____ptrval____), name: re= served, total count 16384, used count: 65, request count 1, align 0)
[   24.107504] cma: cma_alloc(cma (____ptrval____), name: re= served, total count 16384, used count: 66, request count 1, align 0)
[   24.140495] cacheinfo: Unable to detect cache hierarchy f= or CPU 0
[   24.484998] loop: module loaded
[   24.536152] virtio_blk virtio0: [vda] 4194304 512-byte lo= gical blocks (2.15 GB/2.00 GiB)


> --- a/mm/cma.c=
> +++ b= /mm/cma.c
> @@ -403,6 +40= 3,17 @@ static void cma_debug_show_areas(struct cma *cma)
>   =     spin_unlock_irq(&cma->lock);
>  } >
> +static unsig= ned long cma_get_used(struct cma *cma)
> +{
> +  =    unsigned long used;
> +
> +  =    spin_lock_irq(&cma->lock);
> +  =    used =3D bitmap_weight(cma->bitmap, (int)cma_bitmap_maxno(c= ma));

Is the (int) cast need= ed?
No need here.

> +  =    spin_unlock_irq(&cma->lock);
> +
> +  =    return (unsigned long)used << cma->order_per_bit;

Is the (unsigned long)= cast needed?
No need here.



=B7=A2=BC=FE=C8=CB: Andre= w Morton <akpm@linux-foundation.org>
=B7=A2=CB=CD=CA=B1=BC=E4: 2024=C4=EA9=D4=C225=C8=D5 8:27:19
=CA=D5=BC=FE=C8=CB: Xiang Gao
=B3=AD=CB=CD: linux-mm@kvack.org; linux-kernel@vger.kernel.org; =B8= =DF=CF=E8
=D6=F7=CC=E2: [External Mail]Re: [PATCH] mm/cma.c: To better underst= and cma area during debugging, add total and used count logs to in cma_allo= c
 
[=CD=E2=B2=BF=D3=CA=BC=FE] =B4=CB=D3=CA=BC=FE=C0= =B4=D4=B4=D3=DA=D0=A1=C3=D7=B9=AB=CB=BE=CD=E2=B2=BF=A3=AC=C7=EB=BD=F7=C9=F7= =B4=A6=C0=ED=A1=A3=C8=F4=B6=D4=D3=CA=BC=FE=B0=B2=C8=AB=D0=D4=B4=E6=D2=C9=A3= =AC=C7=EB=BD=AB=D3=CA=BC=FE=D7=AA=B7=A2=B8=F8misec@xiaomi.com=BD=F8=D0=D0= =B7=B4=C0=A1

On Wed, 18 Sep 2024 20:43:25 +0800 Xiang Gao <gxxa03070307@gmail.com= > wrote:

> From: gaoxiang17 <gaoxiang17@xiaomi.com>
>
> [   24.225125] cma: cma_alloc(cma (____ptrval____), name: re= served, total count 16384, used count: 64, request count 1, align 0)
> [   24.231963] cma: cma_alloc(cma (____ptrval____), name: re= served, total count 16384, used count: 65, request count 1, align 0)
> [   24.235712] cma: cma_alloc(cma (____ptrval____), name: re= served, total count 16384, used count: 66, request count 1, align 0)
>

Providing before-and-after output would make the proposal more easily
understood.

> --- a/mm/cma.c
> +++ b/mm/cma.c
> @@ -403,6 +403,17 @@ static void cma_debug_show_areas(struct cma *= cma)
>       spin_unlock_irq(&cma->lock)= ;
>  }
>
> +static unsigned long cma_get_used(struct cma *cma)
> +{
> +     unsigned long used;
> +
> +     spin_lock_irq(&cma->lock);
> +     used =3D bitmap_weight(cma->bitmap, (= int)cma_bitmap_maxno(cma));

Is the (int) cast needed?

> +     spin_unlock_irq(&cma->lock);
> +
> +     return (unsigned long)used << cma-= >order_per_bit;

Is the (unsigned long) bast needed?

> +}
> +
>  /**
>   * cma_alloc() - allocate pages from contiguous area
>   * @cma:   Contiguous memory region for which the= allocation is performed.
> @@ -430,8 +441,8 @@ struct page *cma_alloc(struct cma *cma, unsign= ed long count,
>       if (!cma || !cma->count || !cma= ->bitmap)
>            = ;   return page;
>
> -     pr_debug("%s(cma %p, name: %s, count %l= u, align %d)\n", __func__,
> -           &nb= sp; (void *)cma, cma->name, count, align);
> +     pr_debug("%s(cma %p, name: %s, tota= l count %lu, used count: %lu, request count %lu, align %d)\n", __func_= _,
> +           = ;  (void *)cma, cma->name, cma->count, cma_get_used(cma), count,= align);
>
>       if (!count)
>            = ;   return page;
> --
> 2.34.1
#/******=B1=BE=D3=CA=BC=FE=BC=B0=C6=E4=B8=BD=BC=FE=BA=AC=D3= =D0=D0=A1=C3=D7=B9=AB=CB=BE=B5=C4=B1=A3=C3=DC=D0=C5=CF=A2=A3=AC=BD=F6=CF=DE= =D3=DA=B7=A2=CB=CD=B8=F8=C9=CF=C3=E6=B5=D8=D6=B7=D6=D0=C1=D0=B3=F6=B5=C4=B8= =F6=C8=CB=BB=F2=C8=BA=D7=E9=A1=A3=BD=FB=D6=B9=C8=CE=BA=CE=C6=E4=CB=FB=C8=CB= =D2=D4=C8=CE=BA=CE=D0=CE=CA=BD=CA=B9=D3=C3=A3=A8=B0=FC=C0=A8=B5=AB=B2=BB=CF= =DE=D3=DA=C8=AB=B2=BF=BB=F2=B2=BF=B7=D6=B5=D8=D0=B9=C2=B6=A1=A2=B8=B4=D6=C6= =A1=A2=BB=F2=C9=A2=B7=A2=A3=A9=B1=BE=D3=CA=BC=FE=D6=D0=B5=C4=D0=C5=CF=A2=A1= =A3=C8=E7=B9=FB=C4=FA=B4=ED=CA=D5=C1=CB=B1=BE=D3=CA=BC=FE=A3=AC=C7=EB=C4=FA= =C1=A2=BC=B4=B5=E7=BB=B0=BB=F2=D3=CA=BC=FE=CD=A8=D6=AA=B7=A2=BC=FE=C8=CB=B2= =A2=C9=BE=B3=FD=B1=BE=D3=CA=BC=FE=A3=A1 This e-mail and its attachments con= tain confidential information from XIAOMI, which is intended only for the p= erson or entity whose address is listed above. Any use of the information contained= herein in any way (including, but not limited to, total or partial disclos= ure, reproduction, or dissemination) by persons other than the intended rec= ipient(s) is prohibited. If you receive this e-mail in error, please notify the sender by phone or email i= mmediately and delete it!******/# --_000_fc8822dd647c4aafbb72a83f5f57c6f1xiaomicom_--