From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB75FC433EF for ; Tue, 7 Jun 2022 12:55:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7B8718D000C; Tue, 7 Jun 2022 08:55:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7676B8D0003; Tue, 7 Jun 2022 08:55:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 608778D000C; Tue, 7 Jun 2022 08:55:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 50EAE8D0003 for ; Tue, 7 Jun 2022 08:55:16 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 2222434333 for ; Tue, 7 Jun 2022 12:55:16 +0000 (UTC) X-FDA: 79551435432.16.65BDFBC Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf27.hostedemail.com (Postfix) with ESMTP id E2BAC4001D for ; Tue, 7 Jun 2022 12:55:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1654606514; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5RVe0C3aiNOz3oukHUGPNmLDRkCuls8RKalvV3ngHRA=; b=KtgiTA3UuuxpgGVXdwM/f0J2AAZrFRUy49DTrk2dyELY3KyZg5JG2qMYmhZZARQVdbr4kv 7/iwhpm67/zYjMWIgzrL4ZlDmVn/pqfTZAJFmbDzJRG36vRICGIp84ziAikOlCwI5DJXU3 KIAlPveZXy1NZ37jA2qT67YQCA7sEaI= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-357-4yG4ENbBPr2Wc7tRXLWdzA-1; Tue, 07 Jun 2022 08:55:13 -0400 X-MC-Unique: 4yG4ENbBPr2Wc7tRXLWdzA-1 Received: by mail-wm1-f71.google.com with SMTP id u12-20020a05600c19cc00b0038ec265155fso12735598wmq.6 for ; Tue, 07 Jun 2022 05:55:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=5RVe0C3aiNOz3oukHUGPNmLDRkCuls8RKalvV3ngHRA=; b=CPNHkUfaWsYWrfk4pG2wp0k0w0Q7RkydNxpNUWG0yGapPYTkWV+YNjsIbVtBwBXzJr vIHkMIOmfUqCzuG4y7lB8luc2iIV10MDCEq/R21xDJalZSIazLQovxAb2U7GELM0ywb6 Vv8QL74jkybZh5F7R6gruwuHV7mt9hILWhpjy6jk66/CqrFNNZrQN6asOoPwPt2Y6MjC +kJoRTJXLqLgNc6wqGK/X+Ewgqs00DMg1UxO4eapBn8SgsZg1yoqXbH2PdN2jyYA1f8N c8hRmJ+3Cti63Tnj7E+i9ouFqKjBDlroaqk5t2mFkBGHpz13iC+Gl4dMxJq6/Wz7v7S9 V9zg== X-Gm-Message-State: AOAM531kaBS9GG9lFeONFQZ8d+ZxBLTENqXzAKFb+AjcECT/O5QMOJuF DpbG6CI20waZ+eegchs0Bxj97JjqdeCHEixMVedFQ3vpu/EbEjxyrz+gfasgCqonuwVmM7rdJTi DRcSk0Zpz8V8= X-Received: by 2002:a05:6000:1869:b0:211:7f25:89da with SMTP id d9-20020a056000186900b002117f2589damr27583433wri.696.1654606512504; Tue, 07 Jun 2022 05:55:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzbWFPyRplg1fzsNFrxr12dVS/TCLObe8BDTTUd8jCGAm7C/o75+Wu8cxSIdVKTvYrcl5Ga5w== X-Received: by 2002:a05:6000:1869:b0:211:7f25:89da with SMTP id d9-20020a056000186900b002117f2589damr27583405wri.696.1654606512140; Tue, 07 Jun 2022 05:55:12 -0700 (PDT) Received: from ?IPV6:2003:cb:c709:500:4c8d:4886:f874:7b6f? (p200300cbc70905004c8d4886f8747b6f.dip0.t-ipconnect.de. [2003:cb:c709:500:4c8d:4886:f874:7b6f]) by smtp.gmail.com with ESMTPSA id w11-20020a05600018cb00b0020d0435c97bsm18212989wrq.92.2022.06.07.05.55.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Jun 2022 05:55:11 -0700 (PDT) Message-ID: Date: Tue, 7 Jun 2022 14:55:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH] mm: add a new emergency page migratetype. To: Huanpeng Xin , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, xinhuanpeng References: <20220606032709.11800-1-xinhuanpeng9@gmail.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220606032709.11800-1-xinhuanpeng9@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: E2BAC4001D X-Stat-Signature: 11ronpzg4nmhaf11eyxgbke4yk3jt1nc X-Rspam-User: Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=KtgiTA3U; spf=none (imf27.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam08 X-HE-Tag: 1654606510-431949 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 06.06.22 05:27, Huanpeng Xin wrote: > From: xinhuanpeng > > add a new page migratetype reserved for > non-costly non-NOWARN page allocation failure. Sorry to say, but this patch description is not expressive enough. I have absolutely no clue what you are trying to achieve and why we should care. Especially, why do we care about locally grouping these allocations (that's what pageblock flags are for after all)? Your Kconfig option is also not particularly user friendly to read either: "This enables the migration type MIGRATE_EMERGENCY,which reserves a small amount of memory for non-costly non-NOWARN page allocation failure." Usually we reserve memory via different mechanisms, like atomic reserves? Why can't something like that be used. On first sight, defining a new pageblock migratype feels wrong to me. But then, I have no clue what you are actually trying to achieve. -- Thanks, David / dhildenb