From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86670E77180 for ; Sat, 14 Dec 2024 15:32:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D95DC6B0085; Sat, 14 Dec 2024 10:32:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D45C86B0088; Sat, 14 Dec 2024 10:32:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B97546B0089; Sat, 14 Dec 2024 10:32:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 9DB2C6B0085 for ; Sat, 14 Dec 2024 10:32:10 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 0BA00122383 for ; Sat, 14 Dec 2024 15:32:10 +0000 (UTC) X-FDA: 82893954360.08.78EC8FD Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf29.hostedemail.com (Postfix) with ESMTP id A0E60120014 for ; Sat, 14 Dec 2024 15:31:29 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NQdmOI29; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734190314; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=03N6Z6LVTWl2BXm3uGhmS6liuy/PRc0F/lQH4ag9wfQ=; b=R4HScP4NZwefBQtoThDv67ionvY1w564tQjh/uvgNnqWOJFRKm9W8wHr7o7Qs1HjR/7vTC QTAzeNJi8Vpjm+XfledKnzAOs5FH8QQImCp2gENADnQsOrfMr7ZHRGyi4hYJRTLy1qpnaW YsBmDHbzgDU7BkFgYsHguvWyBX7ziGY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734190314; a=rsa-sha256; cv=none; b=Nxe7P9/ToNKapptTvMk+LFR91nGlQTXfC6Hr1X0sMNGhGdfxZL+jDrmT8VdM/0CMVQWePS KnF1kso47l7tTkN65onQpdjnzZED3SYrJ1eLSBkAtXHAlsIu79tGsZJwwgc3/z/X7H5UEG AY9nwXl8So3lvNHdV+dUUR7zHx1ZOek= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NQdmOI29; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1734190326; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=03N6Z6LVTWl2BXm3uGhmS6liuy/PRc0F/lQH4ag9wfQ=; b=NQdmOI29k4VzgE6FvkFv9l5K23SWw4tcMoxTcElILiK4nS+1urVQItGv7u1WlMSfUv+8TK 2o4ZIMD3Jq0sUdE9wOg3oTrdgbTQ5clC9l1dkASyLj2YLZ9rrWQE0jf8jxRlPX+kWyokZg Iv689c8xnbSpU4MEnuXjAwlZ2EgwTx8= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-356-J5w2lRt1NLinwiLv9yZUGA-1; Sat, 14 Dec 2024 10:32:05 -0500 X-MC-Unique: J5w2lRt1NLinwiLv9yZUGA-1 X-Mimecast-MFC-AGG-ID: J5w2lRt1NLinwiLv9yZUGA Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-385dc37cb3eso1546486f8f.0 for ; Sat, 14 Dec 2024 07:32:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734190324; x=1734795124; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=03N6Z6LVTWl2BXm3uGhmS6liuy/PRc0F/lQH4ag9wfQ=; b=G3LZpV/WfRLr7JucCb+4S3KMKvDA4YHSjpWV+UbuEoMMwH1gNC9gkLNW+IEhirH/4c F8hGvobZ0hTbGVN2XkV3NmQmwJym+05QknsJSBwmic7Y8l5/y4LZvGI4TJuKC54SVirK 6ilgGuMrzzN70FjUtL9TetTNc4o3WKN4KeiW7+PkKirLo1P5NrNoWE8WHNx9g/kJ13A0 IyX6E+KvT6XoJuPdQ6qwqtv0pc4lO9Lv6h1VayNDx/pBVar/JPayiKdk0wnbfPuUed1h yvFmN1YiMn15FGfXHvrKBaIWNwgmvzHyK0fIFo9h3AXXa1W7bt7Yii2MpWpzMTd3MOEu bKrQ== X-Forwarded-Encrypted: i=1; AJvYcCXYaygR+350sRRcaqnGD+0H0fTB6/eq3DPU2dHVSR+tl5dkBSqLOBvQFYzwVWPnBk8qxsEvZ8Hk8A==@kvack.org X-Gm-Message-State: AOJu0YxlA/kE5MTxZ5YJcUBVLwvx2Md2yvbzJmwr0D/IR40cC8F3v/3N 8d968A688D2HRPMTqpcywpBAtgdrEMVG0JcsbM8TkL66oiQAIoXss7TeKLu9/joAERyegfYxL7k IycVEBamth5MECvLsV1h3tcqEWrYPkmOqTxLq9JZV6aDoTjmt X-Gm-Gg: ASbGncsF3TMWY6HiO7QrmzSCXgIOpzjD37jYeI/Hvmkm/bXsMDTlcMz/IMbHUh2w19Y M2M60VZMY4z77p6oRvntJlqFH0WuwrAzWz17M/HFtY/yixvtSvNWiKw7RyFoshIvDG7Hc7sIMZ3 X/nznXLDI5BJ5JHNNRoBhruZobOb7DTkecKTBdku0dpS+Ahjy2HaSqMSghLp5QX2J9PlznHnERt sweJIRiiYuI2UcDBAOeLYqSzgrWD8ZNbR+0jla3DSpL1K1ba+Oqo06HcIdEbIr1CHtdUYNpfVaf ybO25t0iJHiz+3lvgFHQhYX5v++NGEQN+S8Hk1bm02Zx1tp3EKoeAsKrjNwifByRpGETl782tlo dz0JQRjvD X-Received: by 2002:a5d:64a7:0:b0:385:e9ca:4e18 with SMTP id ffacd0b85a97d-38880ac23d0mr5273153f8f.1.1734190323887; Sat, 14 Dec 2024 07:32:03 -0800 (PST) X-Google-Smtp-Source: AGHT+IGCAoXGEeWaw7IcCbVrauVtoSu57S5/3Q7OA9u+ckTPTWUXqMKHzSJmCciXfEjs+C07Qo9JLg== X-Received: by 2002:a5d:64a7:0:b0:385:e9ca:4e18 with SMTP id ffacd0b85a97d-38880ac23d0mr5273103f8f.1.1734190323507; Sat, 14 Dec 2024 07:32:03 -0800 (PST) Received: from ?IPV6:2003:cb:c711:6400:d1b9:21c5:b517:5f4e? (p200300cbc7116400d1b921c5b5175f4e.dip0.t-ipconnect.de. [2003:cb:c711:6400:d1b9:21c5:b517:5f4e]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-388c801211dsm2844150f8f.17.2024.12.14.07.32.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 14 Dec 2024 07:32:03 -0800 (PST) Message-ID: Date: Sat, 14 Dec 2024 16:32:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 14/25] huge_memory: Allow mappings of PUD sized pages To: Alistair Popple , dan.j.williams@intel.com, linux-mm@kvack.org Cc: lina@asahilina.net, zhang.lyra@gmail.com, gerald.schaefer@linux.ibm.com, vishal.l.verma@intel.com, dave.jiang@intel.com, logang@deltatee.com, bhelgaas@google.com, jack@suse.cz, jgg@ziepe.ca, catalin.marinas@arm.com, will@kernel.org, mpe@ellerman.id.au, npiggin@gmail.com, dave.hansen@linux.intel.com, ira.weiny@intel.com, willy@infradead.org, djwong@kernel.org, tytso@mit.edu, linmiaohe@huawei.com, peterx@redhat.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, jhubbard@nvidia.com, hch@lst.de, david@fromorbit.com References: From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: pMWq4UppHso3-fr5ZVCIn-JEjHaY30tnChEXmPTUsBs_1734190324 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: A0E60120014 X-Stat-Signature: ukxcxazgzhpqxzz557h7mupujikawqqg X-Rspam-User: X-HE-Tag: 1734190289-490453 X-HE-Meta: U2FsdGVkX1+nN386HXAqNq0V5eNx1MAoYOVqbuApKvM8jjQClsbVNikvjUbukmE2uBqNAlwpMn/23gNyu4U017Yjah+2XGKBmfiCUCsGT4hQ0Ik4XghvCX1PiDSB+ehBlu6H4Z1UKzpVJg8+u7fljbZgjrk8h34CATm4WNxdZB5RjeSd+oQew6cyRrxpCIUpCSMLItUZz8QIb8bn77CnfF1nNWKw32Jof1n9K0fEBWSFRIz1L3RoIpPKMMnXWBGk8htuGH2ZRpLmMMjD8gvKUsnAzPF6NL1xXOzwxUDtFfYwj6ziJLG/g5fC/vtyZWEzcDUoq3iD22QGLhedDzz2Juk0tzN3GKi1AFqSBBT/AyfXsoUFAihd7mbbiEy3mL/3pNizoPr0/bQJ9LAAhUAuolVbKy9CrQ/N6YURpWdHA3BJ6sBRRzt7GXs+MaHfqFJfft+VfniHG7MhYWshn3uNR20hPn8RvsVifxxmiuclc4piC+kwS1kEl39cFlaftPku5k/4qvbkNpz0e0JEFlqBfg13NPibgCOkiPegwIe3SSmQjpRjaa7CjqJnP3cqAycyaOFzVBh+KQSJ+L+Np0TnytTmVY76C53lUzhpMBHAWrw0IHmbE1zZFom1fiLg/Ytrjf+tff0qZABLbE18l88MqoFnJkzhym3Qr60fGy3gZC+Bqa5JuCZwE8FyGzptq/6Jm0m+btUJhImf/L71k72tSdoakBS4tzqnEInsQ2uXL37X4P1BBoKkIUwQCCuInIfJ6zoiTnjoXt/Ph7VhmhEXMIXubSCpqQKRLPvcqr5fqFowjfikauPbzaCV2B3ZX1tYGvKVdqFLROc+RYSdDx9V8FeoAhev/9sr+mA1UAm1glLmsIvF2lvcbmByDI5qWE8RcD946XAZ5JA+cKDHYV7eqn2GUrbUCWw1Fj9BFQ4hTwvxBaquf/BU4uJ1TyHLkayKoaO4b59yQZECXKmwh7k G/vbVpOv KOLIAZlYdM89wwRNEawDZJN/JRc4hl7qpqJxaYFYLQBxz3YIJpthZsC5KHtnbMHgnywnEDQMEgHKmr+ki2kN6lGPZpQCzceSL/cYLGgODOdcO10rEgRmyiEMLeo/LECk6kbl1p7t6NJNlW1jgjso371pqR5qIuK/iqf5MvIcZRRJ5c0SXlQP9M6KQoOUf8b1KqcpR7OcSD+jPBcHcmRjSgvDQQY+5d/S85sOdCvrDi7MbLYfvNrynYGD89cclu/WSZbAFFOrdmag17s22BBj9Vkj08GxOt/2t1lZMa9yELLK68lKhgi+9k0dj4JFAewSdrsjXaK0cLJQ38EDC8CAXUpJWr5NSmPcp0whtFfpakhy95dff7GaHubIA8/bLNJcD1i5Pl/Pkt3xqn9aS9W8BABHs8fSaSP4SVAcEFLr/kIbeHAHJIS1EcDgmAyKuL1gXLnjpEv5zuq7xrt6FKzLqebFZ2tT7uNWDcExOqFk92Lz/b38BCY9Zud1NPfS0tH/RzVVf3LSwxZxmj030bJLkCZ0BVqiRq6/K4D+HswfqJZU/vNvix4ceD+9uqCU9SNrUI8rirtC9MZkNRtg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.001125, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 22.11.24 02:40, Alistair Popple wrote: > Currently DAX folio/page reference counts are managed differently to > normal pages. To allow these to be managed the same as normal pages > introduce vmf_insert_folio_pud. This will map the entire PUD-sized folio > and take references as it would for a normally mapped page. > > This is distinct from the current mechanism, vmf_insert_pfn_pud, which > simply inserts a special devmap PUD entry into the page table without > holding a reference to the page for the mapping. > > Signed-off-by: Alistair Popple > --- Hi, The patch subject of this (and especially the next patch) is misleading. Likely you meant to have it as: "mm/huge_memory: add vmf_insert_folio_pud() for mapping PUD sized pages" > for (i = 0; i < nr_pages; i++) { > @@ -1523,6 +1531,26 @@ void folio_add_file_rmap_pmd(struct folio *folio, struct page *page, > #endif > } > > +/** > + * folio_add_file_rmap_pud - add a PUD mapping to a page range of a folio > + * @folio: The folio to add the mapping to > + * @page: The first page to add > + * @vma: The vm area in which the mapping is added > + * > + * The page range of the folio is defined by [page, page + HPAGE_PUD_NR) > + * > + * The caller needs to hold the page table lock. > + */ > +void folio_add_file_rmap_pud(struct folio *folio, struct page *page, > + struct vm_area_struct *vma) > +{ > +#ifdef CONFIG_HAVE_ARCH_TRANSPARENT_HUGEPAGE_PUD > + __folio_add_file_rmap(folio, page, HPAGE_PUD_NR, vma, RMAP_LEVEL_PUD); > +#else > + WARN_ON_ONCE(true); > +#endif > +} > + > static __always_inline void __folio_remove_rmap(struct folio *folio, > struct page *page, int nr_pages, struct vm_area_struct *vma, > enum rmap_level level) > @@ -1552,6 +1580,7 @@ static __always_inline void __folio_remove_rmap(struct folio *folio, > partially_mapped = nr && atomic_read(mapped); > break; > case RMAP_LEVEL_PMD: > + case RMAP_LEVEL_PUD: > atomic_dec(&folio->_large_mapcount); > last = atomic_add_negative(-1, &folio->_entire_mapcount); > if (last) { If you simply reuse that code (here and on the adding path), you will end up effectively setting nr_pmdmapped to a very large value and passing that into __folio_mod_stat(). There, we will adjust NR_SHMEM_PMDMAPPED/NR_FILE_PMDMAPPED, which is wrong (it's PUD mapped ;) ). It's probably best to split out the rmap changes from the other things in this patch. -- Cheers, David / dhildenb