From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC714C433EF for ; Tue, 19 Apr 2022 16:57:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2519F6B0071; Tue, 19 Apr 2022 12:57:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2005B6B0072; Tue, 19 Apr 2022 12:57:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 07AA48D0001; Tue, 19 Apr 2022 12:57:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.25]) by kanga.kvack.org (Postfix) with ESMTP id EBF266B0071 for ; Tue, 19 Apr 2022 12:57:21 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id B45E020CA9 for ; Tue, 19 Apr 2022 16:57:21 +0000 (UTC) X-FDA: 79374234282.01.C501342 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf12.hostedemail.com (Postfix) with ESMTP id 6709A4000A for ; Tue, 19 Apr 2022 16:57:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1650387440; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5ZJkSy0snYmZQYcdUUa6S5DK0dg8RNx6ZqzPz1gftNw=; b=a1BYWQR7rPTV+i2Fkhv/ipyn7Ov8tz2r/rShm6/Fz6qEp1VTdpRXPOlqI71nKeeRogG5eR z09qyF4/d7JgjdBM3vXBKINLjV2IC18WSPeoPw8XDAE2nBRA9t4PmnaL33NYrbYjNYxqHU nLrT4LY33lvyw8SosyW16dOtsn4nA2U= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-461-8GBUTEriPKiA2huuLNoCfg-1; Tue, 19 Apr 2022 12:57:19 -0400 X-MC-Unique: 8GBUTEriPKiA2huuLNoCfg-1 Received: by mail-wm1-f72.google.com with SMTP id c125-20020a1c3583000000b0038e3f6e871aso9542045wma.8 for ; Tue, 19 Apr 2022 09:57:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=5ZJkSy0snYmZQYcdUUa6S5DK0dg8RNx6ZqzPz1gftNw=; b=lJuOv6rSlET/bZBCxMoTQOfR9Jd9lAC6fjLLFxZWAsKMx3qh2ivxNLBW5O6sN7MI9+ 1q+gtEiJtUeD4mO6yrQqVp961vtEecp7S8RGuWbrp/TLs/4yhI2lLzs5erWtlNOpRR4Z 9LjSgoM269DXrRIa3SLqvkIMf6k8UoHABFa+weE7thtISdPuNdKymcPckHdqJGACsrtA AMd0jg73i70blblqBzLG+aI4czdv0KDsO2czF7lCR4cAL0+VOarAPwDB/pdjjn0xcOpl nVFkPAlBeXoopsFWK8zz6U2d7Yi7RJML+pYRAD7UCRjkwCWemib3bk+qwKPTh6Z7C8vX fzsw== X-Gm-Message-State: AOAM530BEgb14s6qrA6ovMFLyBpwAHM3LzBeHmTubagzx4BSBmSEru52 wDFhJ/VoAG9GLl49tkq8VUi32qtb/neBL27NaNFuHGr/edc23dRO+1FinV7TE5b6/mlHjnthXGZ endux+1gQ838= X-Received: by 2002:a5d:64e7:0:b0:20a:a5e7:7bb9 with SMTP id g7-20020a5d64e7000000b0020aa5e77bb9mr3628630wri.602.1650387438354; Tue, 19 Apr 2022 09:57:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzAV9fdedIcGeuV2Sqhw1e79/2vn/6x1RS1YayTk1NHOIQXEZD6gNhkoNR/6wpyP8giNy9qtA== X-Received: by 2002:a5d:64e7:0:b0:20a:a5e7:7bb9 with SMTP id g7-20020a5d64e7000000b0020aa5e77bb9mr3628621wri.602.1650387438105; Tue, 19 Apr 2022 09:57:18 -0700 (PDT) Received: from ?IPV6:2003:cb:c704:5d00:d8c2:fbf6:a608:957a? (p200300cbc7045d00d8c2fbf6a608957a.dip0.t-ipconnect.de. [2003:cb:c704:5d00:d8c2:fbf6:a608:957a]) by smtp.gmail.com with ESMTPSA id a9-20020a7bc1c9000000b0038eb67e966esm15963513wmj.29.2022.04.19.09.57.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 Apr 2022 09:57:17 -0700 (PDT) Message-ID: Date: Tue, 19 Apr 2022 18:57:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH] mm: do not call add_nr_deferred() with zero deferred To: Roman Gushchin Cc: linux-mm@kvack.org, Andrew Morton , Dave Chinner , linux-kernel@vger.kernel.org, Johannes Weiner , Michal Hocko , Shakeel Butt , Yang Shi References: <20220416004104.4089743-1-roman.gushchin@linux.dev> <59404249-de0c-c569-d04a-9da38ed14b0a@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 6709A4000A X-Rspam-User: Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=a1BYWQR7; spf=none (imf12.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Stat-Signature: rejqiwauu1q7hhbf4pp9zodbxphc5a7k X-HE-Tag: 1650387439-422964 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 19.04.22 18:42, Roman Gushchin wrote: > On Tue, Apr 19, 2022 at 02:56:06PM +0200, David Hildenbrand wrote: >> On 16.04.22 02:41, Roman Gushchin wrote: >>> add_nr_deferred() is often called with next_deferred equal to 0. >>> For instance, it's happening under low memory pressure for any >>> shrinkers with a low number of cached objects. A corresponding trace >>> looks like: >>> <...>-619914 [005] .... 467456.345160: mm_shrink_slab_end: \ >>> super_cache_scan+0x0/0x1a0 0000000087027f06: nid: 1 \ >>> unused scan count 0 new scan count 0 total_scan 0 \ >>> last shrinker return val 0 >>> >>> <...>-619914 [005] .... 467456.345371: mm_shrink_slab_end: \ >>> super_cache_scan+0x0/0x1a0 0000000087027f06: nid: 1 \ >>> unused scan count 0 new scan count 0 total_scan 0 \ >>> last shrinker return val 0 >>> >>> <...>-619914 [005] .... 467456.345380: mm_shrink_slab_end: \ >>> super_cache_scan+0x0/0x1a0 0000000087027f06: nid: 1 unused \ >>> scan count 0 new scan count 0 total_scan 0 \ >>> last shrinker return val 0 >>> >>> This lead to unnecessary checks and atomic operations, which can be >>> avoided by checking next_deferred for not being zero before calling >>> add_nr_deferred(). In this case the mm_shrink_slab_end trace point >>> will get a potentially slightly outdated "new scan count" value, but >>> it's totally fine. >> >> Sufficient improvement to justify added complexity for anybody reading >> that code? > > I don't have any numbers and really doubt the difference is significant, > however the added complexity is also small: one "if" statement. > Anyway, if you feel strongly against this change, I'm fine with dropping it. > No strong opinion, naturally, more conditions make the code harder to read -- that's why I'm asking. >> >>> >>> Signed-off-by: Roman Gushchin >>> --- >>> mm/vmscan.c | 5 ++++- >>> 1 file changed, 4 insertions(+), 1 deletion(-) >>> >>> diff --git a/mm/vmscan.c b/mm/vmscan.c >>> index d4a7d2bd276d..19d3d4fa1aad 100644 >>> --- a/mm/vmscan.c >>> +++ b/mm/vmscan.c >>> @@ -808,7 +808,10 @@ static unsigned long do_shrink_slab(struct shrink_control *shrinkctl, >>> * move the unused scan count back into the shrinker in a >>> * manner that handles concurrent updates. >>> */ >>> - new_nr = add_nr_deferred(next_deferred, shrinker, shrinkctl); >>> + if (next_deferred) >>> + new_nr = add_nr_deferred(next_deferred, shrinker, shrinkctl); >>> + else >>> + new_nr = nr; >>> >>> trace_mm_shrink_slab_end(shrinker, shrinkctl->nid, freed, nr, new_nr, total_scan); >>> return freed; >> >> And if we still want to do this optimization, why not put it into >> add_nr_deferred()? > > Because of the semantics of add_nr_deferred(), which returns the deferred value. > It's not used for anything except tracing, so maybe it's a place for another > change. Skimming over the code I somehow missed that add_nr_deferred() doesn't have "nr" naturally available. LGTM Acked-by: David Hildenbrand -- Thanks, David / dhildenb