From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=JVxk=ZL=kvack.org=owner-linux-mm@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1
	autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 39432C432C0
	for <linux-mm@archiver.kernel.org>; Tue, 19 Nov 2019 10:08:14 +0000 (UTC)
Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17])
	by mail.kernel.org (Postfix) with ESMTP id F36552230E
	for <linux-mm@archiver.kernel.org>; Tue, 19 Nov 2019 10:08:13 +0000 (UTC)
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F36552230E
Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.alibaba.com
Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org
Received: by kanga.kvack.org (Postfix)
	id 9FB8C6B0274; Tue, 19 Nov 2019 05:08:13 -0500 (EST)
Received: by kanga.kvack.org (Postfix, from userid 40)
	id 987026B0275; Tue, 19 Nov 2019 05:08:13 -0500 (EST)
X-Delivered-To: int-list-linux-mm@kvack.org
Received: by kanga.kvack.org (Postfix, from userid 63042)
	id 8742E6B0276; Tue, 19 Nov 2019 05:08:13 -0500 (EST)
X-Delivered-To: linux-mm@kvack.org
Received: from forelay.hostedemail.com (smtprelay0168.hostedemail.com [216.40.44.168])
	by kanga.kvack.org (Postfix) with ESMTP id 6D6DE6B0274
	for <linux-mm@kvack.org>; Tue, 19 Nov 2019 05:08:13 -0500 (EST)
Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251])
	by forelay02.hostedemail.com (Postfix) with SMTP id 454882DFA
	for <linux-mm@kvack.org>; Tue, 19 Nov 2019 10:08:13 +0000 (UTC)
X-FDA: 76172601666.26.color66_d73b47f07d55
X-HE-Tag: color66_d73b47f07d55
X-Filterd-Recvd-Size: 3628
Received: from out30-56.freemail.mail.aliyun.com (out30-56.freemail.mail.aliyun.com [115.124.30.56])
	by imf26.hostedemail.com (Postfix) with ESMTP
	for <linux-mm@kvack.org>; Tue, 19 Nov 2019 10:08:11 +0000 (UTC)
X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R481e4;CH=green;DM=||false|;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04423;MF=alex.shi@linux.alibaba.com;NM=1;PH=DS;RN=38;SR=0;TI=SMTPD_---0TiYQdSY_1574158084;
Received: from IT-FVFX43SYHV2H.local(mailfrom:alex.shi@linux.alibaba.com fp:SMTPD_---0TiYQdSY_1574158084)
          by smtp.aliyun-inc.com(127.0.0.1);
          Tue, 19 Nov 2019 18:08:05 +0800
Subject: Re: [PATCH v3 3/7] mm/lru: replace pgdat lru_lock with lruvec lock
To: Matthew Wilcox <willy@infradead.org>
Cc: Shakeel Butt <shakeelb@google.com>, Cgroups <cgroups@vger.kernel.org>,
 LKML <linux-kernel@vger.kernel.org>, Linux MM <linux-mm@kvack.org>,
 Andrew Morton <akpm@linux-foundation.org>,
 Mel Gorman <mgorman@techsingularity.net>, Tejun Heo <tj@kernel.org>,
 Hugh Dickins <hughd@google.com>,
 Konstantin Khlebnikov <khlebnikov@yandex-team.ru>,
 Daniel Jordan <daniel.m.jordan@oracle.com>,
 Yang Shi <yang.shi@linux.alibaba.com>, Johannes Weiner <hannes@cmpxchg.org>,
 Michal Hocko <mhocko@kernel.org>, Vladimir Davydov <vdavydov.dev@gmail.com>,
 Roman Gushchin <guro@fb.com>, Chris Down <chris@chrisdown.name>,
 Thomas Gleixner <tglx@linutronix.de>, Vlastimil Babka <vbabka@suse.cz>,
 Qian Cai <cai@lca.pw>, Andrey Ryabinin <aryabinin@virtuozzo.com>,
 "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
 =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= <jglisse@redhat.com>,
 Andrea Arcangeli <aarcange@redhat.com>, David Rientjes
 <rientjes@google.com>, "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>,
 swkhack <swkhack@gmail.com>, "Potyra, Stefan"
 <Stefan.Potyra@elektrobit.com>, Mike Rapoport <rppt@linux.vnet.ibm.com>,
 Stephen Rothwell <sfr@canb.auug.org.au>,
 Colin Ian King <colin.king@canonical.com>, Jason Gunthorpe <jgg@ziepe.ca>,
 Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
 Peng Fan <peng.fan@nxp.com>, Nikolay Borisov <nborisov@suse.com>,
 Ira Weiny <ira.weiny@intel.com>, Kirill Tkhai <ktkhai@virtuozzo.com>,
 Yafang Shao <laoar.shao@gmail.com>
References: <1573874106-23802-1-git-send-email-alex.shi@linux.alibaba.com>
 <1573874106-23802-4-git-send-email-alex.shi@linux.alibaba.com>
 <CALvZod7oUmUCk96ATrRwYvrROFNqL1gPGt7fy949M8TMwCQrWA@mail.gmail.com>
 <3f179d84-85e2-bace-2dbc-e77f73883c71@linux.alibaba.com>
 <20191118123138.GL20752@bombadil.infradead.org>
From: Alex Shi <alex.shi@linux.alibaba.com>
Message-ID: <fc4716ae-a49e-68f0-98da-9318ff1f4138@linux.alibaba.com>
Date: Tue, 19 Nov 2019 18:08:04 +0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:60.0)
 Gecko/20100101 Thunderbird/60.9.1
MIME-Version: 1.0
In-Reply-To: <20191118123138.GL20752@bombadil.infradead.org>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4
Sender: owner-linux-mm@kvack.org
Precedence: bulk
X-Loop: owner-majordomo@kvack.org
List-ID: <linux-mm.kvack.org>



=E5=9C=A8 2019/11/18 =E4=B8=8B=E5=8D=888:31, Matthew Wilcox =E5=86=99=E9=81=
=93:
>> Thanks for comments, Shakeel.
>>
>> lruvec lifetime is same as memcg, which allocted in mem_cgroup_alloc()=
->alloc_mem_cgroup_per_node_info()
>> I have read Hugh's patchset, even not every lines. But what's point of=
 you here?
> I believe Shakeel's point is that here:
>=20
> struct lruvec *mem_cgroup_page_lruvec(struct page *page, struct pglist_=
data *pgdat)
> {
> ...
>         memcg =3D page->mem_cgroup;
>=20
> there is nothing pinning the memcg, and it could be freed before
> dereferencing memcg->nodeinfo in mem_cgroup_page_nodeinfo().

That's right! I will send the fix patches for review.=20
Thanks a lot!