From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C53EC2BBCA for ; Tue, 25 Jun 2024 20:41:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CC67C6B0092; Tue, 25 Jun 2024 16:41:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C76176B0093; Tue, 25 Jun 2024 16:41:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AEF946B0095; Tue, 25 Jun 2024 16:41:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 91B146B0092 for ; Tue, 25 Jun 2024 16:41:18 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 49F461605E9 for ; Tue, 25 Jun 2024 20:41:18 +0000 (UTC) X-FDA: 82270581036.01.81CFF5F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf18.hostedemail.com (Postfix) with ESMTP id E5C2C1C0004 for ; Tue, 25 Jun 2024 20:41:15 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dAj4M7hm; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719348064; a=rsa-sha256; cv=none; b=tINfRJUgcmdpld1BzzG/kLoi6bguDQOHq8miwUFsrA3Ms3tWUs3ctP0AzAKpaCCeWPb3AR pNgeiDwCKVGwkisVmszdLxy5Te4kN5MPt+S4HH425Rhn2GaN2K9PVmhBeJE4dkTrgqE7ZJ ref2RMK3ZPRQOYppxq0lRu4vWacFzog= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dAj4M7hm; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719348064; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8o/LZltz2Srf/59+hcmhRn1Z8GI9CbfzhFVCfFTqJko=; b=KF6Tq2FPj24vDgzGMwoM83NRqEHIWxUEnb/6VqHM2shGShflgH62GIc9yvZwH5sU0dem+P mSWWKUiTp+BAHTZZEeDhl+lxCPrcssytjKQWqLOCez5EseKb8sBHPcpI6fOm4INUOmQIzT YL1o8M0IdwgjFF+xdB82UiPzw6538JM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1719348075; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=8o/LZltz2Srf/59+hcmhRn1Z8GI9CbfzhFVCfFTqJko=; b=dAj4M7hmkYT3MbYdHoeCx5Li6WJK7S21pzaSh6cOzGuNgNe9PUtJ744+VurznPOrXGB3I9 24qxOayATJlXgfcG5dXHa7Il7zeTF1gMRQb9J/mwsqRJsJLF4Zy/cGNzT+N0PQJwxPrz5g 4mRnsBCyVlZH0PEzWs5U5tnmuchiomk= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-572-kd367l1sOWGfLkMlPawySw-1; Tue, 25 Jun 2024 16:41:13 -0400 X-MC-Unique: kd367l1sOWGfLkMlPawySw-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3653f54d94eso2824316f8f.2 for ; Tue, 25 Jun 2024 13:41:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719348073; x=1719952873; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=8o/LZltz2Srf/59+hcmhRn1Z8GI9CbfzhFVCfFTqJko=; b=HsFl/4OgbkwbWaEHx15y7Nbd3yYRKA4SMpGRQpMU+nYrHx4BvXke3lQjhdvlEp6n1h Pri4YY7Pj4L0OG+S21CDUjAl0bUUwyKlydA83OQ4pbxa3v/byk/TNmgX2yth660V4FcY 53GiaX/it2s6Xp067tCrpKVZI6NJy1FW7gm+BQdYSNXz5GFrjLz0nvKNhxZPZ247arX4 mVWGviMKGBGAMh8REDuRkUd1yQ2NCf0AklaXU40C+7xwRoUkqlrc+dE0Dm7unTYc+xPy AL8MM1qAGRPjzhKJeIILQT42LJVA6Dl1m/HU2eedcFbS6snRqrvW2Rgi+28swE7UOZ60 2wyA== X-Forwarded-Encrypted: i=1; AJvYcCVdEzSMUnXm4t9fJY+l7yDQOSV9OJ8HElptNMj0eCkI3wm8+4IO2o1XcMqDWmSYPpCPcQPFkif3cHAXgVWv+Eju94k= X-Gm-Message-State: AOJu0YysvQTilL0hF2vOavz0dLdk7nIJuvP2YdBP3+zKw7ejtxYcQWUy wxc9gqS6nMHoNqLhB4UJukH/2uqrIDjQrT4J5x+YlVt/jbZupA1maCzXw8XsOZcIEQyv6doh8e+ 9LfEQz0aWEVKzXjljyb39gZ6q73Vt0vJiOXZeF6SqXEPXk6iO X-Received: by 2002:a5d:61c2:0:b0:35f:10a0:9b7 with SMTP id ffacd0b85a97d-366e95db2f1mr4875830f8f.46.1719348072787; Tue, 25 Jun 2024 13:41:12 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGPWXWs96hXpRVsd/M233FSA1Wm/ro0WOYYwz6ZNo6zROmWfLhjGHJalzTa8m7E6AVV00Dkcw== X-Received: by 2002:a5d:61c2:0:b0:35f:10a0:9b7 with SMTP id ffacd0b85a97d-366e95db2f1mr4875817f8f.46.1719348072290; Tue, 25 Jun 2024 13:41:12 -0700 (PDT) Received: from [192.168.1.34] (p548825e3.dip0.t-ipconnect.de. [84.136.37.227]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-424c823c28asm712865e9.5.2024.06.25.13.41.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Jun 2024 13:41:11 -0700 (PDT) Message-ID: Date: Tue, 25 Jun 2024 22:41:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [linus:master] [mm] efa7df3e3b: kernel_BUG_at_include/linux/page_ref.h To: Yang Shi , Oliver Sang Cc: Andrew Morton , Christopher Lameter , Jason Gunthorpe , Matthew Wilcox , Peter Xu , Rik van Riel , Vivek Kasireddy , linux-kernel@vger.kernel.org, linux-mm@kvack.org, lkp@intel.com, oe-lkp@lists.linux.dev References: From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: E5C2C1C0004 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: dkgsektq4s1ubh91imhcxhr76xzgbnz8 X-HE-Tag: 1719348075-751759 X-HE-Meta: U2FsdGVkX19nep+DYksOy3+8SVa/ClKW9GEi8emQ5ET1fWkrS/ZEzgzEhCIoM3nR8hHEwyy9+la4zmcnCY5DiFytax9tSgFKnqZNJe6Y91cZZpbDuw2kNLAxzo5oM4odmxWV9vFG3jXkoyTraso3CSNq2gPp2/3Y22wUZy/K/DBHIDT90Ueuf27QU+9ptkmb8LPQ41shT/F44zkMlo4uXTfPYjFIW2XH2pIZ826nAcGZBVcz+l0auCj4RTGZLLCS83w30yPx4LKJWFL3fCdDNziXcIN8x5/vrZTDnibvLy5Qu1RXS5i88LULh6QG/e8XmCHCJPN8tHAk6LTGe3krFPaIPAY4F8ChEtbEyzJksi7qjz3oThFDjmrE7pGL0OG0ky5sC+7rcFxatDFsXhp1uygcaZp/gNMwoikNY/GEv6G6Q1SalJOoEp6crvFO2lugQMSh6s0KIhVzUmlxe570GI+DfqTuKFFybG0CoCR68TS/2tCXfpubMnfqCWdsZRle0RKKL52w2f+jMpt+ZDGzRzx/5oAoKxYc5B2I9XhJ1VQvlOhT7WTblyV4SRhH+nZiwxoZgeRerRTygPddD3qjO0q7Co3PeFnjbsiBRj/Es/W6P0boo8GYmk/whjwnGVZhU3h55Nha3dHKOxSfuvUVq8GHc4bXvY3szS+Tsp2LaSYR/FZt8wI9dmvZwxagrEaIkG8O126bWsSDzdHye4y7ERh+mwBSz+1T0S0bjXP5mkVHVd2mc/3L/X8adkx8OARKmLzdXStnYUcOG4m5stN/ewpN8Fu4rEafp6FGOAkKuaitjvb2aaTTq9KMr15rqTSnfsRXwCJosrnO8IjX5c0uAg8IKN0rLxTiBWSREqMXd9kHZiTnNbj4tJxfYq2sYmMrI4/LizOc+AU3GC7z0Q/OdF2/HN8/xYIbrFSduN4ZQjrhVdoq8hl75rQiX2CL2Qf3R5Aqx6VFL1Ci8xQiJ2o RAMDZJ1q mOh1TiYW5oUEVmvaBpolFQPqH8fmKy77aw0c6/xLSoEbFzXw/feheppeM3jsQWBXoavs7tDMPvxyyjql3zPVbEB3xYdwCal3fST5UgQ22NIz7ioP2kOIm1+20FRdt2HU3rYVtthwpdYm2Kmljr5e3KI9Ugdbpw40Ygi1gady5hKeYxZxrCgcm3BygsJuGhGOxHlyxiWSNSdGzIMaZyGZakiEAagWV5A9fuBdp/j3hIWO52D3TcV+c0GGnf/NNQ0kN3+rjYRgHVmUZEYz13UZPWzjNg9Dz3e3sB/CMchG1QnIgrE0u/HHvQqZpdSA/A2XqchvwK6zpUB2yG/cLSjkqetTmWadVcv3YVsscITrm+4Fso+dM/8f1gdUcKaDpPaItxhsKcDEt+ON3eFEtXjK98oFhjUX9sNm3Friz63dfQMog18zw94bqjK2ITEaLlxRrBCgckCyCqTM1shsjk2YZYzZN9v44ZQHSCYlZqk+AzWGlaJU4nK6vI7Gw/HlCGyo5d0fXncYmEmjst1/7I4M6P68QfDypFDeN74cjRqehAeLY3nJL4UUhjIBvV5+YaP7DB57IiLKc1fJuADO3kQ9M1aWKI39chf7m8605YQ5A2zG1glU8AhlDlRSNFA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 25.06.24 22:34, Yang Shi wrote: > On Tue, Jun 11, 2024 at 11:01 PM Oliver Sang wrote: >> >> hi, Yang Shi, >> >> On Wed, Jun 05, 2024 at 08:44:37PM -0700, Yang Shi wrote: >>> Oliver Sang 于2024年6月5日 周三19:16写道： >>> >>>> hi, Yang Shi, >>>> >>>> On Tue, Jun 04, 2024 at 04:53:56PM -0700, Yang Shi wrote: >>>>> On Mon, Jun 3, 2024 at 9:54 AM Yang Shi wrote: >>>>>> >>>>>> On Mon, Jun 3, 2024 at 7:02 AM Oliver Sang >>>> wrote: >>>>>>> >>>>>>> hi, Yang Shi, >>>>>>> >>>>>>> On Fri, May 31, 2024 at 01:57:06PM -0700, Yang Shi wrote: >>>>>>>> Hi Oliver, >>>>>>>> >>>>>>>> I just came up with a quick patch (just build test) per the >>>> discussion >>>>>>>> and attached, can you please to give it a try? Once it is >>>> verified, I >>>>>>>> will refine the patch and submit for review. >>>>>>> >>>>>>> what's the base of this patch? I tried to apply it upon efa7df3e3b or >>>>>>> v6.10-rc2. both failed. >>>>>> >>>>>> Its base is mm-unstable. The head commit is 8e06d6b9274d ("mm: add >>>>>> swappiness= arg to memory.reclaim"). Sorry for the confusion, I should >>>>>> have mentioned this. >>>>> >>>>> I just figured out a bug in the patch. Anyway, we are going to take a >>>>> different approach to fix the issue per the discussion. I already sent >>>>> the series to the mailing list. Please refer to >>>>> >>>> https://lore.kernel.org/linux-mm/20240604234858.948986-1-yang@os.amperecomputing.com/ >>>> >>>> got it. seems you will submit v2? should we wait v2 to do the tests? >>> >>> >>> The real fix is patch #1, that doesn’t need v2. So you just need to test >>> that. >> >> we've finished tests and confirmed patch #1 fixed the issue. >> we also tested upon patch #2, still clean. > > Thanks for testing. Sorry for the late reply, just came back from > vacation. It seems like Andrew didn't take the fix yet. I will resend > the patch with your tested-by tag. And I will drop the patch #2 since > it is just a clean up and I didn't receive any review comments. In > addition, the undergoing hugepd clean up may make this clean up > easier, so I will put the clean up on the back burner for now. Sorry, was expecting a v2 of the second patch. But agreed that posting the second patch separately is reasonable -- possibly after the hugepd stuff is gone for good. -- Cheers, David / dhildenb