From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21A55E77188 for ; Wed, 8 Jan 2025 21:05:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A58E36B007B; Wed, 8 Jan 2025 16:05:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9EC476B0083; Wed, 8 Jan 2025 16:05:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 85B6D6B0085; Wed, 8 Jan 2025 16:05:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 698996B007B for ; Wed, 8 Jan 2025 16:05:28 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 063D91A14FA for ; Wed, 8 Jan 2025 21:05:27 +0000 (UTC) X-FDA: 82985515536.03.F36D662 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf14.hostedemail.com (Postfix) with ESMTP id 4531C10000B for ; Wed, 8 Jan 2025 21:05:25 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=RkniSttm; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736370325; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=h4I0PNtnOUgDMotr1i41d8Tf931XThjDVkaFxQw2VQg=; b=e3EViZnwnFW2JN0Jb3dW3+p1xpWRMvYYKGzEe69eQEhlyF+87fGfN6UH4cxGUQXOatd6xQ adKgwbF7dWo706AR3UQhdWqULuuIWAL4hziL+zmx4RRSDNHRWQfT2yGYnbkvCWkoJgtmT8 zGkqpOcd7p0PvVeQj8nk0i/jSSi7avk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736370325; a=rsa-sha256; cv=none; b=oxeJPDsexzIQ6VhoovfThpinWSyUOIs/PwNM4CillfPKzf4lmqjwR8KQi2cKngQWy0yXOe ZEoc0CSDR+bNDaXUXlIoikmyMTtOCxxMyrYx5r4dWruNcPK0TJnDF+HES05euGHpTBRukF 4eZC3XwMkNYpky1vpkeBzLzG4rHN2NQ= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=RkniSttm; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736370324; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=h4I0PNtnOUgDMotr1i41d8Tf931XThjDVkaFxQw2VQg=; b=RkniSttm9CdLZVd6Kl5Xa59sDc3fA1gVlkJ5MoQmQZbXu50PWd2BKqObmLIOtlcqnxC1vS cluk+5Pioz7L5NMP31Q6ixhG/A4kdH3it0mw68YylYUnMFn/hHQmiAnQPcF4xLqjEa2KB9 u/InvKjCflKh4c7EGdnAx9tR4h/zapA= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-21-CuWtxZs0MrWL7JKz3A_RRw-1; Wed, 08 Jan 2025 16:05:23 -0500 X-MC-Unique: CuWtxZs0MrWL7JKz3A_RRw-1 X-Mimecast-MFC-AGG-ID: CuWtxZs0MrWL7JKz3A_RRw Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-43635895374so5841635e9.0 for ; Wed, 08 Jan 2025 13:05:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736370322; x=1736975122; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=h4I0PNtnOUgDMotr1i41d8Tf931XThjDVkaFxQw2VQg=; b=eL0xA0yRACrA9GotVXxt5I4Hc7Nfa8pLiAdPyvl3+Jkj5q3zQpb0rVWFaF/cw2nOwt TfOHghvm2dc/GOBmew27/1G9edUv2CoNPsfklqd5I/5Zv2XXYNeG2nuwAOcx2ZexEZZq i1Hk7c51QKcg8RI43ft4h6vSoSCVRGWSJmh76M01lBAm3lLY0vwlcSa9I6DGnCt1mB8Y shmnTsrLOSD3ycVnh28M39HD3hEWMKGLqZoH0xkDzBIJK7uV74xqRnNDYb8jScTeCbCZ AWyZF2s5IFSRSj9VWNpchYko2C+XAEl/JjbylScSUqD5IFERw/sepVhkS7fgg1IGTIKU bvkA== X-Gm-Message-State: AOJu0YzIT+ZE4YVLFuDxv+xphAcfhHebslJVKGt5AH0xg7LRaCq4vLW5 l6mpDTjn5r2NxshRNm0el8yiWd46qhJ8pwAYA81pLMi96BPX/CwKxbBOO0lU+86tFLjrSGiHdlR Ec04BCnqD2Wrqx1mwMJbsCd73CQBQI5Ukhxdl6IeS1a0ZRJpH0BDVBIW+uAY= X-Gm-Gg: ASbGncuV38HVi/NLr1wUQ3w90ApTxZ+FIKNiNgZNrT4mXi5LQKNC/i15QMrorusGZkB IiMYtGAqoFUpF5oyJj8RQ8DJ17SbrF2UHbAFJUwEVi3FSPRhqED++t/B8JKNnOAbjqFiOuOvAg2 y15t1ZFwxXDGKyA6nTC+Z9joYBr+z3PRq7hB1BjgPOXrOIiVEncEYy25CmQTOZp8PwjTlmtbOWp q2svnty/04zB56K9SB0D/Oqnwe7QZUOYJ2xv3tIqWV53MeZDAunIPW4s+BaPXZvUnNOZkRcRMMT 0pE3fEEaZh5ax0UyEk5WRWfCIDOHMhwRFJh1E7TpR3hkP/rTbtjuE/ECsLNXdW/N2fnbM13PrRl te5gkUw== X-Received: by 2002:a7b:c5cb:0:b0:434:ffb2:f9cf with SMTP id 5b1f17b1804b1-436e883c091mr6735375e9.14.1736370322143; Wed, 08 Jan 2025 13:05:22 -0800 (PST) X-Google-Smtp-Source: AGHT+IHIwp3X0Bhq73aFRylg0Uw3bZY3PG5lXDQl2uIJujsYoN115Ss6zK5awOBbJ1u9Ueagl93VQw== X-Received: by 2002:a7b:c5cb:0:b0:434:ffb2:f9cf with SMTP id 5b1f17b1804b1-436e883c091mr6735225e9.14.1736370321854; Wed, 08 Jan 2025 13:05:21 -0800 (PST) Received: from ?IPV6:2003:cb:c70d:3a00:d73c:6a8:ca9f:1df7? (p200300cbc70d3a00d73c06a8ca9f1df7.dip0.t-ipconnect.de. [2003:cb:c70d:3a00:d73c:6a8:ca9f:1df7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-436e2e1eb34sm32630455e9.35.2025.01.08.13.05.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Jan 2025 13:05:20 -0800 (PST) Message-ID: Date: Wed, 8 Jan 2025 22:05:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] replace free hugepage folios after migration To: Ge Yang , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, 21cnbao@gmail.com, baolin.wang@linux.alibaba.com, muchun.song@linux.dev, liuzixing@hygon.cn References: <1734503588-16254-1-git-send-email-yangge1116@126.com> <0ca35fe5-9799-4518-9fb1-701c88501a8d@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 0VQNgYODRPlbz8NHbbHlz63vyorr2X567kK4FjVbprk_1736370322 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: buoewezhsah7zph56ikqobkxukzh7m3j X-Rspamd-Queue-Id: 4531C10000B X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1736370325-734860 X-HE-Meta: U2FsdGVkX1+isxdmjFJonjYu9VOOTBGSmYBOvFUcPqNS805Do7hh+3+vt3WpFcmXlssm3y0thKRATqyL4NoATccyR3sglrjbm5nGW4IT1eWwBWdpwsXwqNLNiZH4W8BtBWTrIbjYNW2JlcQ8fWfFLTdKix9nT8wBw7vLOQxjW3EnDKv9yefpplM3nsFtOmitYi1wxDCxspZe5F3W9gxu0Mq1LvqCa3rhwFD5cnmc2f5fDEURJMPS+ccfxqU7IAidj3WOX9FdEEcjvqTBxnbJIQz5rdTExOa604lp52HYJdjXeI7K0t5lwU9ojb0ng+EADohu1A25SYR32PZdgPWl7MHqi8xIdDl3SdZJXNWgUpafHueHkvEYg0HHhtmLKA2Y48crPkhtyr89NjwuHHdTo2oNCH86oScBhl1oweHQFX45ur+SVnqkZVLPoy2ntnxaYWXZFUly+uMTvBq/iI/+WCOmsKnhA49YyZeePTiAHyihqXx/ltbPhr5xc8MhJZEK216JEvqJp5DQ7CfZmy+d8tlATN+mOnuBM4f5Mhhg4sPAKE0v29zvGnJkBt9ZqpwN4h2a5JL9b4isqoNiDIo9uyia0RKmSNTkUvlVAodAJNXYT8jpFAlD7CuTEHr70ddAj9HrjHcYwtm/1Hspo98LTVy9Fs83PRGVF1UOH6yG426gqwDQTTZdfGqbNCYDYPnqLiwCb9TaWB+1uQTvU5xmui6unl36wOi71aiyQypl+WOVeOrtKP8kxi1mrG3XjiYadVSkbw6xz2/+DGQoyLODcxmp4wXWr6HO6oMxnOVtZncIVYD6MDVhJeXm8ZIJpSWKShIZpSsR7FUKu6isHf/fpGqnmnLlKDallYYVtISYSFVV+8jSg7oQq16ZFhAkHXf4UyfCWuWRw6IRogX2WE6O78jy2EYl0wVmo7MS47PM2/9RY8uLGxzqLF4/7MDL7LMdysoC94o18IxfGOUTzmb DObrG01v bKB9LUcHj2VsBsXGiY36ef6Qddj11nC6ixIo1sPVrIgLKQ/czuNOnZdDb/gnfzlMk3gbJmswhY3q5KZOg5C8TOFk4Y/mLp6lgC90JD7ma3yZ3oCo7qUs9OHe5DvM4tgy2hjiT9uWs8CfnFQ+YcObx/yLfT+MvSg6lcKC7b4FAtrTIp5A6X2qGFCUVieoM19PA9RmwMEEF7Grv257lIl5cQbKag/pdGDQd0xC/y1MEcONRzxJotxP7ThD/EAL4VuMkIfKMfi3Kg5KRj39snqD5LMyGH8WmMVR8jb5AFJqyj6BEM9vdlMpwRJt1UA7rsr9vSP9+GgqNKH75Vgbjbxcy/M0lKRfiZKGho1qEIMqjIbwLJ0wS2hnVGzNtORyUpljWd2C+9CVCvzhobOA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Sorry for the late reply, holidays ... >> Did you ever try allocating a larger range with a single >> alloc_contig_range() call, that possibly has to migrate multiple hugetlb >> folios in one go (and maybe just allocates one of the just-freed hugetlb >> folios as migration target)? >> > > I have tried using a single alloc_contig_range() call to allocate a > larger contiguous range, and it works properly. This is because during > the period between __alloc_contig_migrate_range() and > isolate_freepages_range(), no one allocates a hugetlb folio from the > free hugetlb pool. Did you trigger the following as well? alloc_contig_range() that covers multiple in-use hugetlb pages, like [ huge 0 ] [ huge 1 ] [ huge 2 ] [ huge 3 ] I assume the following happens: To migrate huge 0, we have to allocate a fresh page from the buddy. After migration, we return now-free huge 0 to the pool. To migrate huge 1, we can just grab now-free huge 0 from the pool, and not allocate a fresh one from the buddy. At least that's my impression when reading alloc_migration_target()->alloc_hugetlb_folio_nodemask(). Or is for some reason available_huge_pages()==false and we always end up in alloc_migrate_hugetlb_folio()->alloc_fresh_hugetlb_folio()? Sorry for the stupid questions, the code is complicated, and I cannot see how this would work. -- Cheers, David / dhildenb