From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56B6EC3ABBE for ; Thu, 8 May 2025 06:33:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EE6ED6B000A; Thu, 8 May 2025 02:33:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E96906B0082; Thu, 8 May 2025 02:33:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D5D166B0085; Thu, 8 May 2025 02:33:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B22736B000A for ; Thu, 8 May 2025 02:33:25 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 27A511A0B09 for ; Thu, 8 May 2025 06:33:27 +0000 (UTC) X-FDA: 83418774054.14.8951C10 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by imf27.hostedemail.com (Postfix) with ESMTP id 3E01640009 for ; Thu, 8 May 2025 06:33:25 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=IqKJoH21; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf27.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.180 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746686005; a=rsa-sha256; cv=none; b=mr2G6tW9p6DwQ0e8WhC0txERTYpWQWDdBQ80rLb43VGpiVZMOuYknaxy2ZGYjKE9ILnHDC QYHrVLW0gJyLc1soD2MY8f9Js+V8RUIcyQFmbofGwDQZnSKCp1WVBinSumLaKz8trFlSkr FSXv+j9W5canDpEHIfUjQE09TliZZXg= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=IqKJoH21; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf27.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.180 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746686005; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HlgheUo164rlqXvFGQwU6HpEq4bJ/pYk3yvNMQQtoWM=; b=xL+4eMdynwWJGQLi12Emr4TxNBj8l7gEoqVkOEa528QWofDsKF1STzyEeTuvuJ4rWRHg// Cu8O2gDe6tIb2q/aNUSgtKeQwJXcbMKgkgnRFoPiFMwadHm4c+i368c4qo3qBa5BOqPVkz 1T2xK8rAfNC+8zkcSVnQAouim+1RP9o= Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-22fa47d6578so2998665ad.2 for ; Wed, 07 May 2025 23:33:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1746686004; x=1747290804; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=HlgheUo164rlqXvFGQwU6HpEq4bJ/pYk3yvNMQQtoWM=; b=IqKJoH21NehUR8E1BNw6CYSgrEcCH5TaarmNuY2BsSDyuTCs8pcU5W3T8oqgL7GEtl dzVgwQ1G7GJ0LeF3W/UPt8LaDKzPTsYS944N2WVc/eyfS5kulAKDjssWHmTf5yZ/W+0c fJPBGdY7xN9urTBx0Cq8kCxc/nbWXszRRyilU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746686004; x=1747290804; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=HlgheUo164rlqXvFGQwU6HpEq4bJ/pYk3yvNMQQtoWM=; b=YU01f3xri8p/nRyzo//BPrxb7Pjf4U3jRWSNHmJ+/tXz2eyDnYatEnw8tjJt8T+oIB r5n6MljpvkUlauAqd8p9ykniYrYpU3EtDwp1DMF3GqPpdBPYMAXGP06/CtySzpNorWzT UdQ9XDVNrI25NvkzOY5EiMfS30k8Zh5skBcsmTBc0PRyIfd2s8M7KxdVWWvZdecCX4xh j99+Uzb3RZ+Iqn4BYUQWn8/u3MyLvpjPpLATRIRs0lKClF++SCpVmcrIYzgWWlEtUDnP qvFMZIOcRQyFbu98d2wGsa/YWmlZFCBYEcKTr0JB/bcoR6Lorw34d3Qs2GZTq08fVOYE I1cA== X-Forwarded-Encrypted: i=1; AJvYcCWGNIlKuhRqwiA/GDhRKW0i8Kqgj9grylXq1oqoakoKqRHlzWDDb4WqiBiSCkQh4fIndobjhMP90g==@kvack.org X-Gm-Message-State: AOJu0YxT1QQb6UXWXJQ1IXeqVUJmw1t9RSviIbnM3AxaCWO1aFtytBqM bV1DbW/D6Xw5CxGsORe4700opTDe18SaRaomC5v8QKfkjgIdtNhF/LCJwnqk2YIMyiwHaeNlqgw hkw== X-Gm-Gg: ASbGncv6DfftjnU3NHudzrqqKlYyllvx1D+7jJ5xNu1dHBDFSx5K/m43yliAhonYq68 rMNaCOIBkLdv6agEayUqrvbez9nQpVnj3cp0pBcf1pwHVY+jMCiAKyIbIHdOX6OXl3VJKw+HvWk 3kfR9rsKeHLAbxHNyKe9HgcxLUhEblK9zHAqIQVd7qdsLsyGQHy5RSvhpumf2nOCDSt7QdBY1zg vdqLLrvkwtSQpr3/I4+fP1ztvgZbgt/YjiE0JWqpVs7/m2Ns7UErheH2idbFrckNH/9ouobrGyW OI6CZsnProBIlszHYEZ63KfbZyRYe+U/56lCrdZ9DGDJ X-Google-Smtp-Source: AGHT+IFTxdpBpcI+dt+ewP/ixBZ5/vcOfiMsuXdPx9TL9kjiJLwdfxwmdioqqOx3ETJijnVQIrm7Kg== X-Received: by 2002:a17:903:1b6d:b0:224:255b:c934 with SMTP id d9443c01a7336-22e5ee1e42emr85523305ad.51.1746686004087; Wed, 07 May 2025 23:33:24 -0700 (PDT) Received: from google.com ([2401:fa00:8f:203:c794:38be:3be8:4c26]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22e815806fdsm11012065ad.17.2025.05.07.23.33.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 May 2025 23:33:23 -0700 (PDT) Date: Thu, 8 May 2025 15:33:17 +0900 From: Sergey Senozhatsky To: Sergey Senozhatsky Cc: Christoph Hellwig , Yosry Ahmed , Vitaly Wool , linux-mm@kvack.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, Nhat Pham , Shakeel Butt , Johannes Weiner , Minchan Kim , Igor Belousov , Herbert Xu Subject: Re: [PATCH] mm/zblock: use vmalloc for page allocations Message-ID: References: <20250502080156.1672957-1-vitaly.wool@konsulko.se> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 3E01640009 X-Stat-Signature: 4n4hw81cdd8xge4tb6uk41eyis5n6jnn X-Rspam-User: X-HE-Tag: 1746686005-201435 X-HE-Meta: U2FsdGVkX1/M35rps+FnUsTzyMjRqC1MIlTzekpnM7SuVHRLTSIMH+yauH/ou/HjxNwySMOFrWJ9y4zP6Gv/k6MEp5uF4el4ISP52UVVT7YSZYXbE6GWeWdGMANspyOvQ3wQnTnez0r5ypBbsIcNuz/hCMO14aTQLZu+mEnoRAjd1Xd1kPtAs1ZxxTo25y0gAs9tRml//wBpYl4mhLKcbkJcYQMXUjx+HLFUf+yQaFuExg5c0PGXEG5A+5Fv5gj7rPXEEBaFJMS4+q1bl/tggsItpg1jWU4bAZ098+XA3x6/t1tXSyb1Gkin2UsHACDlQ9lsnmbwFsIZF7Ik9U4jh07olIwnCX7bZ6oyHLt/hoTYngre+ZzrOME3JO/CenM/VcFdSBXAeizuA77KDd9UPuUsLGwNGGnVx6z4HowRWs6BWUhqxE0GsRPaIBAhgvYDwJB5UJnNRRqAW2LazagCc44h+LhI2zmt9dSmZ3AUyiqZERHJonRQw3jR4T7jt3L4284XoCEcmpeHDsURZbr7XdRhoDcQnaL+K7iTys0B5mjRLdndbrzqTfxPenn6oo1hgzkI0QUv1QUHuS60yPZIYbg3ppBOwzIuc9bdtd4DHHOirIg/QE9ujsgI2ca6gQpvBhzQYvvMGSUqn8rCXR+OeBp0U5zr9qx5z11xqXv7SKMubRWsZztGWiGXCj5cQ4Z97OkCniH84o97f6qypsrc+u6Omt3BRxw6I+Ar2chq1f0Zih1VAwPQVJscR3/A8etNJFoh1gyWLKopy8Bb8RVWuwxRDQ01NAucNI8ECYN1kGzB+VDqwa0mea2T1n1kNOmfnOHvh1L+cyHTtaV6CXCvMnBL89SQuDEgMC0EYXR0ZW25pW4tlrMQG4aofdnf0akImRy6X8UNNGFtW3RFhSHDckB3EKBkZuLeVvLk7NQaJ2YRhwU6SbCjPAmsEsxDMzyo2Jn9ddWGSQFuY91pPdM tzbd+m2P k13J9+NDsMyGOCdyhH31GrOvK31TEKZt8bPtjVPCd4z0hZ/dgxNnaoNSFwxZUtaIVTfHQqnhodaBii5+syA1fQGfTeJ6yFJ5Euk/8Knt0d0QM7vFNqHzoQdxlqkcJuWl7Uz3iPG09I8Xl9AK9Sum38xFOChyhpppaeGHusWZORkoDfJt0X2KYZW9h3ZoYQCZyFfsBp14WWSKXyA/3VOdfsCcdyKegiOeIE7xULMmOjFBy4axND3cHutacYFtkZEvve6EgDI/Bsd/WypSqERfJx+bKUn2dvEmWj3K383BunPjPUqEXv0xDu1TB8qXWDAR4v+gzCjC0oCGw58eHnhttHp4+BF+44r9tF09s0rHlh2GV0+s= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On (25/05/08 15:17), Sergey Senozhatsky wrote: > On (25/05/07 23:00), Christoph Hellwig wrote: > > On Thu, May 08, 2025 at 02:58:14PM +0900, Sergey Senozhatsky wrote: > > > Oh, I didn't realize that zram was the only swap_slot_free_notify > > > user. zram already handles REQ_OP_DISCARD/REQ_OP_WRITE_ZEROES so > > > I guess only swap-cluster needs some work. Are there any > > > blockers/complications on the swap-cluster side? > > > > I think the reason it was added it was so that the discard can be > > done non-blocking with a spinlock held. Which seems a bit sketch > > when calling into a driver anyway.. > > swap_slot_free_notify is not guaranteed to free anything on the zram/zsmalloc > side. zram attempts to trylock entry .. I keep forgetting that slot-free can be called from an IRQ. That's some complication.