From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 319D1C76196 for ; Thu, 23 Mar 2023 15:00:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 96E286B0072; Thu, 23 Mar 2023 11:00:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 91E236B0074; Thu, 23 Mar 2023 11:00:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7BF876B0075; Thu, 23 Mar 2023 11:00:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 6B3706B0072 for ; Thu, 23 Mar 2023 11:00:47 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 0E8C24076E for ; Thu, 23 Mar 2023 15:00:47 +0000 (UTC) X-FDA: 80600474934.03.F663684 Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by imf11.hostedemail.com (Postfix) with ESMTP id 65CD54001D for ; Thu, 23 Mar 2023 15:00:42 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=samsung.com header.s=mail20170921 header.b="a0wEK/WI"; spf=pass (imf11.hostedemail.com: domain of p.raghav@samsung.com designates 210.118.77.11 as permitted sender) smtp.mailfrom=p.raghav@samsung.com; dmarc=pass (policy=none) header.from=samsung.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679583643; a=rsa-sha256; cv=none; b=FIxMyvTF4z9xyeT66KexdlDT6Gj+vdGAkNaEG0ZikrwU5kM37t3WMfvi8UqnMqVeMU0rzG /zVw5mYhcREf58egdG2H5qMdvcJUXFXk538FdP8gHd6sLPMZXa/wky+PPkm+hi1Ruim2Ra 3gGZS+gDWG/vgfuqnsXx/ZQXMiI5llo= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=samsung.com header.s=mail20170921 header.b="a0wEK/WI"; spf=pass (imf11.hostedemail.com: domain of p.raghav@samsung.com designates 210.118.77.11 as permitted sender) smtp.mailfrom=p.raghav@samsung.com; dmarc=pass (policy=none) header.from=samsung.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679583643; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Icol1NVQVqXWLETTQ6qBuGxVjyUvKpu5FRVxPfMJI5w=; b=KVHVHWvwicu88ym6xJTLyfeDq3ctUHuYOAxF+TupulY65p2aHTdXGj536ChY5Fdm4XjO/H ubvP6ZA9eWYpB4/ZbyKMoNMFSGuwyEirELWUxSqTHbRiLjCT27kx25YpxlHFO40tXL9IXf 5L5K3vDeu38aJlfPB8gGA1oppzk/HwY= Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20230323150039euoutp0114dddc6beb3008aa9c8c2aedd92352de~PFGv38LFF2231022310euoutp01M for ; Thu, 23 Mar 2023 15:00:39 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20230323150039euoutp0114dddc6beb3008aa9c8c2aedd92352de~PFGv38LFF2231022310euoutp01M DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1679583640; bh=Icol1NVQVqXWLETTQ6qBuGxVjyUvKpu5FRVxPfMJI5w=; h=Date:Subject:To:CC:From:In-Reply-To:References:From; b=a0wEK/WILT2l2yTo7hODi6knqNCGLVGsWm1o9nnVOFmazylpeSUowNYKpW9hbmAdx 8MhSHQbumCLTtm3Gs9WPa0wNGb01fXT7Mcczv+AaVg7lusT0RJwGXhJk1wBUP3Dwa3 tpo78MbYZkTmwvgVEYiKrAgK892rDgTohFlCd9qc= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20230323150039eucas1p2c7b2e1906656e2f9285fe5c95907c5c9~PFGvm1TmA2995529955eucas1p2N; Thu, 23 Mar 2023 15:00:39 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 28.11.09503.7996C146; Thu, 23 Mar 2023 15:00:39 +0000 (GMT) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20230323150039eucas1p26720ff35cb61c319cf3689f2f692f720~PFGvHi8AG2042820428eucas1p2e; Thu, 23 Mar 2023 15:00:39 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20230323150039eusmtrp27e05b1483f2166f1785c5879c94b1e57~PFGvG7Gmy2667426674eusmtrp2p; Thu, 23 Mar 2023 15:00:39 +0000 (GMT) X-AuditID: cbfec7f2-ea5ff7000000251f-bc-641c6997ca0e Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 1A.39.09583.6996C146; Thu, 23 Mar 2023 15:00:39 +0000 (GMT) Received: from CAMSVWEXC02.scsc.local (unknown [106.1.227.72]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20230323150038eusmtip1bb56ea103192735c274ede4a1e924d2e~PFGu3--cZ1265912659eusmtip1b; Thu, 23 Mar 2023 15:00:38 +0000 (GMT) Received: from [106.110.32.65] (106.110.32.65) by CAMSVWEXC02.scsc.local (2002:6a01:e348::6a01:e348) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 23 Mar 2023 15:00:37 +0000 Message-ID: Date: Thu, 23 Mar 2023 16:00:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [RFC v2 0/5] remove page_endio() Content-Language: en-US To: Matthew Wilcox CC: , , , , , , , , , , , , , , From: Pankaj Raghav In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [106.110.32.65] X-ClientProxiedBy: CAMSVWEXC01.scsc.local (2002:6a01:e347::6a01:e347) To CAMSVWEXC02.scsc.local (2002:6a01:e348::6a01:e348) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrNKsWRmVeSWpSXmKPExsWy7djPc7rTM2VSDPaeUrOYs34Nm8Xqu/1s Fq8Pf2K02L95CpNF+90+Jou9t7Qt9uw9yWJxedccNot7a/6zWpxc/5/Z4saEp4wWy76+Z7fY vXERm8X5v8dZLX7/mMPmwO8xu+Eii8fmFVoel8+Wemxa1cnmsenTJHaPEzN+s3g0TL3F5vHr 9h1Wj8+b5Dw2PXnLFMAVxWWTkpqTWZZapG+XwJXRfeQHY8FVnoqVy44zNjC2c3UxcnJICJhI zN3zirGLkYtDSGAFo8SDDwfZIZwvjBInzm5kBKkSEvjMKDH9qhFMx54jd9kgipYzSrxbep8V rqh7tjREYiejxKu2xywgCV4BO4mDf6aygdgsAqoSLS3vmCHighInZz4BquHgEBWIknjxugwk LCygK3FxTydYK7OAuMStJ/OZQEpEBDQk3mwxAhnPLNDDLLFo7S6wVjYBLYnGTnaQck6g2yY9 WMUO0aop0br9N5QtL7H97RxmiPsVJSbdfM8KYddKnNpyiwlkpoTAPU6Jb+cPskAkXCSWNt+H KhKWeHV8CzuELSPxfyfIPSB2tcTTG7+ZIZpbGCX6d65nAzlIQsBaou9MDkSNo8SezedZIcJ8 EjfeCkLcwycxadt05gmMqrOQAmIWko9nIXlhFpIXFjCyrGIUTy0tzk1PLTbMSy3XK07MLS7N S9dLzs/dxAhMf6f/Hf+0g3Huq496hxiZOBgPMUpwMCuJ8LoxS6QI8aYkVlalFuXHF5XmpBYf YpTmYFES59W2PZksJJCeWJKanZpakFoEk2Xi4JRqYFK5Munvw7ke7WpXNDg1G5si1rrXhJ3l kvw0Revb9oVuDFz7RW+UJL8x3b/sSuzCFN6U53MbE8y8zl5dNCHmq4rC6gP8ov1PpDu443n2 l12/3trGvMHctir5Y7iJ06kd32YuWDingqH1rqvfj4afS6WfNiwSNdyQVu26LN7xek2IWbag h6D896mTJPZ22LBvnLRj8osvFbxPH66S9lyVMfNges/8GI81T47Ha+4wEV7Q+Emut0rmzKGP 7/SPtTT+YAmIkavcF6je26i07QpzWqWI0EnBpWGZgcFbGg/fVzkauWB2gu1FSYdHuWft2h94 H1hgev3+09QzrX+Dp3SrBCUqBQfz7zny/znnnQnMr5RYijMSDbWYi4oTAde99cruAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprMKsWRmVeSWpSXmKPExsVy+t/xu7rTM2VSDKbsYbSYs34Nm8Xqu/1s Fq8Pf2K02L95CpNF+90+Jou9t7Qt9uw9yWJxedccNot7a/6zWpxc/5/Z4saEp4wWy76+Z7fY vXERm8X5v8dZLX7/mMPmwO8xu+Eii8fmFVoel8+Wemxa1cnmsenTJHaPEzN+s3g0TL3F5vHr 9h1Wj8+b5Dw2PXnLFMAVpWdTlF9akqqQkV9cYqsUbWhhpGdoaaFnZGKpZ2hsHmtlZKqkb2eT kpqTWZZapG+XoJfRfeQHY8FVnoqVy44zNjC2c3UxcnJICJhI7Dlyl62LkYtDSGApo8Tsc19Y IRIyEp+ufGSHsIUl/lzrgir6yCjRMv0EM4Szk1FizYJDbCBVvAJ2Egf/TAWzWQRUJVpa3jFD xAUlTs58wgJiiwpESTy9cwgsLiygK3FxTydYnFlAXOLWk/lMXYwcHCICGhJvthiBzGcW6GGW mD9rKiPEsh2MEq17r7CAFLEJaEk0doJdxwn0wqQHq9gh5mhKtG7/DWXLS2x/O4cZ4gNFiUk3 30N9Vivx+e8zxgmMorOQnDcLyRmzkIyahWTUAkaWVYwiqaXFuem5xUZ6xYm5xaV56XrJ+bmb GIGpY9uxn1t2MK589VHvECMTB+MhRgkOZiURXjdmiRQh3pTEyqrUovz4otKc1OJDjKbAMJrI LCWanA9MXnkl8YZmBqaGJmaWBqaWZsZK4ryeBR2JQgLpiSWp2ampBalFMH1MHJxSDUwMymwC TpNn7j6sZ8lplHKrTqX15ur7P77v+rnkrcqXpR/fXJPkOXIyfEPPRYuz979NtKlLeF9591cG 44pOPYG2dXGeZjLHv8zdEKZ47PrZctNFK0tT5r2yefBm/c2TKUlnH00VnnHLnU1JM9VxnhCP s0RTcBf3motOn53W7xEurPnRd2bWdNm6Rw6HFnZkvNrgNee2WnpOVcmhfwomqr07Ln+awhMu zrz8mo7pgqspWY2H1k5ZmNx4t/4af1bMSsVlbrs39Tq///Tm1nPZBbtCusTsvI/kJRpXVkrf a3VjsZrwQjf8xEN9Jw+t3vn84k4++s/dnktzsote1jPrY2uotWj5lPNXpE7YLih68hslluKM REMt5qLiRACWM9NJpgMAAA== X-CMS-MailID: 20230323150039eucas1p26720ff35cb61c319cf3689f2f692f720 X-Msg-Generator: CA X-RootMTR: 20230322135015eucas1p2ff980e76159f0ceef7bf66934580bd6c X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20230322135015eucas1p2ff980e76159f0ceef7bf66934580bd6c References: <20230322135013.197076-1-p.raghav@samsung.com> X-Rspam-User: X-Rspamd-Queue-Id: 65CD54001D X-Rspamd-Server: rspam01 X-Stat-Signature: zkzgs7nby4sgcz8ric9g7bru3dyasu77 X-HE-Tag: 1679583642-934479 X-HE-Meta: U2FsdGVkX1+ZDbkM6DJhWm+j1SBT1LlhAz9uPiBQGbXNvKF4n7dmjdiSlsgnuzZZ0YROxcBbkT3EaspPiQRhqIQ5700u81/a9GSAkk+/Surw6qtCpOJeypXdMpF+znSBAR0YPUVd8bsP5ZC5EK9B+GC9WDHs5PCOLxXGQn8vTo20vzKJXe40YGBUl84ujYIQQcKsJ7XkNVtLpwdfEuhq6XLFPQiV/PYQfUU5BLYRFXOsNtpMUIL217kSN/o3jVw2eGJavu451ohaPLc4kRlCMsbabaDUPGjTM8QK+vzRA5ldDPByfW27WwTz/oVRnMVNo1Gj+ATg3IXjsN59B6sXEgkeAIiUwxYjBo2n51FItgsEQynlYfcA3Tuv/w7+Oy9qXzqkzq9sEKM0dRI+vZMO/fDsewVDDy8CN7P3ScuoQ9/7rk+m7TnCuaNbaYUIqxVl/NZXhl4PCSwUtloqgUl+EDrRXsZxywbj1FmPwSyHmHGgvR232xeOG8kv1Tgz1ojG54v7Qos3G7GH5drrlk5mJS2yTXmmjYjRiCJqrgTMCLKECKnFetlQARMEa7RElSSOInMmkFb5LQUgR2BCdnBW/uYme3FaU4RAI0lc4swDeuA7XkpvTN5epZP3w1mbOqQ4GCKMeiKaTXdexOJQcgxrz4bANJaKKE2L5rwzNQqy0vCfEG+TJlQlSJfhOH3dgVdd8bPQXwNio9uYI0ntVfiLmyYHe/ZNWJ80dUwmAkRo0motKeIuLF4ZbTQOE25chB7FIAI3Kr2JL06HscMM+fgRfLh1MmkkgVKb4v5JTL51YMK5jykKiWct2zIXgjqfx5AkVeBoFEgcQKnhpcjISyc1+JHZStzksK1+xXABTHVDgfJ2jgxDtljUJWLCgbvHnyb5hmnXSwY7CY2Xpus63Ld9559w6SqbTWR0xBVv57GuM25LRWZOaAo4Ywpmue0ITGTo5f9MpSIDzv5Uk+NGZZ3 Vjf1AT/b 0quN7YuRRnIpMWISZtJhyEbDmjU8id1o1Nq2q8BnYRnPtVC7WYdulEJ1r425Bb/pobg0BZ7ddmIughIx4IpW/0Jjb8N3Yqcp2cbCaCHF6Jqd/h9GZJpXuw7vPx/MBTNUs3zG/AbN0o2MAEzW/Wj7cp0kXuSpBIPtNzzgpVJXMtWXL52AQSzaBlAkdog== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: >> Open questions: >> - Willy pointed out that the calls to folio_set_error() and >> folio_clear_uptodate() are not needed anymore in the read path when an >> error happens[2]. I still don't understand 100% why they aren't needed >> anymore as I see those functions are still called in iomap. It will be >> good to put that rationale as a part of the commit message. > > page_endio() was generic. It needed to handle a lot of cases. When it's > being inlined into various completion routines, we know which cases we > need to handle and can omit all the cases which we don't. > > We know the uptodate flag is clear. If the uptodate flag is set, > we don't call the filesystem's read path. Since we know it's clear, > we don't need to clear it. > Got it. > We don't need to set the error flag. Only some filesystems still use > the error flag, and orangefs isn't one of them. I'd like to get rid > of the error flag altogether, and I've sent patches in the past which > get us a lot closer to that desired outcome. Not sure we're there yet. > Regardless, generic code doesn't check the error flag. Thanks for the explanation. I think found the series you are referring here. https://lore.kernel.org/linux-mm/20220527155036.524743-1-willy@infradead.org/#t I see orangefs is still setting the error flag in orangefs_read_folio(), so it should be removed at some point? I also changed mpage to **not set** the error flag in the read path. It does beg the question whether block_read_full_folio() and iomap_finish_folio_read() should also follow the suit. -- Pankaj