From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F048D3DEA1 for ; Mon, 21 Oct 2024 06:33:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 798786B0089; Mon, 21 Oct 2024 02:33:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 749736B008A; Mon, 21 Oct 2024 02:33:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5E95F6B008C; Mon, 21 Oct 2024 02:33:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 3F2EA6B0089 for ; Mon, 21 Oct 2024 02:33:58 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id C3CE91614E0 for ; Mon, 21 Oct 2024 06:33:40 +0000 (UTC) X-FDA: 82696643778.05.813104A Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf24.hostedemail.com (Postfix) with ESMTP id BE22A180011 for ; Mon, 21 Oct 2024 06:33:52 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=ARnhkOK5; spf=pass (imf24.hostedemail.com: domain of borntraeger@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=borntraeger@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729492236; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QKaq4B5URAFGBy0bwe2UmpkraYPJ2j4a6Afx8H1P0X8=; b=K7k3kqxa+kIyM3+NFCCEVV+sK2xBXPG/Rn6yus31V2w2gyoaojiPJkLyZG8JEnkA4PhHFf 6L34SVy3yJ9PYpOGiTMPQi8vDX/LTW64G0nUtys1RdTza6/6/BHfOCaNCdq+aIAjN9HyZU QNxVvQunJk3cBABNBZSjudGokbuUuPA= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=ARnhkOK5; spf=pass (imf24.hostedemail.com: domain of borntraeger@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=borntraeger@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729492236; a=rsa-sha256; cv=none; b=jbp0Ik/VQE3eYruaOj9AQJn3MJWREm97gHDh5Rsg1PXjNpx1mweTmnazIB1YjNOJYlLmS7 S7gQApjsh6UpvFLzd7k8HWkNi66T+oCSWZgmFDvRRS/wXZFMD/MTazFq3Y5rB01ocN3qAu aMGzRemg/iJZG8El949K9JL0rWygM6M= Received: from pps.filterd (m0353729.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 49L2KHwX002179; Mon, 21 Oct 2024 06:33:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=QKaq4B 5URAFGBy0bwe2UmpkraYPJ2j4a6Afx8H1P0X8=; b=ARnhkOK5gLJCohv7zvJln5 KtBlrpHd5u3tMrI0NxOHaHponCeVVkq+d2/uugPxNBEydz/TQr3zG9tDX2Uc2Ldm Q3SLMBz2vLtKHpPzDUoZJk2vmkake10+YLeA440DsVzkph5gTILQBs1+QW66G5nh 61xO4c1/475UDzmjFOPtsMXO1+jhnceejSNmVOSmPW+hKQaHajFPtE70X8KuXsD+ ZkNHcK6Lfud1hzWf1ew+WhQomIZ1FRHRHwZBdHjXyDPh4KEx765d4/6/P9/iERA/ ExBU+gCvB0BeXPWtkCxtPssI6rLKitct5U36/KNdHRmt+8CIhiKmw87KnzTBzj1A == Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 42c5gcfeq5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 21 Oct 2024 06:33:53 +0000 (GMT) Received: from m0353729.ppops.net (m0353729.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 49L6Xqjk000729; Mon, 21 Oct 2024 06:33:53 GMT Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 42c5gcfeq1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 21 Oct 2024 06:33:52 +0000 (GMT) Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 49L5O8fs029401; Mon, 21 Oct 2024 06:33:51 GMT Received: from smtprelay03.fra02v.mail.ibm.com ([9.218.2.224]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 42crkjvmyr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 21 Oct 2024 06:33:51 +0000 Received: from smtpav03.fra02v.mail.ibm.com (smtpav03.fra02v.mail.ibm.com [10.20.54.102]) by smtprelay03.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 49L6XliM49938792 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 21 Oct 2024 06:33:47 GMT Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9B96F2004B; Mon, 21 Oct 2024 06:33:47 +0000 (GMT) Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2FB6A20040; Mon, 21 Oct 2024 06:33:46 +0000 (GMT) Received: from [9.179.24.137] (unknown [9.179.24.137]) by smtpav03.fra02v.mail.ibm.com (Postfix) with ESMTP; Mon, 21 Oct 2024 06:33:46 +0000 (GMT) Message-ID: Date: Mon, 21 Oct 2024 08:33:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 5/7] virtio-mem: s390 support To: Heiko Carstens , David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, virtualization@lists.linux.dev, linux-doc@vger.kernel.org, kvm@vger.kernel.org, Vasily Gorbik , Alexander Gordeev , Sven Schnelle , Thomas Huth , Cornelia Huck , Janosch Frank , Claudio Imbrenda , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?Q?Eugenio_P=C3=A9rez?= , Andrew Morton , Jonathan Corbet , Mario Casquero References: <20241014144622.876731-1-david@redhat.com> <20241014144622.876731-6-david@redhat.com> <20241014184824.10447-F-hca@linux.ibm.com> <20241015083750.7641-D-hca@linux.ibm.com> Content-Language: en-US From: Christian Borntraeger In-Reply-To: <20241015083750.7641-D-hca@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: MZ1yrbyezdS4zll8wFGufHjjP4N0smer X-Proofpoint-ORIG-GUID: 37ZgR9RiC9b_Gof1v4vav0KFZsJWLwy9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-15_01,2024-10-11_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 mlxlogscore=853 clxscore=1011 suspectscore=0 lowpriorityscore=0 mlxscore=0 impostorscore=0 spamscore=0 phishscore=0 adultscore=0 priorityscore=1501 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2409260000 definitions=main-2410210043 X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: BE22A180011 X-Stat-Signature: jfh4xi593tydje48ungsitirbhuyjxi8 X-Rspam-User: X-HE-Tag: 1729492432-773931 X-HE-Meta: U2FsdGVkX18m3FAfpys8axsFN0c+yA1Fof2blDUjf5s/yMhhVBDRha0fPGIOva6WFH1aTbZObvhcsFe6Tv6d2Whj5GmDo31iRp5AUd43ClAY5YfCM9ubzKWyYKxd+RSNFewau8WrXNUga4aELIoKqRChuYNibT4PP6V7UHDpYNV9KxaHCK7TM/iEIL8wvObwk3kfmbGur/OU3uAG0zI3qVlHr3fFG/zm9xn+G4O1QcpWuST0V63J+ykQQoja0mT4YSJD7NypHrE/ik7r8bqOiNssl4mPdxw/tzW1XrAdD5MOlTyteQf95ZjjDQMrNk9HVPOlpSJdIAc7z5GmIUZM3JYi6/RIadfvW01shcE+rS/skeVKerEGz09AwEAP2ZGJxZQKL3U468jH+tIdMT/8KJmnKp64m8IifVt0oLdDbFnqEXfaaqHoYayWGGpTN2q1mlhHXpuMC1FG/RhewoayRXo0cx3RDxPbLeX9u5KGUkuucl1QavFccyyAy3PIW1ozYxYfkrBcT4pYOl8PGp86UC6wudJ6eW0xJyfrpfjpEshHSIH3vpUpBaVXd1Y/apwEJpco5wOOH5oAIyySr+I+/m8DZb8vNcvtRCD3OhjT5cLz25/38M9NcWgq3/JBohtX4E7znc6NluKe45tws7o/87YYQ/IVrAL7ajdyPcqinXZ3Ri03NdF5KdSUrGUvhfvVvkhIR5TkLmQUJ02/fAnz+im5y/p6eWG7DTmk27iuxiqnyIler8kIbqo4TClf6J6gC9dF6pTTv4gxR3QEmaGyEzx9ePzX9xtwKZ4GMh7TvShX2k4yYMNBSNXlkDLmveHaTCTGGHoQvG3qjDCBAJ130og5ypZ7IPONlWrAf9SI3CKMmFQnnFqf1HG4LOY30CxNrxnOiUr/NzNVHbWQq2h7lZJEJ4CzxbP+JjmI7ws3q7DJZUU+wpPMQQvmN+X3IwLZwsA7eMHHICIH8PKn+Zj OrScxTtM oBTa2K5x4s4auCXpM7e5SndRx8SQz8Zl03dI/dALg2byk3lch/xw21kOMR63SDWZ1LB7U+7VdrkHZx3ruwlIxQLthwQFO784i0yoLGA1taTFJsq7fuGQUylV7oOr3p05oGCdE1uk8n8zzMgaKSho3K3zHSdBcx5zchUm4+uMD2zkyykS3YYRz+41g5OE12+aYPBKVopci+jACNSvZGGXOEADv7UiJWwJvIXYsIpBr8YGOlzg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Am 15.10.24 um 10:37 schrieb Heiko Carstens: > On Mon, Oct 14, 2024 at 09:16:45PM +0200, David Hildenbrand wrote: >> On 14.10.24 20:48, Heiko Carstens wrote: >>> On Mon, Oct 14, 2024 at 04:46:17PM +0200, David Hildenbrand wrote: >>>> to dump. Based on this, support for dumping virtio-mem memory can be >>> Hm.. who will add this support? This looks like a showstopper to me. >> >> The cover letter is clearer on that: "One remaining work item is kdump >> support for virtio-mem memory. This will be sent out separately once initial >> support landed." >> >> I had a prototype, but need to spend some time to clean it up -- or find >> someone to hand it over to clean it up. >> >> I have to chose wisely what I work on nowadays, and cannot spend that time >> if the basic support won't get ACKed. >> >>> Who is supposed to debug crash dumps where memory parts are missing? >> >> For many production use cases it certainly needs to exist. >> >> But note that virtio-mem can be used with ZONE_MOVABLE, in which case mostly >> only user data (e.g., pagecache,anon) ends up on hotplugged memory, that >> would get excluded from makedumpfile in the default configs either way. >> >> It's not uncommon to let kdump support be added later (e.g., AMD SNP >> variants). > > I'll leave it up to kvm folks to decide if we need kdump support from > the beginning or if we are good with the current implementation. If David confirms that he has a plan for this, I am fine with a staged approach for upstream.