From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 398C7C4167B for ; Tue, 5 Dec 2023 13:55:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A189E6B0085; Tue, 5 Dec 2023 08:55:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9A5216B0095; Tue, 5 Dec 2023 08:55:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7CD636B0092; Tue, 5 Dec 2023 08:55:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 650996B0096 for ; Tue, 5 Dec 2023 08:55:38 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 383C51C0272 for ; Tue, 5 Dec 2023 13:55:38 +0000 (UTC) X-FDA: 81532912356.14.2CA2185 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf07.hostedemail.com (Postfix) with ESMTP id C802340021 for ; Tue, 5 Dec 2023 13:55:35 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HV1mbPib; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf07.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701784536; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SEVcpVCG5LqbTJH+FlkvSOnAEVuTJl164mBLwlNcRN8=; b=ahQd+hQ3klNmGPtwmjGEELiCyn5bTZVWBpzKM1/dSVfZMvCTtwO6XZSUh6Nb1LFHkjSuDE 9Q1zoVhb/R9IYDCDWzoZKC/nddwBt3mL2ZNKJLugZ+vezb3xkEEpJXiy2R7xJmxBR7OA5x QhFslAOZsZ1prdCIuVIoCfyQ3GwYcJ4= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HV1mbPib; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf07.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701784536; a=rsa-sha256; cv=none; b=tha0qumF6bom6qT02UHHC8pMSuxq8M1MYA3IezsVLoP0+HNEnf0DKMP/LqIm4RIZBVVKiq 7Gs1G7WdukgJO2sOgJqNpbTL1fETibRMC6JSdOFK7bRKtTXISXFUuPKV7qTNeGb0AoiQaY Glmpfbb2ocZfm8k1OWw1lwYQwb13MV0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701784535; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=SEVcpVCG5LqbTJH+FlkvSOnAEVuTJl164mBLwlNcRN8=; b=HV1mbPibXTsxD54b9cy45kVplsZIGT7H+QODQTTCKbLkyn+m6iiy8G+h9MawhPXOEUCZfl kqBptKnH9FhEZxCJWeIKpu3h481jbsAUxopt/lt3sxWjYrGwvGZSSeGc9upAPqqw6zTySE HSMsK3faDEEHvCz97Khg+HSfG+FLiL0= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-682-T3wTajPwMK6I7Aufw4Onkg-1; Tue, 05 Dec 2023 08:55:34 -0500 X-MC-Unique: T3wTajPwMK6I7Aufw4Onkg-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-40c1257782fso4342615e9.1 for ; Tue, 05 Dec 2023 05:55:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701784533; x=1702389333; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=SEVcpVCG5LqbTJH+FlkvSOnAEVuTJl164mBLwlNcRN8=; b=Voz8cTLc37iLbP25WwDCtwZDnjwP85RshK/U85C5gk40ZynALarbDIFFeOwXwlNL+r 6mjnfmywxUFU/A6cibCDH19hXhybEGPROoyU8TZml/neOLWQ4wLxOE6uk9Omvb/0RxgZ Vzsb5D+/mnNQfkq8W8Vtwv8j6nPLT1dcavLMHG/OGP89TOV2CW1BiVrNDcTkDz6ShEuf RvFW9WA3OaoFHtvD3TXiCViGyoEsT/Vfnt0xsosaC67wPGse3gmoIjtKtWcqk1x9BNHQ Tb2pgFqNhy9N+dHjTXeVitc71PHLhdtVTM0zHZ0mWYVK/ilnTz/csiojvxzm8sOhUOQa Cbhw== X-Gm-Message-State: AOJu0YxGSBVOQntW2Nzafa7r7gg4dQBuMsiwM1bNWdtOt2qv61RdzkTu jAb7D/AcAJXI8urduTfhw9PTqy8yPd+rc0C54DxuTkOdcvZlnh+CqLlqtQPGSzVTYBwYyxFoIoS GPumPrzYutsk= X-Received: by 2002:a05:600c:4fc6:b0:40c:e7c:679 with SMTP id o6-20020a05600c4fc600b0040c0e7c0679mr518268wmq.46.1701784532850; Tue, 05 Dec 2023 05:55:32 -0800 (PST) X-Google-Smtp-Source: AGHT+IHBjDwu37NND4o/i6D6CWZ8L3jvtfu6ol6i7UWvkkLTr+fvl/jd8p148SijxenSDIjtz6S8Fg== X-Received: by 2002:a05:600c:4fc6:b0:40c:e7c:679 with SMTP id o6-20020a05600c4fc600b0040c0e7c0679mr518252wmq.46.1701784532451; Tue, 05 Dec 2023 05:55:32 -0800 (PST) Received: from ?IPV6:2003:cb:c72f:300:1ec7:2962:8889:ef6? (p200300cbc72f03001ec7296288890ef6.dip0.t-ipconnect.de. [2003:cb:c72f:300:1ec7:2962:8889:ef6]) by smtp.gmail.com with ESMTPSA id v9-20020a05600c444900b0040b461550c4sm22491562wmn.42.2023.12.05.05.55.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Dec 2023 05:55:31 -0800 (PST) Message-ID: Date: Tue, 5 Dec 2023 14:55:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 00/39] mm/rmap: interface overhaul To: Ryan Roberts , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, Andrew Morton , "Matthew Wilcox (Oracle)" , Hugh Dickins , Yin Fengwei , Mike Kravetz , Muchun Song , Peter Xu References: <20231204142146.91437-1-david@redhat.com> <993ea322-8cdb-4ab1-84d3-0a1cb40049c9@arm.com> <067753e4-faf0-4bc0-9703-ec97b7de705e@redhat.com> <1ba5dd86-a201-4243-bab0-349395468236@arm.com> <537ac106-e4f6-4845-aa09-29b775269562@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: C802340021 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: necuxjztucwg9zqdc4g66t6scxb9u9yd X-HE-Tag: 1701784535-825752 X-HE-Meta: U2FsdGVkX19TGn8FpasTKGewlszLdjR5AiuG6I0KU5sq4B6iAZEBC+nJrnpOiVtkVJm3SHYQ9fbvPyTnmkadvEw0eQPxW3QVi9kFNRDs2MTlVyPQVXcIz6Ax9fgSVciHHldmfS3j+9D6m7lGxHyZC8Yj64cESgKD2CsJ76jVchPpSp3ds0fcaFZHJRbg2WCRxB2HlMHcizjqp15hL3G29ykiaWpW4NSbnua3p9mgCZO9hBBDymamKoDSUr5DsiHdRLhb6biX5QwLhslofSAX7EkUpt4NMlbQt+bWneqeDTiv9vnmbnU9t60FWEM8CGa2nHeV8eIvEmacVBUcQz9RcGvBFZ92xfRcUPW+3jl76rqnaSV+l1AZz92YPNTIzZXjnKgq20ulHnHd6fFZqANEDz1W5ur4L3mvXKxZZkyWGjI4okpr3+r7rSpCIxkDEWOSi0nVeXgjXHQ5K750qMUxCVTjjv9TPIARAPDoTwCXU+5bFGKYUlbEzewQGKWL5zt6GjPsXfYnEy3GmLDHPo2cA78350lIPktTzBBTBPKA/drnVAY6UtJCjMcAqDRiINLmSpVXsAIpofKVGd8U6ZqEcRegeyM/5TX4XN1O+RZNwdmhiBeV50ek6jpxjfH+L4M9ylzPZakjZ/4BEFbf2qYOevMOyGhGQXUhOMuCXbs0DeE9gXbhzoZsjSaCKwsHiEYm8G7XP6rq0ClQz1sIlcl6zBEDo1W0UblrI3ketpaPPJAeCEtS9eDIIK7T7NhUggTycCpNjOwyHKaF1jltjyehSOSGX3UMIkI6g6jPKUe3a3qpbSJyt78+DN9fmi2w0bEw8D/oFRwhCvtP6mHChzsXnsl7lhK/fMW3gbGaevFdpBA9ExPU9BhakttzyUE7+1H6VR3biY924EKmN7UJIBPsrV8nR06uNkUIlfVpu/VOMNbB2lEeZpfroce5q+iE2ki6+Kyy/VO1mDZF46k3Wrw VxJTn0Nn +2awj2QALodorSNV4UIW04QvRm+BFWKj5L8qndz6iKPOZzxcJ8Bp/mtcXjotCXFP7i7smgPcwtwa1mxlXOn3m7pSud9k9gE2VwsiRE0tFhSrzVEmjGlAbSYQwPiGkAaHBFqsW73pFZn8x7qIoJ9rBLHynXQIdM51QBDvo1R7hOFozZjZjeXyYpaXwJrRTAQn0Rg3/DRUv03wWFQEmem/3xu+JHpFewoe2HspWP1WJkadgMPXNLiYqjWushDw1p6RuD/hoqtRyifoZB846QG37qNAMjnam1x6kqCK9EHuD0s8YmYMA5uL0TOFP6jr9JSw4lQ4x/8zfkn3cq3zguYyX5l+nsE6GaYEmQ35v1i8njtOdaVHvPs5867yyAk7BSgreEaAE9BL/hctKXxlR8o6SFdBev/EUy48ya12mEFGcfWqLvis= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: >>>>>>> >>>> Regarding the contpte, I think it needs more work. Especially, as raised, to not >>>> degrade >>>> order-0 performance. Maybe we won't make the next merge window (and you already >>>> predicated >>>> that in some cover letter :P ). Let's see. >>> >>> Yeah that's ok. I'll do the work to fix the order-0 perf. And also do the same >>> for patch 2 in that series - would also be really helpful if you had a chance to >>> look at patch 2 - its new for v3. >> >> I only skimmed over it, but it seems to go into the direction we'll need. >> Keeping order-0 performance unharmed should have highest priority. Hopefully my >> microbenchmarks are helpful. > > Yes absolutely - are you able to share them?? I shared them in the reply to your patchset. Let me know if you can't find them. [...] >>> Having now reviewed your series, I have a less strong opinion, perhaps it's >>> actually best with your original names; "folio" is actually the subject after >>> all; it's the thing being operated on. >>> >> >> I think having "folio" in there looks cleaner and more consistent to other >> functions. >> >> I tend to like "rmap_dup_file_folio_[pte|ptes|pmd]()", because then we have >> "file folio" and "anon folio" as one word. >> >> But then I wonder about the hugetlb part. Maybe simply >> "hugetlb_rmap_remove_folio()" etc. >> >> Having the "hugetlb_" prefix at the beginning feels like the right thing to do, >> looking at orher hugetlb special-handlings. >> >> But I'll wait a bit until I go crazy on renaming :) > > I suspect we could argue in multiple directions for hours :) :) > > Let's see if others have opinions. > > FWIW, I've looked through all the patches; I like what I see! This is a really > nice clean up and will definitely help with the various patch sets I've been > working on. Apart from the comments I've already raised, looks in pretty good > shape to me. Thanks! -- Cheers, David / dhildenb