From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8F01C05027 for ; Wed, 1 Feb 2023 18:04:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 698D16B0073; Wed, 1 Feb 2023 13:04:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 647486B0074; Wed, 1 Feb 2023 13:04:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4C0A56B0075; Wed, 1 Feb 2023 13:04:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 383336B0073 for ; Wed, 1 Feb 2023 13:04:00 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id D9E3E160C27 for ; Wed, 1 Feb 2023 18:03:59 +0000 (UTC) X-FDA: 80419496598.12.F006EDD Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 9A3AA14001D for ; Wed, 1 Feb 2023 18:03:57 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DIBoJ6+8; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675274637; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NHqnRVrVGsH0s7BP5ODEjlWZFmtlmfotNCTTEzO/Y1o=; b=XoRYxiXYbXBX0IH7RMrb0BcACgrQPEVma+mLY8jYr+rYY+8gA3J4CJaNHtHlp/3V8dMuSu B2JCeHlSB2RH8DH4O1UhStxnBw1CJbJ9TYQJ/FbLnKLwxZN07K2UUghiCqjYsEE+wK0RfU /ju0OA0CbabfBYr/haZhvpJrC0VWlVg= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DIBoJ6+8; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675274637; a=rsa-sha256; cv=none; b=8LsZiHkGGLbVkjMer8feODilVEbESprYG+QPq5QNWmpcT4K93ONTyxz4MCXealwpHENDvw 6uq7xTI+AedcgOJdapr/VPegpr6WMj0qet71scMQfrCKUDbT4ncz8zUpPTPpTGjXwQdddF uf5afFF85GZ9qHywNzs0qnXPLKBqaOQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675274636; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NHqnRVrVGsH0s7BP5ODEjlWZFmtlmfotNCTTEzO/Y1o=; b=DIBoJ6+80ovzVRxNc4PwCfUoztxTdNK6j596B59r5PD0Umz9nemKxn9TKynhO6DktUJDsT 4BOM6VebW2SSf/iksi7EPB2xWNBz1Blc2kMNI1LJnRIuDwpoVpAbkV048MznuesVE/EQI7 zoWp1s9XuyXyVHdW+uGloKFOrUAhQTk= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-287-ABBXPWVLO92uP4KHASNXkQ-1; Wed, 01 Feb 2023 13:03:53 -0500 X-MC-Unique: ABBXPWVLO92uP4KHASNXkQ-1 Received: by mail-wm1-f70.google.com with SMTP id h9-20020a1ccc09000000b003db1c488826so1493168wmb.3 for ; Wed, 01 Feb 2023 10:03:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NHqnRVrVGsH0s7BP5ODEjlWZFmtlmfotNCTTEzO/Y1o=; b=SQt8aoI3/iByMEOy+9YxRms0e3eQl/f9SOAQjW19lMoQHZ74oC1Ioyn7I2Dt+avMtm owhjvlW/wYvAwEttP+jS2dkmMLZl5oWoJRAB4FiiU4OH6SHNnWqykOYyz39TBU8SzMUT dw5l0w9gbk91xu/gnwu92NQv0AOeMXFRIEw3ntvQcZCxgNbFnjsWIQFrsKvm2A4n9Hdj WHhpx2S3KBQmH64VXnnKqnrAzKmKx+pOKLiJMLkij9K1H2USNEj3Fa59BVPyCVaYg+eP pkp5NpZB5xxBOvGKbRK6DLwPudT4wAuvv7wCrF8YgpqLeJ4SZDia8WMa4iov+Ffx7Bxo bbWg== X-Gm-Message-State: AO0yUKWvyAcVRMMNyayn+LqGr7kxL/41+Q5u8kziAtoZUoGFOujP/tVA YGCsCgvCTiPjFdNfRV2APLc6+9jgF+7ZtywKnkYrX0Xpa5JdFLGrLEx/EPmbM+MDD+Y2hDEF/wL eyLF7D+uRvmI= X-Received: by 2002:a05:600c:4e53:b0:3dc:5390:6499 with SMTP id e19-20020a05600c4e5300b003dc53906499mr2951535wmq.1.1675274632546; Wed, 01 Feb 2023 10:03:52 -0800 (PST) X-Google-Smtp-Source: AK7set8RWgxHAxxme3PCml6Vw4YQkL/Vp0Q30f/GZD4RoMNh8TWXDsQ+OvBtB+e0X6QNaxXSFYW6iA== X-Received: by 2002:a05:600c:4e53:b0:3dc:5390:6499 with SMTP id e19-20020a05600c4e5300b003dc53906499mr2951490wmq.1.1675274632249; Wed, 01 Feb 2023 10:03:52 -0800 (PST) Received: from ?IPV6:2003:cb:c705:3100:e20e:4ace:6f25:6a79? (p200300cbc7053100e20e4ace6f256a79.dip0.t-ipconnect.de. [2003:cb:c705:3100:e20e:4ace:6f25:6a79]) by smtp.gmail.com with ESMTPSA id p11-20020a1c544b000000b003dc4fd6e624sm2570630wmi.19.2023.02.01.10.03.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Feb 2023 10:03:51 -0800 (PST) Message-ID: Date: Wed, 1 Feb 2023 19:03:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v5 18/39] mm: Handle faultless write upgrades for shstk To: "Edgecombe, Rick P" , "bsingharora@gmail.com" , "hpa@zytor.com" , "Syromiatnikov, Eugene" , "peterz@infradead.org" , "rdunlap@infradead.org" , "keescook@chromium.org" , "Eranian, Stephane" , "kirill.shutemov@linux.intel.com" , "dave.hansen@linux.intel.com" , "linux-mm@kvack.org" , "fweimer@redhat.com" , "nadav.amit@gmail.com" , "jannh@google.com" , "dethoma@microsoft.com" , "kcc@google.com" , "linux-arch@vger.kernel.org" , "pavel@ucw.cz" , "andrew.cooper3@citrix.com" , "hjl.tools@gmail.com" , "Yang, Weijiang" , "oleg@redhat.com" , "Lutomirski, Andy" , "bp@alien8.de" , "jamorris@linux.microsoft.com" , "akpm@linux-foundation.org" , "Schimpe, Christina" , "x86@kernel.org" , "tglx@linutronix.de" , "linux-doc@vger.kernel.org" , "mike.kravetz@oracle.com" , "arnd@arndb.de" , "john.allen@amd.com" , "rppt@kernel.org" , "mingo@redhat.com" , "corbet@lwn.net" , "linux-kernel@vger.kernel.org" , "linux-api@vger.kernel.org" , "gorcunov@gmail.com" Cc: "Yu, Yu-cheng" References: <20230119212317.8324-1-rick.p.edgecombe@intel.com> <20230119212317.8324-19-rick.p.edgecombe@intel.com> <7f63d13d-7940-afb6-8b25-26fdf3804e00@redhat.com> <50cf64932507ba60639eca28692e7df285bcc0a7.camel@intel.com> <1327c608-1473-af4f-d962-c24f04f3952c@redhat.com> <8c3820ae1448de4baffe7c476b4b5d9ba0a309ff.camel@intel.com> <4d224020-f26f-60a4-c7ab-721a024c7a6d@redhat.com> <899d8f3baaf45b896cf335dec2143cd0969a2d8a.camel@intel.com> <27b141c06c37da78afca7214ec7efeaf730162d9.camel@intel.com> <6a38779c1539c2bcfeb6bc8251ed04aa9b06802e.camel@intel.com> <0e29a2d0-08d8-bcd6-ff26-4bea0e4037b0@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 9A3AA14001D X-Stat-Signature: dqrr1asindtnkkdtu3o5we8bz97jz5i7 X-Rspam-User: X-HE-Tag: 1675274637-693627 X-HE-Meta: U2FsdGVkX18C2CjKVj8wEtu8F8Tc6pR0MkS2lJcPKprma0Ms+ZTLhcq3dkmZnv0G3v5WTXkqyBBRdh1fnNKUUbWomcvJ47WozOEAINpJFHbFmITZAFVP+kQkAdYzfJuGopgT4ePxk+e9Su19t3ax1gtyrkisHu/WTt8Q1OBeF1WJgweC3bmPBu99BepLhSNtEm2eMs8KRddbnZDXXBlFgpBJ7kjk/qJEFTYCcLmNTJSQGeZ78eJxOCgTyl4ZWhRtjVTSqC74H2kGuRrf6G5rwMSGkaFjB7YSyxX4cGPteX7nLkUNHfnv+vZ4Ct+68AnU500jAusVoXYqYU9PbIHRCaDRuhumAORz0Nt5NzonWFNiBIrQCl3LBTpWJO821AbPIpuYY8gLngqUjC0NNadySgKpjjJfvxPTBuRZ96qShGPTFiErV+7uNnWl2weIMkpLzYp/ae60vntkShXv0QXpkJ7YG9kC819zYZnjZHFffI7RjiJ5t1UMAmaf2w199OcL8MYdP7uQazAsUFvhgSJMbYxnZC06Yk7/UGXIIbeyTWnxAlUJU9Gpl7AfUX8QQgWx3UHLtA82KQdHY1XwWpI/kZce7+MVpPIWDtoxY4VXDHc+87pSQS7GUA/mP77IIimZ1bLroJhtsbTIx/SwOqJvo3XkHygAIx/Eq5n2l4W9BcLtgKIl9e98bIU3/hG8n2ssdRDLTkepXejCQ21u90dQBI2l1sv8oCj4ZdW3MYy602CpIN+b7kGht5TlL1ILs/RtExzBy/9AydIU7jxC/wFrb4RmHPowrDfmOAdxv3Ura+MTVuzGYr9ueTII6PPAlhDB4pVQ00/K4QChspHhkR1FXnQAa6B9EdErAGZtO6WouJiOH5G7j3V2JG8U9iB6HIhRKJcdhC03aHJsU7upXgshzU8SoQEjfW6WwSrpu48QKdy+ePfivz4m1gQUbbBhvZMLaV5XyQMzhWh9PkLInJO lba4srcM odTQikOp07qL+83cZH+u5uaMSCopUS59eubtneKkOtSQO8ey5rApZNCS1+vmLbMUDNYc3tFZlOBpqQpf6+TmrvMLiyqTbPoC9mogsrheL4ZnLZkJ4ejm00KobpJB8ZkGFxIyjKc/68uMdYwr+XgIFcCIWi9uwjA8yKSw3Og+vmQ98oBlRxkftcnGgam/udjjds92W3XvbjdCNJHngLrvMbY63hdfI3fF9vSkTFinQupwNoO9cFBwAqgAeXYmFEzZlVp+X4U1mn9w3xCNO1+gWBwYYa6D2O4rWPV/v50RQ4X/frhwcDyrj7BwT+qXdPl5F6B8DMrPTgC+Xby5T8wnPMSY0hr9Cb/AhQ3lBaH3qSb1/QFgfXv6RuKLjnxtTDbGjcMPijY4IfNSw4Hd2ooS0MQv4FydRBeHl4UqF X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 01.02.23 18:32, Edgecombe, Rick P wrote: > On Wed, 2023-02-01 at 10:03 +0100, David Hildenbrand wrote: >>> >>> The other problem is that one of NULL passers is not for kernel >>> memory. >>> huge_pte_mkwrite() calls pte_mkwrite(). Shadow stack memory can't >>> be >>> created with MAP_HUGETLB, so it is not needed. Using >>> pte_mkwrite_kernel() would look weird in this case, but making >>> huge_pte_mkwrite() take a VMA would be for no reason. Maybe making >>> huge_pte_mkwrite() take a VMA is the better of those two options. >>> Or >>> keep the NULL semantics... Any thoughts? >> >> Well, the reason would be consistency. From a core-mm point of view >> it >> makes sense to handle this all consistency, even if the single user >> (x86) wouldn't strictly require it right now. >> >> I'd just pass in the VMA and call it a day :) > > Ok, I'll give it a spin. It would be good to get more opinions on that, but I'm afraid we won't get more deep down in this thread :) -- Thanks, David / dhildenb