From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5103C47077 for ; Thu, 11 Jan 2024 03:44:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2BD296B007B; Wed, 10 Jan 2024 22:44:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 26F596B0095; Wed, 10 Jan 2024 22:44:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 139336B0096; Wed, 10 Jan 2024 22:44:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 0224F6B007B for ; Wed, 10 Jan 2024 22:44:56 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id CBA90160729 for ; Thu, 11 Jan 2024 03:44:56 +0000 (UTC) X-FDA: 81665638992.11.66F53F5 Received: from out-172.mta0.migadu.com (out-172.mta0.migadu.com [91.218.175.172]) by imf07.hostedemail.com (Postfix) with ESMTP id E5B7740003 for ; Thu, 11 Jan 2024 03:44:54 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=jaPkQKwS; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf07.hostedemail.com: domain of gang.li@linux.dev designates 91.218.175.172 as permitted sender) smtp.mailfrom=gang.li@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704944695; a=rsa-sha256; cv=none; b=7PtIVBZJEwtyl3tMqWGihKHLTG6lgk1xPY8AqA4SCQakiEBxUul6HPj2Yc99mpV3WskmEN unTwDYsLToMxc3uBv+PWCNy2Hmn4r8daZBIZs7A6lt1KySLDwSVmunrXGdyGQFT6EfjI4L 6spwofE0hB52DDHGC/2HyGd9ciWP8gQ= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=jaPkQKwS; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf07.hostedemail.com: domain of gang.li@linux.dev designates 91.218.175.172 as permitted sender) smtp.mailfrom=gang.li@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704944695; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=U+CspYEcNwuvAfYHCq77jqt2mm1/5Jx/MXmX2v4wHTA=; b=Y28urfB1U02yqPTmDlJFaQJpVLHQ9JdqVufR97UyJu1hIdkjlYp6cBjC0c9da5edXq/KTH VFU0stpxapfk4klFhtim7zUMXdrX2iO6LV3apm/7ywyiLJjKHBfo0Cqn3+mD8ceCc1HxqJ Y1UDxfUz6UqksfN6U+rIGOMVsUuxTnw= Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1704944693; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=U+CspYEcNwuvAfYHCq77jqt2mm1/5Jx/MXmX2v4wHTA=; b=jaPkQKwSulNW+6GDnxLN4KdvaU6ETidV9TpYvT13JhBsYwSTeKxFBJhZyPMj2LpKB2tBDS neQPOGGy61txQzZ20StvoMeJ7gAmtUec8rKDsTMqKDEdnZm8Euc43nxUMGCrVIEG1413Ey VrYFBp9uA50wTh3dwu9bKYivXM9BJXo= Date: Thu, 11 Jan 2024 11:44:46 +0800 MIME-Version: 1.0 Subject: Re: [PATCH v3 2/7] hugetlb: split hugetlb_hstate_alloc_pages Content-Language: en-US To: Tim Chen Cc: linux-mm@kvack.org, Andrew Morton , Mike Kravetz , linux-kernel@vger.kernel.org, David Rientjes , David Hildenbrand , ligang.bdlg@bytedance.com, Muchun Song , Gang Li References: <20240102131249.76622-1-gang.li@linux.dev> <20240102131249.76622-3-gang.li@linux.dev> <9b95c0ac0e5d560f1482af3753df54211a057b9d.camel@linux.intel.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Gang Li In-Reply-To: <9b95c0ac0e5d560f1482af3753df54211a057b9d.camel@linux.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: E5B7740003 X-Stat-Signature: 4u4no6k6mb4zycn5xs1gwxu9jegfn8ws X-HE-Tag: 1704944694-219727 X-HE-Meta: U2FsdGVkX18Er+IID1q/JTZknx0rcYq6InuW7z4iSCod18s2X9h+tXRHIJNoF01rvXs7KZwsy+oHEOTJLSCNThqLQ9KHFDw6CznG8YJvjsuz32Bu7lEtqjgjDcrPoHwnZhgLiTPgAXPvfJaIHrbl7BL1o7CtrWVC2EDUaEraWQ0NJUq+nlr5AF07ma/aaSnQ+J4DRzlx4Hpv/zp/XZTAWmYNsLoLC0E47zuiJzVLRa5WHVcXZOprgutLlaHFb4hqlD9nAuJfd//RA5OfPj2mHZ40KWysZm9qMXJBH15k1cexH8REELAsEMGCUMwnTMJU/xzbdXsWHt9tch+WHNO1f8aIVVtFUPsYN1ApGT5+N79GQurUkE3CgVuLUHanXrrvJLzEhgJVJXx/iC2+8zz9SUnIwCWZWpM4iZnwzTrhyXYvc5I7K8TdBWFfgyTF733fULh/twbWzjRlotEl9mEtz9LCMJlFY8UW9IR72FftBBy85Y3OFHGEPoE2USGsclxtoBCeHbO2AffG/2gAed8N7HJrmS+qvLFJaqoxgG/B5pA2YKjKp9l8EqUeL/2HtlMmAKaImdvbJyWMvtXJUI1AWVCniqAWbtEfnv09BPbWeQI9cKnwaUttw4hU3Q0nDAVNhYSVnSuJVx2+Vepz89VF5AX5Mawa6k/5aH1rh1NhAMrgkWbl46Lk/73KmmO1tTW63DBP1p0nm4hpL5iB00wQEAtdjpKv9BzaN6l79FQqD7+exMYukC8RMYb3Q2vXXcaT2JLuRVwkoFQOu+ZCySsXbK8Dsi8WPd8kvMqaEixCqh59aTu5nWGFC++63oiYsCLR5+v99QCjJgw3skH/xl6tS2Ww1vsRw8KojSkdzOtlI4NkxIxEFv0AGr7Ke4XBC788GRpm7nEiOo0OqtN8RKubMRBSuKAAvgStuAQ2nCo7H8f8cXaN/UhoMelCJy11Zt+zCtzh5JOQUzRlNJINI6m 4cKggnVS pNv18LICJoDPSQdRoWXBj7KrLgH7tLUF+11klh1kHCKkTfuuzKDuxL1Amck9ac5zcfzZSEFff9MG6/W0U5UR8833+fsdCuPCE24eXaZ2rDQYjxVatAJFVkTOm2tJ8+mz+hlguayQHOztPvVNG3LU85UqQTM7f7ZyUjw26 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/1/11 07:12, Tim Chen wrote: > On Tue, 2024-01-02 at 21:12 +0800, Gang Li wrote: >> +static unsigned long __init hugetlb_hstate_alloc_pages_gigantic(struct hstate *h) >> +{ >> + unsigned long i; >> + >> + for (i = 0; i < h->max_huge_pages; ++i) { >> + /* >> + * gigantic pages not added to list as they are not >> + * added to pools now. >> + */ > > This comment unnecessary as now we don't have mix gigantic and non-gigantic code, > which uses foilio list. And folio_list is not in this routine. > > Can be removed. > > Otherwise Reviewed-by: Tim Chen > Thanks!