From: David Hildenbrand <david@redhat.com>
To: Wei Yang <richard.weiyang@gmail.com>, Dev Jain <dev.jain@arm.com>
Cc: akpm@linux-foundation.org, lorenzo.stoakes@oracle.com,
ziy@nvidia.com, baolin.wang@linux.alibaba.com,
Liam.Howlett@oracle.com, npache@redhat.com, ryan.roberts@arm.com,
baohua@kernel.org, lance.yang@linux.dev, linux-mm@kvack.org
Subject: Re: [PATCH] mm/khugepaged: use [pmd|pte]_addr for better reading
Date: Mon, 22 Sep 2025 15:28:32 +0200 [thread overview]
Message-ID: <fb5bbaae-15bd-43c7-afbe-84a951f97044@redhat.com> (raw)
In-Reply-To: <20250922130255.lbrrbrr54iwso42i@master>
On 22.09.25 15:02, Wei Yang wrote:
> On Mon, Sep 22, 2025 at 01:56:54PM +0530, Dev Jain wrote:
> [...]
>>>>>
>>>>
>>>> Take another look into the code.
>>>>
>>>> The change touch three functions:
>>>>
>>>> __collapse_huge_page_isolate()
>>>> __collapse_huge_page_swapin()
>>>> hpage_collapse_scan_pmd()
>>>>
>>>> Use pmd_addr/pte_addr look reasonable for hpage_collapse_scan_pmd().
>>>> And haddr/addr would be suitable for the other two.
>>>
>>> haddr vs. addr is just nasty.
>>>
>>> Can we call the aligned one "aligned_addr" or something like that?
>>
>> This works. Let us use aligned_addr/addr everywhere then.
>>
>
> Including hpage_collapse_scan_pmd()?
Yes. Anything is better than what we have right now :)
If we just want to express "this is the start of the new THP", simply
"start_addr" might also do?
--
Cheers
David / dhildenb
next prev parent reply other threads:[~2025-09-22 13:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-20 0:54 Wei Yang
2025-09-20 4:30 ` Lance Yang
2025-09-20 9:00 ` Wei Yang
2025-09-20 12:42 ` Lance Yang
2025-09-20 4:51 ` Dev Jain
2025-09-20 9:02 ` Wei Yang
2025-09-20 12:31 ` Dev Jain
2025-09-22 8:12 ` Wei Yang
2025-09-22 8:16 ` David Hildenbrand
2025-09-22 8:26 ` Dev Jain
2025-09-22 13:02 ` Wei Yang
2025-09-22 13:28 ` David Hildenbrand [this message]
2025-09-22 13:32 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb5bbaae-15bd-43c7-afbe-84a951f97044@redhat.com \
--to=david@redhat.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=dev.jain@arm.com \
--cc=lance.yang@linux.dev \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=npache@redhat.com \
--cc=richard.weiyang@gmail.com \
--cc=ryan.roberts@arm.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox