From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8998FCE79AB for ; Wed, 20 Sep 2023 07:46:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ECE6F6B0125; Wed, 20 Sep 2023 03:46:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E7F976B0126; Wed, 20 Sep 2023 03:46:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D46526B0127; Wed, 20 Sep 2023 03:46:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C4E826B0125 for ; Wed, 20 Sep 2023 03:46:45 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 9A7581CA162 for ; Wed, 20 Sep 2023 07:46:45 +0000 (UTC) X-FDA: 81256193970.02.43612D7 Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by imf17.hostedemail.com (Postfix) with ESMTP id E4A6B40018 for ; Wed, 20 Sep 2023 07:46:41 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=samsung.com header.s=mail20170921 header.b=RqiJiqir; spf=pass (imf17.hostedemail.com: domain of p.raghav@samsung.com designates 210.118.77.11 as permitted sender) smtp.mailfrom=p.raghav@samsung.com; dmarc=pass (policy=none) header.from=samsung.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695196002; a=rsa-sha256; cv=none; b=H5J9u4OVSCQN0rVc47+WnZ7/ZfaB5r46pNex2mjY0V9VdgeKyRsQoY/ijd9RnuZJt2e365 nYItplQ7Tr3lnw8E5vxmXin3mxvGIqwgMG4iYb1Y4AwJlKnkXhhrzoY4XUnjAgOcTtMU91 oNwVANT8ONJfWBTLuvfyDQhSDAZzM7g= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=samsung.com header.s=mail20170921 header.b=RqiJiqir; spf=pass (imf17.hostedemail.com: domain of p.raghav@samsung.com designates 210.118.77.11 as permitted sender) smtp.mailfrom=p.raghav@samsung.com; dmarc=pass (policy=none) header.from=samsung.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695196002; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mpadb/9tFj+5PzcSP6XTgQODzpOlX5ctR1kmrU44hZQ=; b=hcTYzTOXYYTtIBHXamo3Jz2OmCBfjstHNmwLiiVpdA2RJr2MtOcfY5xnOu2jJzlgL5yFJV AcSxn1+XvBivYjzuL0DKC/JL7DCv+HT2SvsQrKlLfYDSBCfMPGU4+T9n6F4dd1Gj7RGUF3 eIcfdtPRH9eKdCIFcpZEy5UmSY6P5TA= Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20230920074639euoutp016cdae5c781436aa24f579f5c0a783db2~Gi8esBvge1116011160euoutp01h for ; Wed, 20 Sep 2023 07:46:39 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20230920074639euoutp016cdae5c781436aa24f579f5c0a783db2~Gi8esBvge1116011160euoutp01h DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1695195999; bh=mpadb/9tFj+5PzcSP6XTgQODzpOlX5ctR1kmrU44hZQ=; h=Date:Subject:To:CC:From:In-Reply-To:References:From; b=RqiJiqir9mni6uSwxjTyCnAyWsdN66fOTrl3lQQdEGPJKUJ45r+ASLOrVcv36+UK1 0aTPfkQlZE6CZ6N5HikIWQtuv+04NMYz4datyc8HU9DzNSvYtr+77Q/qltcH+TQcK2 6HcspKq0gtSmF4a45V7nVv9l8Mml8UUX5krX5mNY= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20230920074639eucas1p2315f875b51eefe3573cc37eed8e420d1~Gi8eV8OOj2272522725eucas1p2x; Wed, 20 Sep 2023 07:46:39 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 23.C8.37758.E53AA056; Wed, 20 Sep 2023 08:46:39 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20230920074638eucas1p2f7dfdd629156a591697f8ba3376446e8~Gi8dldIsw1101511015eucas1p2H; Wed, 20 Sep 2023 07:46:38 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20230920074638eusmtrp267241c28aabb2e2e221d362156a13169~Gi8dh4NqC1560015600eusmtrp2C; Wed, 20 Sep 2023 07:46:38 +0000 (GMT) X-AuditID: cbfec7f5-01f15a800002937e-11-650aa35e2c32 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id A6.EE.10549.E53AA056; Wed, 20 Sep 2023 08:46:38 +0100 (BST) Received: from CAMSVWEXC02.scsc.local (unknown [106.1.227.72]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20230920074637eusmtip1832c020440adb3cb8ad9bab001921d4e~Gi8dT7wug1555115551eusmtip1w; Wed, 20 Sep 2023 07:46:37 +0000 (GMT) Received: from [192.168.8.209] (106.210.248.121) by CAMSVWEXC02.scsc.local (2002:6a01:e348::6a01:e348) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 20 Sep 2023 08:46:36 +0100 Message-ID: Date: Wed, 20 Sep 2023 09:46:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [RFC 02/23] pagemap: use mapping_min_order in fgf_set_order() Content-Language: en-US To: Matthew Wilcox , Pankaj Raghav CC: , , , , , , , , , , From: Pankaj Raghav In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [106.210.248.121] X-ClientProxiedBy: CAMSVWEXC01.scsc.local (2002:6a01:e347::6a01:e347) To CAMSVWEXC02.scsc.local (2002:6a01:e348::6a01:e348) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrDKsWRmVeSWpSXmKPExsWy7djP87rxi7lSDU6VWsxZv4bN4tJROYst x+4xWlx+wmdx5uVnFos9e0+yWFzeNYfN4t6a/6wWu/7sYLe4MeEpo8XvH3PYHLg9Ti2S8Ni8 Qstj06pONo9Nnyaxe5yY8ZvF4+PTWyweZ1c6enzeJBfAEcVlk5Kak1mWWqRvl8CVcWuZVsFH 9opj6x+yNDBeZe1i5OSQEDCReHPoC5DNxSEksIJR4vqGOywQzhdGiU1fF7NDOJ8ZJaY2PmKG aWnYchCqajmjxPKbl5nhqp6dfwQ1bDdQ/6vd7CAtvAJ2EsvW/GACsVkEVCWu3FzHBhEXlDg5 8wkLiC0qEC0xc9pCRhBbWMBL4s2Ml2DrmAXEJW49mQ/Uy8EhIhAs8fqsGch8ZoGlTBIfzv5m AYmzCWhJNHaCreIEuu7unq9sEK2aEq3bf7ND2PIS29/OgfpAWeLU9u/sEHatxKktt5hAZkoI LOeU+Lt8NRtEwkWiqWMrNJSEJV4d3wLVICPxf+d8Jgi7WuLpjd/MEM0tjBL9O9ezgRwkIWAt 0XcmB6LGUWLR82WMEGE+iRtvBSHu4ZOYtG068wRG1VlIITELycezkLwwC8kLCxhZVjGKp5YW 56anFhvnpZbrFSfmFpfmpesl5+duYgQmsNP/jn/dwbji1Ue9Q4xMHIyHGCU4mJVEeHPVuFKF eFMSK6tSi/Lji0pzUosPMUpzsCiJ82rbnkwWEkhPLEnNTk0tSC2CyTJxcEo1MJXus/rPu/Bt /P+/TyXl7pX+fHAyhqfPZ/qlEDWxnQ+q5jptvhyy35n/3I7HsTwzhYuXNX0KFHWUudcjYOEQ 0yqsyLErZ3r2saUmfvunO1RqLei8xSmbcY+/9GCASLLnSumF50O2L9xsUbZM3PQh499r13cG zXvB+OUM0/vfh1/HfV6a/sX9i/eJ+3f/8Kx/Kq8s4bd0jbL0sgn7Np30fquzr1V+I8uqtF+r H3rKtwXrpK9OsLXn1VdMn1nxbN9CF9cP01xvhd5LKXBtPZv70FNk8bwdZtFehtfW552eJnir 6uIl28Ckx/171dZOPHWr3lnvbv2mDdv5na9O6le6uZo9+uab7JAWb7v5wrcEFycqsRRnJBpq MRcVJwIAsTFFx88DAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrIIsWRmVeSWpSXmKPExsVy+t/xu7pxi7lSDf7cZbOYs34Nm8Wlo3IW W47dY7S4/ITP4szLzywWe/aeZLG4vGsOm8W9Nf9ZLXb92cFucWPCU0aL3z/msDlwe5xaJOGx eYWWx6ZVnWwemz5NYvc4MeM3i8fHp7dYPM6udPT4vEkugCNKz6Yov7QkVSEjv7jEVina0MJI z9DSQs/IxFLP0Ng81srIVEnfziYlNSezLLVI3y5BL+PWMq2Cj+wVx9Y/ZGlgvMraxcjJISFg ItGw5SBLFyMXh5DAUkaJRwuPMEMkZCQ2foEpEpb4c62LDaLoI6PEti0/oDp2M0oc2D+VDaSK V8BOYtmaH0wgNouAqsSVm+ug4oISJ2c+AWrg4BAViJboemkMEhYW8JJ4M+Ml2DJmAXGJW0/m M4GUiAgES7w+awYynllgKZPEh7O/WeAWNzy6xQZSxCagJdHYyQ7Sywn0wd09X9kg5mhKtG7/ zQ5hy0tsfzsH6hlliVPbv7ND2LUSn/8+Y5zAKDoLyXWzkJwxC8moWUhGLWBkWcUoklpanJue W2yoV5yYW1yal66XnJ+7iREY99uO/dy8g3Heq496hxiZOBgPMUpwMCuJ8OaqcaUK8aYkVlal FuXHF5XmpBYfYjQFBtFEZinR5Hxg4skriTc0MzA1NDGzNDC1NDNWEuf1LOhIFBJITyxJzU5N LUgtgulj4uCUamCy1uEMWfyofLkd3/mAoAvfa/dVvb9eH+YSc+ugsQBLbdntntBttV1zIkoi RSfzfSmf9z4rulF807PExjXCzxOyXi5WcZcV9lVvEt20ddaf4zF6WVen1n2YUZwYu6YoxHqu Qf5179U9nzWcL26aHWyu3b5W4r5ztNSxLE6tS+dZjntv9S8tiD/BYik4Y/bRapsdP3s1JT1n 7NwisLzxxoP9FRNZ5EvypuxfmX/GR21ekaLk/cKmxaq6W5YzRi9nE7BaOX1a3m8VazudE+1l ASxpy1a7vti8wrJRo9xPXbg0rewfw6dj810FzL87Tmi8OkPh344DjvcWX/xmVXPC4oj5SSb9 dTGLa5l03+na3FFiKc5INNRiLipOBAAZe6NShAMAAA== X-CMS-MailID: 20230920074638eucas1p2f7dfdd629156a591697f8ba3376446e8 X-Msg-Generator: CA X-RootMTR: 20230915185527eucas1p1dc822c08a58effe30e3bf487103b22a0 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20230915185527eucas1p1dc822c08a58effe30e3bf487103b22a0 References: <20230915183848.1018717-1-kernel@pankajraghav.com> <20230915183848.1018717-3-kernel@pankajraghav.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: E4A6B40018 X-Stat-Signature: nq3b34r3j8p44qa1nstsa4ikrunbspt8 X-Rspam-User: X-HE-Tag: 1695196001-806355 X-HE-Meta: U2FsdGVkX19m0JW0Mlko9e2rmW0nD4GgkGnH8kKe4oP3xOjVezbxnV2CEy4/QBe2MGQZILr29+QHms3WJw7mppv1ed/9GD5H/5s9js5ij9xyQZyQ6y3ZbS12ME/ekSP3neQH4l0obtuqwtLiobk9q/fzU1ZqYxACL7t3MrwZjKaseFrHTXQAgrBsLA1yIGKlCtcYvHDbs7QiKWvFWtsEdvSsVAOzk9GreCMtG8BYox5kBAHJiT5usbg4QSXxLGNEXpt9okuBgpKKAQHB0Ffrihem20W5dMl9NGIfw+dq9by1VKaiwQlqkHLIdE1uHiu7UT+C4yt+R9+DZPiOoeYXH272oHUo8qiK2/QjEAHNsfT3xey12IIphkfGZ4ooCzJ+G+BfIj3m8Puum6s578DaBCD6zb26EaEFr/FXTaE1PEgTBSh4k2EsP13jGd4v/ucwbDh++a7VA9LEx85mazXWQq+HWj0JJnoz4BM/Apa3dCTHH0N/QJjYyzMxJy/dmLFz2xzkJl+x04VkKkAawmoxrnp2AWvinsE3nBmK4kC6Qq32rdBOEhuHroo+q2kwYsvJW0zvV+nAvtAHY/GliSyop0BX0WsnYF7d3fi6RIEvdv3vnpVBwM1e3Amfwp0fW7yWRk0mg3BY1GD+/N8fqH3agl5DwON7hR6Fs6IPcnw1yCSCAO8bCNSSl/Plb1dt8Q+AgQFBheKivUYBe5TmyR2srVoZfdpTso6bizw2MV/4kq5qWkpv3b4/rSVL8V4ZYqRYXtTFqIKZco/V9aFUIHMPuPzXvo7J3i094r/8MmK8mbVp/rv25sokh8U+WpQCuGVI8xKQyzEv9LTJEfoiS0WJsV44dcptSie8giKEv8B14y6/scUADBuTh892uf8Tzm1GJgE5Zcj2on2K5gvQUlrq7fZnhyNBtVKAB5XILoZbH6tFvb8oC9Qqc0UJgt1saml7wdRMuuxehCunFvWhniZ RYwZDBuV sLc1cNcAzSQCzupH0CQUoktD6CtcjmdfaM/k3WN7n6pZz0MWCMnhOehQPsy7pFPNTpe3AB+T1KLL/dck3mmbU+Nw826GCIuZU4IvXwGrlh2q0wL2ZJWP8A3TFlQ0nC9V9kZqdwRu+IB02uzS+R6D7h8cTp8IOevAugz86WJ7t125zPdM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023-09-15 20:55, Matthew Wilcox wrote: > On Fri, Sep 15, 2023 at 08:38:27PM +0200, Pankaj Raghav wrote: >> From: Pankaj Raghav >> >> fgf_set_order() encodes optimal order in fgp flags. Set it to at least >> mapping_min_order from the page cache. Default to the old behaviour if >> min_order is not set. > > Why not simply: > That is a good idea to move this to filemap instead of changing it in iomap. I will do that! > +++ b/mm/filemap.c > @@ -1906,9 +1906,12 @@ struct folio *__filemap_get_folio(struct address_space *mapping, pgoff_t index, > folio_wait_stable(folio); > no_page: > if (!folio && (fgp_flags & FGP_CREAT)) { > - unsigned order = FGF_GET_ORDER(fgp_flags); > + unsigned order; > int err; > > + order = min(mapping_min_folio_order(mapping), > + FGF_GET_ORDER(fgp_flags)); > I think this needs to max(mapping..., FGF...)