From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 657AFC54E60 for ; Thu, 14 Mar 2024 17:05:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E93C8800CB; Thu, 14 Mar 2024 13:05:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E1B95800B4; Thu, 14 Mar 2024 13:05:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CBC83800CB; Thu, 14 Mar 2024 13:05:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id B81DC800B4 for ; Thu, 14 Mar 2024 13:05:30 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 25D191C1A44 for ; Thu, 14 Mar 2024 17:05:30 +0000 (UTC) X-FDA: 81896270820.22.9D12D09 Received: from mx2.freebsd.org (mx2.freebsd.org [96.47.72.81]) by imf07.hostedemail.com (Postfix) with ESMTP id 0358F40027 for ; Thu, 14 Mar 2024 17:05:26 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=freebsd.org header.s=dkim header.b=A51Ptusn; dmarc=pass (policy=none) header.from=freebsd.org; arc=pass ("freebsd.org:s=dkim:i=1"); spf=pass (imf07.hostedemail.com: domain of jhb@FreeBSD.org designates 96.47.72.81 as permitted sender) smtp.mailfrom=jhb@FreeBSD.org ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710435927; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9j0M8JjxyKdPr3iVbt4uZU0hUBO6Bi0AlJBh7AZ66ww=; b=mL/VvJaUV8TtrDgaBjzYdliMiScHI3Akcat0EH9SwRceV0yOerTqoYOxB4oo5VEzHUmPhu lNjNTWR+AbTAR/O+O9bLMcS7OHTMDJK269bFks9tGLZkUAnOJLn7H1aEQR6iJhQUzT2tKM dHl3gf9zvhwxzlLvkc4c8jExgf5dIQM= ARC-Authentication-Results: i=2; imf07.hostedemail.com; dkim=pass header.d=freebsd.org header.s=dkim header.b=A51Ptusn; dmarc=pass (policy=none) header.from=freebsd.org; arc=pass ("freebsd.org:s=dkim:i=1"); spf=pass (imf07.hostedemail.com: domain of jhb@FreeBSD.org designates 96.47.72.81 as permitted sender) smtp.mailfrom=jhb@FreeBSD.org ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1710435927; a=rsa-sha256; cv=pass; b=I7sOpJjnXxAaY7rKOPyNCCXmj2H8nM9lo5cpTkN2Zu2yAoAeTEPKU5DvaKEObv1zv54O0n N7gNftY08mkbVWBva7t7RiBayGfCqK3vrMREsrzMPoZDX110dY+OT/OcQ/Y4BkVTEUgum8 GEkxuWTwTm9uFA6oY7THyC5OXBr9lG4= Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 4TwYfZ2dfkz41HY; Thu, 14 Mar 2024 17:05:26 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TwYfZ1j4gz49x0; Thu, 14 Mar 2024 17:05:26 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1710435926; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9j0M8JjxyKdPr3iVbt4uZU0hUBO6Bi0AlJBh7AZ66ww=; b=A51PtusnP8asP8mnDHEarH6Ygs7ApTBboH+2fkmMUZZWMQd6O2ZnfnsaAeM8sabDEqzkRz 08bgNG2faS/SlNd+34rb2StDL/E4oUpsYVrp6oXecdQ0/OYpQuzjus+pS+TQOeM0ng0tp7 QHMsNl8RFwMn5FGJB67uGfsa0d+LpJ/eycek8xJH5HmFKOTHJoMd62ecdomzVEwcWY7bmK p0brbvdkTeniKPoV/EjTlAJiwPO5BGqGAlfqV52jdnd0eoxx8Yur9qaHX+rlcQSn76NJ2R MfamkDe2dJS7AjEVgYh560gB65doD8KEU0iSd7STNxGd8hRm+qABTqZjkyYvzg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1710435926; a=rsa-sha256; cv=none; b=vm7k1fiPbWJRiqvXvm7Ez8E4FTzKcB6GfoF7flPBilfr1wfM2/Ld+gpgSkWKjj2Mi3aZ3T ydoR2k0dpzwRFhgsdFLo9skNsAJ2Kih9sVr1RZlitKN3Ohgn8ukmZO1xgkET5Ngi7yNJjM z3s9nC5zBIZ3Y4r072FqqL415nfL8ZmaXUgiUQOqhEyDp4c6Rx9G6iImsohDZJb4JQPer1 T8b258H0cmME0PYhrmb0LYRn0yci2wNvlH3hulkrA7C3c24UWOre/J1BMetsV2DsD/Tb1x BNzR9R9/BYzyiWnueGwKXmGuxwe7HUWqGfTLq65SXVPsxCYPMaRhFs2U7pfJyA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1710435926; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9j0M8JjxyKdPr3iVbt4uZU0hUBO6Bi0AlJBh7AZ66ww=; b=JFPLHqMDzcZhkDiXx3+G2enS6uq9qihacbeSHGKIV38irhdfze26RrdTDocRqr8zue12EY N6+A8Ff1UBf6S94UeegAQu2uLdml9S4HeXYhhsRYG3kO61rFByJNxoZ6AbqdsN+VB3JARj vaJLd1EJm2AVZ32/AB9zvK7jFTW0u6LkUd/ICBFJ7H+BsHbJF1uZQBcf9TwnS2PllWVhlS gqLehBMi5XHoo4LIpKvRr4Smq50V2rZ8wYYrVoyl+/u1IqK1ngVqtkey6K5Fa44nobLMy3 me7kgcdz6lWhIMKR4qf3GX2tDCBDV4h5ISeMKj7Krt5ameP8vWRAio9DNA4wtg== Received: from [128.232.109.22] (user-109-22.vpn.cl.cam.ac.uk [128.232.109.22]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4TwYfT3WVWzNvT; Thu, 14 Mar 2024 17:05:21 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: Date: Thu, 14 Mar 2024 10:05:18 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1] x86/elf: Add a new .note section containing Xfeatures information to x86 core files Content-Language: en-US To: Dave Hansen , Vignesh Balasubramanian , linux-kernel@vger.kernel.org, linux-toolchains@vger.kernel.org Cc: mpe@ellerman.id.au, npiggin@gmail.com, christophe.leroy@csgroup.eu, aneesh.kumar@kernel.org, naveen.n.rao@linux.ibm.com, ebiederm@xmission.com, keescook@chromium.org, x86@kernel.org, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, bpetkov@amd.com, jinisusan.george@amd.com, matz@suse.de, binutils@sourceware.org, felix.willgerodt@intel.com References: <20240314112359.50713-1-vigbalas@amd.com> <20240314112359.50713-2-vigbalas@amd.com> From: John Baldwin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 0358F40027 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: grfrrtdfue48k11gs5ehei5cr11g1zdw X-HE-Tag: 1710435926-57106 X-HE-Meta: U2FsdGVkX19ny97h1r729cy6T502FFZLDfQikozN8aVp+tYNMCN7RUXRanwZmkLBydcbohdehzWbwbYRl94e7uqyUqnzK+zXpsXU/X/R6cJhNwUtcoYcuAz2L14bh33BsFzJWVbeaI7aXxfDJRx8UJ4xK9rO9Z5di8ecRKAu9yT0PFMelNSHeNJSJ5RhAmKQzceYRqFWdtl/8xXPz6FsG3GMNFIV51IglWsnO9+aOaTxxWOZTVwdB3gKV+HopGKcuJVF2drWQxYXg22P3FfcSxvrb53g/Li6SZIxnW7IlfWvNRfIY6FHD06STjT7dHFxDSbYI9ReMyGSggbdPLehQFlkD42fyWJGiuo7O1bSq9lO9IiGBE93EQjXUFYVlFjLROgs1oWoblnZLkreADhL5xMa+OsVr6xVdA5Ac9uaVcBVY3OMm+JyY892brNRHsOrjxw6pDknkIMkG4PCxHHJMGrZLzhE/9vTZSnAkaRFXSW0iuqB1qFqTP2D/vMV4psiQhIsc7Q1QC3jKNl3Tm9cRY8G+su1MwK0XM6AGDWHXd27qTjubaq3Crpy1o+fIbIrmZ/DbH4N5ssj32/xpItwrVCxJSns4b4FtVsoQz0qnbHG93Ayy8XSUd5MVMr+RQVLS8i0sIOpkviqfLVi+Gw1gi1InEwgfI7EMSTUneWyQNwqFP2tIKUgJexPQ17hSM5T9aWy0XOepP4eb87ToNOng/Gma9T7a0V7CMKEq3Ks9bjVMRxEm9Lc4eY/ky9sYUaLr2oyk9uDEaZX3JcRhpTZ3noj7XNmPlJCJS0QfzvEPZcEVdvzsSIJ5fJSayH2biYmOz2yIE60CwqGQKRt8iTYJCG5z7QeLfovvEVTZoMdtBtARwMZfoaUIdHFIFuyp73uRMc8BWEDA0oXJ0M0FTJr6Mgn+AZmR+cOFZCNn9eTTqqrIhENp7AMKrQJZ9a2F+vxygZQVhwW5xjSUguPUaj QWMlwh4q 4sqdwUfB0aki6NnJ62caxU+Ea2TjZUO0bEw+vkAeLlxB5rxC6CbLMy09JneOr5ikyXQizw+kP3yt0Zt7zH4egk93io8uk18RE+CiP3fFxNo0zYp32t56fkLOthub1vxZC0TDNghDp2O562s2ilxk9VLb2NZ9VWRmDrM/nxgAfMzZs+rskpP/FnHSHXz6ire/ci67GavQbjuNE1uzbHu0r8dd6n0cO5ERWY4JWQaTVgKNYFYWqfcoTiCqxiDirKN52Pqh1kivhkumrT3jLbzwgXZ8rkPV5vzBpF9bxBm+az8JCWSfQ8dese74UoBvchcE4QRFx98KucVC2J8BknAHR8/KpUrt2TfeZ0zw2V/twF/FI1TilHrt/FxwFmg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.001659, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/14/24 8:37 AM, Dave Hansen wrote: > On 3/14/24 04:23, Vignesh Balasubramanian wrote: >> But this patch series depends on heuristics based on the total XSAVE >> register set size and the XCR0 mask to infer the layouts of the >> various register blocks for core dumps, and hence, is not a foolproof >> mechanism to determine the layout of the XSAVE area. > > It may not be theoretically foolproof. But I'm struggling to think of a > case where it would matter in practice. Is there any CPU from any > vendor where this is actually _needed_? > > Sure, it's ugly as hell, but these notes aren't going to be available > universally _ever_, so it's not like the crummy heuristic code gets to > go away. I forgot to mention one other use case for this note. Today (and before my earlier patch series to add the ugly heuristic), when the NT_X86_XSTATE core dump note grows because a CPU vendor adds a new xfeature and OS's which just dump the entire XSAVE state start including that, GDB fails to parse the entire note. Having a note describing the layout (whichever format is chosen), allows GDB to still pull registers for features it understands from the larger note and ignoring the parts of the XSAVE block it doesn't understand. -- John Baldwin