From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1096BC83F10 for ; Sun, 27 Aug 2023 10:15:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5868F900008; Sun, 27 Aug 2023 06:15:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 537908E0001; Sun, 27 Aug 2023 06:15:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 42557900008; Sun, 27 Aug 2023 06:15:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 323878E0001 for ; Sun, 27 Aug 2023 06:15:26 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id CE497C01AB for ; Sun, 27 Aug 2023 10:15:25 +0000 (UTC) X-FDA: 81169477410.01.7F452E5 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) by imf14.hostedemail.com (Postfix) with ESMTP id F1FAB100021 for ; Sun, 27 Aug 2023 10:15:23 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=MZyNrK+z; spf=pass (imf14.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.221.44 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693131324; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JKRUbUuhJKaIwa3qDyE5pLuTPeYn99sgtOiRmzFrU1o=; b=ZQ5fT+q1bQq0J7VVNVdTZCvfWEF+YUgxcH5pOOrFRD0a/wh40Hx+RBQ35NzUG47hdD3/FP DQgZiM/ykSCYs3nsFwJenkcX8Z5HGNw0Ih2uL8QiFitCxn75GbiOqQ2nP4xZZTJ7NWOPkN y6o/xxLS6RYhVclGToVIe9u+dPpDG5A= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693131324; a=rsa-sha256; cv=none; b=p7wDK3Hvy+w6OYCbMVTZp6VzOAkAuDUsbCkn1xJZzGXhwELgYZcDmGlD8Iu+kxhYTGhaxk gYpWpwXoviQJuVR4xy4uUQAWs58fiwWuIj3AU6a0Uphwr8IM2EvO4TXZr2TP8KZPqRo4P7 DwtmiCJTgIVQ657WKCCc3fGaLmsJsAw= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=MZyNrK+z; spf=pass (imf14.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.221.44 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-31ae6bf91a9so1838325f8f.2 for ; Sun, 27 Aug 2023 03:15:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693131322; x=1693736122; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=JKRUbUuhJKaIwa3qDyE5pLuTPeYn99sgtOiRmzFrU1o=; b=MZyNrK+zky4qPiM7YuIzYBRlUuXPVUlmaKRgMfhThnYq47Y8ZgEawrMIWMia4hy+GD 7QvwOzwmBddVVPfsHaU9D/y6wOwSYQBybpHv68Mpsnzae4ruR86Q0hr1Yr7mzimyRZTJ FVFWgOtjqMUMfa4yKwS6gLnzUX+XO4bLr8EgmWX2tXY1gz3H20YiqvTRh6qN41xPD5dT CL3tw9oCEg1TmsKgCglKmSx+KtCUdhbeII4Iv2qd2PxA3E/PIzuK0xGeI0oItDtkOKWr RhNGS+DAqGyOKVdLJ4syJWoPOOZ0QbUdIbYQ+FVs2VjZF6bkAT8YehWikZl2JtOcfPzj TcVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693131322; x=1693736122; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=JKRUbUuhJKaIwa3qDyE5pLuTPeYn99sgtOiRmzFrU1o=; b=IA2P6h3QEhe2R+6FrhRSPRMwEhZwKi1LQUQ+PHbvbm6CX+veeaLJvGA44fQT7XMZAk k8MXwfE7ZhXbOsVJHldIRA5wJ36QyPXqlYc4b9bqMOCxqgLMibSc+DMxu9yR6mxV1eP/ iEufV1YnAs20V0Np0A1eLay6CqXnqVxY+FXjRPSVueYtwE7mXD4OnHBcCziEdTyaJSGT f9AfFFzoSXc7325m7cxWbrFFTmpw/y67sahchOUnz7ptMTZqRS9+v2GFmsMEMrKo0jIZ NSPSl2GPCvoRj9GGQoExwRZlWp5JbeGSRjfeR9pUNsVo5uiOqu/HKM4fEThBKSsB1/9i q8rg== X-Gm-Message-State: AOJu0Yx7KEeSW4qBzLelI/ERyO8W6qHdbbjdGtniKsHTd279UdQInqSf PC/cHmI5XWts/FZmPYSH3js= X-Google-Smtp-Source: AGHT+IEnyudIg3nKBtZiGWQhS9+o2sGjSVBJKjN8yVI0U2TXJjqwP76b4fojHe+sCRqJD3GIgEKUhw== X-Received: by 2002:adf:dc86:0:b0:317:ef76:b778 with SMTP id r6-20020adfdc86000000b00317ef76b778mr16658985wrj.63.1693131322390; Sun, 27 Aug 2023 03:15:22 -0700 (PDT) Received: from localhost ([2a00:23c5:dc8c:8701:1663:9a35:5a7b:1d76]) by smtp.gmail.com with ESMTPSA id e8-20020a5d5948000000b003143add4396sm7168911wri.22.2023.08.27.03.15.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Aug 2023 03:15:21 -0700 (PDT) Date: Sun, 27 Aug 2023 11:15:20 +0100 From: Lorenzo Stoakes To: "Joel Fernandes (Google)" Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, Shuah Khan , Vlastimil Babka , Michal Hocko , Linus Torvalds , Kirill A Shutemov , "Liam R. Howlett" , "Paul E. McKenney" , Suren Baghdasaryan , Kalesh Singh , Lokesh Gidra Subject: Re: [PATCH v5 6/7] selftests: mm: Add a test for remapping within a range Message-ID: References: <20230822015501.791637-1-joel@joelfernandes.org> <20230822015501.791637-7-joel@joelfernandes.org> <08ce8c61-e7a2-417a-a3cc-d20861753ae8@lucifer.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <08ce8c61-e7a2-417a-a3cc-d20861753ae8@lucifer.local> X-Rspamd-Queue-Id: F1FAB100021 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: c6a411ram55zxtnjfjgs597oy9gutike X-HE-Tag: 1693131323-871305 X-HE-Meta: U2FsdGVkX18JRXcDXHGvMJHxdo0L+CcqdhynjbBtT/zwQQ6tpj92PJ6Fe8ScrXsQEaH1eey5YAv+25/JGxA7c91iB4/L9Mhnfov8Opr5U/DjF305eTTQb3dHADVK1QKoaIGNglVhVII5XxzKvnYZmxYmvse3C1DyXTiOBYGhi1I+YjTBC0cacAuFBRm9/vfwlaLFu4tuvPZDiHqMVmEGa9k42syCPf8eI3aqknTM3YfMMiuJzAKMLXyMH77ebG5gd9kF7PTsRuI8tGMmUkTNOVYMjnxKWeAxHF+nA463Fl+HetUBYACz9GWBOZKQ7cQdX2Pw8F8HDffacORW8Pp7xOnTLJUiFmiaQ5NTqJkkBI4fICidS9tb5WmVKSw4qUkDyoPm6iySYAF0pZwDtmggUvZpjFq+N2pQCEDDnR4WA00PZahaaznJtTQcr4C2w4QxmchWMK5owHdEPeExe7HG4BvOFvA+c0Cw9sRbQLw+FPXuEPrriR7+wZl1un07pifkN3pPjYSphlX2thXZsglNy390e5Px/vv8JPEOzJahPFEtMBot4M+gswi7GV+CvSlO/xFZLSgZ2KpxHYGAexrNpYoIvI05ssbKWpVTVxbGrUrRoPoXUpPVS0MbTtrB+w3DWUlV5i3kLPRKjafAcGsJUBAtbEorYnTkjvqra8zVfMkeAdLABshxcQ7OPDktnzU3wvTjVdUKrVKN0f8IRh3AhE+1xHD+5R2+tsDk4UALGkB1ZsZq4nM3MRAypp1WZr7hiUfADbfD4tvgtWqSo09H2JosDzfue9rxPFwVA3qbrLo9SC+gONreJXxf4znjf2Nr9/NqsLHbf+FPfj2Eqw+S4c3lLnyxkjH8Sqq5H3BVGoR/7wmbzcQQW3qGeT3ibI6rPPQHaMCBrPNaIUEyWJ/iQdnADJf6+vjC8ww0FKwH1Gu4hX8M6cAWd6+qlbucCnk3pADj21xRPP2rClMkPTR 0ReIN4yg 4SBte1HaLBo2KoEbWYdtDjZrzR/96jHMWjjDJtjUPTTwSWpaiIRMJKeGxTtuQjrot70sQNmAPC4v7bh5yh0kt1PnMF/beNVT6hXEZXWhOpBXTJh/JjH9ZYhJj9NqNHSjaNcwtbQC2KPwALhu1okLcqDFpwOsFgtwgtwR2x/0qD7SB6mVpl+d+klwHM7smBaQeUmx6Qx5K7nj9ac1ojnucZiuygxjoA4aO3DN2lEV+zR4PcugkMiqFSslcQEsvEvniGHRFLZPAuvSrEOSzWzpE+3m/3XgbYtMvn4to8hqbECwRJEY9BWxJCBhJMOnrsE8Rtik3HBx33xYrl1xgkf8oEwbiB+Vbi9dPL5YOmLy6eL3rY1MaMenxLncnSii3TaOzWszLtPuWtQxfebzvHXHzVku5B52ZrNNmmvZ5UCKj65IEkeRP+DR5CynRm7NKnHYaTDmOM2ywN5x6qYk+rcIn/6sFR/GS+PLRNKVgFVg+UrKtqF8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Aug 27, 2023 at 10:57:59AM +0100, Lorenzo Stoakes wrote: [snip] > > +/* > > + * Verify that an mremap within a range does not cause corruption > > + * of unrelated part of range. > > + * > > + * Consider the following range which is 2MB aligned and is > > + * a part of a larger 10MB range which is not shown. Each > > + * character is 256KB below making the source and destination Just noticed, I think you misspeak here, as this test doens't seem to offset by 256 KiB? That is the strategy for mremap_move_1mb_from_start() rather than this test so perhaps comment needs to be moved around? * 2MB each. The lower case letters are moved (s to d) and the * upper case letters are not moved. The below test verifies * that the upper case S letters are not corrupted by the * adjacent mremap. * * |DDDDddddSSSSssss| */ static void mremap_move_within_range(char pattern_seed) [snip]