From: Lorenzo Stoakes <lstoakes@gmail.com>
To: "Joel Fernandes (Google)" <joel@joelfernandes.org>
Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-mm@kvack.org, Shuah Khan <shuah@kernel.org>,
Vlastimil Babka <vbabka@suse.cz>, Michal Hocko <mhocko@suse.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Kirill A Shutemov <kirill@shutemov.name>,
"Liam R. Howlett" <liam.howlett@oracle.com>,
"Paul E. McKenney" <paulmck@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Kalesh Singh <kaleshsingh@google.com>,
Lokesh Gidra <lokeshgidra@google.com>
Subject: Re: [PATCH v5 6/7] selftests: mm: Add a test for remapping within a range
Date: Sun, 27 Aug 2023 11:15:20 +0100 [thread overview]
Message-ID: <fb429d82-4576-42d7-b51f-7a72f7f8caec@lucifer.local> (raw)
In-Reply-To: <08ce8c61-e7a2-417a-a3cc-d20861753ae8@lucifer.local>
On Sun, Aug 27, 2023 at 10:57:59AM +0100, Lorenzo Stoakes wrote:
[snip]
> > +/*
> > + * Verify that an mremap within a range does not cause corruption
> > + * of unrelated part of range.
> > + *
> > + * Consider the following range which is 2MB aligned and is
> > + * a part of a larger 10MB range which is not shown. Each
> > + * character is 256KB below making the source and destination
Just noticed, I think you misspeak here, as this test doens't seem to
offset by 256 KiB? That is the strategy for mremap_move_1mb_from_start()
rather than this test so perhaps comment needs to be moved around?
* 2MB each. The lower case letters are moved (s to d) and the
* upper case letters are not moved. The below test verifies
* that the upper case S letters are not corrupted by the
* adjacent mremap.
*
* |DDDDddddSSSSssss|
*/
static void mremap_move_within_range(char pattern_seed)
[snip]
next prev parent reply other threads:[~2023-08-27 10:15 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-22 1:54 [PATCH v5 0/7] Optimize mremap during mutual alignment within PMD Joel Fernandes (Google)
2023-08-22 1:54 ` [PATCH v5 1/7] mm/mremap: Optimize the start addresses in move_page_tables() Joel Fernandes (Google)
2023-08-27 9:09 ` Lorenzo Stoakes
2023-08-22 1:54 ` [PATCH v5 2/7] mm/mremap: Allow moves within the same VMA Joel Fernandes (Google)
2023-08-27 9:21 ` Lorenzo Stoakes
2023-08-28 18:32 ` Joel Fernandes
2023-08-28 19:00 ` Lorenzo Stoakes
2023-08-28 20:26 ` Joel Fernandes
2023-08-22 1:54 ` [PATCH v5 3/7] selftests: mm: Fix failure case when new remap region was not found Joel Fernandes (Google)
2023-08-27 9:22 ` Lorenzo Stoakes
2023-08-22 1:54 ` [PATCH v5 4/7] selftests: mm: Add a test for mutually aligned moves > PMD size Joel Fernandes (Google)
2023-08-27 9:36 ` Lorenzo Stoakes
2023-08-22 1:54 ` [PATCH v5 5/7] selftests: mm: Add a test for remapping to area immediately after existing mapping Joel Fernandes (Google)
2023-08-27 9:42 ` Lorenzo Stoakes
2023-08-28 18:36 ` Joel Fernandes
2023-08-22 1:54 ` [PATCH v5 6/7] selftests: mm: Add a test for remapping within a range Joel Fernandes (Google)
2023-08-27 9:57 ` Lorenzo Stoakes
2023-08-27 10:15 ` Lorenzo Stoakes [this message]
2023-08-28 18:59 ` Joel Fernandes
2023-08-28 19:38 ` Lorenzo Stoakes
2023-08-28 20:10 ` Joel Fernandes
2023-08-28 18:37 ` Joel Fernandes
2023-08-22 1:55 ` [PATCH v5 7/7] selftests: mm: Add a test for moving from an offset from start of mapping Joel Fernandes (Google)
2023-08-27 10:12 ` Lorenzo Stoakes
2023-08-28 20:17 ` Joel Fernandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb429d82-4576-42d7-b51f-7a72f7f8caec@lucifer.local \
--to=lstoakes@gmail.com \
--cc=joel@joelfernandes.org \
--cc=kaleshsingh@google.com \
--cc=kirill@shutemov.name \
--cc=liam.howlett@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lokeshgidra@google.com \
--cc=mhocko@suse.com \
--cc=paulmck@kernel.org \
--cc=shuah@kernel.org \
--cc=surenb@google.com \
--cc=torvalds@linux-foundation.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox