From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D572ECAAA1 for ; Wed, 31 Aug 2022 01:52:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D7AFE6B0071; Tue, 30 Aug 2022 21:52:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D29DD6B0072; Tue, 30 Aug 2022 21:52:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BCC098D0001; Tue, 30 Aug 2022 21:52:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id ADECE6B0071 for ; Tue, 30 Aug 2022 21:52:19 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 8B0BA1A02F0 for ; Wed, 31 Aug 2022 01:52:19 +0000 (UTC) X-FDA: 79858212798.15.2607422 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by imf03.hostedemail.com (Postfix) with ESMTP id EDB6C20012 for ; Wed, 31 Aug 2022 01:52:17 +0000 (UTC) Received: from dggpemm500023.china.huawei.com (unknown [172.30.72.55]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4MHRrx33CVz1N7hL; Wed, 31 Aug 2022 09:48:01 +0800 (CST) Received: from dggpemm500006.china.huawei.com (7.185.36.236) by dggpemm500023.china.huawei.com (7.185.36.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 31 Aug 2022 09:51:27 +0800 Received: from [10.174.178.55] (10.174.178.55) by dggpemm500006.china.huawei.com (7.185.36.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 31 Aug 2022 09:51:26 +0800 Subject: Re: [PATCH 2/2] arm64: remove unneed defer_reserve_crashkernel() and crash_mem_map To: Baoquan He , CC: , , , , , , , , , References: <20220828005545.94389-1-bhe@redhat.com> <20220828005545.94389-3-bhe@redhat.com> From: "Leizhen (ThunderTown)" Message-ID: Date: Wed, 31 Aug 2022 09:51:25 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20220828005545.94389-3-bhe@redhat.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.178.55] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpemm500006.china.huawei.com (7.185.36.236) X-CFilter-Loop: Reflected ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=none; spf=pass (imf03.hostedemail.com: domain of thunder.leizhen@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=thunder.leizhen@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661910739; a=rsa-sha256; cv=none; b=mIiq9aQjAntrGmKPv0vVexYMmahYXOvGSV+9pI4RJxWVrEJVIzfAdC79koX+DhJJFM4tba ot6lfDZ5e5XlQzufrw4S7TrITqhdnCLLQYQgRStON0MGt+LXRlHZS7S+NIshd2jiuXbFrc l8pkj8ReLDpBnRkEJfXnS4ySM+WqSrc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661910739; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2FlBkbWPhluINltE5HHP6ruPhpef9sot+YuX0+uaPWI=; b=0MnjyhHpba3oPjB8pjbFYsbUCAqIW7525d2L4bS/AC6XTvhOQzgGwVGuHyw45KiX5T7E5v C2IYZlSj8ZZV9NaQLiTK/XLsVv6yG878ptjvcu0SehGnIL60862RH0kpMabdtaQ102vEg6 D5zEoF7+xlv88xAaKXIr942GCPvrLCQ= X-Stat-Signature: mhsmgqd4jfxdnxe1zcakpzes87d8518i X-Rspamd-Queue-Id: EDB6C20012 Authentication-Results: imf03.hostedemail.com; dkim=none; spf=pass (imf03.hostedemail.com: domain of thunder.leizhen@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=thunder.leizhen@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1661910737-550729 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/8/28 8:55, Baoquan He wrote: > Now they are not needed any more, clean them up. Reviewed-by: Zhen Lei > > Signed-off-by: Baoquan He > --- > arch/arm64/include/asm/memory.h | 5 ----- > arch/arm64/mm/mmu.c | 15 --------------- > 2 files changed, 20 deletions(-) > > diff --git a/arch/arm64/include/asm/memory.h b/arch/arm64/include/asm/memory.h > index 9dd08cd339c3..b9e71583c9cb 100644 > --- a/arch/arm64/include/asm/memory.h > +++ b/arch/arm64/include/asm/memory.h > @@ -363,11 +363,6 @@ static inline void *phys_to_virt(phys_addr_t x) > }) > > void dump_mem_limit(void); > - > -static inline bool defer_reserve_crashkernel(void) > -{ > - return IS_ENABLED(CONFIG_ZONE_DMA) || IS_ENABLED(CONFIG_ZONE_DMA32); > -} > #endif /* !ASSEMBLY */ > > /* > diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c > index cdd338fa2115..c3f8f426c3d8 100644 > --- a/arch/arm64/mm/mmu.c > +++ b/arch/arm64/mm/mmu.c > @@ -502,21 +502,6 @@ void __init mark_linear_text_alias_ro(void) > PAGE_KERNEL_RO); > } > > -static bool crash_mem_map __initdata; > - > -static int __init enable_crash_mem_map(char *arg) > -{ > - /* > - * Proper parameter parsing is done by reserve_crashkernel(). We only > - * need to know if the linear map has to avoid block mappings so that > - * the crashkernel reservations can be unmapped later. > - */ > - crash_mem_map = true; > - > - return 0; > -} > -early_param("crashkernel", enable_crash_mem_map); > - > static void __init map_mem(pgd_t *pgdp) > { > static const u64 direct_map_end = _PAGE_END(VA_BITS_MIN); > -- Regards, Zhen Lei