From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B83E5C25B74 for ; Fri, 24 May 2024 13:39:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DAF976B0082; Fri, 24 May 2024 09:39:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D37FD6B0083; Fri, 24 May 2024 09:39:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B63C26B0085; Fri, 24 May 2024 09:39:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 98B6B6B0082 for ; Fri, 24 May 2024 09:39:05 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 26F60140AFA for ; Fri, 24 May 2024 13:39:05 +0000 (UTC) X-FDA: 82153395450.05.FF888B1 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf29.hostedemail.com (Postfix) with ESMTP id 35578120018 for ; Fri, 24 May 2024 13:39:00 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=z7RkUxJ7; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=rfcOve+j; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=z7RkUxJ7; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=rfcOve+j; dmarc=none; spf=pass (imf29.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716557943; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Sr7QFX273aoyVkyQ2G7PSaznp9RsacGkzHrDqv37t+4=; b=a8PitPC0Nrg/Dis8hcUzHuZ1UcZr1V8AxVkdXFz9tWRFzcYioFvo7FvMzdl7qk4LDGsuwd UK9M7K6AiqYJ95VtO3DAfB1xaKXCj1gR3C4tQOPOM0ffDfDLTzF6NCPSi9Q5arTXof4nWU JiwTQj6sI36Plp273vHFNMFIKHiHSIU= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=z7RkUxJ7; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=rfcOve+j; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=z7RkUxJ7; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=rfcOve+j; dmarc=none; spf=pass (imf29.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716557943; a=rsa-sha256; cv=none; b=ZHgpV4yFke93PuiBsfOHrZhkV4kkyG4ieXELcm88c5/V9wBpXSczZekObtgKhZvcSsd3M7 QS1iIgYlnNHJmsYyI+jdqaraC0eFU9jH3VU6UbVTK7aLLn0vOetTtKlIC1Qu6Dwax+7wl7 AOwZW4dElJLWe7pX5s6TsB9bMpr29To= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 1DD1333B32; Fri, 24 May 2024 13:38:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1716557939; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Sr7QFX273aoyVkyQ2G7PSaznp9RsacGkzHrDqv37t+4=; b=z7RkUxJ75FaTQyG4dbyaqSHuxxgEgipVt/aureD0JYfBjK988LT73nc89yhoXJbUs4yDZz oq5U7fmwBNFdODyjlsvEw9pkDEgdZZ0lPi3ggux0hBHHmUmVu4rlrElgs/Fddate2mxFFf 2iFPJcB9IpgHJ8KkO6f6JUICAVdnGjU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1716557939; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Sr7QFX273aoyVkyQ2G7PSaznp9RsacGkzHrDqv37t+4=; b=rfcOve+j5R5pYqlcmUhqL374dcVvVDJqkcfjKuWNQNIXHOOOLwstGb+A64LRZESw2/P66j EmHuT+ty0xT87cCA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1716557939; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Sr7QFX273aoyVkyQ2G7PSaznp9RsacGkzHrDqv37t+4=; b=z7RkUxJ75FaTQyG4dbyaqSHuxxgEgipVt/aureD0JYfBjK988LT73nc89yhoXJbUs4yDZz oq5U7fmwBNFdODyjlsvEw9pkDEgdZZ0lPi3ggux0hBHHmUmVu4rlrElgs/Fddate2mxFFf 2iFPJcB9IpgHJ8KkO6f6JUICAVdnGjU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1716557939; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Sr7QFX273aoyVkyQ2G7PSaznp9RsacGkzHrDqv37t+4=; b=rfcOve+j5R5pYqlcmUhqL374dcVvVDJqkcfjKuWNQNIXHOOOLwstGb+A64LRZESw2/P66j EmHuT+ty0xT87cCA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id D5DE213A3D; Fri, 24 May 2024 13:38:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id rF69M3KYUGarSgAAD6G6ig (envelope-from ); Fri, 24 May 2024 13:38:58 +0000 Message-ID: Date: Fri, 24 May 2024 15:38:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/6] mm/slab: Plumb kmem_buckets into __do_kmalloc_node() Content-Language: en-US To: Kees Cook Cc: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-hardening@vger.kernel.org, "GONG, Ruiqi" , Xiu Jianfeng , Suren Baghdasaryan , Kent Overstreet , Jann Horn , Matteo Rizzo , Thomas Graf , Herbert Xu , julien.voisin@dustri.org, linux-kernel@vger.kernel.org References: <20240424213019.make.366-kees@kernel.org> <20240424214104.3248214-2-keescook@chromium.org> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <20240424214104.3248214-2-keescook@chromium.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 35578120018 X-Stat-Signature: h17wu3jzhu9wsj7n6kmbi94w4ujrnn3x X-HE-Tag: 1716557940-594066 X-HE-Meta: U2FsdGVkX1/A3wV946WEuzmZhl5ZVAW+SBTZbxCDJPhPLyhbN3DwDF9tsLWNOENEmPt1U+dTcRYQ7LUId+GtpY7LE8CTplPy7dETNMflAiahlE+8LAuRPVF/Mzef0in9sZWF6X10vHFCZGXyOQW/ILqTNSn1hT3vojjnjzchh4uMI0iOMJWKwg5yQ0hK1k6rg21aanIaSnf8TP7Ok+B+DH/XQ/RQTDpEatejb4vtyIKmHjZxyDvrMEulHE099943l/DWNRLP6Qjy7G8AcVX2RpDdn+0DdlM0gWAO1PJ4vR4Xd0ugeYxqNEqNJBHHTb1HtEnnBPax1s5yzEQ6IveXrZwwFSqlKkg4hnPbmc6jxDkuGcXKgDVUSw/HJ+J1ak2jpSIzEJYTogcTLT4yztQogKBQ9v+7VixPPh6Pe6rX/QVy4ndwebxRp8E8NWaCZLqcAaLU7RXbxMl6aNOKSoCZ/VVCxvdi/D9karRkjFVVrcOCBdPYq2815B5e4rr2YeaLn6Q6a27XhDN3A5+cHNXU4r0b88jTdf5zfUZUhzzOzMP2Uy9PGCMIbWsArMG0O7UL+8aElW7Q7JDgjEQ62VvaEhXnsywHAbWRTY+vxYQ6GXONsEpyzpX+3Ofz+gn+cREAJLrqPiQvr58AOcL7EmuMZRX914ns1g8b/LZP/3cMSJNj23TUWb3YwTyPkcamyK6lmdOFahU9LlAsap/un3UrUSC2C3dobckC8iexYt9diacMm3BAz/Yp01nEH8+NBju05fdbPKoS7hA737V1zPGSwKlIrBfHTW/LyrB5qi0Z1i/DKLkl8rOPJCxvYOakbj27p+e2WJN0ojoJARR+uG/psKRbRcdazHuTFUL51uOLcdpz3HkxrjCw3D6AUU1svk2ntXb1ufnlk2+rpaf96b2uthWI/UWmVBLp2ReemC1EYIm98PQhnheHy/UWVV5LX833oUrko1yTjbBmU1DO1UO DV5Vz4GO W9PJSCVwndalx2l+pCRZkolSSzXihi3vnrW89JK1rt6Nsu+a9u1PDY/gbB0SKhBdw93C0N/yLiSFkjO4iwnwNDBjwu7FodmPG8gJom2b0omCyrJwECew8zSy5qB5KzxwSXy40IrCHlX3mde9JpDTNzFov+vrtmrCkpe7tT76WAQMfbeFbexmRYBF1dvtjGGTyFpTNUAKRfLMrRIyXbX7rrEETPQfwaWkOVTMkJkokR8y8SjUUe0CnVnLnVS7D1VwHfPJccAsEuFvhkCpx39CPxdDALoeCqZ4NMcCBQIn6KdKgX7uymZOkcNvQc4foNnreJrpj2gdcDS0DyH7yl+wF2zrrvS0/nedNY6syLqKJMvU3idhlb3jrReLlMZg6h5x53FLx0YW45XOKQnMsphClkW+KutNchLM46Jpp+85DWPUVCUeuvEDGh3k+j3XgBrpplOXIxSH+zwQZFw+aqpRJSsHh+CZYfzjYtJ/njVj3ZyFedUQigy0lbI3kAmJAG2aCmMNBQtupDzKr69uqVzCPIund4A3EJOC6MXj//AzU4ibiZ67ECyYRReIs0KQj8VZx5oj+hPOE/vd9of7iWPbhLvnts+UiD8NZ774wW4VpAny8yRTx/g4wH5Y3ftmnVgz8kD1VYjVoUalhzPtJdCbnwElEBomrpl5Kgw6ZIP+WRjPvMHpcnXQacpie8+ZOgs5MRZpW+Ku7hAhqQe/9Lj5XJCulUmjmUYuYVQtA85vBSR8mtGzixAZqDzFCThPANRqxGUchsRR4mYJ1zzpLexhr1PjT5Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/24/24 11:40 PM, Kees Cook wrote: > To be able to choose which buckets to allocate from, make the buckets > available to the lower level kmalloc interfaces by adding them as the > first argument. Where the bucket is not available, pass NULL, which means > "use the default system kmalloc bucket set" (the prior existing behavior), > as implemented in kmalloc_slab(). > > Signed-off-by: Kees Cook > --- > Cc: Vlastimil Babka > Cc: Christoph Lameter > Cc: Pekka Enberg > Cc: David Rientjes > Cc: Joonsoo Kim > Cc: Andrew Morton > Cc: Roman Gushchin > Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com> > Cc: linux-mm@kvack.org > Cc: linux-hardening@vger.kernel.org > --- > include/linux/slab.h | 16 ++++++++-------- > lib/fortify_kunit.c | 2 +- > mm/slab.h | 6 ++++-- > mm/slab_common.c | 4 ++-- > mm/slub.c | 14 +++++++------- > mm/util.c | 2 +- > 6 files changed, 23 insertions(+), 21 deletions(-) > > diff --git a/include/linux/slab.h b/include/linux/slab.h > index c8164d5db420..07373b680894 100644 > --- a/include/linux/slab.h > +++ b/include/linux/slab.h > @@ -569,8 +569,8 @@ static __always_inline void kfree_bulk(size_t size, void **p) > kmem_cache_free_bulk(NULL, size, p); > } > > -void *__kmalloc_node_noprof(size_t size, gfp_t flags, int node) __assume_kmalloc_alignment > - __alloc_size(1); > +void *__kmalloc_node_noprof(kmem_buckets *b, size_t size, gfp_t flags, int node) > + __assume_kmalloc_alignment __alloc_size(2); > #define __kmalloc_node(...) alloc_hooks(__kmalloc_node_noprof(__VA_ARGS__)) > > void *kmem_cache_alloc_node_noprof(struct kmem_cache *s, gfp_t flags, > @@ -679,7 +679,7 @@ static __always_inline __alloc_size(1) void *kmalloc_node_noprof(size_t size, gf > kmalloc_caches[kmalloc_type(flags, _RET_IP_)][index], > flags, node, size); > } > - return __kmalloc_node_noprof(size, flags, node); > + return __kmalloc_node_noprof(NULL, size, flags, node); This is not ideal as now every kmalloc_node() callsite will now have to add the NULL parameter even if this is not enabled. Could the new parameter be only added depending on the respective config? > } > #define kmalloc_node(...) alloc_hooks(kmalloc_node_noprof(__VA_ARGS__))