From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 861ABC4345F for ; Wed, 24 Apr 2024 06:10:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 942266B0204; Wed, 24 Apr 2024 02:10:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8CA046B0205; Wed, 24 Apr 2024 02:10:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 76AAD6B0206; Wed, 24 Apr 2024 02:10:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 579066B0204 for ; Wed, 24 Apr 2024 02:10:19 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C8B5C141034 for ; Wed, 24 Apr 2024 06:10:18 +0000 (UTC) X-FDA: 82043400516.03.DEF1A77 Received: from out30-113.freemail.mail.aliyun.com (out30-113.freemail.mail.aliyun.com [115.124.30.113]) by imf21.hostedemail.com (Postfix) with ESMTP id 60F451C0011 for ; Wed, 24 Apr 2024 06:10:15 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=tbA1ITQ7; spf=pass (imf21.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.113 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713939017; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UgkEafpjB4FkcGXYRGgNcZe1C+yfzAPApUHISBw8ick=; b=8MKeTd1N96WiOc+kH+mqrPMsPVrkdUQMTqN65oSVQEZhkphUfuhgTWjcy1nDDDrF2dbTIS odGut5+Ks5U6Sf+gFsLrrotcqAm7I7bubFqjacGaxQavYz1/ZPVIcrUmgbj9RExhImB3zP ObSyuMKeCRlSdnCymJBc629Vy+eWUHQ= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=tbA1ITQ7; spf=pass (imf21.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.113 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713939017; a=rsa-sha256; cv=none; b=UNzsx2SbA70+7l5khCrkFz6cu1n0KxM05i6dwykN1TB0nGr4s8KDQrz6zHdGu3n7KCfUmN wON3FlhN1MWxGUJ5stQLjBv87fKNIdLgUxPJ/kpkFTCw3Y6nd92u/5qTyoRbbsJtG+NpbB 6dlxCbr6F96My33OajnVJfKOl4BfEDI= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1713939012; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=UgkEafpjB4FkcGXYRGgNcZe1C+yfzAPApUHISBw8ick=; b=tbA1ITQ7JOi4N3i5flMh6w+j1dMDnvZ1WLJNw01aR7lge1LVRC+2dv2ARfCyk1BJXPLT8EiGQSppRtsNCY6kL0CYfbshfojf+6hatBdC4/EcXIzRbed9sTZ+vr/duJN0LxeQotuiAaDLXvTsCkH11awgwAyKXbyjwZuMCfOzcZ0= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R141e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=maildocker-contentspam033045046011;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=12;SR=0;TI=SMTPD_---0W5BPSdR_1713939009; Received: from 30.97.56.58(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0W5BPSdR_1713939009) by smtp.aliyun-inc.com; Wed, 24 Apr 2024 14:10:10 +0800 Message-ID: Date: Wed, 24 Apr 2024 14:10:09 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 5/5] mm: shmem: add anonymous share mTHP counters To: David Hildenbrand , Barry Song <21cnbao@gmail.com> Cc: akpm@linux-foundation.org, hughd@google.com, willy@infradead.org, wangkefeng.wang@huawei.com, ryan.roberts@arm.com, ying.huang@intel.com, shy828301@gmail.com, ziy@nvidia.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <05d0096e4ec3e572d1d52d33a31a661321ac1551.1713755580.git.baolin.wang@linux.alibaba.com> From: Baolin Wang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 60F451C0011 X-Stat-Signature: neg1ehmui6oihcwq7xkqwb6r7dg1un7k X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1713939015-579224 X-HE-Meta: U2FsdGVkX1/Z0jsuIO2OyUouVB5cQ7b6I34HNo8/RmYwc/AOKuDthIl4VQoyvS4/FoZb7kUxhqqqyc7J4W05S2bu9EIMU3UCoR65HFF/nh8ve0Jmn9vTj9tvx4Jdx3muKXmhSC5PQq48sVCNp7qOtQ4fnAmwGM/yEA1ScAGBsreAIB/q+atXS5ibRfuFXk8xC9hlIRGwzFL8VtQxQ++Uix3UyeCY2AJI0GLNyMHDxF+g0yHbRkwIM2pb5E0gpTIz8IATel+Q6vYbV/2u2d490/XwUNAEXxiVkOH3c6dewo8GyfiXDzrum5wnybltwie0cZbJa1KsmXFQzpfA36Hj1qLpx5kI3mIppps3hNSszaXgeYI2w/Nd+OOxJGznggr6u/gdBDEbPgC95qMb4jkscnU2vE3bwpK1vbA4ov2aX9w4CntGWb/52nCyr1iy4isjVuAr6wygJQqJR+A1qY82s5kmcy9hOk3JQsKf00lxySUU6DXimrj6fChf0Qfsv5zSkDHP/MZD2JBgKdMQKDdN0reRvLrA5nJFQHfQ+yFBcHbp1ANKCvbwQvWPgglGWOLCcPoyllNymKdwCRigt1yAta/ycp+F0idPTe66c4PySZcmZehabv/3MiYciQIMOcJMJQ8oAJlPYjdJYFIDUoc3T8RPoW78i7PPs7ntFgMMYLxoH1ABlOyRHee/AZzn8TxiGD99fkQ51/ygdOekVcIb6E9SM+YE71tkElVo4Yofc3cEBqh3GwWVw2s5GoOeWzL/ri88Vx1K8MKLr1PQyHTo0F+HqsF43T4sS45zjtHeDOHiO6n+HG7BQO5ms+Qym7UC8tW2dzquMN1LYfq4bTlN2c2c/fIcHRmz6XA5LIHYb3vPoAmRAH3SUa8Lb3sPP9EEtAwX7lMLomyJdD7mEi1gdh7fmkivpIGp X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/4/23 19:37, David Hildenbrand wrote: > On 23.04.24 03:17, Barry Song wrote: >> On Mon, Apr 22, 2024 at 3:03 PM Baolin Wang >> wrote: >>> >>> Signed-off-by: Baolin Wang >>> --- >>>   include/linux/huge_mm.h | 2 ++ >>>   mm/huge_memory.c        | 4 ++++ >>>   mm/shmem.c              | 5 ++++- >>>   3 files changed, 10 insertions(+), 1 deletion(-) >>> >>> diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h >>> index 26b6fa98d8ac..67b9c1acad31 100644 >>> --- a/include/linux/huge_mm.h >>> +++ b/include/linux/huge_mm.h >>> @@ -270,6 +270,8 @@ enum mthp_stat_item { >>>          MTHP_STAT_ANON_SWPOUT, >>>          MTHP_STAT_ANON_SWPOUT_FALLBACK, >>>          MTHP_STAT_ANON_SWPIN_REFAULT, >>> +       MTHP_STAT_SHMEM_ANON_ALLOC, >>> +       MTHP_STAT_SHMEM_ANON_ALLOC_FALLBACK, >> >> not quite sure about this. for 2MB pmd-mapped THP shmem, we count them >> as FILE_THP. >> here we are counting as SHMEM_ANON. To me, SHMEM_ANON is more correct but >> it doesn't align with pmd-mapped THP. David, Ryan, what do you think? > > The term "anonymous share" in the patch subject is weird to begin with > ;) Easy to confuse with anonymous cow-shared memory. Let's just call it > "anonymous shmem", which it is under the hood. Sure. > ... regarding the question: if we add FILE_ALLOC and friends, at least > initially, we wouldn't account other large pagecache folios. > > ... likely we should add that then as well so the counter matches the > actual name? > > If we later realize that we need separate FILE vs. SHMEM vs. WHATEVER > counters, we can always add more fine-grained counters later. Doing it > consistently w.r.t. traditional THPs first sounds reasonable. Um, once we expose it to userspace through the sysfs interface, the sysfs interface should be explicit as much as possible and avoid confusing users, otherwise it will be difficult to change this kind of interface in the future. Personally, I prefer to Ryan's suggestion.