From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1956BC48260 for ; Thu, 8 Feb 2024 16:48:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7BCCE6B0074; Thu, 8 Feb 2024 11:48:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 76ADF6B0075; Thu, 8 Feb 2024 11:48:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 60AB26B007D; Thu, 8 Feb 2024 11:48:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 508696B0074 for ; Thu, 8 Feb 2024 11:48:35 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 12E8DA0314 for ; Thu, 8 Feb 2024 16:48:35 +0000 (UTC) X-FDA: 81769220190.22.A4C9C8E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf16.hostedemail.com (Postfix) with ESMTP id C824418001B for ; Thu, 8 Feb 2024 16:48:31 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LJ6KqaPi; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707410911; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Q7iRmNGt3W93UVFfKwOcrmKhnYBPVT8Fkk7ZIGORewo=; b=dnFGmAHZ9LQEGrADlLTnMJzrAb00WC2t2v70sZHrsoguDKlNIQ3VqWm56KKF+HLJXrrLnw A8BTHzhqvrMeL9UIEt+g2LSvQhkAuAlfnDDXewqfhj92XT/aBr8TilhCX2R1gcF2IQBr3R J4OAtVguEO1sfEka5D+2iZamQ4lLsMY= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LJ6KqaPi; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707410911; a=rsa-sha256; cv=none; b=ROfwkT8+R9xgyPR9grSIgOFLsFuqxdQddIem2oYiZZaZBWFBGqRqVjzIBjysF7YY0/p7d7 b4FgmduM/B0QYlqiQwNbqkmBWFGIzXwJjSoGkE8inZv4VP+IZNh5fuyn+aEFMUnQghiOMD /lhodl6ZX77ZoV/oTjJaGRggard8NkM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1707410911; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Q7iRmNGt3W93UVFfKwOcrmKhnYBPVT8Fkk7ZIGORewo=; b=LJ6KqaPiblPkK+02b8WGPvaLXCY3YHfZ/JIrP8eo8+PO1qA3i4MPW1/8Y6kuQibmzZn13h MB9hUj937Z/PuMFB9aUWAmFupZ6d8eVfRNKuv6Ka7+7/GauJVdDon54qIgq6mMw3vCO4Xq NM8HJCC85WHmV3AoFMeCU1IQPbdIo88= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-320-Se_vi3RMPvqHjOiI2ZKD_g-1; Thu, 08 Feb 2024 11:48:29 -0500 X-MC-Unique: Se_vi3RMPvqHjOiI2ZKD_g-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-40e40126031so435825e9.0 for ; Thu, 08 Feb 2024 08:48:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707410908; x=1708015708; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Q7iRmNGt3W93UVFfKwOcrmKhnYBPVT8Fkk7ZIGORewo=; b=w8m4guQJoT8T3m3UQDl3HbJrUJoPBWQ7OE20l8gUGf9s1aH3zEzrKRpPXb4Ow778TG pBzDXLbzqZSTyU+mhq6gm7WZNHX92vZIfRB2NI9puYoVSdqFlip2p0uhQLhcyYJpk+DG Zk+991ttaLsOKrbIwN7Vb1Kcbx6As4Xe6AH8gS9LVuF6SE9Zn5kFmsKLc8PQXzDFQdQP 8VClcEsK4uUTznoofx9eFLwViIQRSwDeVYL4Vut9EYSviGTYdxnmLgDqzoRwbbYEf5VX I9CrR6Ww4KYLk+KisUEmvJk3hy7r1un1O+5QtvEoU0ko28jVo3B09uxqGJMd7Rjt/XPa +doA== X-Forwarded-Encrypted: i=1; AJvYcCUvYDQbA7EaBYeZvfF7Cp+2r7td3+S4JHZ1TJotZ9aBOmJkkO6/nL/o1g3XmRiPl3zue5Z57Zv0MBPi631rw33QIjQ= X-Gm-Message-State: AOJu0YxbZ9Kl8qiMYbmN5dLzazOXRdeNVgVNYE8HTH/DUYMssaYvWRHa SeB+o3BJDsVuJtIXFZzfFsLFAUmBjRB10BXFbkx7rXbBpC4GiPhMF1zaytAqX/WpJd7F4IDA7y0 NudGXTA4he9TURlq6sNayt437hTIZroPPjqTkbTj0tOza/hir X-Received: by 2002:a05:600c:35ce:b0:40e:a3b8:a2b8 with SMTP id r14-20020a05600c35ce00b0040ea3b8a2b8mr7191204wmq.26.1707410908511; Thu, 08 Feb 2024 08:48:28 -0800 (PST) X-Google-Smtp-Source: AGHT+IFYKTY1MxUtxzZJ1d4/PLs9cvlxjVLZL0kL6HVGEfXDgqgqqFif8BFLfC0Nh2g7pj8L22pL9w== X-Received: by 2002:a05:600c:35ce:b0:40e:a3b8:a2b8 with SMTP id r14-20020a05600c35ce00b0040ea3b8a2b8mr7191188wmq.26.1707410908118; Thu, 08 Feb 2024 08:48:28 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCUzDrKKFXBLqur477CGccDaqml2yYqHxzEvTTB/RcdMzy/PD5OHYVykEkCAkgQbXW2wpzvnf+3gfKLTBKERw+9eUX41iPuBeuH9HeERquQyC/48oni6USvh0TSbhrX/9d9gT45ycc3pa2iumy+/GaDHpLZd3pQUwovsMXF8qCl0 Received: from [10.3.13.39] ([212.140.138.205]) by smtp.gmail.com with ESMTPSA id n17-20020a05600c4f9100b0040fc56712e8sm2133907wmq.17.2024.02.08.08.48.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Feb 2024 08:48:27 -0800 (PST) Message-ID: Date: Thu, 8 Feb 2024 17:48:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] fs/proc/task_mmu: Add display flag for VM_MAYOVERLAY To: Anshuman Khandual , linux-mm@kvack.org Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org References: <20240208084805.1252337-1-anshuman.khandual@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240208084805.1252337-1-anshuman.khandual@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: C824418001B X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: gr3nkyr19fntsenmnta5thqupjhe3eq1 X-HE-Tag: 1707410911-442161 X-HE-Meta: U2FsdGVkX1/m+K2wVvREHUZBJUI6kUd0uZKZyPbqCKIbC+wl7iduQaMb4dFkiAuYhpU4XYShKHsKSesec8C0EDpfr/kF3qB29dtlOziTOf4jcmpoSoh4lwehEFNY4NbdUZvbjKFhbtEFTwQRuCrqISNuS5aKxk/H3I37z1RhX6BrGOHq87/MQ0ouIEfNTKcfvvU96jyObImbPtNqiXGl5BEtBEiqgmDcSgbNzr74nVNibtzODHbtYAq7pXXA1LdUrVBr2Ik0jaOUkZJ6l2nFBHASYNEBK/4yDaE3ZEVA2Aes6TEAPDkjYf6pzvZ4itdR4aoipv8ae+9gCaHbNKYiVouuMq1OkmBVy3ZNJaJbj7f+kC4xZUsdV0QPRDyFoHSSShaaJXjdB3PycLmmO/w42ywj9kUE90GJzOqwkAxw18kmYrnJq1BmBkJhRcJWKEFtm9o8C463ctTc87roM+ZxJqIXzd4ai5rEvWi+gB7CgXjlOEp+0SG2S/QgHUGGpkUaKjzYPYGe8ymuP/u+ZjRfJiEf8J1wvleOd6EUv+X7eqZ6HhVWw+JstopCF230SRKgA3LCZTlljYOO17iH0cIfUrbwWFTr6YaFQkxdlS3L5euQSY+TSh8MeNbAY5xX5ybB4KDoRVEEh4YJ5ahd97zlc5z18Wnk8S7aHUCd+bfdHxL0ci/BZJA09mQR0jrCgwI98zrFysj8dJTwWCTmLqTXgINT6v/JWsp7kBWPpkgunGmzkXEt6ueqmNZZ/jD13Urfvu3xntEZXU0N4Ljkm0pVEq9LfQbDs4fvYKXzyOspNQkxNVHBXN5MlW2aNs+EWH6VYhrb7mBXep6rMgBEQ9dGSy1TEovlsH7ef6IGNR0TPgj06C0lDfnZV9Jk5hFz37TeNowYyV9CKd/SqUJt1fSf0x9Barbn1OQHMUNNe6QFCdz+rUw/B2emcVvVKac1uaNroNZQ2zT2C85CYFDF6Oq wnRPfitj Hrotmoy6pKs+vqBla8U8TftljnzQ6Chie7tSoWQsghevVFBk+GayHIYk9HMCAANJRqx3bJ+3PisiGijlJPP/ZT0XAvgDLFPtV64WBXFHFpw68IbccLsJnQJlhaW81XCe7Qvi8eDI8DJOt/W+HjyU8HNc5FNYSQFLVT81NlMTgM+SR8pt/cJvp+Tw9EaQ58MC195L3Vmn01TeOl1npaLhLEaqoZiAODkDal10a68eUHVjmMdn70HGuz101nZxc/eUSaqYby1jX59dGFdzG/KmaZ1N/mjafnjCtV9y1/EvfHo7FG6z/mNw6oV81E/SLXdAI+3ozp3xdhQMSrYOx8srVJzW7og7wNw84MNMYTv0/4gC/rMjh0An6++SCeZvyiBfga+DdvOqUjTY0dwUdAZLxl0xywq8z97g0aqXHa6k0kV09E6lQIsPLWj4z/KEOXroG0Ax8q6S6YvoH7TWQIIz5DVxhzOYNTAQ7io/3ubh1qNQBE4XqSDSPFebnRcM3exkcM8a6uJNoOro+nQ04jCqt51RWYY5wIduDK2wpTco5fMACrZyThOb62+p0w+v3MmbmOD7yLG9a6YxsAUb8JkLo1ZMgsvYbVC26RGMba3xuw6dDrZuo7N4lLKigPgSH32afV8SdHGZgTgxJ08/AoIr2fhh96IbLFhLVrP7yMihfyjz8HKY4IzV2m6kTZg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 08.02.24 09:48, Anshuman Khandual wrote: > VM_UFFD_MISSING flag is mutually exclussive with VM_MAYOVERLAY flag as they > both use the same bit position i.e 0x00000200 in the vm_flags. Let's update > show_smap_vma_flags() to display the correct flags depending on CONFIG_MMU. > > Cc: Andrew Morton > Cc: David Hildenbrand > Cc: linux-kernel@vger.kernel.org > Cc: linux-fsdevel@vger.kernel.org > Signed-off-by: Anshuman Khandual > --- > This applies on v6.8-rc3 > > fs/proc/task_mmu.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c > index 3f78ebbb795f..1c4eb25cfc17 100644 > --- a/fs/proc/task_mmu.c > +++ b/fs/proc/task_mmu.c > @@ -681,7 +681,11 @@ static void show_smap_vma_flags(struct seq_file *m, struct vm_area_struct *vma) > [ilog2(VM_HUGEPAGE)] = "hg", > [ilog2(VM_NOHUGEPAGE)] = "nh", > [ilog2(VM_MERGEABLE)] = "mg", > +#ifdef CONFIG_MMU > [ilog2(VM_UFFD_MISSING)]= "um", > +#else > + [ilog2(VM_MAYOVERLAY)] = "ov", > +#endif /* CONFIG_MMU */ > [ilog2(VM_UFFD_WP)] = "uw", > #ifdef CONFIG_ARM64_MTE > [ilog2(VM_MTE)] = "mt", Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb